aboutsummaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorBananeweizen <bananeweizen@gmx.de>2012-05-06 10:48:29 +0200
committerBananeweizen <bananeweizen@gmx.de>2012-05-06 10:48:29 +0200
commit8ecf061ae07dd335017dbfd73727aecf61d6ea91 (patch)
tree77b2c49e01e3d7e06d61e64e78700b3bed52e449 /tests
parentc5e42735b99baaebbc41e697ff716189821cd02c (diff)
downloadcgeo-8ecf061ae07dd335017dbfd73727aecf61d6ea91.zip
cgeo-8ecf061ae07dd335017dbfd73727aecf61d6ea91.tar.gz
cgeo-8ecf061ae07dd335017dbfd73727aecf61d6ea91.tar.bz2
refactoring: remove some of the TODOs
Diffstat (limited to 'tests')
-rw-r--r--tests/src/cgeo/geocaching/files/GPXParserTest.java3
-rw-r--r--tests/src/cgeo/geocaching/files/LocParserTest.java3
-rw-r--r--tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java1
3 files changed, 2 insertions, 5 deletions
diff --git a/tests/src/cgeo/geocaching/files/GPXParserTest.java b/tests/src/cgeo/geocaching/files/GPXParserTest.java
index 47975c9..00e0447 100644
--- a/tests/src/cgeo/geocaching/files/GPXParserTest.java
+++ b/tests/src/cgeo/geocaching/files/GPXParserTest.java
@@ -193,13 +193,12 @@ public class GPXParserTest extends AbstractResourceInstrumentationTestCase {
}
}
- // TODO: may need to sort by geocode when a test imports more than one cache
return new ArrayList<cgCache>(caches);
}
public static void testParseDateWithFractionalSeconds() {
// was experienced in GSAK file
- String dateString = "2011-08-13T02:52:18.103Z";
+ final String dateString = "2011-08-13T02:52:18.103Z";
try {
GPXParser.parseDate(dateString);
} catch (ParseException e) {
diff --git a/tests/src/cgeo/geocaching/files/LocParserTest.java b/tests/src/cgeo/geocaching/files/LocParserTest.java
index 7e7a1be..5170577 100644
--- a/tests/src/cgeo/geocaching/files/LocParserTest.java
+++ b/tests/src/cgeo/geocaching/files/LocParserTest.java
@@ -14,7 +14,7 @@ import java.util.List;
public class LocParserTest extends AbstractResourceInstrumentationTestCase {
private List<cgCache> readLoc(int resourceId) throws IOException, ParserException {
- LocParser parser = new LocParser(1);
+ final LocParser parser = new LocParser(1);
Collection<cgCache> caches = null;
final InputStream instream = getResourceStream(resourceId);
try {
@@ -25,7 +25,6 @@ public class LocParserTest extends AbstractResourceInstrumentationTestCase {
instream.close();
}
- // TODO: may need to sort by geocode when a test imports more than one cache
return new ArrayList<cgCache>(caches);
}
diff --git a/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java b/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java
index e07a518..ab5c290 100644
--- a/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java
+++ b/tests/src/cgeo/geocaching/test/AbstractResourceInstrumentationTestCase.java
@@ -21,7 +21,6 @@ public abstract class AbstractResourceInstrumentationTestCase extends Instrument
try {
ins.close();
} catch (IOException e) {
- // TODO Auto-generated catch block
e.printStackTrace();
}
return result;