refactoring: StoredList

* try more encapsulation instead of ID comparisons all time

2 files changed, 28 insertions, 4 deletions

diff --git a/tests/src/cgeo/geocaching/list/PseudoListTest.java b/tests/src/cgeo/geocaching/list/PseudoListTest.java
new file mode 100644
index 0000000..d120d81
--- /dev/null
+++ b/tests/src/cgeo/geocaching/list/PseudoListTest.java
@@ -0,0 +1,18 @@
+package cgeo.geocaching.list;
+
+import org.apache.commons.lang3.StringUtils;
+
+import junit.framework.TestCase;
+
+public class PseudoListTest extends TestCase {
+
+    public static void testGetTitleAndCount() throws Exception {
+        final String title = PseudoList.ALL_LIST.title;
+        assertTrue("pseudo lists shall not have a number shown in their title", StringUtils.isAlpha(title.substring(1, title.length() - 1)));
+    }
+
+    public static void testIsConcrete() throws Exception {
+        assertFalse("pseudo lists are not concrete lists", PseudoList.ALL_LIST.isConcrete());
+    }
+
+}
diff --git a/tests/src/cgeo/geocaching/list/StoredListTest.java b/tests/src/cgeo/geocaching/list/StoredListTest.java
index ebe0966..985236a 100644
--- a/tests/src/cgeo/geocaching/list/StoredListTest.java
+++ b/tests/src/cgeo/geocaching/list/StoredListTest.java
@@ -1,21 +1,27 @@
 package cgeo.geocaching.list;
 
 import cgeo.geocaching.DataStore;
-import cgeo.geocaching.list.StoredList;
 
 import junit.framework.TestCase;
 
 public class StoredListTest extends TestCase {
 
     public static void testStandardListExists() {
-        final StoredList list = DataStore.getList(StoredList.STANDARD_LIST_ID);
+        final StoredList list = getStandardList();
         assertNotNull(list);
     }
 
+    private static StoredList getStandardList() {
+        return DataStore.getList(StoredList.STANDARD_LIST_ID);
+    }
+
     public static void testEquals() {
-        final StoredList list1 = DataStore.getList(StoredList.STANDARD_LIST_ID);
-        final StoredList list2 = DataStore.getList(StoredList.STANDARD_LIST_ID);
+        final StoredList list1 = getStandardList();
+        final StoredList list2 = getStandardList();
         assertEquals(list1, list2);
     }
 
+    public static void testConcrete() {
+        assertTrue(getStandardList().isConcrete());
+    }
 }