1 files changed, 39 insertions, 45 deletions

diff --git a/main/src/cgeo/geocaching/utils/CryptUtils.java b/main/src/cgeo/geocaching/utils/CryptUtils.java
index 815c2f4..4aec509 100644
--- a/main/src/cgeo/geocaching/utils/CryptUtils.java
+++ b/main/src/cgeo/geocaching/utils/CryptUtils.java
@@ -1,6 +1,5 @@
 package cgeo.geocaching.utils;
 
-
 import org.apache.commons.lang3.CharEncoding;
 import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jdt.annotation.NonNull;
@@ -23,28 +22,29 @@ public final class CryptUtils {
         // utility class
     }
 
-    private static char[] base64map1 = new char[64];
-    private static byte[] base64map2 = new byte[128];
+    private static final byte[] EMPTY = {};
+    private static final char[] BASE64MAP1 = new char[64];
+    private static final byte[] BASE64MAP2 = new byte[128];
 
     static {
         int i = 0;
         for (char c = 'A'; c <= 'Z'; c++) {
-            base64map1[i++] = c;
+            BASE64MAP1[i++] = c;
         }
         for (char c = 'a'; c <= 'z'; c++) {
-            base64map1[i++] = c;
+            BASE64MAP1[i++] = c;
         }
         for (char c = '0'; c <= '9'; c++) {
-            base64map1[i++] = c;
+            BASE64MAP1[i++] = c;
         }
-        base64map1[i++] = '+';
-        base64map1[i++] = '/';
+        BASE64MAP1[i++] = '+';
+        BASE64MAP1[i++] = '/';
 
-        for (i = 0; i < base64map2.length; i++) {
-            base64map2[i] = -1;
+        for (i = 0; i < BASE64MAP2.length; i++) {
+            BASE64MAP2[i] = -1;
         }
         for (i = 0; i < 64; i++) {
-            base64map2[base64map1[i]] = (byte) i;
+            BASE64MAP2[BASE64MAP1[i]] = (byte) i;
         }
     }
 
@@ -58,7 +58,7 @@ public final class CryptUtils {
             } else if (result == ']') {
                 plaintext = false;
             } else if (!plaintext) {
-                int capitalized = result & 32;
+                final int capitalized = result & 32;
                 result &= ~capitalized;
                 result = ((result >= 'A') && (result <= 'Z') ? ((result - 'A' + 13) % 26 + 'A') : result)
                         | capitalized;
@@ -68,50 +68,44 @@ public final class CryptUtils {
     }
 
     @NonNull
-    public static String rot13(String text) {
+    public static String rot13(final String text) {
         if (text == null) {
             return StringUtils.EMPTY;
         }
         final StringBuilder result = new StringBuilder();
-        Rot13Encryption rot13 = new Rot13Encryption();
+        final Rot13Encryption rot13 = new Rot13Encryption();
 
         final int length = text.length();
         for (int index = 0; index < length; index++) {
-            char c = text.charAt(index);
+            final char c = text.charAt(index);
             result.append(rot13.getNextEncryptedCharacter(c));
         }
         return result.toString();
     }
 
-    public static String md5(String text) {
+    public static String md5(final String text) {
         try {
             final MessageDigest digest = MessageDigest.getInstance("MD5");
             digest.update(text.getBytes(CharEncoding.UTF_8), 0, text.length());
             return new BigInteger(1, digest.digest()).toString(16);
-        } catch (NoSuchAlgorithmException e) {
-            Log.e("CryptUtils.md5", e);
-        } catch (UnsupportedEncodingException e) {
+        } catch (NoSuchAlgorithmException | UnsupportedEncodingException e) {
             Log.e("CryptUtils.md5", e);
         }
 
         return StringUtils.EMPTY;
     }
 
-    public static byte[] hashHmac(String text, String salt) {
-        byte[] macBytes = {};
+    public static byte[] hashHmac(final String text, final String salt) {
 
         try {
             final SecretKeySpec secretKeySpec = new SecretKeySpec(salt.getBytes(CharEncoding.UTF_8), "HmacSHA1");
             final Mac mac = Mac.getInstance("HmacSHA1");
             mac.init(secretKeySpec);
-            macBytes = mac.doFinal(text.getBytes(CharEncoding.UTF_8));
-        } catch (GeneralSecurityException e) {
-            Log.e("CryptUtils.hashHmac", e);
-        } catch (UnsupportedEncodingException e) {
+            return mac.doFinal(text.getBytes(CharEncoding.UTF_8));
+        } catch (GeneralSecurityException | UnsupportedEncodingException e) {
             Log.e("CryptUtils.hashHmac", e);
+            return EMPTY;
         }
-
-        return macBytes;
     }
 
     public static CharSequence rot13(final Spannable span) {
@@ -119,37 +113,37 @@ public final class CryptUtils {
         // a SpannableStringBuilder instead of the pure text and we must replace each character inline.
         // Otherwise we loose all the images, colors and so on...
         final SpannableStringBuilder buffer = new SpannableStringBuilder(span);
-        Rot13Encryption rot13 = new Rot13Encryption();
+        final Rot13Encryption rot13 = new Rot13Encryption();
 
         final int length = span.length();
         for (int index = 0; index < length; index++) {
-            char c = span.charAt(index);
+            final char c = span.charAt(index);
             buffer.replace(index, index + 1, String.valueOf(rot13.getNextEncryptedCharacter(c)));
         }
         return buffer;
     }
 
-    public static String base64Encode(byte[] in) {
-        int iLen = in.length;
-        int oDataLen = (iLen * 4 + 2) / 3; // output length without padding
-        int oLen = ((iLen + 2) / 3) * 4; // output length including padding
-        char[] out = new char[oLen];
+    public static String base64Encode(final byte[] in) {
+        final int iLen = in.length;
+        final int oDataLen = (iLen * 4 + 2) / 3; // output length without padding
+        final int oLen = ((iLen + 2) / 3) * 4; // output length including padding
+        final char[] out = new char[oLen];
         int ip = 0;
         int op = 0;
 
         while (ip < iLen) {
-            int i0 = in[ip++] & 0xff;
-            int i1 = ip < iLen ? in[ip++] & 0xff : 0;
-            int i2 = ip < iLen ? in[ip++] & 0xff : 0;
-            int o0 = i0 >>> 2;
-            int o1 = ((i0 & 3) << 4) | (i1 >>> 4);
-            int o2 = ((i1 & 0xf) << 2) | (i2 >>> 6);
-            int o3 = i2 & 0x3F;
-            out[op++] = base64map1[o0];
-            out[op++] = base64map1[o1];
-            out[op] = op < oDataLen ? base64map1[o2] : '=';
+            final int i0 = in[ip++] & 0xff;
+            final int i1 = ip < iLen ? in[ip++] & 0xff : 0;
+            final int i2 = ip < iLen ? in[ip++] & 0xff : 0;
+            final int o0 = i0 >>> 2;
+            final int o1 = ((i0 & 3) << 4) | (i1 >>> 4);
+            final int o2 = ((i1 & 0xf) << 2) | (i2 >>> 6);
+            final int o3 = i2 & 0x3F;
+            out[op++] = BASE64MAP1[o0];
+            out[op++] = BASE64MAP1[o1];
+            out[op] = op < oDataLen ? BASE64MAP1[o2] : '=';
             op++;
-            out[op] = op < oDataLen ? base64map1[o3] : '=';
+            out[op] = op < oDataLen ? BASE64MAP1[o3] : '=';
             op++;
         }