diff options
author | agrieve <agrieve@chromium.org> | 2016-02-16 08:54:38 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-16 16:55:40 +0000 |
commit | 92a9e0684f6a76060f59a9c8caab0420bc36ec06 (patch) | |
tree | e5c7b443a1e7c60837d813bcb79012caab91e10a /.gn | |
parent | 84efb4de22a98e02ecead98c8bdfe95e9d3f1c7a (diff) | |
download | chromium_src-92a9e0684f6a76060f59a9c8caab0420bc36ec06.zip chromium_src-92a9e0684f6a76060f59a9c8caab0420bc36ec06.tar.gz chromium_src-92a9e0684f6a76060f59a9c8caab0420bc36ec06.tar.bz2 |
Reland of Have gn gen assert that the output directory does not have GYP artifacts (patchset #1 id:1 of https://codereview.chromium.org/1602393002/ )
Reason for revert:
Verified manually (via ssh) that patch works fine on a trybot that broke last time. Perhaps more time just needed to pass?
Original issue's description:
> Revert of Have gn gen assert that the output directory does not have GYP artifacts (patchset #2 id:20001 of https://codereview.chromium.org/1601893002/ )
>
> Reason for revert:
> arm-builder-rel, arm64-builder-rel, gn-release-builder-l consistently fail the assertion added in this change.
>
> Original issue's description:
> > Have gn gen assert that the output directory does not have GYP artifacts
> >
> > This can often lead to compile errors.
> >
> > BUG=578862
> >
> > Committed: https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0
> > Cr-Commit-Position: refs/heads/master@{#370210}
>
> TBR=brettw@chromium.org,agrieve@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=578862
>
> Committed: https://crrev.com/caf664a996be25ec5f567f183dd897de4abff952
> Cr-Commit-Position: refs/heads/master@{#370288}
TBR=brettw@chromium.org,jbudorick@chromium.org,mdjones@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578862
Review URL: https://codereview.chromium.org/1702013002
Cr-Commit-Position: refs/heads/master@{#375598}
Diffstat (limited to '.gn')
-rw-r--r-- | .gn | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -131,6 +131,7 @@ check_targets = [ exec_script_whitelist = [ "//android_webview/BUILD.gn", "//ash/BUILD.gn", + "//build/config/BUILD.gn", "//build/config/android/config.gni", "//build/config/android/internal_rules.gni", "//build/config/android/rules.gni", |