diff options
author | dtu <dtu@chromium.org> | 2015-12-02 08:09:00 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-02 16:10:06 +0000 |
commit | d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d (patch) | |
tree | 723ec373197bf3394b45823e0facd1d35c1275a4 /.gn | |
parent | fe6381bc6b30cda9ac6b4c3d97434507146165c2 (diff) | |
download | chromium_src-d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d.zip chromium_src-d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d.tar.gz chromium_src-d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d.tar.bz2 |
Revert of Add all components to "gn check". (patchset #4 id:60001 of https://codereview.chromium.org/1491743002/ )
Reason for revert:
Failing Perf (Official) Linux Builder.
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266
ERROR at //components/version_info/version_info.cc:12:11: Include not allowed.
#include "ui/base/l10n/l10n_util.h"
^-----------------------
It is not in any dependency of
//components/version_info:version_info
The include file is in the target(s):
//ui/base:base
which should somehow be reachable.
GN gen failed: 1
Original issue's description:
> Add all components to "gn check".
>
> All components now pass a "gn check" step. Whitelist with a wildcard.
>
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
> Cr-Commit-Position: refs/heads/master@{#362652}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1490313002
Cr-Commit-Position: refs/heads/master@{#362725}
Diffstat (limited to '.gn')
-rw-r--r-- | .gn | 153 |
1 files changed, 152 insertions, 1 deletions
@@ -34,7 +34,158 @@ check_targets = [ #"//chrome_elf/*", #"//cloud_print/*", - "//components/*", + #"//components/*", # Needs nacl below. + "//components:*", + "//components/about_handler/*", + "//components/about_ui/*", + "//components/app_modal/*", + "//components/audio_modem/*", + "//components/autofill/*", + "//components/auto_login_parser/*", + "//components/bitmap_uploader/*", + "//components/bookmarks/*", + "//components/browser_sync/*", + "//components/browser_watcher/*", + "//components/browsing_data/*", + "//components/bubble/*", + "//components/captive_portal/*", + "//components/cdm/*", + "//components/certificate_reporting/*", + "//components/certificate_transparency/*", + "//components/chrome_apps/*", + "//components/clipboard/*", + "//components/cloud_devices/*", + "//components/component_updater/*", + "//components/compression/*", + "//components/constrained_window/*", + "//components/content_settings/*", + "//components/cookie_config/*", + "//components/copresence/*", + "//components/crash/*", + "//components/cronet/*", + "//components/crx_file/*", + "//components/data_reduction_proxy/*", + "//components/data_usage/*", + "//components/data_use_measurement/*", + "//components/device_event_log/*", + "//components/devtools_discovery/*", + "//components/devtools_http_handler/*", + "//components/devtools_service/*", + "//components/dom_distiller/*", + "//components/domain_reliability/*", + "//components/drive/*", + "//components/enhanced_bookmarks/*", + "//components/error_page/*", + "//components/exp/*", + "//components/external_video_surface/*", + "//components/favicon/*", + "//components/favicon_base/*", + "//components/feedback/*", + "//components/filesystem/*", + "//components/flags_ui/*", + "//components/font_service/*", + "//components/gcm_driver/*", + "//components/google/*", + "//components/gpu/*", + "//components/guest_view/*", + "//components/handoff/*", + "//components/history/*", + "//components/html_viewer/*", + "//components/infobars/*", + "//components/invalidation/*", + "//components/json_schema/*", + "//components/keyed_service/*", + "//components/language_usage_metrics/*", + "//components/leveldb_proto/*", + "//components/login/*", + "//components/memory_pressure/*", + "//components/message_port/*", + "//components/metrics/*", + "//components/metrics_services_manager/*", + "//components/mime_util/*", + "//components/mus/*", + "//components/nacl/*", + "//components/navigation_interception/*", + "//components/navigation_metrics/*", + "//components/net_log/*", + "//components/network_hints/*", + "//components/network_time/*", + "//components/offline_pages/*", + "//components/omnibox/*", + "//components/onc/*", + "//components/open_from_clipboard/*", + "//components/os_crypt/*", + "//components/ownership/*", + "//components/packed_ct_ev_whitelist/*", + "//components/page_load_metrics/*", + "//components/pairing/*", + "//components/password_manager/*", + "//components/pdf/*", + "//components/pdf_viewer/*", + "//components/plugins/*", + "//components/policy/*", + "//components/power/*", + "//components/precache/*", + "//components/pref_registry/*", + "//components/printing/*", + "//components/proximity_auth/*", + "//components/proxy_config/*", + "//components/query_parser/*", + "//components/rappor/*", + "//components/renderer_context_menu/*", + "//components/resource_provider/*", + "//components/resources/*", + "//components/rlz/*", + "//components/safe_browsing_db/*", + "//components/safe_json/*", + "//components/scheduler/*", + "//components/search/*", + "//components/search_engines/*", + "//components/search_provider_logos/*", + "//components/security_interstitials/*", + "//components/service_tab_launcher/*", + "//components/session_manager/*", + "//components/sessions/*", + "//components/signin/*", + "//components/ssl_config/*", + "//components/ssl_errors/*", + "//components/startup_metric_utils/*", + "//components/storage_monitor/*", + "//components/strings/*", + "//components/suggestions/*", + "//components/sync_bookmarks/*", + "//components/sync_driver/*", + "//components/sync_sessions/*", + "//components/syncable_prefs/*", + "//components/test/*", + "//components/test_runner/*", + "//components/timers/*", + "//components/toolbar/*", + "//components/tools/*", + "//components/tracing/*", + "//components/translate/*", + "//components/ui/*", + "//components/undo/*", + "//components/update_client/*", + "//components/upload_list/*", + "//components/url_formatter/*", + "//components/url_matcher/*", + "//components/user_manager/*", + "//components/user_prefs/*", + "//components/variations/*", + "//components/visitedlink/*", + "//components/wallpaper/*", + "//components/web_cache/*", + "//components/web_modal/*", + "//components/web_resource/*", + "//components/web_view/*", + "//components/webcrypto/*", + "//components/webdata/*", + "//components/webdata_services/*", + "//components/webp_transcode/*", + "//components/webui_generator/*", + "//components/webusb/*", + "//components/wifi/*", #"//content/*", # A whole lot of errors. "//content/public/common:result_codes", |