diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-26 08:48:23 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-26 08:48:23 +0000 |
| commit | 01589482064f17c32f9f0ae8bf59a361583cc6bb (patch) | |
| tree | 180449fb7cc03c7a1480cf61d6d210b8b51b82aa | |
| parent | e73f561839608e4665b5a5cd805a08057619111e (diff) | |
| download | chromium_src-01589482064f17c32f9f0ae8bf59a361583cc6bb.zip chromium_src-01589482064f17c32f9f0ae8bf59a361583cc6bb.tar.gz chromium_src-01589482064f17c32f9f0ae8bf59a361583cc6bb.tar.bz2 | |
Change a result code ENUM value to help diagnose unexpected histogram data
We've gotten histogram data showing the integer value of 24, which happens to
be the same as RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR, as the exit code for
some renderer crashes. This seems impossible since that result code should only
be used for browser process exit very early in startup, when a special
--install-from-webstore experimental command line flag is present.
What seems more likely is that some other exit values are getting conflated with
this one somewhere in the reporting pipeline, perhaps because it comes last in
the list. To verify this hypothesis, I'm changing the name and value of
RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR, adding a dummy value in its place, as
well as following it with another dummy value.
BUG=152285
Review URL: https://chromiumcodereview.appspot.com/10987038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158769 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/chrome_browser_main.cc | 2 | ||||
| -rw-r--r-- | chrome/common/chrome_result_codes.h | 8 |
2 files changed, 8 insertions, 2 deletions
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc index 53ab39b..d40fb0d 100644 --- a/chrome/browser/chrome_browser_main.cc +++ b/chrome/browser/chrome_browser_main.cc @@ -1307,7 +1307,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() { extensions::StartupHelper helper; if (helper.InstallFromWebstore(parsed_command_line(), profile_)) return content::RESULT_CODE_NORMAL_EXIT; - return chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR; + return chrome::RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2; } diff --git a/chrome/common/chrome_result_codes.h b/chrome/common/chrome_result_codes.h index 045edd9..b6f7a839 100644 --- a/chrome/common/chrome_result_codes.h +++ b/chrome/common/chrome_result_codes.h @@ -72,9 +72,15 @@ enum ResultCode { // running browser. RESULT_CODE_NORMAL_EXIT_PROCESS_NOTIFIED, + // A dummy value we should not use. See crbug.com/152285. + RESULT_CODE_NOTUSED_1, + // Failed to install an item from the webstore when the kInstallFromWebstore // command line flag was present. - RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR, + RESULT_CODE_INSTALL_FROM_WEBSTORE_ERROR_2, + + // A dummy value we should not use. See crbug.com/152285. + RESULT_CODE_NOTUSED_2, // Last return code (keep this last). RESULT_CODE_CHROME_LAST_CODE, |