summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordmazzoni <dmazzoni@chromium.org>2015-01-30 23:10:28 -0800
committerCommit bot <commit-bot@chromium.org>2015-01-31 07:11:32 +0000
commit041d87ffac000386810baf9cddfac46e20c8862b (patch)
treec914063e46b66d0c0a386a5ec9d57072791517ba
parent47f77af24354054857d07a6790e61fc745b2ce41 (diff)
downloadchromium_src-041d87ffac000386810baf9cddfac46e20c8862b.zip
chromium_src-041d87ffac000386810baf9cddfac46e20c8862b.tar.gz
chromium_src-041d87ffac000386810baf9cddfac46e20c8862b.tar.bz2
Add more logging to track down flakiness.
BUG=440579 TBR=nasko NOTRY=true Review URL: https://codereview.chromium.org/893773002 Cr-Commit-Position: refs/heads/master@{#314051}
-rw-r--r--content/browser/renderer_host/legacy_render_widget_host_win.cc17
1 files changed, 15 insertions, 2 deletions
diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.cc b/content/browser/renderer_host/legacy_render_widget_host_win.cc
index f680448..a1e5881 100644
--- a/content/browser/renderer_host/legacy_render_widget_host_win.cc
+++ b/content/browser/renderer_host/legacy_render_widget_host_win.cc
@@ -147,6 +147,15 @@ LRESULT LegacyRenderWidgetHostHWND::OnGetObject(UINT message,
// because it sometimes gets sign-extended incorrectly (but not always).
DWORD obj_id = static_cast<DWORD>(static_cast<DWORD_PTR>(l_param));
+ // http://crbug.com/440579 TODO(dmazzoni): remove this logging when
+ // flakiness is fixed.
+ LOG(INFO) << "LegacyRenderWidgetHostHWND::OnGetObject"
+ << " message=" << message
+ << " w_param=" << w_param
+ << " l_param=" << l_param
+ << " obj_id=" << obj_id
+ << " host_=" << host_;
+
if (kIdScreenReaderHoneyPot == obj_id) {
// When an MSAA client has responded to our fake event on this id,
// enable screen reader support.
@@ -159,14 +168,18 @@ LRESULT LegacyRenderWidgetHostHWND::OnGetObject(UINT message,
RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(
host_->GetRenderWidgetHost());
- if (!rwhi)
+ if (!rwhi) {
+ LOG(WARNING) << "No RWHI";
return static_cast<LRESULT>(0L);
+ }
BrowserAccessibilityManagerWin* manager =
static_cast<BrowserAccessibilityManagerWin*>(
rwhi->GetRootBrowserAccessibilityManager());
- if (!manager)
+ if (!manager) {
+ LOG(WARNING) << "No manager";
return static_cast<LRESULT>(0L);
+ }
base::win::ScopedComPtr<IAccessible> root(
manager->GetRoot()->ToBrowserAccessibilityWin());