Revert 115227 - Coverity: Initialize member variables.

CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513
    102546,102552,102567,102617,102674,102677,102678,102679,102681,102685,
    102714,102750,102751,102781
BUG=none
TEST=none
R=groby

Review URL: http://codereview.chromium.org/9005015

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8965062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115228 0039d316-1c4b-4281-b951-d872f2087c98

26 files changed, 20 insertions, 66 deletions

diff --git a/chrome/browser/extensions/extension_web_socket_proxy_private_api.cc b/chrome/browser/extensions/extension_web_socket_proxy_private_api.cc
index 367bdfb..ddfe14c 100644
--- a/chrome/browser/extensions/extension_web_socket_proxy_private_api.cc
+++ b/chrome/browser/extensions/extension_web_socket_proxy_private_api.cc
@@ -32,10 +32,7 @@ const char kPermissionDeniedError[] =
 }
 
 WebSocketProxyPrivate::WebSocketProxyPrivate()
-    : port_(-1),
-      listening_port_(-1),
-      do_tls_(false),
-      is_finalized_(false) {
+    : listening_port_(-1), do_tls_(false), is_finalized_(false){
 }
 
 WebSocketProxyPrivate::~WebSocketProxyPrivate() {
diff --git a/chrome/browser/history/in_memory_url_index.cc b/chrome/browser/history/in_memory_url_index.cc
index 384322f8..eb03b95 100644
--- a/chrome/browser/history/in_memory_url_index.cc
+++ b/chrome/browser/history/in_memory_url_index.cc
@@ -115,20 +115,14 @@ int ScoreForValue(int value, const int* value_ranks) {
 InMemoryURLIndex::InMemoryURLIndex(const FilePath& history_dir)
     : history_dir_(history_dir),
       private_data_(new URLIndexPrivateData),
-      cached_at_shutdown_(false),
-      pre_filter_item_count(0),
-      post_filter_item_count(0),
-      post_scoring_item_count(0) {
+      cached_at_shutdown_(false) {
   InMemoryURLIndex::InitializeSchemeWhitelist(&scheme_whitelist_);
 }
 
 // Called only by unit tests.
 InMemoryURLIndex::InMemoryURLIndex()
     : private_data_(new URLIndexPrivateData),
-      cached_at_shutdown_(false),
-      pre_filter_item_count(0),
-      post_filter_item_count(0),
-      post_scoring_item_count(0) {
+      cached_at_shutdown_(false) {
   InMemoryURLIndex::InitializeSchemeWhitelist(&scheme_whitelist_);
 }
 
diff --git a/chrome/browser/policy/cloud_policy_subsystem.cc b/chrome/browser/policy/cloud_policy_subsystem.cc
index b8e40dd..21663eb 100644
--- a/chrome/browser/policy/cloud_policy_subsystem.cc
+++ b/chrome/browser/policy/cloud_policy_subsystem.cc
@@ -205,8 +205,6 @@ CloudPolicyCacheBase* CloudPolicySubsystem::GetCloudPolicyCacheBase() const {
 }
 
 CloudPolicySubsystem::CloudPolicySubsystem()
-    : refresh_pref_name_(NULL),
-      data_store_(NULL) {
-}
+    : refresh_pref_name_(NULL) {}
 
 }  // namespace policy
diff --git a/chrome/browser/speech/speech_input_bubble_views.cc b/chrome/browser/speech/speech_input_bubble_views.cc
index e7714c9..5e56c73 100644
--- a/chrome/browser/speech/speech_input_bubble_views.cc
+++ b/chrome/browser/speech/speech_input_bubble_views.cc
@@ -93,12 +93,6 @@ SpeechInputBubbleView::SpeechInputBubbleView(
       delegate_(delegate),
       element_rect_(element_rect),
       tab_contents_(tab_contents),
-      icon_(NULL),
-      heading_(NULL),
-      message_(NULL),
-      try_again_(NULL),
-      cancel_(NULL),
-      mic_settings_(NULL),
       display_mode_(SpeechInputBubbleBase::DISPLAY_MODE_WARM_UP),
       kIconLayoutMinWidth(ResourceBundle::GetSharedInstance().GetBitmapNamed(
                           IDR_SPEECH_INPUT_MIC_EMPTY)->width()) {
diff --git a/chrome/browser/ui/snapshot_tab_helper.cc b/chrome/browser/ui/snapshot_tab_helper.cc
index 0078d57..1a073dc 100644
--- a/chrome/browser/ui/snapshot_tab_helper.cc
+++ b/chrome/browser/ui/snapshot_tab_helper.cc
@@ -10,8 +10,7 @@
 #include "content/public/browser/notification_service.h"
 
 SnapshotTabHelper::SnapshotTabHelper(TabContentsWrapper* wrapper)
-    : TabContentsObserver(wrapper->tab_contents()),
-      wrapper_(wrapper) {
+    : TabContentsObserver(wrapper->tab_contents()) {
 }
 
 SnapshotTabHelper::~SnapshotTabHelper() {
diff --git a/chrome/browser/ui/views/sad_tab_view.cc b/chrome/browser/ui/views/sad_tab_view.cc
index 046a794..1e65bc6 100644
--- a/chrome/browser/ui/views/sad_tab_view.cc
+++ b/chrome/browser/ui/views/sad_tab_view.cc
@@ -46,8 +46,7 @@ SadTabView::SadTabView(TabContents* tab_contents, Kind kind)
           ResourceBundle::BaseFont)),
       message_(NULL),
       help_link_(NULL),
-      feedback_link_(NULL),
-      reload_button_(NULL) {
+      feedback_link_(NULL) {
   DCHECK(tab_contents);
 
   // Sometimes the user will never see this tab, so keep track of the total
diff --git a/chrome/browser/ui/views/web_intent_picker_view.cc b/chrome/browser/ui/views/web_intent_picker_view.cc
index 75c3ffe..297d783 100644
--- a/chrome/browser/ui/views/web_intent_picker_view.cc
+++ b/chrome/browser/ui/views/web_intent_picker_view.cc
@@ -148,9 +148,7 @@ WebIntentPickerView::WebIntentPickerView(views::View* anchor_view,
                                          WebIntentPickerDelegate* delegate)
     : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),
       delegate_(delegate),
-      button_hbox_(NULL),
-      plus_button_(NULL) {
-}
+      button_hbox_(NULL) {}
 
 WebIntentPickerView::~WebIntentPickerView() {
 }
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index e8685ec..7478a19 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -279,8 +279,7 @@ RenderMessageFilter::RenderMessageFilter(
       render_widget_helper_(render_widget_helper),
       incognito_(browser_context->IsOffTheRecord()),
       webkit_context_(browser_context->GetWebKitContext()),
-      render_process_id_(render_process_id),
-      cpu_usage_(0) {
+      render_process_id_(render_process_id) {
   DCHECK(request_context_);
 
   render_widget_helper_->Init(render_process_id_, resource_dispatcher_host_);
diff --git a/crypto/p224_spake.cc b/crypto/p224_spake.cc
index af3c2b8..ec0c416 100644
--- a/crypto/p224_spake.cc
+++ b/crypto/p224_spake.cc
@@ -99,9 +99,6 @@ P224EncryptedKeyExchange::P224EncryptedKeyExchange(
     PeerType peer_type, const base::StringPiece& password)
     : state_(kStateInitial),
       is_server_(peer_type == kPeerTypeServer) {
-  memset(&x_, 0, sizeof(x_));
-  memset(&expected_authenticator_, 0, sizeof(expected_authenticator_));
-
   // x_ is a random scalar.
   base::RandBytes(x_, sizeof(x_));
 
diff --git a/crypto/signature_creator_win.cc b/crypto/signature_creator_win.cc
index 94fe87d..244b06a 100644
--- a/crypto/signature_creator_win.cc
+++ b/crypto/signature_creator_win.cc
@@ -23,7 +23,7 @@ SignatureCreator* SignatureCreator::Create(RSAPrivateKey* key) {
   return result.release();
 }
 
-SignatureCreator::SignatureCreator() : key_(NULL), hash_object_(0) {}
+SignatureCreator::SignatureCreator() : hash_object_(0) {}
 
 SignatureCreator::~SignatureCreator() {}
 
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index 5ea444c..f4d8774 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -69,8 +69,7 @@ PipelineImpl::PipelineImpl(MessageLoop* message_loop, MediaLog* media_log)
       waiting_for_clock_update_(false),
       state_(kCreated),
       current_bytes_(0),
-      creation_time_(base::Time::Now()),
-      is_downloading_data_(false) {
+      creation_time_(base::Time::Now()) {
   media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated));
   ResetState();
   media_log_->AddEvent(
diff --git a/media/filters/reference_audio_renderer.cc b/media/filters/reference_audio_renderer.cc
index 9aa38eb..8e95628 100644
--- a/media/filters/reference_audio_renderer.cc
+++ b/media/filters/reference_audio_renderer.cc
@@ -13,8 +13,7 @@ namespace media {
 ReferenceAudioRenderer::ReferenceAudioRenderer(AudioManager* audio_manager)
     : AudioRendererBase(),
       audio_manager_(audio_manager),
-      bytes_per_second_(0),
-      buffer_capacity_(0) {
+      bytes_per_second_(0) {
 }
 
 ReferenceAudioRenderer::~ReferenceAudioRenderer() {
diff --git a/net/base/origin_bound_cert_store.cc b/net/base/origin_bound_cert_store.cc
index 6a31a7e..f597204 100644
--- a/net/base/origin_bound_cert_store.cc
+++ b/net/base/origin_bound_cert_store.cc
@@ -6,9 +6,7 @@
 
 namespace net {
 
-OriginBoundCertStore::OriginBoundCert::OriginBoundCert()
-    : type_(CLIENT_CERT_INVALID_TYPE) {
-}
+OriginBoundCertStore::OriginBoundCert::OriginBoundCert() {}
 
 OriginBoundCertStore::OriginBoundCert::OriginBoundCert(
     const std::string& origin,
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 0637f4c..0116e37 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -68,7 +68,7 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
   // an agreement about the application level protocol to speak over a
   // connection.
   enum NextProtoStatus {
-    // WARNING: These values are serialized to disk. Don't change them.
+    // WARNING: These values are serialised to disk. Don't change them.
 
     kNextProtoUnsupported = 0,  // The server doesn't support NPN.
     kNextProtoNegotiated = 1,   // We agreed on a protocol.
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 815ce94..1dcc232 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -447,7 +447,6 @@ SSLClientSocketNSS::SSLClientSocketNSS(ClientSocketHandle* transport_socket,
       cert_verifier_(context.cert_verifier),
       ob_cert_xtn_negotiated_(false),
       origin_bound_cert_service_(context.origin_bound_cert_service),
-      ob_cert_type_(CLIENT_CERT_INVALID_TYPE),
       ob_cert_request_handle_(NULL),
       handshake_callback_called_(false),
       completed_handshake_(false),
diff --git a/net/socket/ssl_server_socket_nss.cc b/net/socket/ssl_server_socket_nss.cc
index 9135464..5b57492 100644
--- a/net/socket/ssl_server_socket_nss.cc
+++ b/net/socket/ssl_server_socket_nss.cc
@@ -60,7 +60,6 @@ SSLServerSocketNSS::SSLServerSocketNSS(
     const SSLConfig& ssl_config)
     : transport_send_busy_(false),
       transport_recv_busy_(false),
-      user_handshake_callback_(NULL),
       nss_fd_(NULL),
       nss_bufs_(NULL),
       transport_socket_(transport_socket),
diff --git a/net/socket/transport_client_socket_pool.cc b/net/socket/transport_client_socket_pool.cc
index 001225e..02d48fba 100644
--- a/net/socket/transport_client_socket_pool.cc
+++ b/net/socket/transport_client_socket_pool.cc
@@ -99,9 +99,7 @@ TransportConnectJob::TransportConnectJob(
                  BoundNetLog::Make(net_log, NetLog::SOURCE_CONNECT_JOB)),
       params_(params),
       client_socket_factory_(client_socket_factory),
-      resolver_(host_resolver),
-      next_state_(STATE_NONE) {
-}
+      resolver_(host_resolver) {}
 
 TransportConnectJob::~TransportConnectJob() {
   // We don't worry about cancelling the host resolution and TCP connect, since
diff --git a/net/url_request/url_request_job_manager.cc b/net/url_request/url_request_job_manager.cc
index f149fb2..71e9e55 100644
--- a/net/url_request/url_request_job_manager.cc
+++ b/net/url_request/url_request_job_manager.cc
@@ -262,10 +262,11 @@ void URLRequestJobManager::UnregisterRequestInterceptor(
   interceptors_.erase(i);
 }
 
-URLRequestJobManager::URLRequestJobManager()
-    : allowed_thread_(0),
-      allowed_thread_initialized_(false),
-      enable_file_access_(false) {
+URLRequestJobManager::URLRequestJobManager() : enable_file_access_(false) {
+#ifndef NDEBUG
+  allowed_thread_ = 0;
+  allowed_thread_initialized_ = false;
+#endif
 }
 
 URLRequestJobManager::~URLRequestJobManager() {}
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h
index 20ef900..7daecae 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h
@@ -37,7 +37,6 @@ class BrowserPpp {
         ppp_messaging_interface_(NULL),
         ppp_input_event_interface_(NULL) {
     CHECK(main_channel_ != NULL);
-    upcall_thread_.tid = 0;
   }
 
   ~BrowserPpp() {}
diff --git a/ppapi/proxy/serialized_structs.cc b/ppapi/proxy/serialized_structs.cc
index bd17e4d..e327b60 100644
--- a/ppapi/proxy/serialized_structs.cc
+++ b/ppapi/proxy/serialized_structs.cc
@@ -73,7 +73,6 @@ PPBFlash_DrawGlyphs_Params::PPBFlash_DrawGlyphs_Params()
   clip.size.width = 0;
   position.x = 0;
   position.y = 0;
-  allow_subpixel_aa = PP_FALSE;
 }
 
 PPBFlash_DrawGlyphs_Params::~PPBFlash_DrawGlyphs_Params() {}
diff --git a/ppapi/shared_impl/ppb_file_io_shared.cc b/ppapi/shared_impl/ppb_file_io_shared.cc
index dcad4d7..a51c33f 100644
--- a/ppapi/shared_impl/ppb_file_io_shared.cc
+++ b/ppapi/shared_impl/ppb_file_io_shared.cc
@@ -24,8 +24,6 @@ using thunk::PPB_FileRef_API;
 PPB_FileIO_Shared::CallbackEntry::CallbackEntry()
     : read_buffer(NULL),
       info(NULL) {
-  callback.func = NULL;
-  callback.user_data = NULL;
 }
 
 PPB_FileIO_Shared::CallbackEntry::CallbackEntry(const CallbackEntry& entry)
diff --git a/remoting/jingle_glue/ssl_socket_adapter.cc b/remoting/jingle_glue/ssl_socket_adapter.cc
index 314e3cd..5bf2f73 100644
--- a/remoting/jingle_glue/ssl_socket_adapter.cc
+++ b/remoting/jingle_glue/ssl_socket_adapter.cc
@@ -29,8 +29,7 @@ SSLSocketAdapter::SSLSocketAdapter(AsyncSocket* socket)
       cert_verifier_(new net::CertVerifier()),
       ssl_state_(SSLSTATE_NONE),
       read_state_(IOSTATE_NONE),
-      write_state_(IOSTATE_NONE),
-      data_transferred_(0) {
+      write_state_(IOSTATE_NONE) {
   transport_socket_ = new TransportSocket(socket, this);
 }
 
diff --git a/webkit/glue/context_menu.cc b/webkit/glue/context_menu.cc
index 634bfd9..d4bad35 100644
--- a/webkit/glue/context_menu.cc
+++ b/webkit/glue/context_menu.cc
@@ -24,7 +24,6 @@ ContextMenuParams::ContextMenuParams()
       is_image_blocked(false),
       frame_id(0),
       media_flags(0),
-      speech_input_enabled(false),
       spellcheck_enabled(false),
       is_editable(false),
       edit_flags(0),
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index 37eed33..3d17f86 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -115,7 +115,6 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
       seeking_(false),
       playback_rate_(0.0f),
       pending_seek_(false),
-      pending_seek_seconds_(0.0f),
       client_(client),
       proxy_(NULL),
       delegate_(delegate),
diff --git a/webkit/plugins/ppapi/ppb_transport_impl.cc b/webkit/plugins/ppapi/ppb_transport_impl.cc
index 23c5ab8..da656c8 100644
--- a/webkit/plugins/ppapi/ppb_transport_impl.cc
+++ b/webkit/plugins/ppapi/ppb_transport_impl.cc
@@ -67,7 +67,6 @@ WebKit::WebFrame* GetFrameForResource(const ::ppapi::Resource* resource) {
 
 PPB_Transport_Impl::PPB_Transport_Impl(PP_Instance instance)
     : Resource(instance),
-      type_(PP_TRANSPORTTYPE_DATAGRAM),
       started_(false),
       writable_(false) {
 }
diff --git a/webkit/plugins/ppapi/ppb_websocket_impl.cc b/webkit/plugins/ppapi/ppb_websocket_impl.cc
index 825a4e9..48bc1f5 100644
--- a/webkit/plugins/ppapi/ppb_websocket_impl.cc
+++ b/webkit/plugins/ppapi/ppb_websocket_impl.cc
@@ -85,12 +85,6 @@ PPB_WebSocket_Impl::PPB_WebSocket_Impl(PP_Instance instance)
       close_was_clean_(PP_FALSE),
       buffered_amount_(0),
       buffered_amount_after_close_(0) {
-  connect_callback_.func = NULL;
-  connect_callback_.user_data = NULL;
-  receive_callback_.func = NULL;
-  receive_callback_.user_data = NULL;
-  close_callback_.func = NULL;
-  close_callback_.user_data = NULL;
   empty_string_ = new StringVar("", 0);
 }