diff options
author | pranay.kumar <pranay.kumar@samsung.com> | 2015-05-04 07:03:58 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-04 14:04:34 +0000 |
commit | 073007884e53864c17468be392431903be8e718e (patch) | |
tree | 0301a2409850ea8de69f9fea793f87aa20b5f95d | |
parent | eccfe8ac8608eff88e71e4f295a72b6a56af3824 (diff) | |
download | chromium_src-073007884e53864c17468be392431903be8e718e.zip chromium_src-073007884e53864c17468be392431903be8e718e.tar.gz chromium_src-073007884e53864c17468be392431903be8e718e.tar.bz2 |
Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome browser extensions module.
MessageLoopProxy is deprecated.
This basically does a search and replace:
MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().
BUG=391045
Review URL: https://codereview.chromium.org/1112573002
Cr-Commit-Position: refs/heads/master@{#328118}
24 files changed, 68 insertions, 51 deletions
diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc index d5b0e9c..077559f 100644 --- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc +++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc @@ -5,8 +5,8 @@ #include <string> #include "base/bind.h" -#include "base/message_loop/message_loop.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h" #include "chrome/browser/extensions/extension_api_unittest.h" @@ -456,7 +456,7 @@ class FakeExtensionSystem : public extensions::TestExtensionSystem { explicit FakeExtensionSystem(Profile* profile) : TestExtensionSystem(profile), prefs_(new extensions::TestExtensionPrefs( - base::MessageLoopProxy::current())) { + base::ThreadTaskRunnerHandle::Get())) { fake_event_router_.reset(new FakeEventRouter(profile, prefs_->prefs())); } diff --git a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc index 08f01f0..0537e65 100644 --- a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc +++ b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc @@ -8,9 +8,9 @@ #include "base/bind.h" #include "base/location.h" -#include "base/message_loop/message_loop_proxy.h" #include "base/prefs/pref_service.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h" #include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h" @@ -57,7 +57,7 @@ class FakeBoolDBusMethod { value_(value) {} void operator() (const chromeos::BoolDBusMethodCallback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, status_, value_)); } @@ -72,7 +72,7 @@ void RegisterKeyCallbackTrue( const std::string& user_id, const std::string& key_name, const cryptohome::AsyncMethodCaller::Callback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, true, cryptohome::MOUNT_ERROR_NONE)); } @@ -82,7 +82,7 @@ void RegisterKeyCallbackFalse( const std::string& user_id, const std::string& key_name, const cryptohome::AsyncMethodCaller::Callback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, false, cryptohome::MOUNT_ERROR_NONE)); } @@ -96,7 +96,7 @@ void SignChallengeCallbackTrue( chromeos::attestation::AttestationChallengeOptions options, const std::string& challenge, const cryptohome::AsyncMethodCaller::DataCallback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, true, "response")); } @@ -110,7 +110,7 @@ void SignChallengeCallbackFalse( chromeos::attestation::AttestationChallengeOptions options, const std::string& challenge, const cryptohome::AsyncMethodCaller::DataCallback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, false, "")); } @@ -122,7 +122,7 @@ void GetCertificateCallbackTrue( bool force_new_key, const chromeos::attestation::AttestationFlow::CertificateCallback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, true, "certificate")); } @@ -134,7 +134,7 @@ void GetCertificateCallbackFalse( bool force_new_key, const chromeos::attestation::AttestationFlow::CertificateCallback& callback) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, false, "")); } diff --git a/chrome/browser/extensions/api/file_handlers/mime_util.cc b/chrome/browser/extensions/api/file_handlers/mime_util.cc index e19f747..76c0534 100644 --- a/chrome/browser/extensions/api/file_handlers/mime_util.cc +++ b/chrome/browser/extensions/api/file_handlers/mime_util.cc @@ -6,6 +6,7 @@ #include "base/files/file_path.h" #include "base/files/file_util.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/profiles/profile.h" #include "content/public/browser/browser_thread.h" #include "net/base/filename_util.h" @@ -191,7 +192,7 @@ void MimeTypeCollector::CollectForLocalPaths( if (!left_) { // Nothing to process. - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback_, base::Passed(&result_))); callback_ = CompletionCallback(); return; @@ -210,7 +211,7 @@ void MimeTypeCollector::OnMimeTypeCollected(size_t index, const std::string& mime_type) { (*result_)[index] = mime_type; if (!--left_) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback_, base::Passed(&result_))); // Release the callback to avoid a circullar reference in case an instance // of this class is a member of a ref counted class, which instance is bound diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc index 96aea63..434ab8e 100644 --- a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc +++ b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc @@ -5,7 +5,7 @@ #include "base/bind.h" #include "base/command_line.h" #include "base/json/json_reader.h" -#include "base/message_loop/message_loop_proxy.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/api/gcd_private/gcd_private_api.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/extensions/extension_service.h" @@ -313,7 +313,7 @@ IN_PROC_BROWSER_TEST_F(GcdPrivateAPITest, AddBefore) { } IN_PROC_BROWSER_TEST_F(GcdPrivateAPITest, AddAfter) { - base::MessageLoopProxy::current()->PostDelayedTask( + base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( FROM_HERE, base::Bind(&local_discovery::TestServiceDiscoveryClient::SimulateReceive, test_service_discovery_client_, @@ -329,7 +329,7 @@ IN_PROC_BROWSER_TEST_F(GcdPrivateAPITest, AddRemove) { test_service_discovery_client_->SimulateReceive(kAnnouncePacket, sizeof(kAnnouncePacket)); - base::MessageLoopProxy::current()->PostDelayedTask( + base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( FROM_HERE, base::Bind(&local_discovery::TestServiceDiscoveryClient::SimulateReceive, test_service_discovery_client_, diff --git a/chrome/browser/extensions/api/messaging/message_property_provider.cc b/chrome/browser/extensions/api/messaging/message_property_provider.cc index c57bb16..cee56d7 100644 --- a/chrome/browser/extensions/api/messaging/message_property_provider.cc +++ b/chrome/browser/extensions/api/messaging/message_property_provider.cc @@ -6,8 +6,8 @@ #include "base/json/json_writer.h" #include "base/logging.h" -#include "base/message_loop/message_loop_proxy.h" #include "base/strings/string_piece.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/profiles/profile.h" #include "content/public/browser/browser_thread.h" @@ -36,7 +36,7 @@ void MessagePropertyProvider::GetChannelID(Profile* profile, profile->GetRequestContext()); content::BrowserThread::PostTask(content::BrowserThread::IO, FROM_HERE, base::Bind(&MessagePropertyProvider::GetChannelIDOnIOThread, - base::MessageLoopProxy::current(), + base::ThreadTaskRunnerHandle::Get(), request_context_getter, source_url.host(), reply)); diff --git a/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc b/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc index 416db29..4977908 100644 --- a/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc +++ b/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc @@ -14,6 +14,7 @@ #include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop_proxy.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/extensions/api/messaging/native_messaging_test_util.h" @@ -64,7 +65,7 @@ class EchoHost : public NativeMessageHost { }; scoped_refptr<base::SingleThreadTaskRunner> task_runner() const override { - return base::MessageLoopProxy::current(); + return base::ThreadTaskRunnerHandle::Get(); }; private: diff --git a/chrome/browser/extensions/api/messaging/native_message_port.cc b/chrome/browser/extensions/api/messaging/native_message_port.cc index 31c5502..8d26d30 100644 --- a/chrome/browser/extensions/api/messaging/native_message_port.cc +++ b/chrome/browser/extensions/api/messaging/native_message_port.cc @@ -6,6 +6,7 @@ #include "base/bind.h" #include "base/single_thread_task_runner.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/api/messaging/native_message_process_host.h" #include "content/public/browser/browser_thread.h" @@ -91,7 +92,7 @@ NativeMessagePort::NativeMessagePort( weak_factory_(this) { core_.reset(new Core(native_message_host.Pass(), weak_factory_.GetWeakPtr(), - base::MessageLoopProxy::current())); + base::ThreadTaskRunnerHandle::Get())); } NativeMessagePort::~NativeMessagePort() { diff --git a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc index cfb88357..bf54695 100644 --- a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc +++ b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc @@ -6,7 +6,7 @@ #include "base/base64.h" #include "base/bind.h" -#include "base/message_loop/message_loop.h" +#include "base/thread_task_runner_handle.h" #include "base/threading/sequenced_worker_pool.h" #include "chrome/common/extensions/api/networking_private/networking_private_crypto.h" #include "chrome/common/extensions/chrome_utility_extensions_messages.h" @@ -100,7 +100,7 @@ void CredentialsGetterHostClient::StartProcessOnIOThread( DCHECK_CURRENTLY_ON(BrowserThread::IO); callback_ = callback; UtilityProcessHost* host = - UtilityProcessHost::Create(this, base::MessageLoopProxy::current()); + UtilityProcessHost::Create(this, base::ThreadTaskRunnerHandle::Get()); host->SetName(l10n_util::GetStringUTF16( IDS_UTILITY_PROCESS_WIFI_CREDENTIALS_GETTER_NAME)); host->ElevatePrivileges(); diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc index fbb1d60..2aad324 100644 --- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc +++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc @@ -5,6 +5,7 @@ #include "base/bind.h" #include "base/command_line.h" #include "base/run_loop.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/sync_file_system/file_status_observer.h" #include "chrome/browser/sync_file_system/local_change_processor.h" @@ -84,7 +85,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest { ACTION_P(NotifyOkStateAndCallback, mock_remote_service) { mock_remote_service->NotifyRemoteServiceStateUpdated( sync_file_system::REMOTE_SERVICE_OK, "Test event description."); - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(arg1, sync_file_system::SYNC_STATUS_OK)); } @@ -104,7 +105,7 @@ ACTION_P6(ReturnWithFakeFileAddedStatus, *origin, base::FilePath(FILE_PATH_LITERAL("foo.txt"))); mock_remote_service->NotifyRemoteChangeQueueUpdated(0); - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(arg0, sync_file_system::SYNC_STATUS_OK, mock_url)); diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc index 60d4d27..934a9e9 100644 --- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc +++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc @@ -19,6 +19,7 @@ #include "base/strings/string_piece.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" +#include "base/thread_task_runner_handle.h" #include "base/time/time.h" #include "chrome/browser/content_settings/cookie_settings.h" #include "chrome/browser/extensions/event_router_forwarder.h" @@ -511,7 +512,9 @@ void ExtensionWebRequestTest::FireURLRequestWithData( element_readers.push_back(new net::UploadBytesElementReader( &(bytes_1[0]), bytes_1.size())); element_readers.push_back( - new net::UploadFileElementReader(base::MessageLoopProxy::current().get(), + new net::UploadFileElementReader( + base::ThreadTaskRunnerHandle::Get() + .get(), base::FilePath(), 0, 0, diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc index a3a58c7..c4406ee 100644 --- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc +++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc @@ -7,10 +7,10 @@ #include "base/bind_helpers.h" #include "base/lazy_instance.h" #include "base/memory/scoped_vector.h" -#include "base/message_loop/message_loop_proxy.h" #include "base/metrics/histogram.h" #include "base/prefs/pref_service.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "base/version.h" #include "chrome/browser/apps/ephemeral_app_launcher.h" @@ -621,7 +621,7 @@ ExtensionFunction::ResponseAction WebstorePrivateInstallBundleFunction::Run() { net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE, net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES); } else { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&WebstorePrivateInstallBundleFunction::OnFetchComplete, this, GURL(), nullptr)); diff --git a/chrome/browser/extensions/blacklist.cc b/chrome/browser/extensions/blacklist.cc index e52eb00..ef1cdfe 100644 --- a/chrome/browser/extensions/blacklist.cc +++ b/chrome/browser/extensions/blacklist.cc @@ -11,7 +11,9 @@ #include "base/lazy_instance.h" #include "base/memory/ref_counted.h" #include "base/prefs/pref_service.h" +#include "base/single_thread_task_runner.h" #include "base/stl_util.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/extensions/blacklist_factory.h" @@ -72,7 +74,7 @@ class SafeBrowsingClientImpl SafeBrowsingClientImpl( const std::set<std::string>& extension_ids, const OnResultCallback& callback) - : callback_message_loop_(base::MessageLoopProxy::current()), + : callback_task_runner_(base::ThreadTaskRunnerHandle::Get()), callback_(callback) { BrowserThread::PostTask( BrowserThread::IO, @@ -93,7 +95,7 @@ class SafeBrowsingClientImpl DCHECK_CURRENTLY_ON(BrowserThread::IO); if (database_manager->CheckExtensionIDs(extension_ids, this)) { // Definitely not blacklisted. Callback immediately. - callback_message_loop_->PostTask( + callback_task_runner_->PostTask( FROM_HERE, base::Bind(callback_, std::set<std::string>())); return; @@ -105,11 +107,11 @@ class SafeBrowsingClientImpl void OnCheckExtensionsResult(const std::set<std::string>& hits) override { DCHECK_CURRENTLY_ON(BrowserThread::IO); - callback_message_loop_->PostTask(FROM_HERE, base::Bind(callback_, hits)); + callback_task_runner_->PostTask(FROM_HERE, base::Bind(callback_, hits)); Release(); // Balanced in StartCheck. } - scoped_refptr<base::MessageLoopProxy> callback_message_loop_; + scoped_refptr<base::SingleThreadTaskRunner> callback_task_runner_; OnResultCallback callback_; DISALLOW_COPY_AND_ASSIGN(SafeBrowsingClientImpl); @@ -191,7 +193,7 @@ void Blacklist::GetBlacklistedIDs(const std::set<std::string>& ids, DCHECK_CURRENTLY_ON(BrowserThread::UI); if (ids.empty() || !g_database_manager.Get().get().get()) { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, BlacklistStateMap())); return; } diff --git a/chrome/browser/extensions/blacklist_state_fetcher.cc b/chrome/browser/extensions/blacklist_state_fetcher.cc index c74831e..8348240 100644 --- a/chrome/browser/extensions/blacklist_state_fetcher.cc +++ b/chrome/browser/extensions/blacklist_state_fetcher.cc @@ -6,6 +6,7 @@ #include "base/stl_util.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/safe_browsing/protocol_manager_helper.h" #include "chrome/browser/safe_browsing/safe_browsing_service.h" @@ -88,7 +89,7 @@ void BlacklistStateFetcher::Request(const std::string& id, SetSafeBrowsingConfig( g_browser_process->safe_browsing_service()->GetProtocolConfig()); } else { - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(callback, BLACKLISTED_UNKNOWN)); return; } diff --git a/chrome/browser/extensions/blacklist_unittest.cc b/chrome/browser/extensions/blacklist_unittest.cc index 84c7680..8902895 100644 --- a/chrome/browser/extensions/blacklist_unittest.cc +++ b/chrome/browser/extensions/blacklist_unittest.cc @@ -3,9 +3,9 @@ // found in the LICENSE file. #include "base/bind.h" -#include "base/message_loop/message_loop.h" #include "base/run_loop.h" #include "base/stl_util.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/blacklist.h" #include "chrome/browser/extensions/blacklist_state_fetcher.h" #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h" @@ -48,7 +48,7 @@ std::set<std::string> Set(const std::string& a, class BlacklistTest : public testing::Test { public: BlacklistTest() - : test_prefs_(base::MessageLoopProxy::current()) {} + : test_prefs_(base::ThreadTaskRunnerHandle::Get()) {} protected: ExtensionPrefs* prefs() { diff --git a/chrome/browser/extensions/extension_service_test_base.cc b/chrome/browser/extensions/extension_service_test_base.cc index 10f16f3..c05d9ef 100644 --- a/chrome/browser/extensions/extension_service_test_base.cc +++ b/chrome/browser/extensions/extension_service_test_base.cc @@ -7,8 +7,8 @@ #include "base/command_line.h" #include "base/files/file_util.h" #include "base/memory/ref_counted.h" -#include "base/message_loop/message_loop.h" #include "base/path_service.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/extension_error_reporter.h" #include "chrome/browser/extensions/extension_garbage_collector_factory.h" #include "chrome/browser/extensions/extension_service.h" @@ -47,7 +47,7 @@ scoped_ptr<TestingProfile> BuildTestingProfile( // TestingPrefServiceSyncable instance. if (!params.pref_file.empty()) { factory.SetUserPrefsFile(params.pref_file, - base::MessageLoopProxy::current().get()); + base::ThreadTaskRunnerHandle::Get().get()); scoped_refptr<user_prefs::PrefRegistrySyncable> registry( new user_prefs::PrefRegistrySyncable); scoped_ptr<PrefServiceSyncable> prefs( @@ -221,7 +221,7 @@ void ExtensionServiceTestBase::CreateExtensionService( params.autoupdate_enabled); service_->SetFileTaskRunnerForTesting( - base::MessageLoopProxy::current().get()); + base::ThreadTaskRunnerHandle::Get().get()); service_->set_extensions_enabled(true); service_->set_show_extensions_prompts(false); service_->set_install_updates_when_idle_for_test(false); diff --git a/chrome/browser/extensions/extension_web_ui.cc b/chrome/browser/extensions/extension_web_ui.cc index ebb22a7..9d6526d 100644 --- a/chrome/browser/extensions/extension_web_ui.cc +++ b/chrome/browser/extensions/extension_web_ui.cc @@ -12,6 +12,7 @@ #include "base/prefs/scoped_user_pref_update.h" #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h" #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/extensions/extension_util.h" @@ -115,7 +116,7 @@ void RunFaviconCallbackAsync( } } - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&favicon::FaviconService::FaviconResultsCallbackRunner, callback, base::Owned(favicon_bitmap_results))); diff --git a/chrome/browser/extensions/fake_safe_browsing_database_manager.cc b/chrome/browser/extensions/fake_safe_browsing_database_manager.cc index f3af7fb..7a02e5c 100644 --- a/chrome/browser/extensions/fake_safe_browsing_database_manager.cc +++ b/chrome/browser/extensions/fake_safe_browsing_database_manager.cc @@ -10,8 +10,8 @@ #include "base/bind_helpers.h" #include "base/memory/ref_counted.h" -#include "base/message_loop/message_loop_proxy.h" #include "base/run_loop.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/safe_browsing/safe_browsing_service.h" #include "chrome/browser/safe_browsing/safe_browsing_util.h" @@ -116,7 +116,7 @@ bool FakeSafeBrowsingDatabaseManager::CheckExtensionIDs( safe_browsing_check->full_hash_results[i] = SB_THREAT_TYPE_EXTENSION; } - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&FakeSafeBrowsingDatabaseManager::OnSafeBrowsingResult, this, diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc index 07c868b..c435799 100644 --- a/chrome/browser/extensions/startup_helper.cc +++ b/chrome/browser/extensions/startup_helper.cc @@ -10,6 +10,7 @@ #include "base/files/file_path.h" #include "base/message_loop/message_loop.h" #include "base/run_loop.h" +#include "base/single_thread_task_runner.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" @@ -174,7 +175,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient { void StartOnFileThread() { CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); - scoped_refptr<base::MessageLoopProxy> file_thread_proxy = + scoped_refptr<base::SingleThreadTaskRunner> file_task_runner = BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE); scoped_refptr<SandboxedUnpacker> unpacker( @@ -182,7 +183,7 @@ class ValidateCrxHelper : public SandboxedUnpackerClient { Manifest::INTERNAL, 0, /* no special creation flags */ temp_dir_, - file_thread_proxy.get(), + file_task_runner.get(), this)); unpacker->Start(); } diff --git a/chrome/browser/extensions/test_blacklist.cc b/chrome/browser/extensions/test_blacklist.cc index f4941bd..254dc7b 100644 --- a/chrome/browser/extensions/test_blacklist.cc +++ b/chrome/browser/extensions/test_blacklist.cc @@ -7,9 +7,9 @@ #include <set> #include "base/bind.h" -#include "base/message_loop/message_loop.h" #include "base/run_loop.h" #include "base/stl_util.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/blacklist.h" #include "chrome/browser/extensions/blacklist_state_fetcher.h" #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h" @@ -36,7 +36,7 @@ void BlacklistStateFetcherMock::Request(const std::string& id, if (ContainsKey(states_, id)) result = states_[id]; - base::MessageLoopProxy::current()->PostTask(FROM_HERE, + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, base::Bind(callback, result)); } diff --git a/chrome/browser/extensions/test_blacklist_state_fetcher.cc b/chrome/browser/extensions/test_blacklist_state_fetcher.cc index 986da8f..9e7ef4c 100644 --- a/chrome/browser/extensions/test_blacklist_state_fetcher.cc +++ b/chrome/browser/extensions/test_blacklist_state_fetcher.cc @@ -4,8 +4,8 @@ #include "chrome/browser/extensions/test_blacklist_state_fetcher.h" -#include "base/message_loop/message_loop.h" #include "base/stl_util.h" +#include "base/thread_task_runner_handle.h" #include "net/url_request/url_request_test_util.h" namespace extensions { @@ -36,7 +36,7 @@ TestBlacklistStateFetcher::TestBlacklistStateFetcher( fetcher_->SetSafeBrowsingConfig(CreateSafeBrowsingProtocolConfig()); scoped_refptr<net::TestURLRequestContextGetter> context = new net::TestURLRequestContextGetter( - base::MessageLoopProxy::current()); + base::ThreadTaskRunnerHandle::Get()); fetcher_->SetURLRequestContextForTest(context.get()); } diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc index 2c8b334..0efe0f6 100644 --- a/chrome/browser/extensions/updater/extension_updater_unittest.cc +++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc @@ -21,6 +21,7 @@ #include "base/strings/string_split.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/threading/thread.h" #include "base/version.h" #include "chrome/browser/chrome_notification_types.h" @@ -647,7 +648,7 @@ class ExtensionUpdaterTest : public testing::Test { } void SetUp() override { - prefs_.reset(new TestExtensionPrefs(base::MessageLoopProxy::current())); + prefs_.reset(new TestExtensionPrefs(base::ThreadTaskRunnerHandle::Get())); } void TearDown() override { @@ -1618,7 +1619,7 @@ class ExtensionUpdaterTest : public testing::Test { // Set up 2 mock extensions, one with a google.com update url and one // without. - prefs_.reset(new TestExtensionPrefs(base::MessageLoopProxy::current())); + prefs_.reset(new TestExtensionPrefs(base::ThreadTaskRunnerHandle::Get())); ServiceForManifestTests service(prefs_.get()); ExtensionList tmp; GURL url1("http://clients2.google.com/service/update2/crx"); diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/browser/extensions/webstore_install_helper.cc index 4b33b46..948d995 100644 --- a/chrome/browser/extensions/webstore_install_helper.cc +++ b/chrome/browser/extensions/webstore_install_helper.cc @@ -7,6 +7,7 @@ #include <string> #include "base/bind.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h" #include "chrome/common/chrome_utility_messages.h" @@ -72,7 +73,7 @@ void WebstoreInstallHelper::Start() { void WebstoreInstallHelper::StartWorkOnIOThread() { CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); utility_host_ = UtilityProcessHost::Create( - this, base::MessageLoopProxy::current().get())->AsWeakPtr(); + this, base::ThreadTaskRunnerHandle::Get().get())->AsWeakPtr(); utility_host_->SetName(l10n_util::GetStringUTF16( IDS_UTILITY_PROCESS_JSON_PARSER_NAME)); utility_host_->StartBatchMode(); diff --git a/chrome/browser/extensions/zipfile_installer.cc b/chrome/browser/extensions/zipfile_installer.cc index aecb2f2..d2f16b2 100644 --- a/chrome/browser/extensions/zipfile_installer.cc +++ b/chrome/browser/extensions/zipfile_installer.cc @@ -6,6 +6,7 @@ #include "base/files/file_util.h" #include "base/path_service.h" +#include "base/thread_task_runner_handle.h" #include "chrome/browser/extensions/extension_error_reporter.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/unpacked_installer.h" @@ -74,7 +75,8 @@ scoped_refptr<ZipFileInstaller> ZipFileInstaller::Create( void ZipFileInstaller::StartWorkOnIOThread(const base::FilePath& temp_dir) { CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); UtilityProcessHost* host = - UtilityProcessHost::Create(this, base::MessageLoopProxy::current().get()); + UtilityProcessHost::Create(this, + base::ThreadTaskRunnerHandle::Get().get()); host->SetName(l10n_util::GetStringUTF16( IDS_UTILITY_PROCESS_ZIP_FILE_INSTALLER_NAME)); host->SetExposedDir(temp_dir); diff --git a/chrome/browser/extensions/zipfile_installer_unittest.cc b/chrome/browser/extensions/zipfile_installer_unittest.cc index 0c8343c..a42b9c5 100644 --- a/chrome/browser/extensions/zipfile_installer_unittest.cc +++ b/chrome/browser/extensions/zipfile_installer_unittest.cc @@ -10,6 +10,7 @@ #include "base/path_service.h" #include "base/run_loop.h" #include "base/strings/string_util.h" +#include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/test_extension_system.h" @@ -96,7 +97,7 @@ class ZipFileInstallerTest : public testing::Test { zipfile_installer_ = ZipFileInstaller::Create(extension_service_); - base::MessageLoopProxy::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&ZipFileInstaller::LoadFromZipFile, zipfile_installer_.get(), |