diff options
author | nhiroki@chromium.org <nhiroki@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 13:26:52 +0000 |
---|---|---|
committer | nhiroki@chromium.org <nhiroki@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 13:26:52 +0000 |
commit | 0904e1384e12f94ddb53d67a0ecd98d8a16bb48d (patch) | |
tree | 874ad7b59d48a32bea7ee22775889607307222bf | |
parent | eb22dc33ca0d43931c39d1ea9e94a46d0d4326a2 (diff) | |
download | chromium_src-0904e1384e12f94ddb53d67a0ecd98d8a16bb48d.zip chromium_src-0904e1384e12f94ddb53d67a0ecd98d8a16bb48d.tar.gz chromium_src-0904e1384e12f94ddb53d67a0ecd98d8a16bb48d.tar.bz2 |
FileAPI: Update outdated comments on ChildProcessSecurityPolicy
BUG=n/a
TEST=n/a
Review URL: https://codereview.chromium.org/52463005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232102 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | content/public/browser/child_process_security_policy.h | 22 |
1 files changed, 9 insertions, 13 deletions
diff --git a/content/public/browser/child_process_security_policy.h b/content/public/browser/child_process_security_policy.h index 6807690..cd83f06 100644 --- a/content/public/browser/child_process_security_policy.h +++ b/content/public/browser/child_process_security_policy.h @@ -66,12 +66,8 @@ class ChildProcessSecurityPolicy { // created for a set of native files/directories (like dropped files) // using fileapi::IsolatedContext. A child process needs to be granted // permission to the file system to access the files in it using - // file system URL. - // - // Note: to grant read access to the content of files you also need - // to give permission directly to the file paths using GrantReadFile. - // TODO(kinuko): We should unify this file-level and file-system-level - // permission when a file is accessed via a file system. + // file system URL. You do NOT need to give direct permission to + // individual file paths. // // Note: files/directories in the same file system share the same // permission as far as they are accessed via the file system, i.e. @@ -82,18 +78,18 @@ class ChildProcessSecurityPolicy { // Grants write access permission to the given isolated file system // identified by |filesystem_id|. See comments for GrantReadFileSystem - // for more details. For writing you do NOT need to give direct permission - // to individual file paths. + // for more details. You do NOT need to give direct permission to + // individual file paths. // // This must be called with a great care as this gives write permission // to all files/directories included in the file system. virtual void GrantWriteFileSystem(int child_id, const std::string& filesystem_id) = 0; - // Grant create file permission to the given isolated file system identified - // by |filesystem_id|. - // See comments for GrantReadFileSystem for more details. For creating you - // do NOT need to give direct permission to individual file paths. + // Grants create file permission to the given isolated file system + // identified by |filesystem_id|. See comments for GrantReadFileSystem + // for more details. You do NOT need to give direct permission to + // individual file paths. // // This must be called with a great care as this gives create permission // within all directories included in the file system. @@ -134,6 +130,6 @@ class ChildProcessSecurityPolicy { const std::string& filesystem_id) = 0; }; -}; // namespace content +} // namespace content #endif // CONTENT_PUBLIC_BROWSER_CHILD_PROCESS_SECURITY_POLICY_H_ |