diff options
author | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-22 00:03:48 +0000 |
---|---|---|
committer | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-22 00:03:48 +0000 |
commit | 090d7108424b5a8600e1b590b2227e52f23d6e7e (patch) | |
tree | b8bcbf8fc24c16e84fdc72806fc3702ce3db0572 | |
parent | 5157dd5fee258e451cb47c2052f8b1ab2b106801 (diff) | |
download | chromium_src-090d7108424b5a8600e1b590b2227e52f23d6e7e.zip chromium_src-090d7108424b5a8600e1b590b2227e52f23d6e7e.tar.gz chromium_src-090d7108424b5a8600e1b590b2227e52f23d6e7e.tar.bz2 |
DOMUI Prefs: Miscellaneous style tweaks
Addresses various small review comments and other issues:
- Removes the min-height for the main-page startup page list, where it doesn't make sense
- Changed the min-height for other lists to a multiple of the list item heights
- Removes some of the left padding in select elements
- Makes the bottom shadow of subpages slightly lighter
- Makes the close buttons centered vertically
- Changes the input type of the Add Startup Page overlay to prevent over-aggresive validation
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6359011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72239 0039d316-1c4b-4281-b951-d872f2087c98
3 files changed, 10 insertions, 4 deletions
diff --git a/chrome/browser/resources/options/add_startup_page_overlay.html b/chrome/browser/resources/options/add_startup_page_overlay.html index c2f97d2..230c1a9 100644 --- a/chrome/browser/resources/options/add_startup_page_overlay.html +++ b/chrome/browser/resources/options/add_startup_page_overlay.html @@ -4,7 +4,7 @@ <form id="addStartupPageForm"> <label id="addURLBlock"><span i18n-content="addStartupPageURLLabel"></span> - <input type="url" id="addStartupPageURL"></label> + <input id="addStartupPageURL"></label> <list id="addStartupRecentPageList"></list> diff --git a/chrome/browser/resources/options/browser_options_page.css b/chrome/browser/resources/options/browser_options_page.css index ea4a2ed..5992c6e 100644 --- a/chrome/browser/resources/options/browser_options_page.css +++ b/chrome/browser/resources/options/browser_options_page.css @@ -4,6 +4,10 @@ padding: 5px 10px; } +#startupPagesShortList { + min-height: 0; +} + .startup-page-list .title { width: 40%; } diff --git a/chrome/browser/resources/options/options_page.css b/chrome/browser/resources/options/options_page.css index fce8293..fef6d6f 100644 --- a/chrome/browser/resources/options/options_page.css +++ b/chrome/browser/resources/options/options_page.css @@ -226,7 +226,7 @@ html[hide-menu=true] #mainview { } .subpage-sheet { - -webkit-box-shadow: #666 0px 3px 5px; + -webkit-box-shadow: #666 0px 2px 5px; background-color: white; border: 1px solid #b8b8b8; border-radius: 2px; @@ -289,7 +289,8 @@ html[hide-menu=true] #mainview { } .page list { - min-height: 200px; + /* Min height is a multiple of the list item height (32) */ + min-height: 192px; } section { @@ -446,6 +447,7 @@ list .close-button { /* TODO(stuartmorgan): Replace with real images once they are available. */ background-image: url("../../../app/theme/close_bar.png"); border: none; + display: block; height: 16px; opacity: 1; width: 16px; @@ -606,7 +608,7 @@ select { font-size: inherit; margin: 0; overflow: hidden; - padding: 2px 20px 2px 12px; + padding: 2px 20px 2px 5px; text-overflow: ellipsis; white-space: nowrap; } |