summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-18 13:52:57 +0000
committergroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-18 13:52:57 +0000
commit0cecd447860421f603339cea1199de71a36d4f86 (patch)
treef4d14b8edbdf8a54c469222375a30348924b7561
parentb3f8a7545884175682532adffca2adea89ec8cde (diff)
downloadchromium_src-0cecd447860421f603339cea1199de71a36d4f86.zip
chromium_src-0cecd447860421f603339cea1199de71a36d4f86.tar.gz
chromium_src-0cecd447860421f603339cea1199de71a36d4f86.tar.bz2
[Memory Sheriff]
Modified waterfall.sh to pass arguments on to match_suppressions. Needed for new features (top-symbols/symbol-filter) R=thestig@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/17286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206976 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-xtools/valgrind/waterfall.sh51
1 files changed, 27 insertions, 24 deletions
diff --git a/tools/valgrind/waterfall.sh b/tools/valgrind/waterfall.sh
index 8f0f4af..bce3e63 100755
--- a/tools/valgrind/waterfall.sh
+++ b/tools/valgrind/waterfall.sh
@@ -177,30 +177,33 @@ EOF
NUMBUILDS=3
CMD=$1
-shift
-
-while getopts “hn:” OPTION
-do
- case $OPTION in
- h)
- usage
- exit
- ;;
- n)
- NUMBUILDS=$OPTARG
- ;;
- ?)
- usage
- exit
- ;;
- esac
-done
-
-shift $((OPTIND-1))
-
if [ $# != 0 ]; then
- usage
- exit 1
+ shift
+fi
+
+# Arguments for "match" are handled in match_suppressions
+if [ "$CMD" != "match" ]; then
+ while getopts “hn:” OPTION
+ do
+ case $OPTION in
+ h)
+ usage
+ exit
+ ;;
+ n)
+ NUMBUILDS=$OPTARG
+ ;;
+ ?)
+ usage
+ exit
+ ;;
+ esac
+ done
+ shift $((OPTIND-1))
+ if [ $# != 0 ]; then
+ usage
+ exit 1
+ fi
fi
if [ "$CMD" = "fetch" ]; then
@@ -208,7 +211,7 @@ if [ "$CMD" = "fetch" ]; then
fetch_logs $WATERFALL_PAGE
fetch_logs $WATERFALL_FYI_PAGE
elif [ "$CMD" = "match" ]; then
- match_suppressions ${@:2}
+ match_suppressions $@
match_gtest_excludes
elif [ "$CMD" = "blame" ]; then
echo The blame command died of bitrot. If you need it, please reimplement it.