diff options
author | hashimoto <hashimoto@chromium.org> | 2014-09-24 22:07:10 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-25 05:07:26 +0000 |
commit | 0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3 (patch) | |
tree | f922b5ae52f2c63869bfbe7df6d0dc13b8750e77 | |
parent | 94d0c1bb01e98f35043ba1d170049a2e10818b59 (diff) | |
download | chromium_src-0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3.zip chromium_src-0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3.tar.gz chromium_src-0e6cd43eb9a467c81382e37f686f3ebfdda5c1d3.tar.bz2 |
Move nsview_additions and hyperlink_text_view to ui/base/cocoa
BUG=402485
TBR=thakis@chrmoium.org for chrome_nibs.gyp
Review URL: https://codereview.chromium.org/595283002
Cr-Commit-Position: refs/heads/master@{#296651}
54 files changed, 76 insertions, 71 deletions
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_main_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_main_container.mm index 108ebc6..fc28d43 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_main_container.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_main_container.mm @@ -11,17 +11,17 @@ #include "base/strings/sys_string_conversions.h" #include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h" #include "chrome/browser/ui/chrome_style.h" -#include "chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h" -#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h" #import "chrome/browser/ui/cocoa/autofill/autofill_details_container.h" +#include "chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h" #import "chrome/browser/ui/cocoa/autofill/autofill_notification_container.h" #import "chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" +#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h" #import "chrome/browser/ui/cocoa/key_equivalent_constants.h" #include "grit/theme_resources.h" #include "skia/ext/skia_utils_mac.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" #import "ui/base/cocoa/controls/blue_label_button.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/cocoa/window_size_constants.h" #include "ui/gfx/range/range.h" diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm index f163397..01a29b3 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm @@ -15,9 +15,9 @@ #include "chrome/browser/ui/chrome_style.h" #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h" #import "chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "grit/theme_resources.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" @interface AutofillNotificationView : NSView { @private diff --git a/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm b/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm index 3176b3b..a4baf81 100644 --- a/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm +++ b/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm @@ -10,12 +10,12 @@ #include "chrome/browser/ui/autofill/generated_credit_card_bubble_controller.h" #include "chrome/browser/ui/autofill/generated_credit_card_bubble_view.h" #import "chrome/browser/ui/cocoa/base_bubble_controller.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/info_bubble_view.h" #import "chrome/browser/ui/cocoa/info_bubble_window.h" #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/cocoa/window_size_constants.h" #include "ui/native_theme/native_theme.h" diff --git a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm index a3db139..8fc9e52 100644 --- a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm +++ b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm @@ -13,11 +13,11 @@ #include "chrome/browser/ui/autofill/popup_constants.h" #include "chrome/browser/ui/chrome_style.h" #include "chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/l10n_util.h" #include "components/autofill/core/browser/popup_item_ids.h" #include "grit/theme_resources.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/font_list.h" #include "ui/gfx/image/image.h" diff --git a/chrome/browser/ui/cocoa/background_gradient_view.mm b/chrome/browser/ui/cocoa/background_gradient_view.mm index 7d0b9bd..1cb6c2f 100644 --- a/chrome/browser/ui/cocoa/background_gradient_view.mm +++ b/chrome/browser/ui/cocoa/background_gradient_view.mm @@ -6,9 +6,9 @@ #import "chrome/browser/themes/theme_properties.h" #import "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/themed_window.h" #include "grit/theme_resources.h" +#import "ui/base/cocoa/nsview_additions.h" @interface BackgroundGradientView (Private) - (void)commonInit; diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm index 50ab741f..8ac9248 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm @@ -10,11 +10,11 @@ #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/themed_window.h" #include "chrome/browser/ui/search/search_ui.h" #include "skia/ext/skia_utils_mac.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/theme_provider.h" #include "ui/gfx/canvas_skia_paint.h" #include "ui/gfx/rect.h" diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm index 13da74c..ffaefda 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm @@ -12,10 +12,10 @@ #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h" #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/view_id_util.h" #include "components/bookmarks/browser/bookmark_model.h" #include "content/public/browser/user_metrics.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" using base::UserMetricsAction; diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm index cd225f1..a9add4a 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm @@ -8,10 +8,10 @@ #include "chrome/browser/signin/signin_promo.h" #include "chrome/browser/ui/chrome_pages.h" #include "chrome/browser/ui/chrome_style.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/grit/generated_resources.h" #include "skia/ext/skia_utils_mac.h" #include "third_party/skia/include/core/SkColor.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util_mac.h" diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm index 2230fc6..4918b47 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller.mm @@ -56,7 +56,6 @@ #import "chrome/browser/ui/cocoa/fullscreen_window.h" #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/presentation_mode_controller.h" #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h" #import "chrome/browser/ui/cocoa/profiles/avatar_button_controller.h" @@ -94,6 +93,7 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" #import "ui/base/cocoa/cocoa_base_utils.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util_mac.h" #include "ui/gfx/mac/scoped_ns_disable_screen_updates.h" diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm index b6909c9..7dadf20 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm @@ -28,19 +28,19 @@ #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h" #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h" #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h" #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h" #include "chrome/browser/ui/extensions/application_launch.h" -#include "chrome/browser/ui/find_bar/find_bar_controller.h" #include "chrome/browser/ui/find_bar/find_bar.h" +#include "chrome/browser/ui/find_bar/find_bar_controller.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/web_contents.h" #include "content/public/test/test_utils.h" #import "testing/gtest_mac.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/animation/slide_animation.h" namespace { diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm index 89bab85..a247738 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm @@ -28,7 +28,6 @@ #import "chrome/browser/ui/cocoa/fullscreen_window.h" #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/presentation_mode_controller.h" #import "chrome/browser/ui/cocoa/profiles/avatar_button_controller.h" #import "chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h" @@ -45,6 +44,7 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" #import "ui/base/cocoa/focus_tracker.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/ui_base_types.h" using content::RenderWidgetHostView; diff --git a/chrome/browser/ui/cocoa/download/download_item_button.mm b/chrome/browser/ui/cocoa/download/download_item_button.mm index 67726e8..7c88b1d 100644 --- a/chrome/browser/ui/cocoa/download/download_item_button.mm +++ b/chrome/browser/ui/cocoa/download/download_item_button.mm @@ -9,8 +9,8 @@ #import "chrome/browser/ui/cocoa/download/download_item_cell.h" #import "chrome/browser/ui/cocoa/download/download_item_controller.h" #import "chrome/browser/ui/cocoa/download/download_shelf_context_menu_controller.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/view_id_util.h" +#import "ui/base/cocoa/nsview_additions.h" @implementation DownloadItemButton diff --git a/chrome/browser/ui/cocoa/download/download_shelf_view.mm b/chrome/browser/ui/cocoa/download/download_shelf_view.mm index 7923038..7563b0c 100644 --- a/chrome/browser/ui/cocoa/download/download_shelf_view.mm +++ b/chrome/browser/ui/cocoa/download/download_shelf_view.mm @@ -6,11 +6,11 @@ #include "chrome/browser/themes/theme_properties.h" #include "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h" #import "chrome/browser/ui/cocoa/themed_window.h" #import "chrome/browser/ui/cocoa/view_id_util.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" @implementation DownloadShelfView diff --git a/chrome/browser/ui/cocoa/download/download_show_all_button.mm b/chrome/browser/ui/cocoa/download/download_show_all_button.mm index 11ba3bb..1220112 100644 --- a/chrome/browser/ui/cocoa/download/download_show_all_button.mm +++ b/chrome/browser/ui/cocoa/download/download_show_all_button.mm @@ -6,9 +6,9 @@ #include "base/logging.h" #import "chrome/browser/ui/cocoa/download/download_show_all_cell.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/view_id_util.h" #include "grit/theme_resources.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/image/image.h" diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm index e43d063..b7e99b5 100644 --- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm +++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm @@ -24,7 +24,6 @@ #include "chrome/browser/ui/cocoa/browser_window_controller.h" #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" #include "chrome/browser/ui/cocoa/hover_close_button.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/cocoa/info_bubble_view.h" #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" #include "chrome/browser/ui/cocoa/new_tab_button.h" @@ -45,6 +44,7 @@ #include "extensions/common/extension.h" #import "skia/ext/skia_utils_mac.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util.h" using content::BrowserThread; diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm index cabe1be..60e21af 100644 --- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm +++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm @@ -16,7 +16,6 @@ #import "chrome/browser/ui/cocoa/find_bar/find_bar_text_field.h" #import "chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h" #import "chrome/browser/ui/cocoa/image_button_cell.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h" #include "chrome/browser/ui/find_bar/find_bar_controller.h" #include "chrome/browser/ui/find_bar/find_tab_helper.h" @@ -26,6 +25,7 @@ #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h" #import "ui/base/cocoa/find_pasteboard.h" #import "ui/base/cocoa/focus_tracker.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/resources/grit/ui_resources.h" using content::NativeWebKeyboardEvent; diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_view.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_view.mm index 4250a57..41dfa64 100644 --- a/chrome/browser/ui/cocoa/find_bar/find_bar_view.mm +++ b/chrome/browser/ui/cocoa/find_bar/find_bar_view.mm @@ -4,11 +4,11 @@ #import "chrome/browser/ui/cocoa/find_bar/find_bar_view.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/themed_window.h" #import "chrome/browser/ui/cocoa/url_drop_target.h" #import "chrome/browser/ui/cocoa/view_id_util.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" namespace { diff --git a/chrome/browser/ui/cocoa/framed_browser_window.mm b/chrome/browser/ui/cocoa/framed_browser_window.mm index 0989b6a..78a2079 100644 --- a/chrome/browser/ui/cocoa/framed_browser_window.mm +++ b/chrome/browser/ui/cocoa/framed_browser_window.mm @@ -8,16 +8,16 @@ #include "base/mac/sdk_forward_declarations.h" #include "chrome/browser/global_keyboard_shortcuts_mac.h" #include "chrome/browser/profiles/profile_avatar_icon_util.h" +#include "chrome/browser/themes/theme_properties.h" +#include "chrome/browser/themes/theme_service.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" #import "chrome/browser/ui/cocoa/browser_window_utils.h" #import "chrome/browser/ui/cocoa/custom_frame_view.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h" #import "chrome/browser/ui/cocoa/themed_window.h" -#include "chrome/browser/themes/theme_properties.h" -#include "chrome/browser/themes/theme_service.h" #include "grit/theme_resources.h" #include "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" // Implementer's note: Moving the window controls is tricky. When altering the // code, ensure that: diff --git a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm index de26281..0b52383 100644 --- a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm +++ b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm @@ -15,7 +15,6 @@ #include "chrome/browser/ui/browser_commands.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" #import "chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/info_bubble_view.h" #import "chrome/browser/ui/cocoa/info_bubble_window.h" #include "chrome/browser/ui/fullscreen/fullscreen_controller.h" @@ -26,6 +25,7 @@ #include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" #include "ui/base/accelerators/platform_accelerator_cocoa.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util_mac.h" #include "ui/strings/grit/ui_strings.h" diff --git a/chrome/browser/ui/cocoa/gradient_button_cell.mm b/chrome/browser/ui/cocoa/gradient_button_cell.mm index 4cd6f37..88b3e4b 100644 --- a/chrome/browser/ui/cocoa/gradient_button_cell.mm +++ b/chrome/browser/ui/cocoa/gradient_button_cell.mm @@ -10,12 +10,12 @@ #import "base/mac/scoped_nsobject.h" #import "chrome/browser/themes/theme_properties.h" #import "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/rect_path_utils.h" #import "chrome/browser/ui/cocoa/themed_window.h" #include "grit/theme_resources.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" @interface GradientButtonCell (Private) diff --git a/chrome/browser/ui/cocoa/image_button_cell.mm b/chrome/browser/ui/cocoa/image_button_cell.mm index cefb4d3..6572d2b 100644 --- a/chrome/browser/ui/cocoa/image_button_cell.mm +++ b/chrome/browser/ui/cocoa/image_button_cell.mm @@ -6,9 +6,9 @@ #include "base/logging.h" #import "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/rect_path_utils.h" #import "chrome/browser/ui/cocoa/themed_window.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/image/image.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" diff --git a/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm index 16e83e09..506c896 100644 --- a/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm +++ b/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm @@ -6,10 +6,10 @@ #include "base/logging.h" #include "base/strings/sys_string_conversions.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" #include "chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h" #import "ui/base/cocoa/cocoa_base_utils.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/window_open_disposition.h" @implementation AlternateNavInfoBarController diff --git a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm index 7931c3a..405305b 100644 --- a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm +++ b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm @@ -6,11 +6,11 @@ #include "base/logging.h" #include "base/strings/sys_string_conversions.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" #include "components/infobars/core/confirm_infobar_delegate.h" #include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" #import "ui/base/cocoa/cocoa_base_utils.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/window_open_disposition.h" @implementation ConfirmInfoBarController diff --git a/chrome/browser/ui/cocoa/infobars/infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/infobar_controller.mm index 9dc93ff..5137178 100644 --- a/chrome/browser/ui/cocoa/infobars/infobar_controller.mm +++ b/chrome/browser/ui/cocoa/infobars/infobar_controller.mm @@ -10,7 +10,6 @@ #include "chrome/browser/infobars/infobar_service.h" #import "chrome/browser/ui/cocoa/animatable_view.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/image_button_cell.h" #include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" #import "chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h" @@ -18,6 +17,7 @@ #import "chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h" #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" #include "grit/theme_resources.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/gfx/image/image.h" #include "ui/resources/grit/ui_resources.h" diff --git a/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm b/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm index e96d567..0e58c15 100644 --- a/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm +++ b/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm @@ -9,10 +9,10 @@ #import "chrome/browser/ui/cocoa/browser_window_controller.h" #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/themed_window.h" #include "components/infobars/core/infobar.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/theme_provider.h" @implementation InfoBarGradientView diff --git a/chrome/browser/ui/cocoa/infobars/infobar_utilities.mm b/chrome/browser/ui/cocoa/infobars/infobar_utilities.mm index aeec574..2ff64d0 100644 --- a/chrome/browser/ui/cocoa/infobars/infobar_utilities.mm +++ b/chrome/browser/ui/cocoa/infobars/infobar_utilities.mm @@ -7,8 +7,8 @@ #include "base/mac/scoped_nsobject.h" #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" #import "chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "components/infobars/core/infobar.h" +#import "ui/base/cocoa/nsview_additions.h" @interface InfobarLabelTextField : NSTextField @end diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm index e43e54a..38b5a4e 100644 --- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm +++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm @@ -11,11 +11,11 @@ #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h" #import "chrome/browser/ui/cocoa/location_bar/button_decoration.h" #import "chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "extensions/common/feature_switch.h" #include "grit/theme_resources.h" #import "third_party/mozilla/NSPasteboard+Utils.h" #import "ui/base/cocoa/appkit_utils.h" +#import "ui/base/cocoa/nsview_additions.h" #import "ui/base/cocoa/tracking_area.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" diff --git a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm index 63e03f2..09ccff2 100644 --- a/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm +++ b/chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm @@ -13,12 +13,12 @@ #include "chrome/browser/search/search.h" #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" #import "chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "content/public/browser/user_metrics.h" #include "extensions/browser/extension_icon_image.h" #include "grit/theme_resources.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/image/image.h" namespace { diff --git a/chrome/browser/ui/cocoa/menu_button.mm b/chrome/browser/ui/cocoa/menu_button.mm index 8d27401..2bf7378 100644 --- a/chrome/browser/ui/cocoa/menu_button.mm +++ b/chrome/browser/ui/cocoa/menu_button.mm @@ -6,7 +6,7 @@ #include "base/logging.h" #import "chrome/browser/ui/cocoa/clickhold_button_cell.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" +#import "ui/base/cocoa/nsview_additions.h" @interface MenuButton (Private) - (void)showMenu:(BOOL)isDragging; diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm index 1e43cea..49f9a0d 100644 --- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm +++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.mm @@ -4,8 +4,8 @@ #import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #include "grit/theme_resources.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/resource/resource_bundle.h" @implementation OmniboxPopupTopSeparatorView diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm index cfc85e1..09f2623 100644 --- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm +++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm @@ -8,7 +8,6 @@ #include "base/logging.h" #include "base/mac/bundle_locations.h" #import "chrome/browser/ui/chrome_style.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/sync/one_click_signin_helper.h" #include "chrome/browser/ui/sync/one_click_signin_histogram.h" #include "chrome/common/url_constants.h" @@ -18,6 +17,7 @@ #include "grit/components_strings.h" #include "skia/ext/skia_utils_mac.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util_mac.h" namespace { diff --git a/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm b/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm index beca1ff..f82f3f6 100644 --- a/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm +++ b/chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm @@ -8,7 +8,6 @@ #include "base/logging.h" #include "base/mac/scoped_nsautorelease_pool.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h" #import "chrome/browser/ui/panels/panel_constants.h" #include "chrome/grit/generated_resources.h" @@ -16,6 +15,7 @@ #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSBezierPath+RoundRect.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h" #import "ui/base/cocoa/hover_image_button.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/l10n/l10n_util_mac.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/image/image.h" diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm index b822f33..adaa08a 100644 --- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm +++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_confirmation_view_controller.mm @@ -8,13 +8,13 @@ #include "base/strings/sys_string_conversions.h" #include "chrome/browser/ui/chrome_style.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" #include "grit/generated_resources.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" +#include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/font_list.h" -#include "ui/base/l10n/l10n_util.h" using namespace password_manager::mac::ui; diff --git a/chrome/browser/ui/cocoa/presentation_mode_controller.mm b/chrome/browser/ui/cocoa/presentation_mode_controller.mm index 17e6e84..d92fb7b 100644 --- a/chrome/browser/ui/cocoa/presentation_mode_controller.mm +++ b/chrome/browser/ui/cocoa/presentation_mode_controller.mm @@ -7,13 +7,13 @@ #include <algorithm> #include "base/command_line.h" -#include "base/mac/sdk_forward_declarations.h" #import "base/mac/mac_util.h" +#include "base/mac/sdk_forward_declarations.h" #include "chrome/browser/fullscreen.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #include "chrome/common/chrome_switches.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h" +#import "ui/base/cocoa/nsview_additions.h" NSString* const kWillEnterFullscreenNotification = @"WillEnterFullscreenNotification"; diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm index 861af99..0d00e35 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm @@ -34,12 +34,11 @@ #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/chrome_pages.h" #include "chrome/browser/ui/chrome_style.h" -#include "chrome/browser/ui/user_manager.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/info_bubble_view.h" #import "chrome/browser/ui/cocoa/info_bubble_window.h" #import "chrome/browser/ui/cocoa/profiles/user_manager_mac.h" #include "chrome/browser/ui/singleton_tabs.h" +#include "chrome/browser/ui/user_manager.h" #include "chrome/browser/ui/webui/signin/login_ui_service.h" #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h" #include "chrome/common/pref_names.h" @@ -59,6 +58,7 @@ #import "ui/base/cocoa/cocoa_base_utils.h" #import "ui/base/cocoa/controls/blue_label_button.h" #import "ui/base/cocoa/controls/hyperlink_button_cell.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #import "ui/base/cocoa/hover_image_button.h" #include "ui/base/cocoa/window_size_constants.h" #include "ui/base/l10n/l10n_util.h" diff --git a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm index 7413fec..d9879a4 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm @@ -16,7 +16,6 @@ #import "chrome/browser/ui/chrome_style.h" #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.h" #import "chrome/browser/ui/cocoa/hover_close_button.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/host_desktop.h" #include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h" #include "chrome/common/url_constants.h" @@ -26,6 +25,7 @@ #include "skia/ext/skia_utils_mac.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" #import "ui/base/cocoa/controls/hyperlink_button_cell.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util.h" namespace { diff --git a/chrome/browser/ui/cocoa/styled_text_field_cell.mm b/chrome/browser/ui/cocoa/styled_text_field_cell.mm index 9b883ab..90a9784 100644 --- a/chrome/browser/ui/cocoa/styled_text_field_cell.mm +++ b/chrome/browser/ui/cocoa/styled_text_field_cell.mm @@ -7,10 +7,10 @@ #include "base/logging.h" #include "chrome/browser/themes/theme_properties.h" #include "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/themed_window.h" #include "grit/theme_resources.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/font.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm index 0067968..0a813a4 100644 --- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm @@ -5,11 +5,11 @@ #include "base/debug/debugger.h" #include "base/mac/scoped_nsobject.h" #import "chrome/browser/ui/cocoa/cocoa_test_helper.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h" #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" @interface SadTabView (ExposedForTesting) // Implementation is below. diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm index 735bbc5..c33f1c1 100644 --- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm +++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm @@ -6,12 +6,12 @@ #include "base/logging.h" #include "base/strings/sys_string_conversions.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h" #include "chrome/common/url_constants.h" #include "chrome/grit/generated_resources.h" #include "grit/theme_resources.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/l10n/l10n_util_mac.h" #include "ui/base/resource/resource_bundle.h" diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm index 2d546af..df4d718d 100644 --- a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm +++ b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm @@ -11,13 +11,13 @@ #include "chrome/browser/themes/theme_service.h" #import "chrome/browser/ui/cocoa/browser_window_controller.h" #import "chrome/browser/ui/cocoa/new_tab_button.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h" #import "chrome/browser/ui/cocoa/tabs/tab_view.h" #import "chrome/browser/ui/cocoa/view_id_util.h" #include "chrome/grit/generated_resources.h" #include "grit/theme_resources.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/l10n/l10n_util_mac.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" diff --git a/chrome/browser/ui/cocoa/tabs/tab_view.mm b/chrome/browser/ui/cocoa/tabs/tab_view.mm index 0cea57e..1cf99d4 100644 --- a/chrome/browser/ui/cocoa/tabs/tab_view.mm +++ b/chrome/browser/ui/cocoa/tabs/tab_view.mm @@ -9,7 +9,6 @@ #include "base/mac/sdk_forward_declarations.h" #include "base/strings/sys_string_conversions.h" #include "chrome/browser/themes/theme_service.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" #import "chrome/browser/ui/cocoa/tabs/tab_controller.h" #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h" #import "chrome/browser/ui/cocoa/themed_window.h" @@ -18,6 +17,7 @@ #include "grit/theme_resources.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMFadeTruncatingTextFieldCell.h" #import "ui/base/cocoa/nsgraphics_context_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm index 4538bc7..33b51a3 100644 --- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm +++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm @@ -18,7 +18,6 @@ #import "chrome/browser/ui/cocoa/browser_window_utils.h" #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h" #import "chrome/browser/ui/cocoa/hover_close_button.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #import "chrome/browser/ui/cocoa/info_bubble_view.h" #import "chrome/browser/ui/cocoa/info_bubble_window.h" #include "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h" @@ -32,6 +31,7 @@ #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/user_metrics.h" #include "skia/ext/skia_utils_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #import "ui/base/cocoa/menu_controller.h" #include "ui/base/cocoa/window_size_constants.h" #include "ui/base/l10n/l10n_util_mac.h" diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi index d7aa205..9bb9704 100644 --- a/chrome/chrome_browser_ui.gypi +++ b/chrome/chrome_browser_ui.gypi @@ -484,8 +484,6 @@ 'browser/ui/cocoa/hover_close_button.mm', 'browser/ui/cocoa/hung_renderer_controller.h', 'browser/ui/cocoa/hung_renderer_controller.mm', - 'browser/ui/cocoa/hyperlink_text_view.h', - 'browser/ui/cocoa/hyperlink_text_view.mm', 'browser/ui/cocoa/image_button_cell.h', 'browser/ui/cocoa/image_button_cell.mm', 'browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm', @@ -594,8 +592,6 @@ 'browser/ui/cocoa/notifications/message_center_tray_bridge.mm', 'browser/ui/cocoa/nsmenuitem_additions.h', 'browser/ui/cocoa/nsmenuitem_additions.mm', - 'browser/ui/cocoa/nsview_additions.h', - 'browser/ui/cocoa/nsview_additions.mm', 'browser/ui/cocoa/omnibox/omnibox_popup_cell.h', 'browser/ui/cocoa/omnibox/omnibox_popup_cell.mm', 'browser/ui/cocoa/omnibox/omnibox_popup_matrix.h', diff --git a/chrome/chrome_nibs.gyp b/chrome/chrome_nibs.gyp index b2a661c..f0ea18f 100644 --- a/chrome/chrome_nibs.gyp +++ b/chrome/chrome_nibs.gyp @@ -47,6 +47,8 @@ '../ui/base/cocoa/hover_image_button.mm', '../ui/base/cocoa/menu_controller.h', '../ui/base/cocoa/menu_controller.mm', + '../ui/base/cocoa/nsview_additions.h', + '../ui/base/cocoa/nsview_additions.mm', 'browser/app_controller_mac.h', 'browser/app_controller_mac.mm', 'browser/ui/cocoa/about_ipc_controller.h', @@ -185,8 +187,6 @@ 'browser/ui/cocoa/new_tab_button.mm', 'browser/ui/cocoa/nsmenuitem_additions.h', 'browser/ui/cocoa/nsmenuitem_additions.mm', - 'browser/ui/cocoa/nsview_additions.h', - 'browser/ui/cocoa/nsview_additions.mm', 'browser/ui/cocoa/one_click_signin_view_controller.h', 'browser/ui/cocoa/one_click_signin_view_controller.mm', 'browser/ui/cocoa/screen_capture_notification_ui_cocoa.h', diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index a1f9345..2a1e922 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -1039,7 +1039,6 @@ 'browser/ui/cocoa/history_overlay_controller_unittest.mm', 'browser/ui/cocoa/hover_close_button_unittest.mm', 'browser/ui/cocoa/hung_renderer_controller_unittest.mm', - 'browser/ui/cocoa/hyperlink_text_view_unittest.mm', 'browser/ui/cocoa/image_button_cell_unittest.mm', 'browser/ui/cocoa/info_bubble_view_unittest.mm', 'browser/ui/cocoa/info_bubble_window_unittest.mm', @@ -1063,7 +1062,6 @@ 'browser/ui/cocoa/menu_button_unittest.mm', 'browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm', 'browser/ui/cocoa/nsmenuitem_additions_unittest.mm', - 'browser/ui/cocoa/nsview_additions_unittest.mm', 'browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm', 'browser/ui/cocoa/omnibox/omnibox_popup_matrix_unittest.mm', 'browser/ui/cocoa/omnibox/omnibox_popup_separator_view_unittest.mm', diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn index 0436bec..bc4e0c4 100644 --- a/ui/base/BUILD.gn +++ b/ui/base/BUILD.gn @@ -65,6 +65,8 @@ component("base") { "cocoa/controls/hover_image_menu_button_cell.mm", "cocoa/controls/hyperlink_button_cell.h", "cocoa/controls/hyperlink_button_cell.mm", + "cocoa/controls/hyperlink_text_view.h", + "cocoa/controls/hyperlink_text_view.mm", "cocoa/find_pasteboard.h", "cocoa/find_pasteboard.mm", "cocoa/flipped_view.h", @@ -85,6 +87,8 @@ component("base") { "cocoa/nib_loading.mm", "cocoa/nsgraphics_context_additions.h", "cocoa/nsgraphics_context_additions.mm", + "cocoa/nsview_additions.h", + "cocoa/nsview_additions.mm", "cocoa/remote_layer_api.h", "cocoa/remote_layer_api.mm", "cocoa/tracking_area.h", @@ -735,11 +739,13 @@ test("unittests") { "cocoa/controls/blue_label_button_unittest.mm", "cocoa/controls/hover_image_menu_button_unittest.mm", "cocoa/controls/hyperlink_button_cell_unittest.mm", + "cocoa/controls/hyperlink_text_view_unittest.mm", "cocoa/focus_tracker_unittest.mm", "cocoa/fullscreen_window_manager_unittest.mm", "cocoa/hover_image_button_unittest.mm", "cocoa/menu_controller_unittest.mm", "cocoa/nsgraphics_context_additions_unittest.mm", + "cocoa/nsview_additions_unittest.mm", "cocoa/tracking_area_unittest.mm", "dragdrop/os_exchange_data_provider_aurax11_unittest.cc", "models/list_model_unittest.cc", diff --git a/chrome/browser/ui/cocoa/hyperlink_text_view.h b/ui/base/cocoa/controls/hyperlink_text_view.h index 5ec6934..5ec6934 100644 --- a/chrome/browser/ui/cocoa/hyperlink_text_view.h +++ b/ui/base/cocoa/controls/hyperlink_text_view.h diff --git a/chrome/browser/ui/cocoa/hyperlink_text_view.mm b/ui/base/cocoa/controls/hyperlink_text_view.mm index a58eb1d..0afaafa 100644 --- a/chrome/browser/ui/cocoa/hyperlink_text_view.mm +++ b/ui/base/cocoa/controls/hyperlink_text_view.mm @@ -2,10 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" #include "base/mac/scoped_nsobject.h" -#include "chrome/browser/ui/cocoa/nsview_additions.h" +#include "ui/base/cocoa/nsview_additions.h" // The baseline shift for text in the NSTextView. const float kTextBaselineShift = -1.0; diff --git a/chrome/browser/ui/cocoa/hyperlink_text_view_unittest.mm b/ui/base/cocoa/controls/hyperlink_text_view_unittest.mm index 7a4d216..37f4a54 100644 --- a/chrome/browser/ui/cocoa/hyperlink_text_view_unittest.mm +++ b/ui/base/cocoa/controls/hyperlink_text_view_unittest.mm @@ -3,13 +3,13 @@ // found in the LICENSE file. #include "base/mac/scoped_nsobject.h" -#import "chrome/browser/ui/cocoa/cocoa_test_helper.h" -#import "chrome/browser/ui/cocoa/hyperlink_text_view.h" #include "testing/gtest_mac.h" +#import "ui/base/cocoa/controls/hyperlink_text_view.h" +#import "ui/gfx/test/ui_cocoa_test_helper.h" namespace { -class HyperlinkTextViewTest : public CocoaTest { +class HyperlinkTextViewTest : public ui::CocoaTest { public: HyperlinkTextViewTest() { NSRect frame = NSMakeRect(0, 0, 50, 50); diff --git a/chrome/browser/ui/cocoa/nsview_additions.h b/ui/base/cocoa/nsview_additions.h index 2bbe42b..962d89b 100644 --- a/chrome/browser/ui/cocoa/nsview_additions.h +++ b/ui/base/cocoa/nsview_additions.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_UI_COCOA_NSVIEW_ADDITIONS_H_ -#define CHROME_BROWSER_UI_COCOA_NSVIEW_ADDITIONS_H_ +#ifndef UI_BASE_COCOA_NSVIEW_ADDITIONS_H_ +#define UI_BASE_COCOA_NSVIEW_ADDITIONS_H_ #import <Cocoa/Cocoa.h> @@ -43,4 +43,4 @@ @end -#endif // CHROME_BROWSER_UI_COCOA_NSVIEW_ADDITIONS_H_ +#endif // UI_BASE_COCOA_NSVIEW_ADDITIONS_H_ diff --git a/chrome/browser/ui/cocoa/nsview_additions.mm b/ui/base/cocoa/nsview_additions.mm index 5cf3fa1..068d13d 100644 --- a/chrome/browser/ui/cocoa/nsview_additions.mm +++ b/ui/base/cocoa/nsview_additions.mm @@ -4,8 +4,7 @@ #include "base/mac/mac_util.h" #include "base/mac/sdk_forward_declarations.h" -#import "chrome/browser/ui/cocoa/nsview_additions.h" -#include "chrome/common/chrome_switches.h" +#import "ui/base/cocoa/nsview_additions.h" #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h" #include "base/logging.h" diff --git a/chrome/browser/ui/cocoa/nsview_additions_unittest.mm b/ui/base/cocoa/nsview_additions_unittest.mm index a9b7468..80ad751 100644 --- a/chrome/browser/ui/cocoa/nsview_additions_unittest.mm +++ b/ui/base/cocoa/nsview_additions_unittest.mm @@ -2,14 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#import "chrome/browser/ui/cocoa/nsview_additions.h" +#import "ui/base/cocoa/nsview_additions.h" #include "base/mac/scoped_nsobject.h" -#import "chrome/browser/ui/cocoa/cocoa_test_helper.h" #include "testing/gtest/include/gtest/gtest.h" #import "testing/gtest_mac.h" +#import "ui/gfx/test/ui_cocoa_test_helper.h" -typedef CocoaTest NSViewChromeAdditionsTest; +typedef ui::CocoaTest NSViewChromeAdditionsTest; @interface ParentView : NSView { @private diff --git a/ui/base/ui_base.gyp b/ui/base/ui_base.gyp index 96cb8d9..0d7c90d 100644 --- a/ui/base/ui_base.gyp +++ b/ui/base/ui_base.gyp @@ -91,6 +91,8 @@ 'cocoa/controls/hover_image_menu_button_cell.mm', 'cocoa/controls/hyperlink_button_cell.h', 'cocoa/controls/hyperlink_button_cell.mm', + 'cocoa/controls/hyperlink_text_view.h', + 'cocoa/controls/hyperlink_text_view.mm', 'cocoa/find_pasteboard.h', 'cocoa/find_pasteboard.mm', 'cocoa/flipped_view.h', @@ -111,6 +113,8 @@ 'cocoa/nib_loading.mm', 'cocoa/nsgraphics_context_additions.h', 'cocoa/nsgraphics_context_additions.mm', + 'cocoa/nsview_additions.h', + 'cocoa/nsview_additions.mm', 'cocoa/remote_layer_api.h', 'cocoa/remote_layer_api.mm', 'cocoa/tracking_area.h', diff --git a/ui/base/ui_base_tests.gypi b/ui/base/ui_base_tests.gypi index ac7197f..44a251a 100644 --- a/ui/base/ui_base_tests.gypi +++ b/ui/base/ui_base_tests.gypi @@ -48,11 +48,13 @@ 'cocoa/controls/blue_label_button_unittest.mm', 'cocoa/controls/hover_image_menu_button_unittest.mm', 'cocoa/controls/hyperlink_button_cell_unittest.mm', + 'cocoa/controls/hyperlink_text_view_unittest.mm', 'cocoa/focus_tracker_unittest.mm', 'cocoa/fullscreen_window_manager_unittest.mm', 'cocoa/hover_image_button_unittest.mm', 'cocoa/menu_controller_unittest.mm', 'cocoa/nsgraphics_context_additions_unittest.mm', + 'cocoa/nsview_additions_unittest.mm', 'cocoa/tracking_area_unittest.mm', 'dragdrop/os_exchange_data_provider_aurax11_unittest.cc', 'ime/candidate_window_unittest.cc', |