diff options
| author | Kibeom Kim <kkimlabs@chromium.org> | 2015-01-20 11:24:37 -0800 |
|---|---|---|
| committer | Kibeom Kim <kkimlabs@chromium.org> | 2015-01-20 19:27:03 +0000 |
| commit | 1026a0e87e7108b141812c78c8f2efcf927baefa (patch) | |
| tree | c6a474fc0dddc247a71e51ec85620b561a561418 | |
| parent | cf771b70bb2393715373fc3cde219a09d2815f97 (diff) | |
| download | chromium_src-1026a0e87e7108b141812c78c8f2efcf927baefa.zip chromium_src-1026a0e87e7108b141812c78c8f2efcf927baefa.tar.gz chromium_src-1026a0e87e7108b141812c78c8f2efcf927baefa.tar.bz2 | |
[Android] Fix not showing bookmarks under "All items" when not signed in
On Enhanced bookmark mode, there was no bookmark shown under
"All bookmarks" even if user has bookmarks under "Uncategorized", when
user is not signed in.
The reason was that |BookmarksBridge#IsFolderAvailable| filtered out
desktop and others nodes if it's not signed in because we wanted to hide
them for the old bookmark UI.
Anyways, |BookmarksBridge#IsFolderAvailable| is not so relavent at
|BookmarksBridge::GetAllBookmarkIDsOrderedByCreationDate|'s context so
just remove it.
BUG=447360
Review URL: https://codereview.chromium.org/824913003
Cr-Commit-Position: refs/heads/master@{#311134}
(cherry picked from commit a61b5487a760254cb4df9d7acfc71f8cafe2e824)
TBR=tedchoc@chromium.org
Review URL: https://codereview.chromium.org/854393003
Cr-Commit-Position: refs/branch-heads/2272@{#62}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
| -rw-r--r-- | chrome/browser/android/bookmarks/bookmarks_bridge.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc index d3978e5..1089e78 100644 --- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc +++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc @@ -468,8 +468,7 @@ void BookmarksBridge::GetAllBookmarkIDsOrderedByCreationDate( for (int i = 0; i < (*folder_iter)->child_count(); ++i) { const BookmarkNode* child = (*folder_iter)->GetChild(i); - if (!IsFolderAvailable(child) || !IsReachable(child) || - client_->IsDescendantOfManagedNode(child)) + if (!IsReachable(child) || client_->IsDescendantOfManagedNode(child)) continue; if (child->is_folder()) { |