diff options
| author | philipj <philipj@opera.com> | 2015-11-24 07:20:13 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-24 15:21:05 +0000 |
| commit | 122f84f37a2ff865c3e76ff99280b24da8f2a2f9 (patch) | |
| tree | b27d83e610d67d1658ded39aa99155aead1eabe4 | |
| parent | 760092291653c7591c6a2d99e4069ec6a5bf3d58 (diff) | |
| download | chromium_src-122f84f37a2ff865c3e76ff99280b24da8f2a2f9.zip chromium_src-122f84f37a2ff865c3e76ff99280b24da8f2a2f9.tar.gz chromium_src-122f84f37a2ff865c3e76ff99280b24da8f2a2f9.tar.bz2 | |
Sync the URL constructor with the spec
https://url.spec.whatwg.org/#api
This changes the generated code, but ought not be observable, as any
call to `new URL(x, urlObject)` will now instead behaves as
`new URL(x, urlObject.toString())`.
BUG=460722
Review URL: https://codereview.chromium.org/1464133002
Cr-Commit-Position: refs/heads/master@{#361342}
| -rw-r--r-- | third_party/WebKit/Source/core/dom/DOMURL.h | 5 | ||||
| -rw-r--r-- | third_party/WebKit/Source/core/dom/URL.idl | 6 |
2 files changed, 1 insertions, 10 deletions
diff --git a/third_party/WebKit/Source/core/dom/DOMURL.h b/third_party/WebKit/Source/core/dom/DOMURL.h index 17dc127c45c..a5d11bd 100644 --- a/third_party/WebKit/Source/core/dom/DOMURL.h +++ b/third_party/WebKit/Source/core/dom/DOMURL.h @@ -52,11 +52,6 @@ public: { return new DOMURL(url, KURL(KURL(), base), exceptionState); } - static DOMURL* create(const String& url, DOMURL* base, ExceptionState& exceptionState) - { - ASSERT(base); - return new DOMURL(url, base->m_url, exceptionState); - } static String createObjectURL(ExecutionContext*, Blob*, ExceptionState&); static void revokeObjectURL(ExecutionContext*, const String&); diff --git a/third_party/WebKit/Source/core/dom/URL.idl b/third_party/WebKit/Source/core/dom/URL.idl index 8bd9527..124d9ce 100644 --- a/third_party/WebKit/Source/core/dom/URL.idl +++ b/third_party/WebKit/Source/core/dom/URL.idl @@ -27,11 +27,7 @@ // https://url.spec.whatwg.org/#url [ - // TODO(philipj): There should only be one constructor: - // Constructor(USVString url, optional USVString base) - Constructor(USVString url), - Constructor(USVString url, USVString base), - Constructor(USVString url, URL base), + Constructor(USVString url, optional USVString base), Exposed=(Window,Worker), ImplementedAs=DOMURL, RaisesException=Constructor, |