diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 18:11:40 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-06 18:11:40 +0000 |
| commit | 145db1f5370109e0abcd324c37424dded8a501df (patch) | |
| tree | 5d84aa85fd3b233f7f4845ea19beffa2f17180c4 | |
| parent | bcec360fa3ac93948100e5bb6be5618b9080cdde (diff) | |
| download | chromium_src-145db1f5370109e0abcd324c37424dded8a501df.zip chromium_src-145db1f5370109e0abcd324c37424dded8a501df.tar.gz chromium_src-145db1f5370109e0abcd324c37424dded8a501df.tar.bz2 | |
Skip unresolved hosts for sync notifications instead of having libjingle resolve them.
This is a speculative fix for the crash in the bug below.
BUG=chromeos:5145
TEST=manual
Review URL: http://codereview.chromium.org/2868113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55264 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | jingle/notifier/communicator/single_login_attempt.cc | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/jingle/notifier/communicator/single_login_attempt.cc b/jingle/notifier/communicator/single_login_attempt.cc index 69dd21e..bf29d40 100644 --- a/jingle/notifier/communicator/single_login_attempt.cc +++ b/jingle/notifier/communicator/single_login_attempt.cc @@ -179,6 +179,13 @@ void SingleLoginAttempt::DoLogin( if (client_) { return; } + // TODO(akalin): Resolve any unresolved IPs, possibly through a + // proxy, instead of skipping them. + if (connection_settings.server().IsUnresolvedIP()) { + // Handler should attempt reconnect. + SignalUnexpectedDisconnect(); + return; + } buzz::XmppClientSettings client_settings; // Set the user settings portion. |