diff options
author | tommycli@chromium.org <tommycli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-01 19:00:51 +0000 |
---|---|---|
committer | tommycli@chromium.org <tommycli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-01 19:00:51 +0000 |
commit | 1570fccee5f985e0d40e076702a96ad3a937beac (patch) | |
tree | 797009db7592a0d3795a68375428295f91aa056c | |
parent | a01514105f4deb845a6ec7437a5cc531b37a0970 (diff) | |
download | chromium_src-1570fccee5f985e0d40e076702a96ad3a937beac.zip chromium_src-1570fccee5f985e0d40e076702a96ad3a937beac.tar.gz chromium_src-1570fccee5f985e0d40e076702a96ad3a937beac.tar.bz2 |
Fix findbugs warning - narrow synchronization scope in NmDumper.
BUG=NONE
Review URL: https://codereview.chromium.org/266633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267601 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | build/android/findbugs_filter/findbugs_known_bugs.txt | 1 | ||||
-rw-r--r-- | tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java | 16 |
2 files changed, 9 insertions, 8 deletions
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt index 3b825a6..0fbd914 100644 --- a/build/android/findbugs_filter/findbugs_known_bugs.txt +++ b/build/android/findbugs_filter/findbugs_known_bugs.txt @@ -31,5 +31,4 @@ M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context) At ProfileSyncService.java M B OS: org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() may fail to close stream At Addr2LineWorkerPool.java M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new org.chromium.tools.binary_size.NmDumper$Output(NmDumper) At NmDumper.java -M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope. At NmDumper.java M D REC: Exception is caught when Exception is not thrown in org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() At Addr2LineWorkerPool.java diff --git a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java index 0d77e37..286fd61 100644 --- a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java +++ b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java @@ -120,23 +120,25 @@ class NmDumper { } } - private synchronized void println(PrintWriter writer, String string) { + private void println(PrintWriter writer, String string) { if (writer != null) { - writer.println(string); - writer.flush(); + synchronized (writer) { + writer.println(string); + writer.flush(); + } } } - synchronized void print(String string) { + void print(String string) { println(outWriter, string); } - synchronized void printSkip(String string) { + void printSkip(String string) { println(skipWriter, string); println(outWriter, string); } - synchronized void printFail(String string) { + void printFail(String string) { println(failWriter, string); println(outWriter, string); } @@ -158,4 +160,4 @@ class NmDumper { } } } -}
\ No newline at end of file +} |