summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-06 21:14:54 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-07 04:15:17 +0000
commit165763c20c375201e93c5663f6b1fc0834503747 (patch)
treec4428a19dd281c2b9c9a8af817f664302cd6db88
parentc53c0289d86a263c3446b3c89779612502682a01 (diff)
downloadchromium_src-165763c20c375201e93c5663f6b1fc0834503747.zip
chromium_src-165763c20c375201e93c5663f6b1fc0834503747.tar.gz
chromium_src-165763c20c375201e93c5663f6b1fc0834503747.tar.bz2
Remove implicit conversions from scoped_refptr to T* in content/
This patch was generated by running the rewrite_scoped_refptr clang tool on an Android build. BUG=110610 Review URL: https://codereview.chromium.org/628333003 Cr-Commit-Position: refs/heads/master@{#298364}
-rw-r--r--content/browser/android/in_process/synchronous_compositor_factory_impl.cc12
-rw-r--r--content/browser/android/in_process/synchronous_compositor_output_surface.cc4
-rw-r--r--content/browser/android/java/gin_java_bridge_dispatcher_host.cc6
-rw-r--r--content/browser/android/overscroll_glow.cc8
-rw-r--r--content/browser/android/surface_texture_peer_browser_impl.cc2
-rw-r--r--content/browser/power_save_blocker_android.cc2
-rw-r--r--content/browser/renderer_host/compositor_impl_android.cc8
-rw-r--r--content/browser/renderer_host/image_transport_factory_android.cc2
-rw-r--r--content/browser/renderer_host/render_process_host_impl.cc4
-rw-r--r--content/browser/renderer_host/render_widget_host_view_android.cc22
-rw-r--r--content/browser/web_contents/web_contents_android.cc2
-rw-r--r--content/common/gpu/stream_texture_android.cc4
12 files changed, 38 insertions, 38 deletions
diff --git a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc
index df6d647..ef0c3ed 100644
--- a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc
+++ b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc
@@ -201,7 +201,7 @@ SynchronousCompositorFactoryImpl::CreateOffscreenContextProvider(
scoped_refptr<cc::ContextProvider> SynchronousCompositorFactoryImpl::
CreateOnscreenContextProviderForCompositorThread() {
- DCHECK(service_);
+ DCHECK(service_.get());
gpu::GLInProcessContextSharedMemoryLimits mem_limits;
// This is half of what RenderWidget uses because synchronous compositor
@@ -233,7 +233,7 @@ SynchronousCompositorFactoryImpl::CreateOffscreenGraphicsContext3D(
void SynchronousCompositorFactoryImpl::CompositorInitializedHardwareDraw() {
base::AutoLock lock(num_hardware_compositor_lock_);
num_hardware_compositors_++;
- if (num_hardware_compositors_ == 1 && main_thread_proxy_) {
+ if (num_hardware_compositors_ == 1 && main_thread_proxy_.get()) {
main_thread_proxy_->PostTask(
FROM_HERE,
base::Bind(
@@ -249,7 +249,7 @@ void SynchronousCompositorFactoryImpl::CompositorReleasedHardwareDraw() {
}
void SynchronousCompositorFactoryImpl::RestoreContextOnMainThread() {
- if (CanCreateMainThreadContext() && video_context_provider_ )
+ if (CanCreateMainThreadContext() && video_context_provider_.get())
video_context_provider_->RestoreContext();
}
@@ -274,8 +274,8 @@ SynchronousCompositorFactoryImpl::TryCreateStreamTextureFactory() {
scoped_refptr<StreamTextureFactorySynchronousImpl::ContextProvider>();
}
- if (!video_context_provider_) {
- DCHECK(service_);
+ if (!video_context_provider_.get()) {
+ DCHECK(service_.get());
video_context_provider_ = new VideoContextProvider(
CreateContext(service_,
@@ -286,7 +286,7 @@ SynchronousCompositorFactoryImpl::TryCreateStreamTextureFactory() {
void SynchronousCompositorFactoryImpl::SetDeferredGpuService(
scoped_refptr<gpu::InProcessCommandBuffer::Service> service) {
- DCHECK(!service_);
+ DCHECK(!service_.get());
service_ = service;
}
diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
index 3b7a8c1d..7b8464b 100644
--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc
+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
@@ -150,7 +150,7 @@ bool SynchronousCompositorOutputSurface::InitializeHwDraw(
scoped_refptr<cc::ContextProvider> onscreen_context_provider) {
DCHECK(CalledOnValidThread());
DCHECK(HasClient());
- DCHECK(!context_provider_);
+ DCHECK(!context_provider_.get());
return InitializeAndSetContext3d(onscreen_context_provider);
}
@@ -170,7 +170,7 @@ SynchronousCompositorOutputSurface::DemandDrawHw(
const gfx::Transform& transform_for_tile_priority) {
DCHECK(CalledOnValidThread());
DCHECK(HasClient());
- DCHECK(context_provider_);
+ DCHECK(context_provider_.get());
surface_size_ = surface_size;
InvokeComposite(transform,
diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
index 29341a9..d324b3a 100644
--- a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
+++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
@@ -374,7 +374,7 @@ void GinJavaBridgeDispatcherHost::OnGetMethods(
return;
}
scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));
- if (!object) {
+ if (!object.get()) {
LOG(ERROR) << "WebView: Unknown object: " << object_id;
IPC::WriteParam(reply_msg, std::set<std::string>());
render_frame_host->Send(reply_msg);
@@ -410,7 +410,7 @@ void GinJavaBridgeDispatcherHost::OnHasMethod(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(render_frame_host);
scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));
- if (!object) {
+ if (!object.get()) {
LOG(ERROR) << "WebView: Unknown object: " << object_id;
IPC::WriteParam(reply_msg, false);
render_frame_host->Send(reply_msg);
@@ -447,7 +447,7 @@ void GinJavaBridgeDispatcherHost::OnInvokeMethod(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(render_frame_host);
scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));
- if (!object) {
+ if (!object.get()) {
LOG(ERROR) << "WebView: Unknown object: " << object_id;
base::ListValue result;
result.Append(base::Value::CreateNullValue());
diff --git a/content/browser/android/overscroll_glow.cc b/content/browser/android/overscroll_glow.cc
index b3a969f..6df795a 100644
--- a/content/browser/android/overscroll_glow.cc
+++ b/content/browser/android/overscroll_glow.cc
@@ -186,7 +186,7 @@ bool OverscrollGlow::NeedsAnimate() const {
void OverscrollGlow::UpdateLayerAttachment(cc::Layer* parent) {
DCHECK(parent);
- if (!root_layer_)
+ if (!root_layer_.get())
return;
if (!NeedsAnimate()) {
@@ -198,11 +198,11 @@ void OverscrollGlow::UpdateLayerAttachment(cc::Layer* parent) {
parent->AddChild(root_layer_);
for (size_t i = 0; i < EDGE_COUNT; ++i)
- edge_effects_[i]->SetParent(root_layer_);
+ edge_effects_[i]->SetParent(root_layer_.get());
}
void OverscrollGlow::Detach() {
- if (root_layer_)
+ if (root_layer_.get())
root_layer_->RemoveFromParent();
}
@@ -211,7 +211,7 @@ bool OverscrollGlow::InitializeIfNecessary() {
if (initialized_)
return true;
- DCHECK(!root_layer_);
+ DCHECK(!root_layer_.get());
root_layer_ = cc::Layer::Create();
for (size_t i = 0; i < EDGE_COUNT; ++i) {
edge_effects_[i] = edge_effect_provider_.Run();
diff --git a/content/browser/android/surface_texture_peer_browser_impl.cc b/content/browser/android/surface_texture_peer_browser_impl.cc
index 4f61887..b533bec 100644
--- a/content/browser/android/surface_texture_peer_browser_impl.cc
+++ b/content/browser/android/surface_texture_peer_browser_impl.cc
@@ -62,7 +62,7 @@ static void SetSurfacePeer(
}
if (player != player_manager->GetFullscreenPlayer()) {
- gfx::ScopedJavaSurface scoped_surface(surface_texture);
+ gfx::ScopedJavaSurface scoped_surface(surface_texture.get());
player->SetVideoSurface(scoped_surface.Pass());
}
}
diff --git a/content/browser/power_save_blocker_android.cc b/content/browser/power_save_blocker_android.cc
index 79da1a9..2f79ef9 100644
--- a/content/browser/power_save_blocker_android.cc
+++ b/content/browser/power_save_blocker_android.cc
@@ -62,7 +62,7 @@ PowerSaveBlockerImpl::PowerSaveBlockerImpl(PowerSaveBlockerType type,
}
PowerSaveBlockerImpl::~PowerSaveBlockerImpl() {
- if (delegate_) {
+ if (delegate_.get()) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&Delegate::RemoveBlock, delegate_));
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index e7a1d3c..0d6ee68 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -364,11 +364,11 @@ ui::SystemUIResourceManager& CompositorImpl::GetSystemUIResourceManager() {
}
void CompositorImpl::SetRootLayer(scoped_refptr<cc::Layer> root_layer) {
- if (subroot_layer_) {
+ if (subroot_layer_.get()) {
subroot_layer_->RemoveFromParent();
subroot_layer_ = NULL;
}
- if (root_layer) {
+ if (root_layer.get()) {
subroot_layer_ = root_layer;
root_layer_->AddChild(root_layer);
}
@@ -515,7 +515,7 @@ CreateGpuProcessViewContext(
const scoped_refptr<GpuChannelHost>& gpu_channel_host,
const blink::WebGraphicsContext3D::Attributes attributes,
int surface_id) {
- DCHECK(gpu_channel_host);
+ DCHECK(gpu_channel_host.get());
GURL url("chrome://gpu/Compositor::createContext3D");
static const size_t kBytesPerPixel = 4;
@@ -578,7 +578,7 @@ void CompositorImpl::CreateOutputSurface(bool fallback) {
BrowserGpuChannelHostFactory* factory =
BrowserGpuChannelHostFactory::instance();
scoped_refptr<GpuChannelHost> gpu_channel_host = factory->GetGpuChannel();
- if (gpu_channel_host && !gpu_channel_host->IsLost()) {
+ if (gpu_channel_host.get() && !gpu_channel_host->IsLost()) {
context_provider = ContextProviderCommandBuffer::Create(
CreateGpuProcessViewContext(gpu_channel_host, attrs, surface_id_),
"BrowserCompositor");
diff --git a/content/browser/renderer_host/image_transport_factory_android.cc b/content/browser/renderer_host/image_transport_factory_android.cc
index 919b709..17664a8 100644
--- a/content/browser/renderer_host/image_transport_factory_android.cc
+++ b/content/browser/renderer_host/image_transport_factory_android.cc
@@ -55,7 +55,7 @@ CmdBufferImageTransportFactory::CmdBufferImageTransportFactory() {
BrowserGpuChannelHostFactory::instance();
scoped_refptr<GpuChannelHost> gpu_channel_host(factory->EstablishGpuChannelSync(
CAUSE_FOR_GPU_LAUNCH_WEBGRAPHICSCONTEXT3DCOMMANDBUFFERIMPL_INITIALIZE));
- DCHECK(gpu_channel_host);
+ DCHECK(gpu_channel_host.get());
blink::WebGraphicsContext3D::Attributes attrs;
attrs.shareResources = true;
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 76a7717..8984a79 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -810,11 +810,11 @@ void RenderProcessHostImpl::CreateMessageFilters() {
channel_->AddFilter(new FontCacheDispatcher());
#elif defined(OS_ANDROID)
browser_demuxer_android_ = new BrowserDemuxerAndroid();
- AddFilter(browser_demuxer_android_);
+ AddFilter(browser_demuxer_android_.get());
#endif
#if defined(ENABLE_BROWSER_CDMS)
browser_cdm_manager_ = new BrowserCdmManager(GetID(), NULL);
- AddFilter(browser_cdm_manager_);
+ AddFilter(browser_cdm_manager_.get());
#endif
SocketStreamDispatcherHost::GetRequestContextCallback
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 9f04f99..89efe4e 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -418,7 +418,7 @@ void RenderWidgetHostViewAndroid::GetScaledContentBitmap(
scoped_refptr<cc::DelegatedRendererLayer>
RenderWidgetHostViewAndroid::CreateDelegatedLayerForFrameProvider() const {
- DCHECK(frame_provider_);
+ DCHECK(frame_provider_.get());
scoped_refptr<cc::DelegatedRendererLayer> delegated_layer =
cc::DelegatedRendererLayer::Create(frame_provider_);
@@ -432,7 +432,7 @@ RenderWidgetHostViewAndroid::CreateDelegatedLayerForFrameProvider() const {
bool RenderWidgetHostViewAndroid::HasValidFrame() const {
if (!content_view_core_)
return false;
- if (!layer_)
+ if (!layer_.get())
return false;
if (texture_size_in_layer_.IsEmpty())
@@ -504,7 +504,7 @@ void RenderWidgetHostViewAndroid::Show() {
return;
is_showing_ = true;
- if (layer_)
+ if (layer_.get())
layer_->SetHideLayerAndSubtree(false);
frame_evictor_->SetVisible(true);
@@ -516,7 +516,7 @@ void RenderWidgetHostViewAndroid::Hide() {
return;
is_showing_ = false;
- if (layer_ && locks_on_frame_count_ == 0)
+ if (layer_.get() && locks_on_frame_count_ == 0)
layer_->SetHideLayerAndSubtree(true);
frame_evictor_->SetVisible(false);
@@ -556,7 +556,7 @@ void RenderWidgetHostViewAndroid::UnlockCompositingSurface() {
last_frame_info_.reset();
}
- if (!is_showing_ && layer_)
+ if (!is_showing_ && layer_.get())
layer_->SetHideLayerAndSubtree(true);
}
}
@@ -855,7 +855,7 @@ void RenderWidgetHostViewAndroid::CopyFromCompositingSurface(
ui::WindowAndroidCompositor* compositor =
content_view_core_->GetWindowAndroid()->GetCompositor();
DCHECK(compositor);
- DCHECK(frame_provider_);
+ DCHECK(frame_provider_.get());
scoped_refptr<cc::DelegatedRendererLayer> delegated_layer =
CreateDelegatedLayerForFrameProvider();
delegated_layer->SetHideLayerAndSubtree(true);
@@ -914,7 +914,7 @@ void RenderWidgetHostViewAndroid::SendDelegatedFrameAck(
void RenderWidgetHostViewAndroid::SendReturnedDelegatedResources(
uint32 output_surface_id) {
- DCHECK(resource_collection_);
+ DCHECK(resource_collection_.get());
cc::CompositorFrameAck ack;
resource_collection_->TakeUnusedResourcesForChildCompositor(&ack.resources);
@@ -976,7 +976,7 @@ void RenderWidgetHostViewAndroid::SwapDelegatedFrame(
resource_collection_ = new cc::DelegatedFrameResourceCollection;
resource_collection_->SetClient(this);
}
- if (!frame_provider_ ||
+ if (!frame_provider_.get() ||
texture_size_in_layer_ != frame_provider_->frame_size()) {
RemoveLayers();
frame_provider_ = new cc::DelegatedFrameProvider(
@@ -1036,7 +1036,7 @@ void RenderWidgetHostViewAndroid::InternalSwapCompositorFrame(
return;
}
- if (layer_ && layer_->layer_tree_host()) {
+ if (layer_.get() && layer_->layer_tree_host()) {
for (size_t i = 0; i < frame->metadata.latency_info.size(); i++) {
scoped_ptr<cc::SwapPromise> swap_promise(
new cc::LatencyInfoSwapPromise(frame->metadata.latency_info[i]));
@@ -1120,7 +1120,7 @@ void RenderWidgetHostViewAndroid::SynchronousFrameMetadata(
}
void RenderWidgetHostViewAndroid::SetOverlayVideoMode(bool enabled) {
- if (layer_)
+ if (layer_.get())
layer_->SetContentsOpaque(!enabled);
}
@@ -1511,7 +1511,7 @@ SkColor RenderWidgetHostViewAndroid::GetCachedBackgroundColor() const {
void RenderWidgetHostViewAndroid::DidOverscroll(
const DidOverscrollParams& params) {
- if (!content_view_core_ || !layer_ || !is_showing_)
+ if (!content_view_core_ || !layer_.get() || !is_showing_)
return;
const float device_scale_factor = content_view_core_->GetDpiScale();
diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc
index 363c746..52702a4 100644
--- a/content/browser/web_contents/web_contents_android.cc
+++ b/content/browser/web_contents/web_contents_android.cc
@@ -291,7 +291,7 @@ void WebContentsAndroid::DidDeferAfterResponseStarted(
JNIEnv* env = AttachCurrentThread();
std::vector<GURL> entering_stylesheets;
std::string transition_color;
- if (transition_data.response_headers) {
+ if (transition_data.response_headers.get()) {
TransitionRequestManager::ParseTransitionStylesheetsFromHeaders(
transition_data.response_headers,
entering_stylesheets,
diff --git a/content/common/gpu/stream_texture_android.cc b/content/common/gpu/stream_texture_android.cc
index 0c3173e..eb7f3bb 100644
--- a/content/common/gpu/stream_texture_android.cc
+++ b/content/common/gpu/stream_texture_android.cc
@@ -53,7 +53,7 @@ bool StreamTexture::Create(
GL_UNSIGNED_BYTE,
true);
texture_manager->SetLevelImage(
- texture, GL_TEXTURE_EXTERNAL_OES, 0, gl_image);
+ texture, GL_TEXTURE_EXTERNAL_OES, 0, gl_image.get());
return true;
}
@@ -131,7 +131,7 @@ void StreamTexture::WillUseTexImage() {
const gpu::gles2::TextureUnit& active_unit =
state->texture_units[state->active_texture_unit];
glBindTexture(GL_TEXTURE_EXTERNAL_OES,
- active_unit.bound_texture_external_oes
+ active_unit.bound_texture_external_oes.get()
? active_unit.bound_texture_external_oes->service_id()
: 0);
}