summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authornasko <nasko@chromium.org>2015-01-07 18:08:04 -0800
committerCommit bot <commit-bot@chromium.org>2015-01-08 02:10:35 +0000
commit17c89cc206ea8ce2f4cb8c9b661d1e21baa9175b (patch)
tree7d806c04668568a49ba02d8f458ba0099be2c204
parent3b9db8bd404689f0568f7e8d162c162e120804ad (diff)
downloadchromium_src-17c89cc206ea8ce2f4cb8c9b661d1e21baa9175b.zip
chromium_src-17c89cc206ea8ce2f4cb8c9b661d1e21baa9175b.tar.gz
chromium_src-17c89cc206ea8ce2f4cb8c9b661d1e21baa9175b.tar.bz2
Add some debugging checks to help find repro for crash during child frame creation.
BUG=397744 Review URL: https://codereview.chromium.org/841853002 Cr-Commit-Position: refs/heads/master@{#310440}
-rw-r--r--content/renderer/render_frame_impl.cc8
1 files changed, 5 insertions, 3 deletions
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 36dec29..473b185 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1930,9 +1930,10 @@ blink::WebFrame* RenderFrameImpl::createChildFrame(
// Synchronously notify the browser of a child frame creation to get the
// routing_id for the RenderFrame.
int child_routing_id = MSG_ROUTING_NONE;
- Send(new FrameHostMsg_CreateChildFrame(routing_id_,
- base::UTF16ToUTF8(name),
- &child_routing_id));
+ CHECK(Send(new FrameHostMsg_CreateChildFrame(routing_id_,
+ base::UTF16ToUTF8(name),
+ &child_routing_id)));
+
// Allocation of routing id failed, so we can't create a child frame. This can
// happen if this RenderFrameImpl's IPCs are being filtered when in swapped
// out state.
@@ -1949,6 +1950,7 @@ blink::WebFrame* RenderFrameImpl::createChildFrame(
base::debug::Alias(&is_swapped_out_);
base::debug::DumpWithoutCrashing();
#endif
+ NOTREACHED() << "Failed to allocate routing id for child frame.";
return NULL;
}