summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjchaffraix@chromium.org <jchaffraix@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>2013-06-03 16:18:12 +0000
committerjchaffraix@chromium.org <jchaffraix@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538>2013-06-03 16:18:12 +0000
commit182c8cb88b8cd6f0ee2098ead0807fc3cedc82da (patch)
tree3923ce6025e34bf025dfe88aba4c245abd7b21a6
parentd7910db2103602ff8d52a6ecc23909440c3dbc95 (diff)
downloadchromium_src-182c8cb88b8cd6f0ee2098ead0807fc3cedc82da.zip
chromium_src-182c8cb88b8cd6f0ee2098ead0807fc3cedc82da.tar.gz
chromium_src-182c8cb88b8cd6f0ee2098ead0807fc3cedc82da.tar.bz2
Try harder to unflake the no-clipping-overflow-hidden tests
This is a follow-up on r150693. The original change only forced layout after hovering, which hasn't helped the tests unfortunately. Most tests in LayoutTests do it before and after hovering so trying to match them more closely by replicating the pattern. Review URL: https://chromiumcodereview.appspot.com/15735010 git-svn-id: svn://svn.chromium.org/blink/trunk@151667 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-rwxr-xr-xthird_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html3
-rwxr-xr-xthird_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html3
-rwxr-xr-xthird_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html3
3 files changed, 6 insertions, 3 deletions
diff --git a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html
index 71d3560..f788c70 100755
--- a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html
+++ b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html
@@ -33,10 +33,11 @@ div {
if (!window.eventSender)
alert("To manually test, hover over the green div. The overflow should be properly clipped.");
+ document.body.offsetTop; // Force layout. The mouse is not tracked before first layout.
var transformed = document.getElementById("transformed");
transformed.parentNode.setAttribute("id", "overflowHidden");
eventSender.mouseMoveTo(transformed.offsetLeft + 10, transformed.offsetTop + 10);
- document.body.offsetTop;
+ document.body.offsetTop; // Update layout for hovered state.
</script>
</body>
</html>
diff --git a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html
index 98a6c94..854bccd 100755
--- a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html
+++ b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transition.html
@@ -38,10 +38,11 @@ div {
if (!window.eventSender)
alert("To manually test, hover over the purple divs. The overflow should be properly clipped.");
+ document.body.offsetTop; // Force layout. The mouse is not tracked before first layout.
var transformed = document.getElementsByClassName("transformed");
eventSender.mouseMoveTo(transformed[0].offsetLeft + 10, transformed[0].offsetTop + 10);
eventSender.mouseMoveTo(transformed[1].offsetLeft + 10, transformed[1].offsetTop + 10);
- document.body.offsetTop;
+ document.body.offsetTop; // Update layout for hovered state.
</script>
</body>
</html>
diff --git a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
index 882e93d..c22b158 100755
--- a/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
+++ b/third_party/WebKit/LayoutTests/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
@@ -33,9 +33,10 @@ div {
if (!window.eventSender)
alert("To manually test, hover over the green div. The overflow should be properly clipped.");
+ document.body.offsetTop; // Force layout. The mouse is not tracked before first layout.
var transformed = document.getElementById("transformed");
eventSender.mouseMoveTo(transformed.offsetLeft + 10, transformed.offsetTop + 10);
- document.body.offsetTop;
+ document.body.offsetTop; // Update layout for hovered state.
</script>
</body>
</html>