diff options
| author | brucedawson <brucedawson@chromium.org> | 2016-03-22 14:25:13 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-22 21:27:25 +0000 |
| commit | 1a87fbf87fc1ac4aaef80094be817c6b3a87dc1b (patch) | |
| tree | 711708437a4b4f8c8465024ae6ec9c21c059fceb | |
| parent | e742862f9555579e3239d9658766081ac4729e92 (diff) | |
| download | chromium_src-1a87fbf87fc1ac4aaef80094be817c6b3a87dc1b.zip chromium_src-1a87fbf87fc1ac4aaef80094be817c6b3a87dc1b.tar.gz chromium_src-1a87fbf87fc1ac4aaef80094be817c6b3a87dc1b.tar.bz2 | |
Add fastfail to VC++ linker
/fastfail should get us crash dumps when the linker crashes, which it
has been doing. /maxilksize is being added for consistency with gyp
builds, and because the linker crashes are incremental linking related.
This is being added in order to investigate a particular problem but
it is a good long-term change also - crashing without a crash dump is
not helpful.
BUG=482671
Review URL: https://codereview.chromium.org/1816333002
Cr-Commit-Position: refs/heads/master@{#382682}
| -rw-r--r-- | build/common.gypi | 2 | ||||
| -rw-r--r-- | build/config/compiler/BUILD.gn | 13 |
2 files changed, 15 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 94b3b3a..aea53b9 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -3275,6 +3275,8 @@ # which started happening more regularly after VS2013 Update 4. # Needs to be a bit lower for VS2015, or else errors out. '/maxilksize:0x7ff00000', + # Tell the linker to crash on failures. + '/fastfail', ], }, }, diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index b71d146..a096d56 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -143,6 +143,19 @@ config("compiler") { ":compiler_codegen", ] + if (is_win) { + ldflags += [ + # Suggested by Microsoft Devrel to avoid + # LINK : fatal error LNK1248: image size (80000000) exceeds maximum allowable size (80000000) + # which started happening more regularly after VS2013 Update 4. + # Needs to be a bit lower for VS2015, or else errors out. + "/maxilksize:0x7ff00000", + + # Tell the linker to crash on failures. + "/fastfail", + ] + } + # In general, Windows is totally different, but all the other builds share # some common GCC configuration. if (!is_win) { |