diff options
| author | thakis <thakis@chromium.org> | 2015-04-08 13:49:06 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-08 20:50:46 +0000 |
| commit | 1abe5b4643edb113d9ce3ac58c69d40967d74cc5 (patch) | |
| tree | f86ad53b426980100607a260707a87c7b9d0caa9 | |
| parent | d08e13978878f511b07b8c3aaf61a49054371c84 (diff) | |
| download | chromium_src-1abe5b4643edb113d9ce3ac58c69d40967d74cc5.zip chromium_src-1abe5b4643edb113d9ce3ac58c69d40967d74cc5.tar.gz chromium_src-1abe5b4643edb113d9ce3ac58c69d40967d74cc5.tar.bz2 | |
Add comments about --config-vars that need to be in sync.
BUG=none
Review URL: https://codereview.chromium.org/1062363002
Cr-Commit-Position: refs/heads/master@{#324280}
| -rw-r--r-- | build/android/pylib/utils/isolator.py | 1 | ||||
| -rw-r--r-- | build/isolate.gypi | 5 |
2 files changed, 3 insertions, 3 deletions
diff --git a/build/android/pylib/utils/isolator.py b/build/android/pylib/utils/isolator.py index 8db993d..90d5ca0 100644 --- a/build/android/pylib/utils/isolator.py +++ b/build/android/pylib/utils/isolator.py @@ -24,6 +24,7 @@ def DefaultPathVariables(): def DefaultConfigVariables(): + # Note: This list must match the --config-vars in build/isolate.gypi return { 'CONFIGURATION_NAME': constants.GetBuildType(), 'OS': 'android', diff --git a/build/isolate.gypi b/build/isolate.gypi index a34f265..7b050e2 100644 --- a/build/isolate.gypi +++ b/build/isolate.gypi @@ -61,9 +61,6 @@ # Variables should use the -V FOO=<(FOO) form so frequent values, # like '0' or '1', aren't stripped out by GYP. Run 'isolate.py help' for # more details. - # - # This list needs to be kept in sync with the cmd line options - # in src/build/android/pylib/gtest/setup.py. # Path variables are used to replace file paths when loading a .isolate # file @@ -74,6 +71,8 @@ # the .isolate file but are not considered relative paths. '--extra-variable', 'version_full=<(version_full)', + # Note: This list must match DefaultConfigVariables() + # in build/android/pylib/utils/isolator.py '--config-variable', 'CONFIGURATION_NAME=<(CONFIGURATION_NAME)', '--config-variable', 'OS=<(OS)', '--config-variable', 'asan=<(asan)', |