diff options
author | mlerman@chromium.org <mlerman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 01:44:52 +0000 |
---|---|---|
committer | mlerman@chromium.org <mlerman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 01:44:52 +0000 |
commit | 1c799ff7a5ae01a76a2767bbe0d55e3771287cf1 (patch) | |
tree | bd5dc6d7bba2faf87c6970ae00531df227bcff4e | |
parent | e8c191dcc9f27ca955e027fe4a0f4287a5aded98 (diff) | |
download | chromium_src-1c799ff7a5ae01a76a2767bbe0d55e3771287cf1.zip chromium_src-1c799ff7a5ae01a76a2767bbe0d55e3771287cf1.tar.gz chromium_src-1c799ff7a5ae01a76a2767bbe0d55e3771287cf1.tar.bz2 |
Add profile-switches to signin-internals; move switches to component
The profile related switches have been moved from chrome/common
to components/signin/core/common.
BUG=326577
TEST=chrome://signin-internals page should accurately reflect
the status of the Web Enabled Sign In and New Profile Management Flags.
Review URL: https://codereview.chromium.org/235813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264056 0039d316-1c4b-4281-b951-d872f2087c98
44 files changed, 88 insertions, 83 deletions
diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc index b2cb7bd..43af5fa 100644 --- a/chrome/browser/android/signin/signin_manager_android.cc +++ b/chrome/browser/android/signin/signin_manager_android.cc @@ -21,9 +21,9 @@ #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "jni/SigninManager_jni.h" #if defined(ENABLE_CONFIGURATION_POLICY) diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm index 6e113ad..a4fa0f5 100644 --- a/chrome/browser/app_controller_mac.mm +++ b/chrome/browser/app_controller_mac.mm @@ -74,8 +74,8 @@ #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/mac/app_mode_common.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/signin/core/browser/signin_manager.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/download_manager.h" diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc index fe650ca..dfbb509 100644 --- a/chrome/browser/browser_process_impl.cc +++ b/chrome/browser/browser_process_impl.cc @@ -72,12 +72,12 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/chrome_extensions_client.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/switch_utils.h" #include "chrome/common/url_constants.h" #include "chrome/installer/util/google_update_constants.h" #include "components/policy/core/common/policy_service.h" #include "components/rappor/rappor_service.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/translate/core/browser/translate_download_manager.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/child_process_security_policy.h" diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc index 32c4ad2..e5f5258 100644 --- a/chrome/browser/chrome_browser_main.cc +++ b/chrome/browser/chrome_browser_main.cc @@ -105,13 +105,13 @@ #include "chrome/common/logging_chrome.h" #include "chrome/common/net/net_resource_provider.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/profiling.h" #include "chrome/installer/util/google_update_settings.h" #include "components/language_usage_metrics/language_usage_metrics.h" #include "components/nacl/browser/nacl_browser.h" #include "components/nacl/browser/nacl_process_host.h" #include "components/rappor/rappor_service.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/startup_metric_utils/startup_metric_utils.h" #include "components/translate/core/browser/translate_download_manager.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc index fd7a888..886b3df 100644 --- a/chrome/browser/chrome_content_browser_client.cc +++ b/chrome/browser/chrome_content_browser_client.cc @@ -94,7 +94,6 @@ #include "chrome/common/logging_chrome.h" #include "chrome/common/pepper_permission_util.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/render_messages.h" #include "chrome/common/url_constants.h" #include "chrome/installer/util/google_update_settings.h" @@ -104,6 +103,7 @@ #include "components/nacl/browser/nacl_process_host.h" #include "components/nacl/common/nacl_process_type.h" #include "components/nacl/common/nacl_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/translate/core/common/translate_switches.h" #include "components/user_prefs/pref_registry_syncable.h" #include "content/public/browser/browser_child_process_host.h" diff --git a/chrome/browser/extensions/api/principals_private/principals_private_api.cc b/chrome/browser/extensions/api/principals_private/principals_private_api.cc index 0b7b8b9..a6ff8b6 100644 --- a/chrome/browser/extensions/api/principals_private/principals_private_api.cc +++ b/chrome/browser/extensions/api/principals_private/principals_private_api.cc @@ -9,7 +9,7 @@ #include "chrome/browser/profiles/profile_window.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" namespace extensions { diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc index 5b7ef25..8c5d09b 100644 --- a/chrome/browser/password_manager/save_password_infobar_delegate.cc +++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc @@ -9,8 +9,8 @@ #include "chrome/browser/infobars/infobar.h" #include "chrome/browser/infobars/infobar_service.h" #include "chrome/browser/ui/sync/one_click_signin_helper.h" -#include "chrome/common/profile_management_switches.h" #include "components/password_manager/core/browser/password_form_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/web_contents.h" #include "google_apis/gaia/gaia_urls.h" diff --git a/chrome/browser/profiles/avatar_menu.cc b/chrome/browser/profiles/avatar_menu.cc index ed9c9fc..c8dad05 100644 --- a/chrome/browser/profiles/avatar_menu.cc +++ b/chrome/browser/profiles/avatar_menu.cc @@ -24,7 +24,7 @@ #include "chrome/browser/ui/host_desktop.h" #include "chrome/browser/ui/startup/startup_browser_creator.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_service.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/profiles/gaia_info_update_service.cc b/chrome/browser/profiles/gaia_info_update_service.cc index 31d489b..6d9db89 100644 --- a/chrome/browser/profiles/gaia_info_update_service.cc +++ b/chrome/browser/profiles/gaia_info_update_service.cc @@ -13,7 +13,7 @@ #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/browser/sync/profile_sync_service.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/notification_details.h" #include "third_party/skia/include/core/SkBitmap.h" #include "ui/gfx/image/image.h" diff --git a/chrome/browser/profiles/profile_info_cache.cc b/chrome/browser/profiles/profile_info_cache.cc index c8c63c0..ad18abe 100644 --- a/chrome/browser/profiles/profile_info_cache.cc +++ b/chrome/browser/profiles/profile_info_cache.cc @@ -24,7 +24,7 @@ #include "chrome/browser/profiles/profile_avatar_icon_util.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_service.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/profiles/profile_list_desktop.cc b/chrome/browser/profiles/profile_list_desktop.cc index 480ba5d..21714be 100644 --- a/chrome/browser/profiles/profile_list_desktop.cc +++ b/chrome/browser/profiles/profile_list_desktop.cc @@ -7,7 +7,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_avatar_icon_util.h" #include "chrome/browser/profiles/profile_info_cache.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc index 0f2292d..f32f357 100644 --- a/chrome/browser/profiles/profile_manager.cc +++ b/chrome/browser/profiles/profile_manager.cc @@ -46,8 +46,8 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/logging_chrome.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/user_metrics.h" diff --git a/chrome/browser/signin/chrome_signin_client.cc b/chrome/browser/signin/chrome_signin_client.cc index 0faeffa..7cc19c3 100644 --- a/chrome/browser/signin/chrome_signin_client.cc +++ b/chrome/browser/signin/chrome_signin_client.cc @@ -10,7 +10,7 @@ #include "chrome/browser/signin/local_auth.h" #include "chrome/browser/webdata/web_data_service_factory.h" #include "chrome/common/chrome_version_info.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "content/public/browser/render_process_host.h" diff --git a/chrome/browser/signin/signin_header_helper.cc b/chrome/browser/signin/signin_header_helper.cc index b43c4ba..8e2757a 100644 --- a/chrome/browser/signin/signin_header_helper.cc +++ b/chrome/browser/signin/signin_header_helper.cc @@ -9,7 +9,7 @@ #include "chrome/browser/tab_contents/tab_util.h" #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_window.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" #include "google_apis/gaia/gaia_auth_util.h" diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc index 491f8cf..253ba61 100644 --- a/chrome/browser/signin/signin_promo.cc +++ b/chrome/browser/signin/signin_promo.cc @@ -22,9 +22,9 @@ #include "chrome/browser/ui/webui/theme_source.h" #include "chrome/common/net/url_util.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/user_prefs/pref_registry_syncable.h" #include "content/public/browser/url_data_source.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/signin/signin_tracker_factory.cc b/chrome/browser/signin/signin_tracker_factory.cc index 638460a..5b1febc 100644 --- a/chrome/browser/signin/signin_tracker_factory.cc +++ b/chrome/browser/signin/signin_tracker_factory.cc @@ -8,7 +8,7 @@ #include "chrome/browser/signin/chrome_signin_client_factory.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/signin/signin_manager_factory.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" SigninTrackerFactory::SigninTrackerFactory() {} SigninTrackerFactory::~SigninTrackerFactory() {} diff --git a/chrome/browser/ui/ash/chrome_shell_delegate.cc b/chrome/browser/ui/ash/chrome_shell_delegate.cc index 2307885..bbcaa5d 100644 --- a/chrome/browser/ui/ash/chrome_shell_delegate.cc +++ b/chrome/browser/ui/ash/chrome_shell_delegate.cc @@ -22,7 +22,7 @@ #include "chrome/browser/ui/ash/launcher/launcher_context_menu.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc index b6ad670..7c0601f 100644 --- a/chrome/browser/ui/browser_command_controller_unittest.cc +++ b/chrome/browser/ui/browser_command_controller_unittest.cc @@ -15,11 +15,11 @@ #include "chrome/browser/ui/browser_window_state.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/test_browser_window.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/native_web_keyboard_event.h" #include "ui/events/keycodes/keyboard_codes.h" diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm index a81f119..85e9e5f 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller.mm @@ -77,8 +77,8 @@ #include "chrome/browser/ui/window_sizer/window_sizer.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/command.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/translate/core/browser/translate_ui_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager.h" #include "content/public/browser/render_view_host.h" diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm index e77db1b..b8b75a2 100644 --- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm +++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm @@ -17,7 +17,7 @@ #import "chrome/browser/ui/cocoa/browser_window_controller.h" #import "chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h" #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "ui/base/resource/resource_bundle.h" // Space between the avatar icon and the avatar menu bubble. diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm index f92c6c7..97af36e 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm @@ -35,8 +35,8 @@ #import "chrome/browser/ui/cocoa/profiles/user_manager_mac.h" #include "chrome/browser/ui/singleton_tabs.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/signin/core/browser/mutable_profile_oauth2_token_service.h" #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc index d3372ff..1672f35 100644 --- a/chrome/browser/ui/startup/startup_browser_creator.cc +++ b/chrome/browser/ui/startup/startup_browser_creator.cc @@ -56,9 +56,9 @@ #include "chrome/common/chrome_version_info.h" #include "chrome/common/net/url_fixer_upper.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "chrome/installer/util/browser_distribution.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/child_process_security_policy.h" #include "content/public/browser/navigation_controller.h" diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc index cabc381..fa9753f 100644 --- a/chrome/browser/ui/sync/one_click_signin_helper.cc +++ b/chrome/browser/ui/sync/one_click_signin_helper.cc @@ -58,7 +58,6 @@ #include "chrome/common/chrome_version_info.h" #include "chrome/common/net/url_util.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/autofill/core/common/password_form.h" #include "components/password_manager/core/browser/password_manager.h" @@ -67,6 +66,7 @@ #include "components/signin/core/browser/signin_error_controller.h" #include "components/signin/core/browser/signin_manager.h" #include "components/signin/core/browser/signin_manager_cookie_helper.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/sync_driver/sync_prefs.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/navigation_entry.h" diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc index a3bdde4..afcddd8 100644 --- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc +++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc @@ -35,9 +35,9 @@ #include "chrome/browser/ui/webui/signin/login_ui_service.h" #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h" #include "chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/sync_driver/sync_prefs.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc index 3e50e35..f2f1474 100644 --- a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc +++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc @@ -16,7 +16,7 @@ #include "chrome/browser/ui/views/profiles/avatar_label.h" #include "chrome/browser/ui/views/profiles/avatar_menu_button.h" #include "chrome/browser/ui/views/profiles/new_avatar_button.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" #include "third_party/skia/include/core/SkColor.h" diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index 0430823..da32578 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -95,9 +95,9 @@ #include "chrome/browser/ui/window_sizer/window_sizer.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/password_manager/core/browser/password_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/download_manager.h" #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/notification_service.h" diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc index bc32bc8..62cc54b 100644 --- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc +++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc @@ -18,7 +18,7 @@ #include "chrome/browser/ui/views/tabs/tab_strip.h" #include "chrome/browser/ui/views/toolbar/toolbar_view.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/notification_service.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc index b7f2888..93f8c9b 100644 --- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc +++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc @@ -25,7 +25,7 @@ #include "chrome/browser/ui/views/theme_image_mapper.h" #include "chrome/browser/ui/views/toolbar/toolbar_view.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" #include "grit/chromium_strings.h" diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc index b6d51aa..ec84b5a 100644 --- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc +++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc @@ -9,7 +9,7 @@ #include "chrome/browser/ui/views/profiles/avatar_label.h" #include "chrome/browser/ui/views/profiles/avatar_menu_button.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "ui/gfx/font.h" #include "ui/views/controls/button/image_button.h" #include "ui/views/controls/label.h" diff --git a/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc b/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc index 27b2b6a..aa3b695 100644 --- a/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc +++ b/chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc @@ -21,9 +21,9 @@ #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/chrome_pages.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/page_navigator.h" #include "content/public/browser/web_contents.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/views/profiles/avatar_menu_button.cc b/chrome/browser/ui/views/profiles/avatar_menu_button.cc index b2b1d53..73bf30d 100644 --- a/chrome/browser/ui/views/profiles/avatar_menu_button.cc +++ b/chrome/browser/ui/views/profiles/avatar_menu_button.cc @@ -16,7 +16,7 @@ #include "chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h" #include "chrome/browser/ui/views/profiles/profile_chooser_view.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/notification_service.h" #include "ui/gfx/canvas.h" #include "ui/views/widget/widget.h" diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc index eb811cf..7d6d549 100644 --- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc +++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc @@ -24,11 +24,11 @@ #include "chrome/browser/ui/views/profiles/user_manager_view.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/signin/core/browser/mutable_profile_oauth2_token_service.h" #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc index d3520ac..48fddaa 100644 --- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc +++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc @@ -57,12 +57,12 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/pref_names.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/url_constants.h" #include "components/dom_distiller/core/dom_distiller_constants.h" #include "components/dom_distiller/core/dom_distiller_service.h" #include "components/dom_distiller/webui/dom_distiller_ui.h" #include "components/password_manager/core/common/password_manager_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_ui.h" #include "content/public/common/content_client.h" diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi index ffe71b2..5f6c631 100644 --- a/chrome/chrome_common.gypi +++ b/chrome/chrome_common.gypi @@ -207,8 +207,6 @@ 'common/favicon/favicon_types.h', 'common/favicon/favicon_url_parser.cc', 'common/favicon/favicon_url_parser.h', - 'common/profile_management_switches.cc', - 'common/profile_management_switches.h', 'common/icon_with_badge_image_source.cc', 'common/icon_with_badge_image_source.h', 'common/importer/firefox_importer_utils.cc', diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc index 60f3a87..9b59d4c 100644 --- a/chrome/common/chrome_switches.cc +++ b/chrome/common/chrome_switches.cc @@ -518,10 +518,6 @@ const char kEnableExtensionActivityLogTesting[] = // crbug.com/142458 . const char kEnableFastUnload[] = "enable-fast-unload"; -// Enables the pure web-based flow for sign in on first run/NTP/wrench menu/ -// settings page. -const char kEnableWebBasedSignin[] = "enable-web-based-signin"; - // Enables IPv6 support, even if probes suggest that it may not be fully // supported. Some probes may require internet connections, and this flag will // allow support independent of application testing. This flag overrides @@ -721,10 +717,6 @@ const char kFakeVariationsChannel[] = "fake-variations-channel"; // loaded. It is useful to tell the difference for tracking purposes. const char kFastStart[] = "fast-start"; -// Allows displaying the list of existing profiles in the avatar bubble for -// fast switching between profiles. -const char kFastUserSwitching[] = "fast-user-switching"; - // These two flags are added around the switches about:flags adds to the // command line. This is useful to see which switches were added by about:flags // on about:version. They don't have any effect. @@ -755,9 +747,6 @@ const char kForceVariationIds[] = "force-variation-ids"; // Specifies an alternate URL to use for speaking to Google. Useful for testing. const char kGoogleBaseURL[] = "google-base-url"; -// Enables using GAIA information to populate profile name and icon. -const char kGoogleProfileInfo[] = "google-profile-info"; - // Specifies a custom name for the GSSAPI library to load. const char kGSSAPILibraryName[] = "gssapi-library-name"; @@ -896,16 +885,6 @@ const char kMultiProfiles[] = "multi-profiles"; // Intended primarily for use with --log-net-log. const char kNetLogLevel[] = "net-log-level"; -// Use new avatar menu. When combined with new-profile-management, it simply -// shows the new profile management avatar menu. Otherwise it shows a redesigned -// avatar menu with the same functionality as the old one, plus a tutorial card -// at the top prompting the user to try out the new profile management UI. -const char kNewAvatarMenu[] = "new-avatar-menu"; - -// Use new profile management system, including profile sign-out and new -// choosers. -const char kNewProfileManagement[] = "new-profile-management"; - // Disables the default browser check. Useful for UI/browser tests where we // want to avoid having the default browser info-bar displayed. const char kNoDefaultBrowserCheck[] = "no-default-browser-check"; diff --git a/chrome/common/chrome_switches.h b/chrome/common/chrome_switches.h index 5f438bb..3452f04 100644 --- a/chrome/common/chrome_switches.h +++ b/chrome/common/chrome_switches.h @@ -151,7 +151,6 @@ extern const char kEnableEphemeralApps[]; extern const char kEnableExtensionActivityLogging[]; extern const char kEnableExtensionActivityLogTesting[]; extern const char kEnableFastUnload[]; -extern const char kEnableWebBasedSignin[]; extern const char kEnableIPv6[]; extern const char kEnableLinkableEphemeralApps[]; extern const char kEnableManagedStorage[]; @@ -205,7 +204,6 @@ extern const char kExtensionsUpdateFrequency[]; extern const char kExtraSearchQueryParams[]; extern const char kFakeVariationsChannel[]; extern const char kFastStart[]; -extern const char kFastUserSwitching[]; extern const char kFlagSwitchesBegin[]; extern const char kFlagSwitchesEnd[]; extern const char kFeedbackServer[]; @@ -214,7 +212,6 @@ extern const char kForceAppMode[]; extern const char kForceFirstRun[]; extern const char kForceVariationIds[]; extern const char kGoogleBaseURL[]; -extern const char kGoogleProfileInfo[]; extern const char kGSSAPILibraryName[]; extern const char kHelp[]; extern const char kHelpShort[]; @@ -249,8 +246,6 @@ extern const char kMessageLoopHistogrammer[]; extern const char kMetricsRecordingOnly[]; extern const char kMultiProfiles[]; extern const char kNetLogLevel[]; -extern const char kNewAvatarMenu[]; -extern const char kNewProfileManagement[]; extern const char kNoDefaultBrowserCheck[]; extern const char kNoDisplayingInsecureContent[]; extern const char kNoEvents[]; diff --git a/chrome/renderer/DEPS b/chrome/renderer/DEPS index 30e6f88..d65e9df 100644 --- a/chrome/renderer/DEPS +++ b/chrome/renderer/DEPS @@ -5,6 +5,7 @@ include_rules = [ "+components/autofill/core/common", "+components/nacl/renderer", "+components/plugins/renderer", + "+components/signin/core/common", "+components/translate/content/common", "+components/translate/core/common", "+components/translate/language_detection", diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc index 661a5ac..ad24296 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -24,7 +24,6 @@ #include "chrome/common/extensions/extension_process_policy.h" #include "chrome/common/localized_error.h" #include "chrome/common/pepper_permission_util.h" -#include "chrome/common/profile_management_switches.h" #include "chrome/common/render_messages.h" #include "chrome/common/url_constants.h" #include "chrome/renderer/benchmarking_extension.h" @@ -71,6 +70,7 @@ #include "components/autofill/content/renderer/password_generation_agent.h" #include "components/nacl/renderer/ppb_nacl_private_impl.h" #include "components/plugins/renderer/mobile_youtube_plugin.h" +#include "components/signin/core/common/profile_management_switches.h" #include "components/visitedlink/renderer/visitedlink_slave.h" #include "content/public/common/content_constants.h" #include "content/public/renderer/render_frame.h" diff --git a/components/signin.gypi b/components/signin.gypi index 5473b57..56e2a63 100644 --- a/components/signin.gypi +++ b/components/signin.gypi @@ -15,6 +15,8 @@ 'signin/core/common/signin_pref_names.h', 'signin/core/common/signin_switches.cc', 'signin/core/common/signin_switches.h', + 'signin/core/common/profile_management_switches.cc', + 'signin/core/common/profile_management_switches.h', ], }, { @@ -81,7 +83,6 @@ ], }], ], - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 'msvs_disabled_warnings': [4267, ], }, diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc index 5d2d0f9..71439ef 100644 --- a/components/signin/core/browser/about_signin_internals.cc +++ b/components/signin/core/browser/about_signin_internals.cc @@ -15,6 +15,7 @@ #include "components/signin/core/browser/signin_client.h" #include "components/signin/core/browser/signin_internals_util.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/signin/core/common/profile_management_switches.h" #include "google_apis/gaia/gaia_constants.h" using base::Time; @@ -345,6 +346,10 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue( : "Signed In"; AddSectionEntry(basic_info, "Chrome Version", product_version); AddSectionEntry(basic_info, "Signin Status", signin_status_string); + AddSectionEntry(basic_info, "Web Based Signin Enabled?", + switches::IsEnableWebBasedSignin() == true ? "True" : "False"); + AddSectionEntry(basic_info, "New Profile Management Enabled?", + switches::IsNewProfileManagement() == true ? "True" : "False"); // Only add username. SID and LSID have moved to tokens section. const std::string field = diff --git a/chrome/common/profile_management_switches.cc b/components/signin/core/common/profile_management_switches.cc index 1c83744..f15e939 100644 --- a/chrome/common/profile_management_switches.cc +++ b/components/signin/core/common/profile_management_switches.cc @@ -1,12 +1,12 @@ -// Copyright 2013 The Chromium Authors. All rights reserved. +// Copyright 2014 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/common/profile_management_switches.h" +#include "components/signin/core/common/profile_management_switches.h" #include "base/command_line.h" #include "base/metrics/field_trial.h" -#include "chrome/common/chrome_switches.h" +#include "components/signin/core/common/signin_switches.h" namespace { @@ -45,12 +45,13 @@ bool IsEnableWebBasedSignin() { return CheckProfileManagementFlag(switches::kEnableWebBasedSignin, false); } -bool IsGoogleProfileInfo() { - return CheckProfileManagementFlag(switches::kGoogleProfileInfo, true); +bool IsFastUserSwitching() { + return CommandLine::ForCurrentProcess()->HasSwitch( + switches::kFastUserSwitching); } -bool IsNewProfileManagement() { - return CheckProfileManagementFlag(switches::kNewProfileManagement, true); +bool IsGoogleProfileInfo() { + return CheckProfileManagementFlag(switches::kGoogleProfileInfo, true); } bool IsNewAvatarMenu() { @@ -59,15 +60,14 @@ bool IsNewAvatarMenu() { return is_new_avatar_menu || IsNewProfileManagement(); } +bool IsNewProfileManagement() { + return CheckProfileManagementFlag(switches::kNewProfileManagement, true); +} + bool IsNewProfileManagementPreviewEnabled() { bool is_new_avatar_menu = CommandLine::ForCurrentProcess()->HasSwitch(switches::kNewAvatarMenu); return is_new_avatar_menu && IsNewProfileManagement(); } -bool IsFastUserSwitching() { - return CommandLine::ForCurrentProcess()->HasSwitch( - switches::kFastUserSwitching); -} - } // namespace switches diff --git a/chrome/common/profile_management_switches.h b/components/signin/core/common/profile_management_switches.h index e05bb1b..f4fa439 100644 --- a/chrome/common/profile_management_switches.h +++ b/components/signin/core/common/profile_management_switches.h @@ -1,4 +1,4 @@ -// Copyright 2013 The Chromium Authors. All rights reserved. +// Copyright 2014 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -14,23 +14,23 @@ namespace switches { // Enables the web-based sign in flow on Chrome desktop. bool IsEnableWebBasedSignin(); +// Checks whether the flag for fast user switching is enabled. +bool IsFastUserSwitching(); + // Enables using GAIA information to populate profile name and icon. bool IsGoogleProfileInfo(); -// Use new profile management system, including profile sign-out and new -// choosers. -bool IsNewProfileManagement(); - // Whether the new avatar menu is enabled, either because new profile management // is enabled or because the new profile management preview UI is enabled. bool IsNewAvatarMenu(); +// Use new profile management system, including profile sign-out and new +// choosers. +bool IsNewProfileManagement(); + // Whether the new profile management preview has been enabled. bool IsNewProfileManagementPreviewEnabled(); -// Checks whether the flag for fast user switching is enabled. -bool IsFastUserSwitching(); - } // namespace switches #endif // CHROME_COMMON_PROFILE_MANAGEMENT_SWITCHES_H_ diff --git a/components/signin/core/common/signin_switches.cc b/components/signin/core/common/signin_switches.cc index a6d5b03..2154245 100644 --- a/components/signin/core/common/signin_switches.cc +++ b/components/signin/core/common/signin_switches.cc @@ -10,4 +10,25 @@ namespace switches { // expiration of credentials during testing. const char kClearTokenService[] = "clear-token-service"; +// Enables the pure web-based flow for sign in on first run/NTP/wrench menu/ +// settings page. +const char kEnableWebBasedSignin[] = "enable-web-based-signin"; + +// Allows displaying the list of existing profiles in the avatar bubble for +// fast switching between profiles. +const char kFastUserSwitching[] = "fast-user-switching"; + +// Enables using GAIA information to populate profile name and icon. +const char kGoogleProfileInfo[] = "google-profile-info"; + +// Use new avatar menu. When combined with new-profile-management, it simply +// shows the new profile management avatar menu. Otherwise it shows a redesigned +// avatar menu with the same functionality as the old one, plus a tutorial card +// at the top prompting the user to try out the new profile management UI. +const char kNewAvatarMenu[] = "new-avatar-menu"; + +// Use new profile management system, including profile sign-out and new +// choosers. +const char kNewProfileManagement[] = "new-profile-management"; + } // namespace switches diff --git a/components/signin/core/common/signin_switches.h b/components/signin/core/common/signin_switches.h index 30bd8d3..d7dbd8a 100644 --- a/components/signin/core/common/signin_switches.h +++ b/components/signin/core/common/signin_switches.h @@ -10,6 +10,11 @@ namespace switches { // All switches in alphabetical order. The switches should be documented // alongside the definition of their values in the .cc file. extern const char kClearTokenService[]; +extern const char kEnableWebBasedSignin[]; +extern const char kFastUserSwitching[]; +extern const char kGoogleProfileInfo[]; +extern const char kNewAvatarMenu[]; +extern const char kNewProfileManagement[]; } // namespace switches |