summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorricea <ricea@chromium.org>2014-11-20 21:33:58 -0800
committerCommit bot <commit-bot@chromium.org>2014-11-21 05:34:11 +0000
commit1d956de4c9c32c84ff61c9cecbc03bde41c598d0 (patch)
treed434c5d9ee1a299d82b75e04a3f716136d4538df
parentc32420e15c691f49908603cf5a51257e396082fe (diff)
downloadchromium_src-1d956de4c9c32c84ff61c9cecbc03bde41c598d0.zip
chromium_src-1d956de4c9c32c84ff61c9cecbc03bde41c598d0.tar.gz
chromium_src-1d956de4c9c32c84ff61c9cecbc03bde41c598d0.tar.bz2
Remove NetworkDelegate::OnBeforeSocketStreamConnect
The old WebSocket implementation has been removed, so OnBeforeSocketStreamConnect() will never be called. Remove all implementations. BUG=423201 TEST=compile Review URL: https://codereview.chromium.org/652363005 Cr-Commit-Position: refs/heads/master@{#305176}
-rw-r--r--android_webview/browser/net/aw_network_delegate.cc6
-rw-r--r--android_webview/browser/net/aw_network_delegate.h3
-rw-r--r--components/cronet/android/cronet_url_request_context_adapter.cc6
-rw-r--r--components/cronet/android/url_request_context_adapter.cc6
-rw-r--r--net/base/network_delegate.cc6
-rw-r--r--net/base/network_delegate.h6
-rw-r--r--net/proxy/network_delegate_error_observer_unittest.cc4
-rw-r--r--net/proxy/proxy_script_fetcher_impl_unittest.cc5
-rw-r--r--net/url_request/url_request_context_builder.cc5
-rw-r--r--net/url_request/url_request_test_util.cc6
-rw-r--r--net/url_request/url_request_test_util.h2
11 files changed, 0 insertions, 55 deletions
diff --git a/android_webview/browser/net/aw_network_delegate.cc b/android_webview/browser/net/aw_network_delegate.cc
index cfb597a..85cbdcf 100644
--- a/android_webview/browser/net/aw_network_delegate.cc
+++ b/android_webview/browser/net/aw_network_delegate.cc
@@ -120,10 +120,4 @@ bool AwNetworkDelegate::OnCanThrottleRequest(
return false;
}
-int AwNetworkDelegate::OnBeforeSocketStreamConnect(
- net::SocketStream* stream,
- const net::CompletionCallback& callback) {
- return net::OK;
-}
-
} // namespace android_webview
diff --git a/android_webview/browser/net/aw_network_delegate.h b/android_webview/browser/net/aw_network_delegate.h
index 4447bd1..0cbdefa 100644
--- a/android_webview/browser/net/aw_network_delegate.h
+++ b/android_webview/browser/net/aw_network_delegate.h
@@ -82,9 +82,6 @@ class AwNetworkDelegate : public net::NetworkDelegate {
const base::FilePath& path) const override;
virtual bool OnCanThrottleRequest(
const net::URLRequest& request) const override;
- virtual int OnBeforeSocketStreamConnect(
- net::SocketStream* stream,
- const net::CompletionCallback& callback) override;
// Data reduction proxy parameters object. Must outlive this.
data_reduction_proxy::DataReductionProxyParams* data_reduction_proxy_params_;
diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
index a20880f..da9e663 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.cc
+++ b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -99,12 +99,6 @@ class BasicNetworkDelegate : public net::NetworkDelegate {
return false;
}
- int OnBeforeSocketStreamConnect(
- net::SocketStream* stream,
- const net::CompletionCallback& callback) override {
- return net::OK;
- }
-
DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
};
diff --git a/components/cronet/android/url_request_context_adapter.cc b/components/cronet/android/url_request_context_adapter.cc
index baec6e8..9cd612f 100644
--- a/components/cronet/android/url_request_context_adapter.cc
+++ b/components/cronet/android/url_request_context_adapter.cc
@@ -110,12 +110,6 @@ class BasicNetworkDelegate : public net::NetworkDelegate {
return false;
}
- int OnBeforeSocketStreamConnect(
- net::SocketStream* stream,
- const net::CompletionCallback& callback) override {
- return net::OK;
- }
-
DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
};
diff --git a/net/base/network_delegate.cc b/net/base/network_delegate.cc
index 5b69cfb..d4aa19e 100644
--- a/net/base/network_delegate.cc
+++ b/net/base/network_delegate.cc
@@ -339,12 +339,6 @@ bool NetworkDelegate::OnCanEnablePrivacyMode(
return false;
}
-int NetworkDelegate::OnBeforeSocketStreamConnect(
- SocketStream* socket,
- const CompletionCallback& callback) {
- return OK;
-}
-
bool NetworkDelegate::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
const URLRequest& request,
const GURL& target_url,
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index 03dee0b..a169fc6 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -38,7 +38,6 @@ class HttpResponseHeaders;
class ProxyInfo;
class ProxyServer;
class ProxyService;
-class SocketStream;
class URLRequest;
class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
@@ -268,11 +267,6 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
const GURL& url,
const GURL& first_party_for_cookies) const;
- // Called before a SocketStream tries to connect.
- // See OnBeforeURLRequest for return value description. Returns OK by default.
- virtual int OnBeforeSocketStreamConnect(
- SocketStream* socket, const CompletionCallback& callback);
-
// Called when the |referrer_url| for requesting |target_url| during handling
// of the |request| is does not comply with the referrer policy (e.g. a
// secure referrer for an insecure initial target).
diff --git a/net/proxy/network_delegate_error_observer_unittest.cc b/net/proxy/network_delegate_error_observer_unittest.cc
index 5d2c501..da87f8d 100644
--- a/net/proxy/network_delegate_error_observer_unittest.cc
+++ b/net/proxy/network_delegate_error_observer_unittest.cc
@@ -77,10 +77,6 @@ class TestNetworkDelegate : public net::NetworkDelegate {
bool OnCanThrottleRequest(const URLRequest& request) const override {
return false;
}
- int OnBeforeSocketStreamConnect(SocketStream* stream,
- const CompletionCallback& callback) override {
- return OK;
- }
bool got_pac_error_;
};
diff --git a/net/proxy/proxy_script_fetcher_impl_unittest.cc b/net/proxy/proxy_script_fetcher_impl_unittest.cc
index 2073d00..4c5bd4c 100644
--- a/net/proxy/proxy_script_fetcher_impl_unittest.cc
+++ b/net/proxy/proxy_script_fetcher_impl_unittest.cc
@@ -179,11 +179,6 @@ class BasicNetworkDelegate : public NetworkDelegate {
return false;
}
- int OnBeforeSocketStreamConnect(SocketStream* stream,
- const CompletionCallback& callback) override {
- return OK;
- }
-
DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
};
diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc
index 41420d5..838aa7b 100644
--- a/net/url_request/url_request_context_builder.cc
+++ b/net/url_request/url_request_context_builder.cc
@@ -122,11 +122,6 @@ class BasicNetworkDelegate : public NetworkDelegate {
return true;
}
- int OnBeforeSocketStreamConnect(SocketStream* stream,
- const CompletionCallback& callback) override {
- return OK;
- }
-
DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
};
diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc
index 8f70ee7..6be7da3 100644
--- a/net/url_request/url_request_test_util.cc
+++ b/net/url_request/url_request_test_util.cc
@@ -604,12 +604,6 @@ bool TestNetworkDelegate::OnCanThrottleRequest(
return can_throttle_requests_;
}
-int TestNetworkDelegate::OnBeforeSocketStreamConnect(
- SocketStream* socket,
- const CompletionCallback& callback) {
- return OK;
-}
-
bool TestNetworkDelegate::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
const URLRequest& request,
const GURL& target_url,
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h
index 1289db7..1c385b2 100644
--- a/net/url_request/url_request_test_util.h
+++ b/net/url_request/url_request_test_util.h
@@ -325,8 +325,6 @@ class TestNetworkDelegate : public NetworkDelegate {
bool OnCanAccessFile(const URLRequest& request,
const base::FilePath& path) const override;
bool OnCanThrottleRequest(const URLRequest& request) const override;
- int OnBeforeSocketStreamConnect(SocketStream* stream,
- const CompletionCallback& callback) override;
bool OnCancelURLRequestWithPolicyViolatingReferrerHeader(
const URLRequest& request,
const GURL& target_url,