diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 13:23:40 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 13:23:40 +0000 |
commit | 1e70633dcc7a5a337d0f896b5ad2b81aa91d898b (patch) | |
tree | f95b44980a46e8c9a1d741b42bf9ad81afe02a64 | |
parent | 45f730cf5aa1ee3597a0e716fa82a4fe083f1c4c (diff) | |
download | chromium_src-1e70633dcc7a5a337d0f896b5ad2b81aa91d898b.zip chromium_src-1e70633dcc7a5a337d0f896b5ad2b81aa91d898b.tar.gz chromium_src-1e70633dcc7a5a337d0f896b5ad2b81aa91d898b.tar.bz2 |
ChromeOS: virtual destructors should have virtual keyword.
Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.
BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre
Review URL: http://codereview.chromium.org/6992062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86607 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/chromeos/boot_times_loader.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/cros/network_library.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/customization_document.h | 4 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/existing_user_controller.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/help_app_launcher.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/helper.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/login_html_dialog.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/user_controller.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/login/wizard_controller.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/version_loader.h | 2 | ||||
-rw-r--r-- | chrome/browser/chromeos/wm_message_listener.h | 2 | ||||
-rw-r--r-- | chrome/browser/ui/views/extensions/extension_view.h | 2 |
12 files changed, 13 insertions, 13 deletions
diff --git a/chrome/browser/chromeos/boot_times_loader.h b/chrome/browser/chromeos/boot_times_loader.h index 5bf4257..ac338d8 100644 --- a/chrome/browser/chromeos/boot_times_loader.h +++ b/chrome/browser/chromeos/boot_times_loader.h @@ -33,7 +33,7 @@ class BootTimesLoader public NotificationObserver { public: BootTimesLoader(); - ~BootTimesLoader(); + virtual ~BootTimesLoader(); // All fields are 0.0 if they couldn't be found. typedef struct BootTimes { diff --git a/chrome/browser/chromeos/cros/network_library.h b/chrome/browser/chromeos/cros/network_library.h index e9dc2cb..61d560e 100644 --- a/chrome/browser/chromeos/cros/network_library.h +++ b/chrome/browser/chromeos/cros/network_library.h @@ -430,7 +430,7 @@ class VirtualNetwork : public Network { }; explicit VirtualNetwork(const std::string& service_path); - ~VirtualNetwork(); + virtual ~VirtualNetwork(); const std::string& server_hostname() const { return server_hostname_; } ProviderType provider_type() const { return provider_type_; } diff --git a/chrome/browser/chromeos/customization_document.h b/chrome/browser/chromeos/customization_document.h index 0e5ba2c..d736e88 100644 --- a/chrome/browser/chromeos/customization_document.h +++ b/chrome/browser/chromeos/customization_document.h @@ -83,7 +83,7 @@ class StartupCustomizationDocument : public CustomizationDocument { StartupCustomizationDocument(SystemAccess* system_access, const std::string& manifest); - ~StartupCustomizationDocument(); + virtual ~StartupCustomizationDocument(); void Init(SystemAccess* system_access); @@ -169,7 +169,7 @@ class ServicesCustomizationDocument : public CustomizationDocument, ServicesCustomizationDocument(const std::string& manifest, const std::string& initial_locale); - ~ServicesCustomizationDocument(); + virtual ~ServicesCustomizationDocument(); // Save applied state in machine settings. static void SetApplied(bool val); diff --git a/chrome/browser/chromeos/login/existing_user_controller.h b/chrome/browser/chromeos/login/existing_user_controller.h index 550cf0a..61f8399 100644 --- a/chrome/browser/chromeos/login/existing_user_controller.h +++ b/chrome/browser/chromeos/login/existing_user_controller.h @@ -48,7 +48,7 @@ class ExistingUserController : public LoginDisplay::Delegate, public: // All UI initialization is deferred till Init() call. explicit ExistingUserController(LoginDisplayHost* host); - ~ExistingUserController(); + virtual ~ExistingUserController(); // Returns the current existing user controller if it has been created. static ExistingUserController* current_controller() { diff --git a/chrome/browser/chromeos/login/help_app_launcher.h b/chrome/browser/chromeos/login/help_app_launcher.h index 6c1ee9f..e3cde29 100644 --- a/chrome/browser/chromeos/login/help_app_launcher.h +++ b/chrome/browser/chromeos/login/help_app_launcher.h @@ -37,7 +37,7 @@ class HelpAppLauncher : public LoginHtmlDialog::Delegate, // Parent window is used to show dialog. explicit HelpAppLauncher(gfx::NativeWindow parent_window); - ~HelpAppLauncher(); + virtual ~HelpAppLauncher(); // Shows specified help topic. void ShowHelpTopic(HelpTopic help_topic_id); diff --git a/chrome/browser/chromeos/login/helper.h b/chrome/browser/chromeos/login/helper.h index 7cc2c07..3fc4cd1 100644 --- a/chrome/browser/chromeos/login/helper.h +++ b/chrome/browser/chromeos/login/helper.h @@ -156,7 +156,7 @@ class WideButton : public views::NativeButton { CorrectNativeButtonFontSize(this); } - ~WideButton() {} + virtual ~WideButton() {} private: virtual gfx::Size GetPreferredSize(); diff --git a/chrome/browser/chromeos/login/login_html_dialog.h b/chrome/browser/chromeos/login/login_html_dialog.h index b54ca19..6b3112b 100644 --- a/chrome/browser/chromeos/login/login_html_dialog.h +++ b/chrome/browser/chromeos/login/login_html_dialog.h @@ -41,7 +41,7 @@ class LoginHtmlDialog : public HtmlDialogUIDelegate, const std::wstring& title, const GURL& url, Style style); - ~LoginHtmlDialog(); + virtual ~LoginHtmlDialog(); // Shows created dialog. void Show(); diff --git a/chrome/browser/chromeos/login/user_controller.h b/chrome/browser/chromeos/login/user_controller.h index 1b6471e..8b8d18a 100644 --- a/chrome/browser/chromeos/login/user_controller.h +++ b/chrome/browser/chromeos/login/user_controller.h @@ -60,7 +60,7 @@ class UserController : public views::WidgetDelegate, // Creates a UserController for the specified user. UserController(Delegate* delegate, const UserManager::User& user); - ~UserController(); + virtual ~UserController(); // Initializes the UserController, creating the set of windows/controls. // |index| is the index of this user, and |total_user_count| the total diff --git a/chrome/browser/chromeos/login/wizard_controller.h b/chrome/browser/chromeos/login/wizard_controller.h index 65c817b..fac5554 100644 --- a/chrome/browser/chromeos/login/wizard_controller.h +++ b/chrome/browser/chromeos/login/wizard_controller.h @@ -51,7 +51,7 @@ class WizardController : public chromeos::ScreenObserver, public: explicit WizardController(chromeos::LoginDisplayHost* host, const gfx::Rect& screen_bounds); - ~WizardController(); + virtual ~WizardController(); // Returns the default wizard controller if it has been created. static WizardController* default_controller() { diff --git a/chrome/browser/chromeos/version_loader.h b/chrome/browser/chromeos/version_loader.h index c608b4e..219cd3a 100644 --- a/chrome/browser/chromeos/version_loader.h +++ b/chrome/browser/chromeos/version_loader.h @@ -34,7 +34,7 @@ namespace chromeos { class VersionLoader : public CancelableRequestProvider { public: VersionLoader(); - ~VersionLoader(); + virtual ~VersionLoader(); enum VersionFormat { VERSION_SHORT, diff --git a/chrome/browser/chromeos/wm_message_listener.h b/chrome/browser/chromeos/wm_message_listener.h index 96ac8dc..b01031c3 100644 --- a/chrome/browser/chromeos/wm_message_listener.h +++ b/chrome/browser/chromeos/wm_message_listener.h @@ -49,7 +49,7 @@ class WmMessageListener : public MessageLoopForUI::Observer { friend struct DefaultSingletonTraits<WmMessageListener>; WmMessageListener(); - ~WmMessageListener(); + virtual ~WmMessageListener(); // Invoked when a valid WmIpc::Message is received. void ProcessMessage(const WmIpc::Message& message, GdkWindow* window); diff --git a/chrome/browser/ui/views/extensions/extension_view.h b/chrome/browser/ui/views/extensions/extension_view.h index 52dd41e..e399658 100644 --- a/chrome/browser/ui/views/extensions/extension_view.h +++ b/chrome/browser/ui/views/extensions/extension_view.h @@ -21,7 +21,7 @@ class RenderViewHost; class ExtensionView : public views::NativeViewHost { public: ExtensionView(ExtensionHost* host, Browser* browser); - ~ExtensionView(); + virtual ~ExtensionView(); // A class that represents the container that this view is in. // (bottom shelf, side bar, etc.) |