diff options
| author | cem.kocagil@gmail.com <cem.kocagil@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 17:40:29 +0000 |
|---|---|---|
| committer | cem.kocagil@gmail.com <cem.kocagil@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-05 17:40:29 +0000 |
| commit | 1ec650f4b2f12ac8020ec0ca56f9183180c0a563 (patch) | |
| tree | 9fc60956b644434751de2ad5c5cc09da1f87b8cd | |
| parent | 7dca9a440b238ea252fc119bace1ec9c77b2f695 (diff) | |
| download | chromium_src-1ec650f4b2f12ac8020ec0ca56f9183180c0a563.zip chromium_src-1ec650f4b2f12ac8020ec0ca56f9183180c0a563.tar.gz chromium_src-1ec650f4b2f12ac8020ec0ca56f9183180c0a563.tar.bz2 | |
Update title/favicon after changing history, not before
BUG=121173
TEST=Back/forward button popups should show correct titles and favicons after navigating in uber pages
NOTRY=true
Review URL: http://codereview.chromium.org/9959057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130960 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/uber/uber.js | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/resources/uber/uber.js b/chrome/browser/resources/uber/uber.js index 8ddafb8..c46a821 100644 --- a/chrome/browser/resources/uber/uber.js +++ b/chrome/browser/resources/uber/uber.js @@ -268,9 +268,6 @@ cr.define('uber', function() { if (lastSelected) lastSelected.classList.remove('selected'); container.classList.add('selected'); - if (container.dataset.title) - document.title = container.dataset.title; - $('favicon').href = container.dataset.favicon; setContentChanging(true); adjustToScroll(0); @@ -281,6 +278,10 @@ cr.define('uber', function() { if (historyOption != HISTORY_STATE_OPTION.NONE) changePathTo(path, historyOption); + if (container.dataset.title) + document.title = container.dataset.title; + $('favicon').href = container.dataset.favicon; + updateNavigationControls(); } |