diff options
| author | iclelland <iclelland@chromium.org> | 2015-07-06 19:32:47 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-07 02:33:15 +0000 |
| commit | 201cc1ccba9857c0efc9d6b60fb2be8206ae3f6c (patch) | |
| tree | a163e6d6a8024d897724a9d7d641697630d468a2 | |
| parent | a64aac5f862d6c36c3fc52f5f3a25b80482d37a3 (diff) | |
| download | chromium_src-201cc1ccba9857c0efc9d6b60fb2be8206ae3f6c.zip chromium_src-201cc1ccba9857c0efc9d6b60fb2be8206ae3f6c.tar.gz chromium_src-201cc1ccba9857c0efc9d6b60fb2be8206ae3f6c.tar.bz2 | |
Remove sync button from chrome://serviceworker-internals page
This removes the button, and the code supporting it, from
chrome://serviceworker-internals.
The sync event itself is unchanged, but it will soon require that the details of
the specific sync registration be passed with it (see crbug/482066) so the
button is no longer useful.
BUG=507280
Review URL: https://codereview.chromium.org/1222313007
Cr-Commit-Position: refs/heads/master@{#337548}
3 files changed, 1 insertions, 9 deletions
diff --git a/content/browser/resources/service_worker/serviceworker_internals.html b/content/browser/resources/service_worker/serviceworker_internals.html index fd3fb9e..4e81776 100644 --- a/content/browser/resources/service_worker/serviceworker_internals.html +++ b/content/browser/resources/service_worker/serviceworker_internals.html @@ -49,9 +49,6 @@ <button href="#" class="stop" jsvalues=".cmdArgs:{partition_id:$partition_id,version_id:version_id}" jsdisplay="$this.running_status == 'RUNNING'">Stop</button> - <button href="#" class="sync" - jsvalues=".cmdArgs:{partition_id:$partition_id,version_id:version_id}" - jsdisplay="$this.running_status == 'RUNNING'">Sync</button> <button href="#" class="push" jsvalues=".cmdArgs:{partition_id:$partition_id,version_id:version_id}" jsdisplay="$this.running_status == 'RUNNING'">Push</button> diff --git a/content/browser/resources/service_worker/serviceworker_internals.js b/content/browser/resources/service_worker/serviceworker_internals.js index b5c85ee..ff382dd 100644 --- a/content/browser/resources/service_worker/serviceworker_internals.js +++ b/content/browser/resources/service_worker/serviceworker_internals.js @@ -42,7 +42,7 @@ cr.define('serviceworker', function() { } // All commands are completed with 'onOperationComplete'. - var COMMANDS = ['stop', 'sync', 'push', 'inspect', 'unregister', 'start']; + var COMMANDS = ['stop', 'push', 'inspect', 'unregister', 'start']; function commandHandler(command) { return function(event) { var link = event.target; diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc index 2176eb7..0e50fa4 100644 --- a/content/browser/service_worker/service_worker_internals_ui.cc +++ b/content/browser/service_worker/service_worker_internals_ui.cc @@ -356,11 +356,6 @@ ServiceWorkerInternalsUI::ServiceWorkerInternalsUI(WebUI* web_ui) base::Unretained(this), &ServiceWorkerVersion::StopWorker)); web_ui->RegisterMessageCallback( - "sync", - base::Bind(&ServiceWorkerInternalsUI::CallServiceWorkerVersionMethod, - base::Unretained(this), - &ServiceWorkerVersion::DispatchSyncEvent)); - web_ui->RegisterMessageCallback( "push", base::Bind(&ServiceWorkerInternalsUI::DispatchPushEvent, base::Unretained(this))); |