diff options
author | stuartmorgan <stuartmorgan@chromium.org> | 2015-10-23 16:00:16 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-23 23:01:11 +0000 |
commit | 20443afffd2409eef93ec23e57838d42d0bcd5a1 (patch) | |
tree | cb3f34d9482339454f4c2fa903b28e62baae2f6a | |
parent | 1a30023bb47bb117c3c8d8d078db5aa8d50cedf1 (diff) | |
download | chromium_src-20443afffd2409eef93ec23e57838d42d0bcd5a1.zip chromium_src-20443afffd2409eef93ec23e57838d42d0bcd5a1.tar.gz chromium_src-20443afffd2409eef93ec23e57838d42d0bcd5a1.tar.bz2 |
Remove many of my old TODOs in /chrome
Cleans up TODOs that:
- were copied and pasted along with surrounding code to components where
they don't apply, or
- are about minor refactorings that never happened and are years old, so
aren't worth leaving the TODOs for, or
- are about validation UI that was never implmeneted, but are about mocks
that are 4+ years old at this point so don't make sense to implement.
BUG=546136
Review URL: https://codereview.chromium.org/1415263002
Cr-Commit-Position: refs/heads/master@{#355914}
7 files changed, 6 insertions, 26 deletions
diff --git a/chrome/browser/resources/extensions/chromeos/kiosk_apps.css b/chrome/browser/resources/extensions/chromeos/kiosk_apps.css index 6040b462..55b93b3 100644 --- a/chrome/browser/resources/extensions/chromeos/kiosk_apps.css +++ b/chrome/browser/resources/extensions/chromeos/kiosk_apps.css @@ -24,7 +24,6 @@ list .row-delete-button { -webkit-transition: 150ms opacity; background-color: transparent; - /* TODO(stuartmorgan): Replace with real images once they are available. */ background-image: -webkit-image-set( url(../../../../../ui/resources/default_100_percent/close_2.png) 1x, url(../../../../../ui/resources/default_200_percent/close_2.png) 2x); diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.js b/chrome/browser/resources/options/content_settings_exceptions_area.js index 03ad5ae..7d63dee 100644 --- a/chrome/browser/resources/options/content_settings_exceptions_area.js +++ b/chrome/browser/resources/options/content_settings_exceptions_area.js @@ -63,8 +63,6 @@ cr.define('options.contentSettings', function() { this.patternLabel = patternCell.querySelector('.static-text'); var input = patternCell.querySelector('input'); - // TODO(stuartmorgan): Create an createEditableSelectCell abstracting - // this code. // Setting label for display mode. |pattern| will be null for the 'add new // exception' row. if (this.pattern) { diff --git a/chrome/browser/resources/options/options_page.css b/chrome/browser/resources/options/options_page.css index a35f460..1a35940 100644 --- a/chrome/browser/resources/options/options_page.css +++ b/chrome/browser/resources/options/options_page.css @@ -191,9 +191,8 @@ list:not([disabled]) > :hover { background-color: rgb(228, 236, 247); } -/* TODO(stuartmorgan): Once this becomes the list style for other WebUI pages - * these rules can be simplified (since they wont need to override other rules). - */ +/* Note: If this becomes the list style for other WebUI pages these rules can be + * simplified (since they wont need to override other rules). */ list:not([has-element-focus]) > [selected], list:not([has-element-focus]) > [lead][selected] { @@ -258,7 +257,6 @@ list .deletable-item > :first-child { list .row-delete-button { -webkit-transition: 150ms opacity; background-color: transparent; - /* TODO(stuartmorgan): Replace with real images once they are available. */ background-image: -webkit-image-set( url(../../../../ui/resources/default_100_percent/close_2.png) 1x, url(../../../../ui/resources/default_200_percent/close_2.png) 2x); @@ -331,7 +329,6 @@ list > [editing] [displaymode='static'] { } list > [editing] input:invalid { - /* TODO(stuartmorgan): Replace with validity badge */ background-color: pink; } diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js index b2c6c11..024e62f 100644 --- a/chrome/browser/resources/options/search_engine_manager_engine_list.js +++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js @@ -303,8 +303,6 @@ cr.define('options.search_engines', function() { */ validationComplete: function(validity) { this.waitingForValidation_ = false; - // TODO(stuartmorgan): Implement the full validation UI with - // checkmark/exclamation mark icons and tooltips showing the errors. if (validity.name) { this.nameField_.setCustomValidity(''); } else { diff --git a/chrome/browser/ui/webui/options/startup_pages_handler.h b/chrome/browser/ui/webui/options/startup_pages_handler.h index dbf0a94..67810a2 100644 --- a/chrome/browser/ui/webui/options/startup_pages_handler.h +++ b/chrome/browser/ui/webui/options/startup_pages_handler.h @@ -83,9 +83,7 @@ class StartupPagesHandler : public OptionsPageUIHandler, // on startup, which can be updated via sync. PrefChangeRegistrar pref_change_registrar_; - // TODO(stuartmorgan): Once there are no other clients of - // CustomHomePagesTableModel, consider changing it to something more like - // TemplateURLService. + // The set of pages to launch on startup. scoped_ptr<CustomHomePagesTableModel> startup_custom_pages_table_model_; DISALLOW_COPY_AND_ASSIGN(StartupPagesHandler); diff --git a/chrome/common/extensions/docs/examples/extensions/plugin_settings/js/rule_list.js b/chrome/common/extensions/docs/examples/extensions/plugin_settings/js/rule_list.js index 9919958..63cb846 100644 --- a/chrome/common/extensions/docs/examples/extensions/plugin_settings/js/rule_list.js +++ b/chrome/common/extensions/docs/examples/extensions/plugin_settings/js/rule_list.js @@ -115,8 +115,6 @@ cr.define('pluginSettings.ui', function() { input.placeholder = chrome.i18n.getMessage('addNewPattern'); } - // TODO(stuartmorgan): Create an createEditableSelectCell abstracting - // this code. // Setting label for display mode. |pattern| will be null for the 'add new // exception' row. if (this.pattern) { diff --git a/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css b/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css index 9cc716d..cc12033 100644 --- a/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css +++ b/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/css/list.css @@ -1,8 +1,6 @@ -/* -Copyright (c) 2011 The Chromium Authors. All rights reserved. -Use of this source code is governed by a BSD-style license that can be -found in the LICENSE file. -*/ +/* Copyright 2011 The Chromium Authors. All rights reserved. + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. */ .raw-button, .raw-button:hover, @@ -30,10 +28,6 @@ list:not([disabled]) > :hover { background-color: #e4ecf7; } -/* TODO(stuartmorgan): Once this becomes the list style for other WebUI pages - * these rules can be simplified (since they wont need to override other rules). - */ - list:not([hasElementFocus]) > [selected], list:not([hasElementFocus]) > [lead][selected] { background-color: #d0d0d0; @@ -75,7 +69,6 @@ list .deletable-item > :first-child { list .close-button { -webkit-transition: .15s opacity; background-color: transparent; - /* TODO(stuartmorgan): Replace with real images once they are available. */ background-image: url("../images/close_bar.png"); border: none; display: block; @@ -119,6 +112,5 @@ list[inlineeditable] > [editing] [displaymode="static"] { } list > [editing] input:invalid { - /* TODO(stuartmorgan): Replace with validity badge */ background-color: pink; } |