diff options
| author | dougk <dougk@chromium.org> | 2015-02-12 18:47:52 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-13 02:48:30 +0000 |
| commit | 225bf680e62b2e6d51d2dc108c9098c96138093f (patch) | |
| tree | c2c6c071a26c5d581131eb3e2de913b229b448b3 | |
| parent | 6c3fc94f9ca47dabc0683e53df8ad7fdf971cd2e (diff) | |
| download | chromium_src-225bf680e62b2e6d51d2dc108c9098c96138093f.zip chromium_src-225bf680e62b2e6d51d2dc108c9098c96138093f.tar.gz chromium_src-225bf680e62b2e6d51d2dc108c9098c96138093f.tar.bz2 | |
Cosmetic changes (spelling, grammar) and fix an annoyance.
* "x can't contain y because of z" sounds like it means
"but x might contain y because of a reason OTHER than z"
* wrong reference to Open Group specification
* always interpret the specified "--output" as a directory
BUG=none
Review URL: https://codereview.chromium.org/922833002
Cr-Commit-Position: refs/heads/master@{#316139}
| -rw-r--r-- | base/files/file_path.h | 6 | ||||
| -rw-r--r-- | net/tools/dump_cache/cache_dumper.cc | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/base/files/file_path.h b/base/files/file_path.h index 67bbb4b..93f9ec9 100644 --- a/base/files/file_path.h +++ b/base/files/file_path.h @@ -53,7 +53,7 @@ // between char[]-based pathnames on POSIX systems and wchar_t[]-based // pathnames on Windows. // -// Paths can't contain NULs as a precaution agaist premature truncation. +// As a precaution against premature truncation, paths can't contain NULs. // // Because a FilePath object should not be instantiated at the global scope, // instead, use a FilePath::CharType[] and initialize it with @@ -83,9 +83,9 @@ // in case it ever comes across such a system. FilePath needs this support // for Windows UNC paths, anyway. // References: -// The Open Group Base Specifications Issue 7, sections 3.266 ("Pathname") +// The Open Group Base Specifications Issue 7, sections 3.267 ("Pathname") // and 4.12 ("Pathname Resolution"), available at: -// http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_266 +// http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_267 // http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_12 // // - Windows treats c:\\ the same way it treats \\. This was intended to diff --git a/net/tools/dump_cache/cache_dumper.cc b/net/tools/dump_cache/cache_dumper.cc index 99e3dcd..8820798 100644 --- a/net/tools/dump_cache/cache_dumper.cc +++ b/net/tools/dump_cache/cache_dumper.cc @@ -69,7 +69,7 @@ bool SafeCreateDirectory(const base::FilePath& path) { } DiskDumper::DiskDumper(const base::FilePath& path) - : path_(path), entry_(NULL) { + : path_(path.AsEndingWithSeparator()), entry_(NULL) { base::CreateDirectory(path); } |