diff options
| author | bshe@chromium.org <bshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-11 19:09:44 +0000 |
|---|---|---|
| committer | bshe@chromium.org <bshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-11 19:09:44 +0000 |
| commit | 29ea415078b083c7979c0fcf3ee06b6bb188c735 (patch) | |
| tree | ac08a47a4813857175bc2b7f3ca3a06f57ff7c69 | |
| parent | c032489dec20760f7df8d2cf51ce97a4c6dd4e8c (diff) | |
| download | chromium_src-29ea415078b083c7979c0fcf3ee06b6bb188c735.zip chromium_src-29ea415078b083c7979c0fcf3ee06b6bb188c735.tar.gz chromium_src-29ea415078b083c7979c0fcf3ee06b6bb188c735.tar.bz2 | |
Revert "Add diagnostic logs for transparent app icons for component extension"
The logs were added in codereview.chromium.org/102033005. The issue is no longer
able to repo. So removing the logs.
TBR=miket, xiyuan
BUG=314872
Review URL: https://codereview.chromium.org/158723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250464 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/extensions/extension_icon_image.cc | 11 | ||||
| -rw-r--r-- | chrome/browser/extensions/image_loader.cc | 8 |
2 files changed, 0 insertions, 19 deletions
diff --git a/chrome/browser/extensions/extension_icon_image.cc b/chrome/browser/extensions/extension_icon_image.cc index 3aa36c6..625bb01 100644 --- a/chrome/browser/extensions/extension_icon_image.cc +++ b/chrome/browser/extensions/extension_icon_image.cc @@ -196,12 +196,6 @@ gfx::ImageSkiaRep IconImage::LoadImageForScaleFactor( extensions::ImageLoader* loader = extensions::ImageLoader::Get(browser_context_); - if (extension_->location() == Manifest::COMPONENT) { - // bshe's log for http://crbug.com/314872 - LOG(ERROR) << "Start loading extension icon for " << extension_->name() - << ". scale = " << scale; - } - loader->LoadImagesAsync(extension_, info_list, base::Bind(&IconImage::OnImageLoaded, weak_ptr_factory_.GetWeakPtr(), @@ -214,11 +208,6 @@ void IconImage::OnImageLoaded(float scale, const gfx::Image& image_in) { const gfx::ImageSkia* image = image_in.IsEmpty() ? &default_icon_ : image_in.ToImageSkia(); - if (extension_->location() == Manifest::COMPONENT) { - // bshe's log for http://crbug.com/314872 - LOG(ERROR) << "Component extension icon for " << extension_->name() - << " is loaded. scale = " << scale; - } // Maybe default icon was not set. if (image->isNull()) return; diff --git a/chrome/browser/extensions/image_loader.cc b/chrome/browser/extensions/image_loader.cc index 582ab39..a6e91cf 100644 --- a/chrome/browser/extensions/image_loader.cc +++ b/chrome/browser/extensions/image_loader.cc @@ -312,14 +312,6 @@ void ImageLoader::LoadImagesAsync( it->resource.relative_path(), &resource_id)) { LoadResourceOnUIThread(resource_id, &bitmaps[i]); - if (bitmaps[i].isNull()) { - // bshe's log for http://crbug.com/314872 - LOG(ERROR) << "Component extension icon for " << extension->name() - << " is null."; - LOG(ERROR) << "Extension icon resource id = " << resource_id - << "; desired_size = " << it->desired_size.ToString() - << "; scale_factor = " << it->scale_factor; - } } } |