diff options
| author | haibinlu <haibinlu@chromium.org> | 2016-03-22 17:51:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-23 00:52:51 +0000 |
| commit | 2a8c299f30841161e4dfc30538a8cfd10ef87aa6 (patch) | |
| tree | 25004cb228c6d70847b0a278895c4d0bbba1eb22 | |
| parent | d255da18fe5a85dd249ed8f99e84a2a1c66806bf (diff) | |
| download | chromium_src-2a8c299f30841161e4dfc30538a8cfd10ef87aa6.zip chromium_src-2a8c299f30841161e4dfc30538a8cfd10ef87aa6.tar.gz chromium_src-2a8c299f30841161e4dfc30538a8cfd10ef87aa6.tar.bz2 | |
[Blimp Engine] Removes a few NOTIMPLEMENTED
Removes NOTIMPLEMENTED which generate lots of Engine logs.
Issue with sending tab favicon change to Client (BlimpEngineSession::NavigationStateChanged) is now tracked by crbug.com/597094.
No need to implement BlimpUiContextFactory::ResizeDisplay/GetSharedBitmapManager/CreateOutputSurface
Review URL: https://codereview.chromium.org/1822223002
Cr-Commit-Position: refs/heads/master@{#382750}
| -rw-r--r-- | blimp/engine/app/ui/blimp_ui_context_factory.cc | 3 | ||||
| -rw-r--r-- | blimp/engine/session/blimp_engine_session.cc | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/blimp/engine/app/ui/blimp_ui_context_factory.cc b/blimp/engine/app/ui/blimp_ui_context_factory.cc index d41150a2..b9246d0 100644 --- a/blimp/engine/app/ui/blimp_ui_context_factory.cc +++ b/blimp/engine/app/ui/blimp_ui_context_factory.cc @@ -20,7 +20,6 @@ BlimpUiContextFactory::~BlimpUiContextFactory() {} void BlimpUiContextFactory::CreateOutputSurface( base::WeakPtr<ui::Compositor> compositor) { - NOTIMPLEMENTED(); } scoped_ptr<ui::Reflector> BlimpUiContextFactory::CreateReflector( @@ -55,7 +54,6 @@ uint32_t BlimpUiContextFactory::GetImageTextureTarget(gfx::BufferFormat format, } cc::SharedBitmapManager* BlimpUiContextFactory::GetSharedBitmapManager() { - NOTIMPLEMENTED(); return nullptr; } @@ -76,7 +74,6 @@ BlimpUiContextFactory::CreateSurfaceIdAllocator() { void BlimpUiContextFactory::ResizeDisplay(ui::Compositor* compositor, const gfx::Size& size) { - NOTIMPLEMENTED(); } } // namespace engine diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc index eb144b1..64d0e8f 100644 --- a/blimp/engine/session/blimp_engine_session.cc +++ b/blimp/engine/session/blimp_engine_session.cc @@ -468,8 +468,8 @@ void BlimpEngineSession::NavigationStateChanged( details->set_url(source->GetURL().spec()); if (changed_flags & content::InvalidateTypes::INVALIDATE_TYPE_TAB) { - // TODO(dtrainor): Serialize the favicon? - NOTIMPLEMENTED(); + // TODO(dtrainor): Serialize the favicon? crbug.com/597094. + DVLOG(3) << "Tab favicon changed"; } if (changed_flags & content::InvalidateTypes::INVALIDATE_TYPE_TITLE) |