diff options
| author | ssid <ssid@chromium.org> | 2016-02-01 08:09:51 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-01 16:10:48 +0000 |
| commit | 2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71 (patch) | |
| tree | dbe0139caea9291fb64132f07c20fb7d9bfefc4e | |
| parent | 89b4a2addd0e3e82a1ca8213d31323fdc2e6395a (diff) | |
| download | chromium_src-2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71.zip chromium_src-2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71.tar.gz chromium_src-2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71.tar.bz2 | |
Remove --no-sandbox flag from command line for telemetry
Now that the browser is able to dump for child processes the
--no-sandbox flag is not required for getting memory statistics. So,
this is removed form the telemetry benchmarks.
BUG=461788
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Review URL: https://codereview.chromium.org/1584583003
Cr-Commit-Position: refs/heads/master@{#372667}
| -rw-r--r-- | base/trace_event/memory_dump_manager.cc | 4 | ||||
| -rw-r--r-- | tools/perf/benchmarks/memory_infra.py | 2 | ||||
| -rw-r--r-- | tools/perf/benchmarks/oortonline.py | 2 | ||||
| -rw-r--r-- | tools/perf/benchmarks/v8.py | 2 |
4 files changed, 1 insertions, 9 deletions
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc index a0f0af3..cb59448 100644 --- a/base/trace_event/memory_dump_manager.cc +++ b/base/trace_event/memory_dump_manager.cc @@ -419,9 +419,7 @@ void MemoryDumpManager::ContinueAsyncProcessDump( if (!mdpinfo->disabled) { if (mdpinfo->consecutive_failures >= kMaxConsecutiveFailuresCount) { mdpinfo->disabled = true; - disabled_reason = - "Dump failure, possibly related with sandboxing (crbug.com/461788)." - " Try --no-sandbox."; + disabled_reason = "Dump failed multiple times consecutively."; } else if (post_task_failed && mdpinfo->task_runner) { // Don't disable unbound dump providers. The utility thread is normally // shutdown when disabling the trace and getting here in this case is diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py index cead2ea..15a03e8 100644 --- a/tools/perf/benchmarks/memory_infra.py +++ b/tools/perf/benchmarks/memory_infra.py @@ -26,8 +26,6 @@ class _MemoryInfra(perf_benchmark.PerfBenchmark): # TODO(perezju): Temporary workaround to disable periodic memory dumps. # See: http://crbug.com/513692 '--enable-memory-benchmarking', - # TODO(ssid): Remove this flag after fixing http://crbug.com/461788. - '--no-sandbox' ]) def CreateTimelineBasedMeasurementOptions(self): diff --git a/tools/perf/benchmarks/oortonline.py b/tools/perf/benchmarks/oortonline.py index f5c46a5..f81a421 100644 --- a/tools/perf/benchmarks/oortonline.py +++ b/tools/perf/benchmarks/oortonline.py @@ -61,8 +61,6 @@ class OortOnlineTBM(perf_benchmark.PerfBenchmark): # TODO(perezju): Temporary workaround to disable periodic memory dumps. # See: http://crbug.com/513692 '--enable-memory-benchmarking', - # TODO(ssid): Remove this flag after fixing http://crbug.com/461788. - '--no-sandbox' ]) def CreateStorySet(self, options): diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py index 3208013..64a49b8 100644 --- a/tools/perf/benchmarks/v8.py +++ b/tools/perf/benchmarks/v8.py @@ -63,8 +63,6 @@ class V8InfiniteScroll(perf_benchmark.PerfBenchmark): # TODO(perezju): Temporary workaround to disable periodic memory dumps. # See: http://crbug.com/513692 '--enable-memory-benchmarking', - # TODO(ssid): Remove this flag after fixing http://crbug.com/461788. - '--no-sandbox', '--js-flags=--heap-growing-percent=10' ]) |