diff options
author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-30 20:51:01 +0000 |
---|---|---|
committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-30 20:51:01 +0000 |
commit | 308608cd64ab7012af9c3b8e2509ba7db51a3bd6 (patch) | |
tree | 330c0f52a9f3225c229cc481d64a65a0de5698f2 | |
parent | 5a7de14e6a2b7e742e7189b6fa6d0e641dd2017d (diff) | |
download | chromium_src-308608cd64ab7012af9c3b8e2509ba7db51a3bd6.zip chromium_src-308608cd64ab7012af9c3b8e2509ba7db51a3bd6.tar.gz chromium_src-308608cd64ab7012af9c3b8e2509ba7db51a3bd6.tar.bz2 |
Cleanup: Remove unused metadata parser code.
BUG=76745
Review URL: https://codereview.chromium.org/343343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280659 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/parsers/metadata_parser.cc | 9 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser.h | 54 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_factory.h | 32 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_filebase.cc | 76 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_filebase.h | 57 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_filebase_unittest.cc | 99 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_jpeg.cc | 14 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_jpeg.h | 20 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_jpeg_factory.cc | 31 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_jpeg_factory.h | 30 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_manager.cc | 53 | ||||
-rw-r--r-- | chrome/browser/parsers/metadata_parser_manager.h | 42 | ||||
-rw-r--r-- | chrome/chrome_browser.gypi | 11 | ||||
-rw-r--r-- | chrome/chrome_tests_unit.gypi | 1 |
14 files changed, 0 insertions, 529 deletions
diff --git a/chrome/browser/parsers/metadata_parser.cc b/chrome/browser/parsers/metadata_parser.cc deleted file mode 100644 index 0bf120a..0000000 --- a/chrome/browser/parsers/metadata_parser.cc +++ /dev/null @@ -1,9 +0,0 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/browser/parsers/metadata_parser.h" - -const char* MetadataParser::kPropertyFilesize = "filesize"; -const char* MetadataParser::kPropertyType = "type"; -const char* MetadataParser::kPropertyTitle = "title"; diff --git a/chrome/browser/parsers/metadata_parser.h b/chrome/browser/parsers/metadata_parser.h deleted file mode 100644 index 8034a36..0000000 --- a/chrome/browser/parsers/metadata_parser.h +++ /dev/null @@ -1,54 +0,0 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_H_ - -#include <string> - -namespace base { -class FilePath; -} - -// Allows for Iteration on the Properties of a given file. -class MetadataPropertyIterator { - public: - MetadataPropertyIterator() {} - virtual ~MetadataPropertyIterator() {} - - - // Gets the next Property in the iterator. Returns false if at the end - // of the list. - virtual bool GetNext(std::string* key, std::string* value) = 0; - - // Gets the number of Properties in this iterator. - virtual int Length() = 0; - - // Checks to see if we're at the end of the list. - virtual bool IsEnd() = 0; -}; - -// Represents a single instance of parsing on a particular file. -class MetadataParser { - public: - explicit MetadataParser(const base::FilePath& path) {} - virtual ~MetadataParser() {} - - - static const char* kPropertyType; - static const char* kPropertyFilesize; - static const char* kPropertyTitle; - - // Does all the heavy work of parsing out the file. Blocking until complete. - virtual bool Parse() = 0; - - // Gets a particular property found in a parse call. - virtual bool GetProperty(const std::string& key, std::string* value) = 0; - - // Gets an interator allowing you to iterate over all the properties found - // in a parse call. - virtual MetadataPropertyIterator* GetPropertyIterator() = 0; -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_H_ diff --git a/chrome/browser/parsers/metadata_parser_factory.h b/chrome/browser/parsers/metadata_parser_factory.h deleted file mode 100644 index c6c5a26..0000000 --- a/chrome/browser/parsers/metadata_parser_factory.h +++ /dev/null @@ -1,32 +0,0 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_FACTORY_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_FACTORY_H_ - -#include "chrome/browser/parsers/metadata_parser.h" - -namespace base { -class FilePath; -} - -// Used to check to see if a parser can parse a particular file, and allows -// for creation of a parser on a particular file. -class MetadataParserFactory { - public: - MetadataParserFactory() {} - virtual ~MetadataParserFactory() {} - - // Used to check to see if the parser can parse the given file. This - // should not do any additional reading of the file. - virtual bool CanParse(const base::FilePath& path, - char* bytes, - int bytes_size) = 0; - - // Creates the parser on the given file. Creating the parser does not - // do any parsing on the file. Parse has to be called on the parser. - virtual MetadataParser* CreateParser(const base::FilePath& path) = 0; -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_FACTORY_H_ diff --git a/chrome/browser/parsers/metadata_parser_filebase.cc b/chrome/browser/parsers/metadata_parser_filebase.cc deleted file mode 100644 index 38a0b36..0000000 --- a/chrome/browser/parsers/metadata_parser_filebase.cc +++ /dev/null @@ -1,76 +0,0 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/browser/parsers/metadata_parser_filebase.h" - -#include "base/file_util.h" -#include "base/strings/string_number_conversions.h" -#include "base/strings/utf_string_conversions.h" - -FileMetadataParser::FileMetadataParser(const base::FilePath& path) - : MetadataParser(path), - path_(path) { -} - -FileMetadataParser::~FileMetadataParser() {} - -bool FileMetadataParser::Parse() { - std::string value; - int64 size; - if (base::GetFileSize(path_, &size)) { - properties_[MetadataParser::kPropertyFilesize] = base::Int64ToString(size); - } -#if defined(OS_WIN) - value = base::WideToUTF8(path_.BaseName().value()); - properties_[MetadataParser::kPropertyTitle] = value; -#elif defined(OS_POSIX) - properties_[MetadataParser::kPropertyTitle] = path_.BaseName().value(); -#endif - return true; -} - -bool FileMetadataParser::GetProperty(const std::string& key, - std::string* value) { - PropertyMap::iterator it = properties_.find(key.c_str()); - if (it == properties_.end()) { - return false; - } - - *value = properties_[key.c_str()]; - return true; -} - -MetadataPropertyIterator* FileMetadataParser::GetPropertyIterator() { - return new FileMetadataPropertyIterator(properties_); -} - -FileMetadataPropertyIterator::FileMetadataPropertyIterator( - PropertyMap& properties) : properties_(properties) { - it = properties_.begin(); -} - -FileMetadataPropertyIterator::~FileMetadataPropertyIterator() {} - -bool FileMetadataPropertyIterator::GetNext(std::string* key, - std::string* value) { - if (it == properties_.end()) { - return false; - } - *key = it->first; - *value = it->second; - it++; - return true; -} - -int FileMetadataPropertyIterator::Length() { - return properties_.size(); -} - -bool FileMetadataPropertyIterator::IsEnd() { - if (it == properties_.end()) { - return true; - } else { - return false; - } -} diff --git a/chrome/browser/parsers/metadata_parser_filebase.h b/chrome/browser/parsers/metadata_parser_filebase.h deleted file mode 100644 index 1431a61..0000000 --- a/chrome/browser/parsers/metadata_parser_filebase.h +++ /dev/null @@ -1,57 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_FILEBASE_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_FILEBASE_H_ - -#include <string> - -#include "base/basictypes.h" -#include "base/containers/hash_tables.h" -#include "base/files/file_path.h" -#include "chrome/browser/parsers/metadata_parser.h" - -typedef base::hash_map<std::string, std::string> PropertyMap; - -// Parser for the file type. Allows for parsing of files, and gets -// properties associated with files. -class FileMetadataParser : public MetadataParser { - public: - explicit FileMetadataParser(const base::FilePath& path); - - virtual ~FileMetadataParser(); - - // Implementation of MetadataParser - virtual bool Parse() OVERRIDE; - virtual bool GetProperty(const std::string& key, std::string* value) OVERRIDE; - - virtual MetadataPropertyIterator* GetPropertyIterator() OVERRIDE; - - protected: - PropertyMap properties_; - base::FilePath path_; - - private: - DISALLOW_COPY_AND_ASSIGN(FileMetadataParser); -}; - -class FileMetadataPropertyIterator : public MetadataPropertyIterator { - public: - explicit FileMetadataPropertyIterator(PropertyMap& properties); - - virtual ~FileMetadataPropertyIterator(); - - // Implementation of MetadataPropertyIterator - virtual bool GetNext(std::string* key, std::string* value) OVERRIDE; - virtual int Length() OVERRIDE; - virtual bool IsEnd() OVERRIDE; - - private: - PropertyMap& properties_; - PropertyMap::iterator it; - - DISALLOW_COPY_AND_ASSIGN(FileMetadataPropertyIterator); -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_FILEBASE_H_ diff --git a/chrome/browser/parsers/metadata_parser_filebase_unittest.cc b/chrome/browser/parsers/metadata_parser_filebase_unittest.cc deleted file mode 100644 index 99d4566..0000000 --- a/chrome/browser/parsers/metadata_parser_filebase_unittest.cc +++ /dev/null @@ -1,99 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include <map> -#include <string> - -#include "base/file_util.h" -#include "base/files/file_path.h" -#include "base/files/scoped_temp_dir.h" -#include "base/strings/string_number_conversions.h" -#include "base/strings/utf_string_conversions.h" -#include "chrome/browser/parsers/metadata_parser_filebase.h" -#include "testing/gtest/include/gtest/gtest.h" - -namespace { - -class FileMetaDataParserTest : public testing::Test { - protected: - virtual void SetUp() { - // Create a temporary directory for testing and fill it with a file. - ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); - - test_file_ = temp_dir_.path().AppendASCII("FileMetaDataParserTest"); - - // Create the test file. - std::string content = "content"; - int write_size = base::WriteFile(test_file_, content.c_str(), - content.length()); - ASSERT_EQ(static_cast<int>(content.length()), write_size); - } - - std::string test_file_str() { -#if defined(OS_POSIX) - return test_file_.BaseName().value(); -#elif defined(OS_WIN) - return base::UTF16ToASCII(test_file_.BaseName().value()); -#endif // defined(OS_POSIX) - } - - std::string test_file_size() { - int64 size; - EXPECT_TRUE(base::GetFileSize(test_file_, &size)); - - return base::Int64ToString(size); - } - - base::ScopedTempDir temp_dir_; - base::FilePath test_file_; -}; - -TEST_F(FileMetaDataParserTest, Parse) { - FileMetadataParser parser(test_file_); - - EXPECT_TRUE(parser.Parse()); - - std::string value; - EXPECT_TRUE(parser.GetProperty(MetadataParser::kPropertyTitle, &value)); - EXPECT_EQ(test_file_str(), value); - - // Verify the file size property. - EXPECT_TRUE(parser.GetProperty(MetadataParser::kPropertyFilesize, &value)); - EXPECT_EQ(test_file_size(), value); - - // FileMetadataParser does not set kPropertyType. - EXPECT_FALSE(parser.GetProperty(MetadataParser::kPropertyType, &value)); -} - -TEST_F(FileMetaDataParserTest, PropertyIterator) { - FileMetadataParser parser(test_file_); - - EXPECT_TRUE(parser.Parse()); - - scoped_ptr<MetadataPropertyIterator> iter(parser.GetPropertyIterator()); - ASSERT_NE(static_cast<MetadataPropertyIterator*>(NULL), iter.get()); - ASSERT_EQ(2, iter->Length()); - - std::map<std::string, std::string> expectations; - expectations[MetadataParser::kPropertyFilesize] = test_file_size(); - expectations[MetadataParser::kPropertyTitle] = test_file_str(); - - std::string key, value; - for (int i = 0; i < iter->Length(); ++i) { - EXPECT_FALSE(iter->IsEnd()); - EXPECT_TRUE(iter->GetNext(&key, &value)); - // No ostream operator<< implementation for map iterator, so can't use - // ASSERT_NE. - ASSERT_TRUE(expectations.find(key) != expectations.end()); - EXPECT_EQ(expectations[key], value); - - expectations.erase(key); - } - - EXPECT_TRUE(iter->IsEnd()); - EXPECT_FALSE(iter->GetNext(&key, &value)); - EXPECT_TRUE(expectations.empty()); -} - -} // namespace diff --git a/chrome/browser/parsers/metadata_parser_jpeg.cc b/chrome/browser/parsers/metadata_parser_jpeg.cc deleted file mode 100644 index 4018af5..0000000 --- a/chrome/browser/parsers/metadata_parser_jpeg.cc +++ /dev/null @@ -1,14 +0,0 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/browser/parsers/metadata_parser_jpeg.h" - -JpegMetadataParser::JpegMetadataParser(const base::FilePath& path) - : FileMetadataParser(path) {} - -bool JpegMetadataParser::Parse() { - FileMetadataParser::Parse(); - properties_[MetadataParser::kPropertyType] = "jpeg"; - return true; -} diff --git a/chrome/browser/parsers/metadata_parser_jpeg.h b/chrome/browser/parsers/metadata_parser_jpeg.h deleted file mode 100644 index fcb232c..0000000 --- a/chrome/browser/parsers/metadata_parser_jpeg.h +++ /dev/null @@ -1,20 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_H_ - -#include "chrome/browser/parsers/metadata_parser_filebase.h" - -class JpegMetadataParser : public FileMetadataParser { - public: - explicit JpegMetadataParser(const base::FilePath& path); - // Implementation of MetadataParser - virtual bool Parse() OVERRIDE; - - private: - DISALLOW_COPY_AND_ASSIGN(JpegMetadataParser); -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_H_ diff --git a/chrome/browser/parsers/metadata_parser_jpeg_factory.cc b/chrome/browser/parsers/metadata_parser_jpeg_factory.cc deleted file mode 100644 index 3297e79..0000000 --- a/chrome/browser/parsers/metadata_parser_jpeg_factory.cc +++ /dev/null @@ -1,31 +0,0 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/browser/parsers/metadata_parser_jpeg_factory.h" - -#include "base/files/file_path.h" -#include "base/strings/utf_string_conversions.h" -#include "chrome/browser/parsers/metadata_parser_jpeg.h" - -MetadataParserJpegFactory::MetadataParserJpegFactory() - : MetadataParserFactory() { -} - -bool MetadataParserJpegFactory::CanParse(const base::FilePath& path, - char* bytes, - int bytes_size) { -#if defined(OS_WIN) - base::FilePath::StringType ext = base::UTF8ToWide(std::string(".jpg")); -#elif defined(OS_POSIX) - base::FilePath::StringType ext = ".jpg"; -#endif - return path.MatchesExtension(ext); -} - -MetadataParser* MetadataParserJpegFactory::CreateParser( - const base::FilePath& path) { - JpegMetadataParser* parser; - parser = new JpegMetadataParser(path); - return parser; -} diff --git a/chrome/browser/parsers/metadata_parser_jpeg_factory.h b/chrome/browser/parsers/metadata_parser_jpeg_factory.h deleted file mode 100644 index 1c21144..0000000 --- a/chrome/browser/parsers/metadata_parser_jpeg_factory.h +++ /dev/null @@ -1,30 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_FACTORY_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_FACTORY_H_ - -#include "base/basictypes.h" -#include "base/compiler_specific.h" -#include "chrome/browser/parsers/metadata_parser_factory.h" - -namespace base { -class FilePath; -} - -class MetadataParserJpegFactory : public MetadataParserFactory { - public: - MetadataParserJpegFactory(); - - // Implementation of MetadataParserFactory - virtual bool CanParse(const base::FilePath& path, - char* bytes, - int bytes_size) OVERRIDE; - virtual MetadataParser* CreateParser(const base::FilePath& path) OVERRIDE; - - private: - DISALLOW_COPY_AND_ASSIGN(MetadataParserJpegFactory); -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_JPEG_FACTORY_H_ diff --git a/chrome/browser/parsers/metadata_parser_manager.cc b/chrome/browser/parsers/metadata_parser_manager.cc deleted file mode 100644 index b60a0dd..0000000 --- a/chrome/browser/parsers/metadata_parser_manager.cc +++ /dev/null @@ -1,53 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/browser/parsers/metadata_parser_manager.h" - -#include "base/logging.h" -#include "base/file_util.h" -#include "base/memory/singleton.h" -#include "base/stl_util.h" -#include "build/build_config.h" -#include "chrome/browser/parsers/metadata_parser_factory.h" -#include "chrome/browser/parsers/metadata_parser_jpeg_factory.h" - -static const int kAmountToRead = 256; - -// Gets the singleton -MetadataParserManager* MetadataParserManager::GetInstance() { - // Uses the LeakySingletonTrait because cleanup is optional. - return Singleton<MetadataParserManager, - LeakySingletonTraits<MetadataParserManager> >::get(); -} - -bool MetadataParserManager::RegisterParserFactory( - MetadataParserFactory* parser) { - factories_.push_back(parser); - return true; -} - -MetadataParserManager::MetadataParserManager() { - MetadataParserJpegFactory *factory = new MetadataParserJpegFactory(); - RegisterParserFactory(factory); -} - -MetadataParserManager::~MetadataParserManager() {} - -MetadataParser* MetadataParserManager::GetParserForFile( - const base::FilePath& path) { - char buffer[kAmountToRead]; - int amount_read = 0; - DLOG(ERROR) << path.value(); - amount_read = base::ReadFile(path, buffer, sizeof(buffer)); - if (amount_read <= 0) { - DLOG(ERROR) << "Unable to read file"; - return NULL; - } - for (size_t x = 0; x < factories_.size(); ++x) { - if (factories_[x]->CanParse(path, buffer, amount_read)) { - return factories_[x]->CreateParser(path); - } - } - return NULL; -} diff --git a/chrome/browser/parsers/metadata_parser_manager.h b/chrome/browser/parsers/metadata_parser_manager.h deleted file mode 100644 index 2d5a759..0000000 --- a/chrome/browser/parsers/metadata_parser_manager.h +++ /dev/null @@ -1,42 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CHROME_BROWSER_PARSERS_METADATA_PARSER_MANAGER_H_ -#define CHROME_BROWSER_PARSERS_METADATA_PARSER_MANAGER_H_ - -#include "base/basictypes.h" -#include "base/memory/scoped_vector.h" - -class MetadataParserFactory; -class MetadataParser; - -namespace base { -class FilePath; -} - -// Metadata Parser manager is used to find the correct parser for a -// given file. Allows parsers to register themselves. -class MetadataParserManager { - public: - // Creates a new MetadataParserManager. - MetadataParserManager(); - ~MetadataParserManager(); - - // Gets the singleton - static MetadataParserManager* GetInstance(); - - // Adds a new Parser to the manager, when requests come in for a parser - // the manager will loop through the list of parsers, and query each. - bool RegisterParserFactory(MetadataParserFactory* parser); - - // Returns a new metadata parser for a given file. - MetadataParser* GetParserForFile(const base::FilePath& path); - - private: - ScopedVector<MetadataParserFactory> factories_; - - DISALLOW_COPY_AND_ASSIGN(MetadataParserManager); -}; - -#endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_MANAGER_H_ diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index c5453b8..81fd74f 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -912,11 +912,6 @@ 'browser/omnibox/omnibox_field_trial.h', 'browser/omnibox/omnibox_log.cc', 'browser/omnibox/omnibox_log.h', - 'browser/parsers/metadata_parser.cc', - 'browser/parsers/metadata_parser.h', - 'browser/parsers/metadata_parser_factory.h', - 'browser/parsers/metadata_parser_filebase.cc', - 'browser/parsers/metadata_parser_filebase.h', 'browser/password_manager/chrome_password_manager_client.cc', 'browser/password_manager/chrome_password_manager_client.h', 'browser/password_manager/password_manager_util.h', @@ -2234,12 +2229,6 @@ 'browser/net/firefox_proxy_settings.h', 'browser/net/predictor_tab_helper.cc', 'browser/net/predictor_tab_helper.h', - 'browser/parsers/metadata_parser_jpeg.cc', - 'browser/parsers/metadata_parser_jpeg_factory.cc', - 'browser/parsers/metadata_parser_jpeg_factory.h', - 'browser/parsers/metadata_parser_jpeg.h', - 'browser/parsers/metadata_parser_manager.cc', - 'browser/parsers/metadata_parser_manager.h', 'browser/process_singleton_modal_dialog_lock.cc', 'browser/process_singleton_modal_dialog_lock.h', 'browser/process_singleton_posix.cc', diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index 2b1d8eb..f18a0d0 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -1146,7 +1146,6 @@ 'browser/notifications/message_center_settings_controller_unittest.cc', 'browser/omaha_query_params/chrome_omaha_query_params_delegate_unittest.cc', 'browser/omnibox/omnibox_field_trial_unittest.cc', - 'browser/parsers/metadata_parser_filebase_unittest.cc', 'browser/password_manager/chrome_password_manager_client_unittest.cc', 'browser/password_manager/native_backend_gnome_x_unittest.cc', 'browser/password_manager/native_backend_kwallet_x_unittest.cc', |