summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrockot <rockot@chromium.org>2016-03-25 14:48:18 -0700
committerCommit bot <commit-bot@chromium.org>2016-03-25 21:49:38 +0000
commit317d7f244dbda5394b1f05a38bdb0938ec9fb7e1 (patch)
tree8b7c01d62dcf2ea4446b77912e6fb9a5e99e03e3
parente3cc7bce01caf52aad5eb6d83787eae8499231b6 (diff)
downloadchromium_src-317d7f244dbda5394b1f05a38bdb0938ec9fb7e1.zip
chromium_src-317d7f244dbda5394b1f05a38bdb0938ec9fb7e1.tar.gz
chromium_src-317d7f244dbda5394b1f05a38bdb0938ec9fb7e1.tar.bz2
Turn on standard logging details in Mojo app runners
It's not clear why Mojo runner disabled these, and I think the mash runner just copied whatever the Mojo runner was doing. BUG=None Review URL: https://codereview.chromium.org/1835653002 Cr-Commit-Position: refs/heads/master@{#383373}
-rw-r--r--chrome/app/mash/mash_runner.cc8
-rw-r--r--mojo/shell/runner/init.cc8
2 files changed, 8 insertions, 8 deletions
diff --git a/chrome/app/mash/mash_runner.cc b/chrome/app/mash/mash_runner.cc
index d4102c8..b54a1ff 100644
--- a/chrome/app/mash/mash_runner.cc
+++ b/chrome/app/mash/mash_runner.cc
@@ -219,10 +219,10 @@ int MashMain() {
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
logging::InitLogging(settings);
// To view log output with IDs and timestamps use "adb logcat -v threadtime".
- logging::SetLogItems(false, // Process ID
- false, // Thread ID
- false, // Timestamp
- false); // Tick count
+ logging::SetLogItems(true, // Process ID
+ true, // Thread ID
+ true, // Timestamp
+ true); // Tick count
// TODO(sky): use MessagePumpMojo.
scoped_ptr<base::MessageLoop> message_loop;
diff --git a/mojo/shell/runner/init.cc b/mojo/shell/runner/init.cc
index 6f61cc8..57eb312 100644
--- a/mojo/shell/runner/init.cc
+++ b/mojo/shell/runner/init.cc
@@ -32,10 +32,10 @@ void InitializeLogging() {
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
logging::InitLogging(settings);
// To view log output with IDs and timestamps use "adb logcat -v threadtime".
- logging::SetLogItems(false, // Process ID
- false, // Thread ID
- false, // Timestamp
- false); // Tick count
+ logging::SetLogItems(true, // Process ID
+ true, // Thread ID
+ true, // Timestamp
+ true); // Tick count
}
void WaitForDebuggerIfNecessary() {