diff options
| author | sullivan <sullivan@chromium.org> | 2014-09-19 10:16:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-19 17:16:37 +0000 |
| commit | 318e47b7ea27e08622ef20b69f2066117d70895b (patch) | |
| tree | d3ec66125b34de92903ae02bd4e74f8b6489d5f1 | |
| parent | 958e55816c7f9960588b3da7021cd37ec910846b (diff) | |
| download | chromium_src-318e47b7ea27e08622ef20b69f2066117d70895b.zip chromium_src-318e47b7ea27e08622ef20b69f2066117d70895b.tar.gz chromium_src-318e47b7ea27e08622ef20b69f2066117d70895b.tar.bz2 | |
Better error messaging for perf tryjobs on windows XP.
Remove XP from list of perf trybots in telemetry
Add error message for perf tryjobs on win XP
BUG=414830
Review URL: https://codereview.chromium.org/570413003
Cr-Commit-Position: refs/heads/master@{#295722}
| -rwxr-xr-x | tools/run-bisect-perf-regression.py | 4 | ||||
| -rw-r--r-- | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py index 364d39f..f5f1b7f 100755 --- a/tools/run-bisect-perf-regression.py +++ b/tools/run-bisect-perf-regression.py @@ -351,6 +351,10 @@ def _SetupAndRunPerformanceTest(config, path_to_file, path_to_goma): Returns: The exit code of bisect-perf-regression.py: 0 on success, otherwise 1. """ + if platform.release() == 'XP': + print 'Windows XP is not supported for perf try jobs because it lacks ' + print 'goma support. Please refer to crbug.com/330900.' + return 1 try: with Goma(path_to_goma) as _: config['use_goma'] = bool(path_to_goma) diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py index 62b80a3..e593ec8 100644 --- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py +++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py @@ -234,6 +234,9 @@ def _GetTrybotList(): builders = json.loads(f.read()).get('builders', {}).keys() builders = ['trybot-%s' % b.replace('_perf_bisect', '').replace('_', '-') for b in builders if not b.endswith('_perf_bisect_builder')] + # Perf try jobs do not work on Windows XP + if 'trybot-win-xp' in builders: + builders.remove('trybot-win-xp') return builders |