summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-01 17:12:50 +0000
committermnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-01 17:12:50 +0000
commit32b9c269a98692acf748f7594425d586e838cf96 (patch)
tree952b84d47b9d883457b7c337325335794c0badfc
parent1658b21378c3439fbf7f05caaaf2c8598a23e779 (diff)
downloadchromium_src-32b9c269a98692acf748f7594425d586e838cf96.zip
chromium_src-32b9c269a98692acf748f7594425d586e838cf96.tar.gz
chromium_src-32b9c269a98692acf748f7594425d586e838cf96.tar.bz2
Tighten the check for detecting misbehaving proxies in device management requests.
BUG=chromium-os:20775 TEST=Using a misconfigured-proxy but with direct connections working, registering without a serial shows the serial number invalid error instead of network error. Review URL: http://codereview.chromium.org/9317033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120073 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/policy/device_management_service.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/policy/device_management_service.cc b/chrome/browser/policy/device_management_service.cc
index 1b93c6c..cfb4b56 100644
--- a/chrome/browser/policy/device_management_service.cc
+++ b/chrome/browser/policy/device_management_service.cc
@@ -540,6 +540,7 @@ void DeviceManagementService::OnURLFetchComplete(
LOG(WARNING) << "Proxy failed while contacting dmserver.";
retry = true;
} else if (source->GetStatus().is_success() &&
+ source->GetResponseCode() == kSuccess &&
source->WasFetchedViaProxy() &&
!IsProtobufMimeType(source)) {
// The proxy server can be misconfigured but pointing to an existing