diff options
| author | Brett Wilson <brettw@chromium.org> | 2014-09-11 11:13:38 -0700 |
|---|---|---|
| committer | Brett Wilson <brettw@chromium.org> | 2014-09-11 18:31:41 +0000 |
| commit | 339a17f9efb734ed53112eca9bba0646d3cd1223 (patch) | |
| tree | 30127f8427ba52cf11d6e3dfe4d25e163baac8fd | |
| parent | c3d2efb33238a3ee19cc8e21f4d91ef8c55f23c4 (diff) | |
| download | chromium_src-339a17f9efb734ed53112eca9bba0646d3cd1223.zip chromium_src-339a17f9efb734ed53112eca9bba0646d3cd1223.tar.gz chromium_src-339a17f9efb734ed53112eca9bba0646d3cd1223.tar.bz2 | |
Remove some rtc hacks in the GN build.
Remove explicitly depending on a webrtc config now that it is correctly
exported from webrtc.
R=kjellander@chromium.org
Review URL: https://codereview.chromium.org/534813002
Cr-Commit-Position: refs/heads/master@{#294424}
| -rw-r--r-- | chrome/browser/extensions/BUILD.gn | 5 | ||||
| -rw-r--r-- | remoting/base/BUILD.gn | 5 | ||||
| -rw-r--r-- | third_party/libjingle/BUILD.gn | 4 |
3 files changed, 0 insertions, 14 deletions
diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn index eab3a6e..e77bf4c 100644 --- a/chrome/browser/extensions/BUILD.gn +++ b/chrome/browser/extensions/BUILD.gn @@ -80,11 +80,6 @@ static_library("extensions") { "//content/public/browser", ] - # TODO(GYP) This config should be a direct_dependent_config of - # //third_party/webrtc/modules/desktop_capture so we shouldn't have to - # include it here. Remove this line when the direct_dependent_config is set. - configs += [ "//third_party/webrtc:common_inherited_config" ] - if (is_chromeos) { sources += rebase_path( gypi_values.chrome_browser_extensions_chromeos_sources, diff --git a/remoting/base/BUILD.gn b/remoting/base/BUILD.gn index 3929a9f..6d05466 100644 --- a/remoting/base/BUILD.gn +++ b/remoting/base/BUILD.gn @@ -91,10 +91,5 @@ static_library("base") { "//remoting/proto", "//third_party/protobuf:protobuf_lite", ] - - # TODO(GYP) This config should be a direct_dependent_config of - # //third_party/webrtc/modules/desktop_capture so we shouldn't have to - # include it here. Remove this line when the direct_dependent_config is set. - configs += [ "//third_party/webrtc:common_inherited_config" ] } diff --git a/third_party/libjingle/BUILD.gn b/third_party/libjingle/BUILD.gn index e8f8aa5..ba32bdb 100644 --- a/third_party/libjingle/BUILD.gn +++ b/third_party/libjingle/BUILD.gn @@ -516,10 +516,6 @@ if (enable_webrtc) { "//third_party/webrtc/modules/video_render", ] - # TODO(GYP) this should be removed and we should get this config by one of - # the webrtc targets specifying it for the direct_dependent_configs. - #configs += [ "//third_party/webrtc:common_config" ] # TODO(GYP) - if (!is_ios) { # TODO(mallinath) - Enable SCTP for iOS. sources += [ |