summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsgurun@chromium.org <sgurun@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-02 00:24:31 +0000
committersgurun@chromium.org <sgurun@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-02 00:24:31 +0000
commit3423f1edc1e263cb084f40bf64b74ae8b3979dbd (patch)
tree9b54fc5632673996c54e84266017d53794d50be2
parentdbc26c9807c71d02c6a9a5471c65d571d6e4985f (diff)
downloadchromium_src-3423f1edc1e263cb084f40bf64b74ae8b3979dbd.zip
chromium_src-3423f1edc1e263cb084f40bf64b74ae8b3979dbd.tar.gz
chromium_src-3423f1edc1e263cb084f40bf64b74ae8b3979dbd.tar.bz2
Early out if contentviewcore native side is null.
BUG=b/10911057 Early out before calling native getNavigatonHistory as it may be deleted before. Review URL: https://codereview.chromium.org/25505005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226361 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java16
1 files changed, 12 insertions, 4 deletions
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index a301563..4af9cc5 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -3014,15 +3014,20 @@ import java.util.Map;
*/
public NavigationHistory getNavigationHistory() {
NavigationHistory history = new NavigationHistory();
- int currentIndex = nativeGetNavigationHistory(mNativeContentViewCore, history);
- history.setCurrentEntryIndex(currentIndex);
+ if (mNativeContentViewCore != 0) {
+ int currentIndex = nativeGetNavigationHistory(mNativeContentViewCore, history);
+ history.setCurrentEntryIndex(currentIndex);
+ }
return history;
}
@Override
public NavigationHistory getDirectedNavigationHistory(boolean isForward, int itemLimit) {
NavigationHistory history = new NavigationHistory();
- nativeGetDirectedNavigationHistory(mNativeContentViewCore, history, isForward, itemLimit);
+ if (mNativeContentViewCore != 0) {
+ nativeGetDirectedNavigationHistory(
+ mNativeContentViewCore, history, isForward, itemLimit);
+ }
return history;
}
@@ -3031,7 +3036,10 @@ import java.util.Map;
* current entry.
*/
public String getOriginalUrlForActiveNavigationEntry() {
- return nativeGetOriginalUrlForActiveNavigationEntry(mNativeContentViewCore);
+ if (mNativeContentViewCore != 0) {
+ return nativeGetOriginalUrlForActiveNavigationEntry(mNativeContentViewCore);
+ }
+ return "";
}
/**