diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-14 19:55:05 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-14 19:55:05 +0000 |
| commit | 3c4c86c48955f7c4424e2c21f030bdb17b264fad (patch) | |
| tree | 1573f3abeca7aa676b9957cd54b6f804a3577b46 | |
| parent | 34952d11913bf856e0ec2a35ecd66372ec908f3b (diff) | |
| download | chromium_src-3c4c86c48955f7c4424e2c21f030bdb17b264fad.zip chromium_src-3c4c86c48955f7c4424e2c21f030bdb17b264fad.tar.gz chromium_src-3c4c86c48955f7c4424e2c21f030bdb17b264fad.tar.bz2 | |
Coverity: Fix a resource leak.
CID=12792
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6673012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78077 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/renderer/pepper_plugin_delegate_impl.cc | 12 | ||||
| -rw-r--r-- | chrome/renderer/pepper_plugin_delegate_impl.h | 2 |
2 files changed, 3 insertions, 11 deletions
diff --git a/chrome/renderer/pepper_plugin_delegate_impl.cc b/chrome/renderer/pepper_plugin_delegate_impl.cc index 9ba59c8..858d274 100644 --- a/chrome/renderer/pepper_plugin_delegate_impl.cc +++ b/chrome/renderer/pepper_plugin_delegate_impl.cc @@ -5,6 +5,7 @@ #include "chrome/renderer/pepper_plugin_delegate_impl.h" #include <cmath> +#include <queue> #include "app/surface/transport_dib.h" #include "base/callback.h" @@ -54,14 +55,6 @@ #include "webkit/plugins/ppapi/ppb_flash_impl.h" #include "webkit/plugins/ppapi/ppb_flash_net_connector_impl.h" -#if defined(OS_MACOSX) -#include "chrome/renderer/render_thread.h" -#endif - -#if defined(OS_POSIX) -#include "ipc/ipc_channel_posix.h" -#endif - using WebKit::WebView; namespace { @@ -265,6 +258,8 @@ class PlatformVideoDecoderImpl return false; // TODO(wjia): Create video decoder in GPU process. + // Meanwhile, delete |dib| to free the resource. + delete dib; return true; } @@ -580,7 +575,6 @@ PepperPluginDelegateImpl::CreateAudio( scoped_refptr<PlatformAudioImpl> audio( new PlatformAudioImpl(render_view_->audio_message_filter())); if (audio->Initialize(sample_rate, sample_count, client)) { - // Also note ReleaseSoon invoked in PlatformAudioImpl::ShutDown(). return audio.release(); } else { diff --git a/chrome/renderer/pepper_plugin_delegate_impl.h b/chrome/renderer/pepper_plugin_delegate_impl.h index 627d449..0502b2f 100644 --- a/chrome/renderer/pepper_plugin_delegate_impl.h +++ b/chrome/renderer/pepper_plugin_delegate_impl.h @@ -13,9 +13,7 @@ #include "base/id_map.h" #include "base/ref_counted.h" #include "base/weak_ptr.h" -#include "ppapi/c/pp_errors.h" #include "webkit/plugins/ppapi/plugin_delegate.h" -#include "webkit/plugins/ppapi/ppapi_plugin_instance.h" #include "webkit/plugins/ppapi/ppb_flash_menu_impl.h" class FilePath; |