diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-28 21:16:16 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-28 21:16:16 +0000 |
| commit | 3ce133126fc7c4829d69d776301ab328a4a29f3a (patch) | |
| tree | 6a6e26acd87019b68b81527476b2de731f1f7792 | |
| parent | 8c076cb4d805a90a4cce6ac55b55c707bbabfabf (diff) | |
| download | chromium_src-3ce133126fc7c4829d69d776301ab328a4a29f3a.zip chromium_src-3ce133126fc7c4829d69d776301ab328a4a29f3a.tar.gz chromium_src-3ce133126fc7c4829d69d776301ab328a4a29f3a.tar.bz2 | |
mac: Don't write SCMPath into Info.plist
The key isn't used by anything, the information is redudant with
the version number, the other ports can get by without it, and
this makes it easier to move mac to the LASTCHANGE file.
BUG=161488
Review URL: https://codereview.chromium.org/11434007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170055 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | build/mac/tweak_info_plist.py | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/build/mac/tweak_info_plist.py b/build/mac/tweak_info_plist.py index 05196a8..5c0cf13 100755 --- a/build/mac/tweak_info_plist.py +++ b/build/mac/tweak_info_plist.py @@ -114,11 +114,11 @@ def _AddVersionKeys(plist, version=None): def _DoSCMKeys(plist, add_keys): """Adds the SCM information, visible in about:version, to property list. If |add_keys| is True, it will insert the keys, otherwise it will remove them.""" - scm_path, scm_revision = None, None + scm_revision = None if add_keys: version_info = lastchange.FetchVersionInfo( default_lastchange=None, directory=TOP) - scm_path, scm_revision = version_info.url, version_info.revision + scm_revision = version_info.revision # See if the operation failed. _RemoveKeys(plist, 'SCMRevision') @@ -127,10 +127,8 @@ def _DoSCMKeys(plist, add_keys): elif add_keys: print >>sys.stderr, 'Could not determine SCM revision. This may be OK.' - if scm_path != None: - plist['SCMPath'] = scm_path - else: - _RemoveKeys(plist, 'SCMPath') + # TODO(thakis): Remove this once m25 has reached stable. + _RemoveKeys(plist, 'SCMPath') def _DoPDFKeys(plist, add_keys): |