diff options
author | pmonette <pmonette@chromium.org> | 2016-01-11 18:10:16 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-12 02:11:10 +0000 |
commit | 3d24f096b250b2364f75e6247e8a6d8ac7ec811b (patch) | |
tree | 4047302d6618c8d24bba4120719f50f653b68188 | |
parent | 10215fdb245b735fd0194f0c24e45d2734a5918a (diff) | |
download | chromium_src-3d24f096b250b2364f75e6247e8a6d8ac7ec811b.zip chromium_src-3d24f096b250b2364f75e6247e8a6d8ac7ec811b.tar.gz chromium_src-3d24f096b250b2364f75e6247e8a6d8ac7ec811b.tar.bz2 |
New experiment without registry deletion
Now requires the user to check "Always user this app".
BUG=576490
Review URL: https://codereview.chromium.org/1575163002
Cr-Commit-Position: refs/heads/master@{#368774}
-rw-r--r-- | chrome/browser/shell_integration_win.cc | 27 |
1 files changed, 24 insertions, 3 deletions
diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc index 04bc80c..f53f0f1 100644 --- a/chrome/browser/shell_integration_win.cc +++ b/chrome/browser/shell_integration_win.cc @@ -56,6 +56,15 @@ namespace { const wchar_t kAppListAppNameSuffix[] = L"AppList"; const char kAsyncSetAsDefaultExperimentName[] = "AsyncSetAsDefault"; +// A prefix shared by multiple groups that kicks off the generic +// AsyncSetAsDefault experiment. +const char kAsyncSetAsDefaultExperimentEnabledGroupPrefix[] = "Enabled"; +// One of the group names for the AsyncSetAsDefault experiment. Unlike other +// "Enabled" groups, this group doesn't reset the current default browser choice +// in the registry. +const char kAsyncSetAsDefaultExperimentEnabledNoRegistryGroupName[] = + "EnabledNoRegistry"; + const char kEnableAsyncSetAsDefault[] = "enable-async-set-as-default"; const char kDisableAsyncSetAsDefault[] = "disable-async-set-as-default"; @@ -279,13 +288,24 @@ bool IsAsyncSetAsDefaultEnabled() { // Note: It's important to query the field trial state first, to ensure that // UMA reports the correct group. const std::string group_name = - base::FieldTrialList::FindFullName("AsyncSetAsDefault"); + base::FieldTrialList::FindFullName(kAsyncSetAsDefaultExperimentName); if (CommandLine::ForCurrentProcess()->HasSwitch(kDisableAsyncSetAsDefault)) return false; if (CommandLine::ForCurrentProcess()->HasSwitch(kEnableAsyncSetAsDefault)) return true; - return base::StartsWith(group_name, "Enabled", base::CompareCase::SENSITIVE); + return base::StartsWith(group_name, + kAsyncSetAsDefaultExperimentEnabledGroupPrefix, + base::CompareCase::SENSITIVE); +} + +// Returns true if the default browser choice should be reset for the current +// user. +bool ShouldResetDefaultBrowser() { + return !base::StartsWith( + base::FieldTrialList::FindFullName(kAsyncSetAsDefaultExperimentName), + kAsyncSetAsDefaultExperimentEnabledNoRegistryGroupName, + base::CompareCase::SENSITIVE); } bool RegisterBrowser() { @@ -720,7 +740,8 @@ bool ShellIntegration::DefaultBrowserWorker::SetAsDefaultBrowserAsynchronous() { if (!RegisterBrowser()) return false; - ResetDefaultBrowser(); + if (ShouldResetDefaultBrowser()) + ResetDefaultBrowser(); base::CommandLine cmdline(base::FilePath(L"openwith.exe")); cmdline.AppendArgNative(StartupBrowserCreator::GetDefaultBrowserUrl()); |