extensions: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1724293002

Cr-Commit-Position: refs/heads/master@{#378054}

56 files changed, 108 insertions, 0 deletions

diff --git a/extensions/browser/api/alarms/alarm_manager.cc b/extensions/browser/api/alarms/alarm_manager.cc
index 4f9aeda..0616481 100644
--- a/extensions/browser/api/alarms/alarm_manager.cc
+++ b/extensions/browser/api/alarms/alarm_manager.cc
@@ -465,6 +465,8 @@ Alarm::Alarm(const std::string& name,
   }
 }
 
+Alarm::Alarm(const Alarm& other) = default;
+
 Alarm::~Alarm() {
 }
 
diff --git a/extensions/browser/api/alarms/alarm_manager.h b/extensions/browser/api/alarms/alarm_manager.h
index a93c59f..66e5fb1 100644
--- a/extensions/browser/api/alarms/alarm_manager.h
+++ b/extensions/browser/api/alarms/alarm_manager.h
@@ -38,6 +38,7 @@ struct Alarm {
         const api::alarms::AlarmCreateInfo& create_info,
         base::TimeDelta min_granularity,
         base::Time now);
+  Alarm(const Alarm& other);
   ~Alarm();
 
   linked_ptr<api::alarms::Alarm> js_alarm;
diff --git a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc
index 4d54ee0..d6185db 100644
--- a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc
+++ b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc
@@ -97,6 +97,9 @@ BluetoothSocketEventDispatcher::~BluetoothSocketEventDispatcher() {}
 
 BluetoothSocketEventDispatcher::SocketParams::SocketParams() {}
 
+BluetoothSocketEventDispatcher::SocketParams::SocketParams(
+    const SocketParams& other) = default;
+
 BluetoothSocketEventDispatcher::SocketParams::~SocketParams() {}
 
 void BluetoothSocketEventDispatcher::OnSocketConnect(
diff --git a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h
index e64336b..5e45fc0 100644
--- a/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h
+++ b/extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h
@@ -64,6 +64,7 @@ class BluetoothSocketEventDispatcher
   // StartAccept().
   struct SocketParams {
     SocketParams();
+    SocketParams(const SocketParams& other);
     ~SocketParams();
 
     content::BrowserThread::ID thread_id;
diff --git a/extensions/browser/api/cast_channel/cast_transport.cc b/extensions/browser/api/cast_channel/cast_transport.cc
index 9572f3b..8a22af6 100644
--- a/extensions/browser/api/cast_channel/cast_transport.cc
+++ b/extensions/browser/api/cast_channel/cast_transport.cc
@@ -197,6 +197,9 @@ CastTransportImpl::WriteRequest::WriteRequest(
                                          payload.size());
 }
 
+CastTransportImpl::WriteRequest::WriteRequest(const WriteRequest& other) =
+    default;
+
 CastTransportImpl::WriteRequest::~WriteRequest() {
 }
 
diff --git a/extensions/browser/api/cast_channel/cast_transport.h b/extensions/browser/api/cast_channel/cast_transport.h
index e08216e..740bd5f 100644
--- a/extensions/browser/api/cast_channel/cast_transport.h
+++ b/extensions/browser/api/cast_channel/cast_transport.h
@@ -125,6 +125,7 @@ class CastTransportImpl : public CastTransport, public base::NonThreadSafe {
     explicit WriteRequest(const std::string& namespace_,
                           const std::string& payload,
                           const net::CompletionCallback& callback);
+    WriteRequest(const WriteRequest& other);
     ~WriteRequest();
 
     // Namespace of the serialized message.
diff --git a/extensions/browser/api/document_scan/document_scan_interface.cc b/extensions/browser/api/document_scan/document_scan_interface.cc
index c42cf39..976e1a9 100644
--- a/extensions/browser/api/document_scan/document_scan_interface.cc
+++ b/extensions/browser/api/document_scan/document_scan_interface.cc
@@ -17,6 +17,9 @@ DocumentScanInterface::~DocumentScanInterface() {
 DocumentScanInterface::ScannerDescription::ScannerDescription() {
 }
 
+DocumentScanInterface::ScannerDescription::ScannerDescription(
+    const ScannerDescription& other) = default;
+
 DocumentScanInterface::ScannerDescription::~ScannerDescription() {
 }
 
diff --git a/extensions/browser/api/document_scan/document_scan_interface.h b/extensions/browser/api/document_scan/document_scan_interface.h
index 3339a16..dbcee19 100644
--- a/extensions/browser/api/document_scan/document_scan_interface.h
+++ b/extensions/browser/api/document_scan/document_scan_interface.h
@@ -19,6 +19,7 @@ class DocumentScanInterface {
  public:
   struct ScannerDescription {
     ScannerDescription();
+    ScannerDescription(const ScannerDescription& other);
     ~ScannerDescription();
     std::string name;
     std::string manufacturer;
diff --git a/extensions/browser/api/printer_provider/printer_provider_print_job.cc b/extensions/browser/api/printer_provider/printer_provider_print_job.cc
index 3339daf..a2838be 100644
--- a/extensions/browser/api/printer_provider/printer_provider_print_job.cc
+++ b/extensions/browser/api/printer_provider/printer_provider_print_job.cc
@@ -9,6 +9,9 @@ namespace extensions {
 PrinterProviderPrintJob::PrinterProviderPrintJob() {
 }
 
+PrinterProviderPrintJob::PrinterProviderPrintJob(
+    const PrinterProviderPrintJob& other) = default;
+
 PrinterProviderPrintJob::~PrinterProviderPrintJob() {
 }
 
diff --git a/extensions/browser/api/printer_provider/printer_provider_print_job.h b/extensions/browser/api/printer_provider/printer_provider_print_job.h
index 4148d0d..a9f4b4b 100644
--- a/extensions/browser/api/printer_provider/printer_provider_print_job.h
+++ b/extensions/browser/api/printer_provider/printer_provider_print_job.h
@@ -22,6 +22,7 @@ namespace extensions {
 // or bytes.
 struct PrinterProviderPrintJob {
   PrinterProviderPrintJob();
+  PrinterProviderPrintJob(const PrinterProviderPrintJob& other);
   ~PrinterProviderPrintJob();
 
   // The id of the printer that should handle the print job. The id is
diff --git a/extensions/browser/api/serial/serial_event_dispatcher.cc b/extensions/browser/api/serial/serial_event_dispatcher.cc
index 81f9457..31e44b0 100644
--- a/extensions/browser/api/serial/serial_event_dispatcher.cc
+++ b/extensions/browser/api/serial/serial_event_dispatcher.cc
@@ -59,6 +59,9 @@ SerialEventDispatcher::~SerialEventDispatcher() {
 SerialEventDispatcher::ReceiveParams::ReceiveParams() {
 }
 
+SerialEventDispatcher::ReceiveParams::ReceiveParams(
+    const ReceiveParams& other) = default;
+
 SerialEventDispatcher::ReceiveParams::~ReceiveParams() {
 }
 
diff --git a/extensions/browser/api/serial/serial_event_dispatcher.h b/extensions/browser/api/serial/serial_event_dispatcher.h
index 502f57a..10188af 100644
--- a/extensions/browser/api/serial/serial_event_dispatcher.h
+++ b/extensions/browser/api/serial/serial_event_dispatcher.h
@@ -48,6 +48,7 @@ class SerialEventDispatcher : public BrowserContextKeyedAPI {
 
   struct ReceiveParams {
     ReceiveParams();
+    ReceiveParams(const ReceiveParams& other);
     ~ReceiveParams();
 
     content::BrowserThread::ID thread_id;
diff --git a/extensions/browser/api/socket/socket.cc b/extensions/browser/api/socket/socket.cc
index 52ba321..a47f255 100644
--- a/extensions/browser/api/socket/socket.cc
+++ b/extensions/browser/api/socket/socket.cc
@@ -135,6 +135,8 @@ Socket::WriteRequest::WriteRequest(scoped_refptr<net::IOBuffer> io_buffer,
       callback(callback),
       bytes_written(0) {}
 
+Socket::WriteRequest::WriteRequest(const WriteRequest& other) = default;
+
 Socket::WriteRequest::~WriteRequest() {}
 
 }  // namespace extensions
diff --git a/extensions/browser/api/socket/socket.h b/extensions/browser/api/socket/socket.h
index 49a4dc3..fefe6bc 100644
--- a/extensions/browser/api/socket/socket.h
+++ b/extensions/browser/api/socket/socket.h
@@ -137,6 +137,7 @@ class Socket : public ApiResource {
     WriteRequest(scoped_refptr<net::IOBuffer> io_buffer,
                  int byte_count,
                  const CompletionCallback& callback);
+    WriteRequest(const WriteRequest& other);
     ~WriteRequest();
     scoped_refptr<net::IOBuffer> io_buffer;
     int byte_count;
diff --git a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc
index bdc2fbd..7d2f2ca 100644
--- a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc
+++ b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc
@@ -57,6 +57,9 @@ TCPSocketEventDispatcher::~TCPSocketEventDispatcher() {}
 
 TCPSocketEventDispatcher::ReadParams::ReadParams() {}
 
+TCPSocketEventDispatcher::ReadParams::ReadParams(const ReadParams& other) =
+    default;
+
 TCPSocketEventDispatcher::ReadParams::~ReadParams() {}
 
 void TCPSocketEventDispatcher::OnSocketConnect(const std::string& extension_id,
diff --git a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h
index 886cb28..0c90980 100644
--- a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h
+++ b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h
@@ -56,6 +56,7 @@ class TCPSocketEventDispatcher
   // as a workaround that limitation for invoking StartReceive.
   struct ReadParams {
     ReadParams();
+    ReadParams(const ReadParams& other);
     ~ReadParams();
 
     content::BrowserThread::ID thread_id;
diff --git a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
index 468237ef..a43d6be 100644
--- a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
+++ b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc
@@ -62,6 +62,9 @@ TCPServerSocketEventDispatcher::~TCPServerSocketEventDispatcher() {}
 
 TCPServerSocketEventDispatcher::AcceptParams::AcceptParams() {}
 
+TCPServerSocketEventDispatcher::AcceptParams::AcceptParams(
+    const AcceptParams& other) = default;
+
 TCPServerSocketEventDispatcher::AcceptParams::~AcceptParams() {}
 
 void TCPServerSocketEventDispatcher::OnServerSocketListen(
diff --git a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
index ca5f6bc..e792b82 100644
--- a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
+++ b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h
@@ -58,6 +58,7 @@ class TCPServerSocketEventDispatcher
   // as a workaround that limitation for invoking StartAccept.
   struct AcceptParams {
     AcceptParams();
+    AcceptParams(const AcceptParams& other);
     ~AcceptParams();
 
     content::BrowserThread::ID thread_id;
diff --git a/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc b/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc
index 7b8f9a1..07e2a22 100644
--- a/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc
+++ b/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc
@@ -52,6 +52,9 @@ UDPSocketEventDispatcher::~UDPSocketEventDispatcher() {}
 
 UDPSocketEventDispatcher::ReceiveParams::ReceiveParams() {}
 
+UDPSocketEventDispatcher::ReceiveParams::ReceiveParams(
+    const ReceiveParams& other) = default;
+
 UDPSocketEventDispatcher::ReceiveParams::~ReceiveParams() {}
 
 void UDPSocketEventDispatcher::OnSocketBind(const std::string& extension_id,
diff --git a/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h b/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h
index b4c4624..ff8f111 100644
--- a/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h
+++ b/extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h
@@ -58,6 +58,7 @@ class UDPSocketEventDispatcher
   // as a workaround that limitation for invoking StartReceive.
   struct ReceiveParams {
     ReceiveParams();
+    ReceiveParams(const ReceiveParams& other);
     ~ReceiveParams();
 
     content::BrowserThread::ID thread_id;
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index a43d14a..aa799bb 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -561,6 +561,9 @@ ExtensionWebRequestEventRouter::RequestFilter::RequestFilter()
     : tab_id(-1), window_id(-1) {
 }
 
+ExtensionWebRequestEventRouter::RequestFilter::RequestFilter(
+    const RequestFilter& other) = default;
+
 ExtensionWebRequestEventRouter::RequestFilter::~RequestFilter() {
 }
 
diff --git a/extensions/browser/api/web_request/web_request_api.h b/extensions/browser/api/web_request/web_request_api.h
index 805d11b..382860d 100644
--- a/extensions/browser/api/web_request/web_request_api.h
+++ b/extensions/browser/api/web_request/web_request_api.h
@@ -115,6 +115,7 @@ class ExtensionWebRequestEventRouter
   // filter what network events an extension cares about.
   struct RequestFilter {
     RequestFilter();
+    RequestFilter(const RequestFilter& other);
     ~RequestFilter();
 
     // Returns false if there was an error initializing. If it is a user error,
diff --git a/extensions/browser/api/web_request/web_request_time_tracker.cc b/extensions/browser/api/web_request/web_request_time_tracker.cc
index 806f18d..58bfbad 100644
--- a/extensions/browser/api/web_request/web_request_time_tracker.cc
+++ b/extensions/browser/api/web_request/web_request_time_tracker.cc
@@ -89,6 +89,9 @@ ExtensionWebRequestTimeTracker::RequestTimeLog::RequestTimeLog()
     : profile(NULL), completed(false) {
 }
 
+ExtensionWebRequestTimeTracker::RequestTimeLog::RequestTimeLog(
+    const RequestTimeLog& other) = default;
+
 ExtensionWebRequestTimeTracker::RequestTimeLog::~RequestTimeLog() {
 }
 
diff --git a/extensions/browser/api/web_request/web_request_time_tracker.h b/extensions/browser/api/web_request/web_request_time_tracker.h
index b65e537..af30731 100644
--- a/extensions/browser/api/web_request/web_request_time_tracker.h
+++ b/extensions/browser/api/web_request/web_request_time_tracker.h
@@ -91,6 +91,7 @@ class ExtensionWebRequestTimeTracker {
     base::TimeDelta block_duration;
     std::map<std::string, base::TimeDelta> extension_block_durations;
     RequestTimeLog();
+    RequestTimeLog(const RequestTimeLog& other);
     ~RequestTimeLog();
   };
 
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 5bb73e6..0c0a45b 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -174,6 +174,8 @@ AppWindow::CreateParams::CreateParams()
       visible_on_all_workspaces(false) {
 }
 
+AppWindow::CreateParams::CreateParams(const CreateParams& other) = default;
+
 AppWindow::CreateParams::~CreateParams() {}
 
 gfx::Rect AppWindow::CreateParams::GetInitialWindowBounds(
diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h
index 59d8463..6917c4d 100644
--- a/extensions/browser/app_window/app_window.h
+++ b/extensions/browser/app_window/app_window.h
@@ -145,6 +145,7 @@ class AppWindow : public content::WebContentsDelegate,
 
   struct CreateParams {
     CreateParams();
+    CreateParams(const CreateParams& other);
     ~CreateParams();
 
     WindowType window_type;
diff --git a/extensions/browser/error_map.cc b/extensions/browser/error_map.cc
index dcf0101..5f94e34 100644
--- a/extensions/browser/error_map.cc
+++ b/extensions/browser/error_map.cc
@@ -37,6 +37,8 @@ ErrorMap::Filter::Filter(const std::string& restrict_to_extension_id,
       restrict_to_incognito(restrict_to_incognito) {
 }
 
+ErrorMap::Filter::Filter(const Filter& other) = default;
+
 ErrorMap::Filter::~Filter() {
 }
 
diff --git a/extensions/browser/error_map.h b/extensions/browser/error_map.h
index 4c679ea..929335a 100644
--- a/extensions/browser/error_map.h
+++ b/extensions/browser/error_map.h
@@ -33,6 +33,7 @@ class ErrorMap {
            int restrict_to_type,
            const std::set<int>& restrict_to_ids,
            bool restrict_to_incognito);
+    Filter(const Filter& other);
     ~Filter();
 
     // Convenience methods to get a specific type of filter. Prefer these over
diff --git a/extensions/browser/extension_api_frame_id_map.cc b/extensions/browser/extension_api_frame_id_map.cc
index 5ce80d2..53ee551 100644
--- a/extensions/browser/extension_api_frame_id_map.cc
+++ b/extensions/browser/extension_api_frame_id_map.cc
@@ -64,6 +64,9 @@ ExtensionApiFrameIdMap::RenderFrameIdKey::RenderFrameIdKey(
 ExtensionApiFrameIdMap::FrameDataCallbacks::FrameDataCallbacks()
     : is_iterating(false) {}
 
+ExtensionApiFrameIdMap::FrameDataCallbacks::FrameDataCallbacks(
+    const FrameDataCallbacks& other) = default;
+
 ExtensionApiFrameIdMap::FrameDataCallbacks::~FrameDataCallbacks() {}
 
 bool ExtensionApiFrameIdMap::RenderFrameIdKey::operator<(
diff --git a/extensions/browser/extension_api_frame_id_map.h b/extensions/browser/extension_api_frame_id_map.h
index 58b1320..6c661ff 100644
--- a/extensions/browser/extension_api_frame_id_map.h
+++ b/extensions/browser/extension_api_frame_id_map.h
@@ -137,6 +137,7 @@ class ExtensionApiFrameIdMap {
 
   struct FrameDataCallbacks {
     FrameDataCallbacks();
+    FrameDataCallbacks(const FrameDataCallbacks& other);
     ~FrameDataCallbacks();
 
     // This is a std::list so that iterators are not invalidated when the list
diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
index b0b140e..822f131 100644
--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
@@ -403,6 +403,9 @@ WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo(
       allowed_by_default(allowed_by_default) {
 }
 
+WebViewPermissionHelper::PermissionResponseInfo::PermissionResponseInfo(
+    const PermissionResponseInfo& other) = default;
+
 WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() {
 }
 
diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.h b/extensions/browser/guest_view/web_view/web_view_permission_helper.h
index 8383665..f5d037d 100644
--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.h
+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.h
@@ -43,6 +43,7 @@ class WebViewPermissionHelper
     PermissionResponseInfo(const PermissionResponseCallback& callback,
                            WebViewPermissionType permission_type,
                            bool allowed_by_default);
+    PermissionResponseInfo(const PermissionResponseInfo& other);
     ~PermissionResponseInfo();
   };
 
diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.cc b/extensions/browser/guest_view/web_view/web_view_renderer_state.cc
index 8e9e26d..c95fac9 100644
--- a/extensions/browser/guest_view/web_view/web_view_renderer_state.cc
+++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.cc
@@ -12,6 +12,9 @@ namespace extensions {
 WebViewRendererState::WebViewInfo::WebViewInfo() {
 }
 
+WebViewRendererState::WebViewInfo::WebViewInfo(const WebViewInfo& other) =
+    default;
+
 WebViewRendererState::WebViewInfo::~WebViewInfo() {
 }
 
diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.h b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
index f5b18f5..c1c9242 100644
--- a/extensions/browser/guest_view/web_view/web_view_renderer_state.h
+++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
@@ -36,6 +36,7 @@ class WebViewRendererState {
     std::set<int> content_script_ids;
 
     WebViewInfo();
+    WebViewInfo(const WebViewInfo& other);
     ~WebViewInfo();
   };
 
diff --git a/extensions/browser/value_store/value_store_change.cc b/extensions/browser/value_store/value_store_change.cc
index 904ec82..3bbad59 100644
--- a/extensions/browser/value_store/value_store_change.cc
+++ b/extensions/browser/value_store/value_store_change.cc
@@ -31,6 +31,8 @@ ValueStoreChange::ValueStoreChange(
     const std::string& key, base::Value* old_value, base::Value* new_value)
     : inner_(new Inner(key, old_value, new_value)) {}
 
+ValueStoreChange::ValueStoreChange(const ValueStoreChange& other) = default;
+
 ValueStoreChange::~ValueStoreChange() {}
 
 const std::string& ValueStoreChange::key() const {
diff --git a/extensions/browser/value_store/value_store_change.h b/extensions/browser/value_store/value_store_change.h
index 4c03cc3..a5e6bf5 100644
--- a/extensions/browser/value_store/value_store_change.h
+++ b/extensions/browser/value_store/value_store_change.h
@@ -26,6 +26,8 @@ class ValueStoreChange {
   ValueStoreChange(
       const std::string& key, base::Value* old_value, base::Value* new_value);
 
+  ValueStoreChange(const ValueStoreChange& other);
+
   ~ValueStoreChange();
 
   // Gets the key of the setting which changed.
diff --git a/extensions/common/event_filtering_info.cc b/extensions/common/event_filtering_info.cc
index 3c39864..a426e1b 100644
--- a/extensions/common/event_filtering_info.cc
+++ b/extensions/common/event_filtering_info.cc
@@ -18,6 +18,9 @@ EventFilteringInfo::EventFilteringInfo()
       has_window_type_(false),
       has_window_exposed_by_default_(false) {}
 
+EventFilteringInfo::EventFilteringInfo(const EventFilteringInfo& other) =
+    default;
+
 EventFilteringInfo::~EventFilteringInfo() {
 }
 
diff --git a/extensions/common/event_filtering_info.h b/extensions/common/event_filtering_info.h
index 3058110..aaa03a4 100644
--- a/extensions/common/event_filtering_info.h
+++ b/extensions/common/event_filtering_info.h
@@ -25,6 +25,7 @@ namespace extensions {
 class EventFilteringInfo {
  public:
   EventFilteringInfo();
+  EventFilteringInfo(const EventFilteringInfo& other);
   ~EventFilteringInfo();
   void SetWindowExposedByDefault(bool exposed);
   void SetWindowType(const std::string& window_type);
diff --git a/extensions/common/extension_icon_set.cc b/extensions/common/extension_icon_set.cc
index 221f32f..421407c 100644
--- a/extensions/common/extension_icon_set.cc
+++ b/extensions/common/extension_icon_set.cc
@@ -10,6 +10,8 @@
 
 ExtensionIconSet::ExtensionIconSet() {}
 
+ExtensionIconSet::ExtensionIconSet(const ExtensionIconSet& other) = default;
+
 ExtensionIconSet::~ExtensionIconSet() {}
 
 void ExtensionIconSet::Clear() {
diff --git a/extensions/common/extension_icon_set.h b/extensions/common/extension_icon_set.h
index e491b72..91ce0f5 100644
--- a/extensions/common/extension_icon_set.h
+++ b/extensions/common/extension_icon_set.h
@@ -28,6 +28,7 @@ class ExtensionIconSet {
   typedef std::map<int, std::string> IconMap;
 
   ExtensionIconSet();
+  ExtensionIconSet(const ExtensionIconSet& other);
   ~ExtensionIconSet();
 
   const IconMap& map() const { return map_; }
diff --git a/extensions/common/extension_messages.cc b/extensions/common/extension_messages.cc
index d6ab4f2..c648b28 100644
--- a/extensions/common/extension_messages.cc
+++ b/extensions/common/extension_messages.cc
@@ -35,6 +35,9 @@ ExtensionMsg_PermissionSetStruct::ExtensionMsg_PermissionSetStruct(
       scriptable_hosts(permissions.scriptable_hosts()) {
 }
 
+ExtensionMsg_PermissionSetStruct::ExtensionMsg_PermissionSetStruct(
+    const ExtensionMsg_PermissionSetStruct& other) = default;
+
 ExtensionMsg_PermissionSetStruct::~ExtensionMsg_PermissionSetStruct() {
 }
 
@@ -70,6 +73,9 @@ ExtensionMsg_Loaded_Params::ExtensionMsg_Loaded_Params(
   }
 }
 
+ExtensionMsg_Loaded_Params::ExtensionMsg_Loaded_Params(
+    const ExtensionMsg_Loaded_Params& other) = default;
+
 scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(
     std::string* error) const {
   scoped_refptr<Extension> extension =
diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h
index 5125941..54f1433 100644
--- a/extensions/common/extension_messages.h
+++ b/extensions/common/extension_messages.h
@@ -249,6 +249,8 @@ struct ExtensionMsg_PermissionSetStruct {
   ExtensionMsg_PermissionSetStruct();
   explicit ExtensionMsg_PermissionSetStruct(
       const extensions::PermissionSet& permissions);
+  ExtensionMsg_PermissionSetStruct(
+      const ExtensionMsg_PermissionSetStruct& other);
   ~ExtensionMsg_PermissionSetStruct();
 
   scoped_ptr<const extensions::PermissionSet> ToPermissionSet() const;
@@ -264,6 +266,7 @@ struct ExtensionMsg_Loaded_Params {
   ~ExtensionMsg_Loaded_Params();
   ExtensionMsg_Loaded_Params(const extensions::Extension* extension,
                              bool include_tab_permissions);
+  ExtensionMsg_Loaded_Params(const ExtensionMsg_Loaded_Params& other);
 
   // Creates a new extension from the data in this object.
   scoped_refptr<extensions::Extension> ConvertToExtension(
diff --git a/extensions/common/extension_resource.cc b/extensions/common/extension_resource.cc
index e1eaa3c..fea9286 100644
--- a/extensions/common/extension_resource.cc
+++ b/extensions/common/extension_resource.cc
@@ -24,6 +24,8 @@ ExtensionResource::ExtensionResource(const std::string& extension_id,
       follow_symlinks_anywhere_(false) {
 }
 
+ExtensionResource::ExtensionResource(const ExtensionResource& other) = default;
+
 ExtensionResource::~ExtensionResource() {}
 
 void ExtensionResource::set_follow_symlinks_anywhere() {
diff --git a/extensions/common/extension_resource.h b/extensions/common/extension_resource.h
index 806889e..43281cc 100644
--- a/extensions/common/extension_resource.h
+++ b/extensions/common/extension_resource.h
@@ -30,6 +30,8 @@ class ExtensionResource {
                     const base::FilePath& extension_root,
                     const base::FilePath& relative_path);
 
+  ExtensionResource(const ExtensionResource& other);
+
   ~ExtensionResource();
 
   // set_follow_symlinks_anywhere allows the resource to be a symlink to
diff --git a/extensions/common/manifest_handlers/file_handler_info.cc b/extensions/common/manifest_handlers/file_handler_info.cc
index b525c14..c95a5e4 100644
--- a/extensions/common/manifest_handlers/file_handler_info.cc
+++ b/extensions/common/manifest_handlers/file_handler_info.cc
@@ -26,6 +26,7 @@ const char kNotRecognized[] = "'%s' is not a recognized file handler property.";
 }
 
 FileHandlerInfo::FileHandlerInfo() : include_directories(false) {}
+FileHandlerInfo::FileHandlerInfo(const FileHandlerInfo& other) = default;
 FileHandlerInfo::~FileHandlerInfo() {}
 
 FileHandlers::FileHandlers() {}
diff --git a/extensions/common/manifest_handlers/file_handler_info.h b/extensions/common/manifest_handlers/file_handler_info.h
index ac9e51d..90de31c 100644
--- a/extensions/common/manifest_handlers/file_handler_info.h
+++ b/extensions/common/manifest_handlers/file_handler_info.h
@@ -17,6 +17,7 @@ namespace extensions {
 
 struct FileHandlerInfo {
   FileHandlerInfo();
+  FileHandlerInfo(const FileHandlerInfo& other);
   ~FileHandlerInfo();
 
   // The id of this handler.
diff --git a/extensions/common/permissions/api_permission_set.cc b/extensions/common/permissions/api_permission_set.cc
index 164390b..0e48d2f 100644
--- a/extensions/common/permissions/api_permission_set.cc
+++ b/extensions/common/permissions/api_permission_set.cc
@@ -197,6 +197,8 @@ PermissionID::~PermissionID() {
 PermissionIDSet::PermissionIDSet() {
 }
 
+PermissionIDSet::PermissionIDSet(const PermissionIDSet& other) = default;
+
 PermissionIDSet::~PermissionIDSet() {
 }
 
diff --git a/extensions/common/permissions/api_permission_set.h b/extensions/common/permissions/api_permission_set.h
index c913466..e64d519 100644
--- a/extensions/common/permissions/api_permission_set.h
+++ b/extensions/common/permissions/api_permission_set.h
@@ -117,6 +117,7 @@ class PermissionIDSet {
   using const_iterator = std::set<PermissionID>::const_iterator;
 
   PermissionIDSet();
+  PermissionIDSet(const PermissionIDSet& other);
   virtual ~PermissionIDSet();
 
   // Adds the given permission, and an optional parameter, to the set.
diff --git a/extensions/common/permissions/permission_message.cc b/extensions/common/permissions/permission_message.cc
index 416b6c9..83553e6 100644
--- a/extensions/common/permissions/permission_message.cc
+++ b/extensions/common/permissions/permission_message.cc
@@ -16,6 +16,8 @@ PermissionMessage::PermissionMessage(
     const std::vector<base::string16>& submessages)
     : message_(message), permissions_(permissions), submessages_(submessages) {}
 
+PermissionMessage::PermissionMessage(const PermissionMessage& other) = default;
+
 PermissionMessage::~PermissionMessage() {}
 
 }  // namespace extensions
diff --git a/extensions/common/permissions/permission_message.h b/extensions/common/permissions/permission_message.h
index bdb053a..28f1f15 100644
--- a/extensions/common/permissions/permission_message.h
+++ b/extensions/common/permissions/permission_message.h
@@ -44,6 +44,7 @@ class PermissionMessage {
   PermissionMessage(const base::string16& message,
                     const PermissionIDSet& permissions,
                     const std::vector<base::string16>& submessages);
+  PermissionMessage(const PermissionMessage& other);
   virtual ~PermissionMessage();
 
   const base::string16& message() const { return message_; }
diff --git a/extensions/common/update_manifest.cc b/extensions/common/update_manifest.cc
index 57162da..c8ebdf7 100644
--- a/extensions/common/update_manifest.cc
+++ b/extensions/common/update_manifest.cc
@@ -23,6 +23,8 @@ UpdateManifest::Result::Result()
     : size(0),
       diff_size(0) {}
 
+UpdateManifest::Result::Result(const Result& other) = default;
+
 UpdateManifest::Result::~Result() {}
 
 UpdateManifest::Results::Results() : daystart_elapsed_seconds(kNoDaystart) {}
diff --git a/extensions/common/update_manifest.h b/extensions/common/update_manifest.h
index d2b1be4..6761a39 100644
--- a/extensions/common/update_manifest.h
+++ b/extensions/common/update_manifest.h
@@ -42,6 +42,7 @@ class UpdateManifest {
   // The result of parsing one <app> tag in an xml update check manifest.
   struct Result {
     Result();
+    Result(const Result& other);
     ~Result();
 
     std::string extension_id;
diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc
index 0be7aba..a74c864 100644
--- a/extensions/common/url_pattern.cc
+++ b/extensions/common/url_pattern.cc
@@ -151,6 +151,8 @@ URLPattern::URLPattern(int valid_schemes, const std::string& pattern)
     NOTREACHED() << "URLPattern invalid: " << pattern << " result " << result;
 }
 
+URLPattern::URLPattern(const URLPattern& other) = default;
+
 URLPattern::~URLPattern() {
 }
 
diff --git a/extensions/common/url_pattern.h b/extensions/common/url_pattern.h
index c58c3ef..bcdc7f6 100644
--- a/extensions/common/url_pattern.h
+++ b/extensions/common/url_pattern.h
@@ -90,6 +90,7 @@ class URLPattern {
   URLPattern(int valid_schemes, const std::string& pattern);
 
   URLPattern();
+  URLPattern(const URLPattern& other);
   ~URLPattern();
 
   bool operator<(const URLPattern& other) const;
diff --git a/extensions/common/user_script.cc b/extensions/common/user_script.cc
index 0bb3c8d..20bff9f 100644
--- a/extensions/common/user_script.cc
+++ b/extensions/common/user_script.cc
@@ -82,6 +82,8 @@ UserScript::File::File(const base::FilePath& extension_root,
 
 UserScript::File::File() {}
 
+UserScript::File::File(const File& other) = default;
+
 UserScript::File::~File() {}
 
 UserScript::UserScript()
@@ -93,6 +95,8 @@ UserScript::UserScript()
       match_about_blank_(false),
       incognito_enabled_(false) {}
 
+UserScript::UserScript(const UserScript& other) = default;
+
 UserScript::~UserScript() {
 }
 
diff --git a/extensions/common/user_script.h b/extensions/common/user_script.h
index 8bf16bf..40ad330 100644
--- a/extensions/common/user_script.h
+++ b/extensions/common/user_script.h
@@ -80,6 +80,7 @@ class UserScript {
          const base::FilePath& relative_path,
          const GURL& url);
     File();
+    File(const File& other);
     ~File();
 
     const base::FilePath& extension_root() const { return extension_root_; }
@@ -133,6 +134,7 @@ class UserScript {
   // Constructor. Default the run location to document end, which is like
   // Greasemonkey and probably more useful for typical scripts.
   UserScript();
+  UserScript(const UserScript& other);
   ~UserScript();
 
   const std::string& name_space() const { return name_space_; }