sync: Remove some fields from about:sync

Removes some of the status indicators on about:sync that were made
obsolete by the introduction of the protocol events log.

BUG=349301

Review URL: https://codereview.chromium.org/235923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263483 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 0 insertions, 52 deletions

diff --git a/chrome/browser/sync/about_sync_util.cc b/chrome/browser/sync/about_sync_util.cc
index 6b6a6ac..6f6fa39 100644
--- a/chrome/browser/sync/about_sync_util.cc
+++ b/chrome/browser/sync/about_sync_util.cc
@@ -248,7 +248,6 @@ scoped_ptr<base::DictionaryValue> ConstructAboutInformation(
   StringSyncStat backend_initialization(section_local,
                                         "Sync Backend Initialization");
   BoolSyncStat is_syncing(section_local, "Syncing");
-  BoolSyncStat is_token_available(section_local, "Sync Token Available");
 
   base::ListValue* section_network = AddSection(stats_list, "Network");
   BoolSyncStat is_throttled(section_network, "Throttled");
@@ -284,15 +283,6 @@ scoped_ptr<base::DictionaryValue> ConstructAboutInformation(
   base::ListValue* section_counters = AddSection(stats_list, "Running Totals");
   IntSyncStat notifications_received(section_counters,
                                      "Notifications Received");
-  IntSyncStat empty_get_updates(section_counters, "Cycles Without Updates");
-  IntSyncStat non_empty_get_updates(section_counters, "Cycles With Updates");
-  IntSyncStat sync_cycles_without_commits(section_counters,
-                                          "Cycles Without Commits");
-  IntSyncStat sync_cycles_with_commits(section_counters, "Cycles With Commits");
-  IntSyncStat useless_sync_cycles(section_counters,
-                           "Cycles Without Commits or Updates");
-  IntSyncStat useful_sync_cycles(section_counters,
-                                 "Cycles With Commits or Updates");
   IntSyncStat updates_received(section_counters, "Updates Downloaded");
   IntSyncStat tombstone_updates(section_counters, "Tombstone Updates");
   IntSyncStat reflected_updates(section_counters, "Reflected Updates");
@@ -422,14 +412,6 @@ scoped_ptr<base::DictionaryValue> ConstructAboutInformation(
 
   if (is_status_valid) {
     notifications_received.SetValue(full_status.notifications_received);
-    empty_get_updates.SetValue(full_status.empty_get_updates);
-    non_empty_get_updates.SetValue(full_status.nonempty_get_updates);
-    sync_cycles_without_commits.SetValue(
-        full_status.sync_cycles_without_commits);
-    sync_cycles_with_commits.SetValue(
-        full_status.sync_cycles_with_commits);
-    useless_sync_cycles.SetValue(full_status.useless_sync_cycles);
-    useful_sync_cycles.SetValue(full_status.useful_sync_cycles);
     updates_received.SetValue(full_status.updates_received);
     tombstone_updates.SetValue(full_status.tombstone_updates_received);
     reflected_updates.SetValue(full_status.reflected_updates_received);
diff --git a/sync/engine/all_status.cc b/sync/engine/all_status.cc
index d73f206..3deda48 100644
--- a/sync/engine/all_status.cc
+++ b/sync/engine/all_status.cc
@@ -71,22 +71,6 @@ SyncStatus AllStatus::CalcSyncing(const SyncCycleEvent &event) const {
         snapshot.model_neutral_state().num_local_overwrites;
     status.num_server_overwrites_total +=
         snapshot.model_neutral_state().num_server_overwrites;
-    if (snapshot.model_neutral_state().num_updates_downloaded_total == 0) {
-      ++status.empty_get_updates;
-    } else {
-      ++status.nonempty_get_updates;
-    }
-    if (snapshot.model_neutral_state().num_successful_commits == 0) {
-      ++status.sync_cycles_without_commits;
-    } else {
-      ++status.sync_cycles_with_commits;
-    }
-    if (snapshot.model_neutral_state().num_successful_commits == 0 &&
-        snapshot.model_neutral_state().num_updates_downloaded_total == 0) {
-      ++status.useless_sync_cycles;
-    } else {
-      ++status.useful_sync_cycles;
-    }
   }
   return status;
 }
diff --git a/sync/internal_api/public/engine/sync_status.cc b/sync/internal_api/public/engine/sync_status.cc
index 6291b29..b1687e3 100644
--- a/sync/internal_api/public/engine/sync_status.cc
+++ b/sync/internal_api/public/engine/sync_status.cc
@@ -21,12 +21,6 @@ SyncStatus::SyncStatus()
       num_commits_total(0),
       num_local_overwrites_total(0),
       num_server_overwrites_total(0),
-      nonempty_get_updates(0),
-      empty_get_updates(0),
-      sync_cycles_with_commits(0),
-      sync_cycles_without_commits(0),
-      useless_sync_cycles(0),
-      useful_sync_cycles(0),
       nudge_source_notification(0),
       nudge_source_local(0),
       nudge_source_local_refresh(0),
diff --git a/sync/internal_api/public/engine/sync_status.h b/sync/internal_api/public/engine/sync_status.h
index 124dac6..c32be00 100644
--- a/sync/internal_api/public/engine/sync_status.h
+++ b/sync/internal_api/public/engine/sync_status.h
@@ -65,18 +65,6 @@ struct SYNC_EXPORT SyncStatus {
   int num_local_overwrites_total;
   int num_server_overwrites_total;
 
-  // Count of empty and non empty getupdates;
-  int nonempty_get_updates;
-  int empty_get_updates;
-
-  // Count of sync cycles that successfully committed items;
-  int sync_cycles_with_commits;
-  int sync_cycles_without_commits;
-
-  // Count of useless and useful syncs we perform.
-  int useless_sync_cycles;
-  int useful_sync_cycles;
-
   // Nudge counts for each possible source
   int nudge_source_notification;
   int nudge_source_local;