summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsdefresne <sdefresne@chromium.org>2014-11-27 01:23:25 -0800
committerCommit bot <commit-bot@chromium.org>2014-11-27 09:23:38 +0000
commit4097e31e410d10b96c110109a9e6b152fa483836 (patch)
tree5064b2decdb125822ca133564d2e65d03c205516
parent9c26edc89cf91823c771ac540e12da02449184b0 (diff)
downloadchromium_src-4097e31e410d10b96c110109a9e6b152fa483836.zip
chromium_src-4097e31e410d10b96c110109a9e6b152fa483836.tar.gz
chromium_src-4097e31e410d10b96c110109a9e6b152fa483836.tar.bz2
Update comments in //chrome/browser/history/DEPS
Update comments in DEPS file to mention that sdefresne@chromium.org is leading the componentization effort of history. BUG=370850 Review URL: https://codereview.chromium.org/746763003 Cr-Commit-Position: refs/heads/master@{#305970}
-rw-r--r--chrome/browser/history/DEPS12
1 files changed, 7 insertions, 5 deletions
diff --git a/chrome/browser/history/DEPS b/chrome/browser/history/DEPS
index 42b3071..672b4f5 100644
--- a/chrome/browser/history/DEPS
+++ b/chrome/browser/history/DEPS
@@ -1,7 +1,10 @@
include_rules = [
- # History is being made into a Browser Component, so we have these
- # basic rules followed by temporary exceptions. Please don't
+ # History is being made into a Browser Component (http://crbug.com/370850), so
+ # we have these basic rules followed by temporary exceptions. Please don't
# add to the list of exceptions!
+ #
+ # Please send reviews to sdefresne@chromium.org when adding dependencies to
+ # this list.
"-chrome/browser",
"-components/search_engines",
"+chrome/browser/chrome_notification_types.h",
@@ -12,11 +15,10 @@ include_rules = [
"+chrome/tools/profiles", # For history unit tests.
"+components/visitedlink/browser",
- # TODO(erikwright): Bring this list to zero.
+ # TODO(sdefresne): Bring this list to zero.
#
# Do not add to the list of temporarily-allowed dependencies below,
# and please do not introduce more #includes of these files.
- # http://crbug.com/370850
"!chrome/browser/autocomplete/history_url_provider.h",
"!chrome/browser/bookmarks/bookmark_model_factory.h",
"!chrome/browser/bookmarks/chrome_bookmark_client.h",
@@ -59,7 +61,7 @@ specific_include_rules = {
'.*_(api|browser|)test\.cc': [
"+chrome/browser",
],
- # TODO(sdefresne): Bring this list to zero. http://crbug.com/370850
+ # TODO(sdefresne): Bring this list to zero.
#
# Do not add to the list of temporarily-allowed dependencies below,
# and please do not introduce more #includes of these files.