summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-08-27 09:56:10 -0700
committerCommit bot <commit-bot@chromium.org>2014-08-27 16:56:44 +0000
commit40eae71d25e6353952676a2cfe00c541d5b0fe03 (patch)
tree21544b57c8a874bbc5e3fe344de24d7933dc5638
parent703621781308560423bc1792edf662bb85c7afdc (diff)
downloadchromium_src-40eae71d25e6353952676a2cfe00c541d5b0fe03.zip
chromium_src-40eae71d25e6353952676a2cfe00c541d5b0fe03.tar.gz
chromium_src-40eae71d25e6353952676a2cfe00c541d5b0fe03.tar.bz2
Remove implicit conversions from scoped_refptr to T* in chrome/*/extensions/
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/506883003 Cr-Commit-Position: refs/heads/master@{#292169}
-rw-r--r--chrome/browser/extensions/webstore_standalone_installer.cc6
-rw-r--r--chrome/common/extensions/extension_unittest.cc24
-rw-r--r--chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc4
-rw-r--r--chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc6
-rw-r--r--chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc4
-rw-r--r--chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc2
-rw-r--r--chrome/common/extensions/permissions/permission_set_unittest.cc84
7 files changed, 65 insertions, 65 deletions
diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc
index dd2ac5c..14c5643 100644
--- a/chrome/browser/extensions/webstore_standalone_installer.cc
+++ b/chrome/browser/extensions/webstore_standalone_installer.cc
@@ -351,7 +351,7 @@ void WebstoreStandaloneInstaller::InstallUIProceed() {
// downloading from the Web Store is not necessary.
scoped_refptr<const Extension> extension_to_install =
GetLocalizedExtensionForDisplay();
- if (!extension_to_install) {
+ if (!extension_to_install.get()) {
CompleteInstall(webstore_install::INVALID_MANIFEST,
kInvalidManifestError);
return;
@@ -424,14 +424,14 @@ void WebstoreStandaloneInstaller::OnExtensionInstallFailure(
void WebstoreStandaloneInstaller::ShowInstallUI() {
scoped_refptr<const Extension> localized_extension =
GetLocalizedExtensionForDisplay();
- if (!localized_extension) {
+ if (!localized_extension.get()) {
CompleteInstall(webstore_install::INVALID_MANIFEST, kInvalidManifestError);
return;
}
install_ui_ = CreateInstallUI();
install_ui_->ConfirmStandaloneInstall(
- this, localized_extension, &icon_, install_prompt_);
+ this, localized_extension.get(), &icon_, install_prompt_);
}
void WebstoreStandaloneInstaller::OnWebStoreDataFetcherDone() {
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index f0d401b..2d19733 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -242,69 +242,69 @@ TEST(ExtensionTest, WantsFileAccess) {
extension = LoadManifest("permissions", "permissions_all_urls.json");
EXPECT_TRUE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest(
"permissions", "permissions_all_urls.json", Extension::ALLOW_FILE_ACCESS);
EXPECT_TRUE(extension->wants_file_access());
EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
// file:///* permission
extension = LoadManifest("permissions", "permissions_file_scheme.json");
EXPECT_TRUE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest("permissions",
"permissions_file_scheme.json",
Extension::ALLOW_FILE_ACCESS);
EXPECT_TRUE(extension->wants_file_access());
EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
// http://* permission
extension = LoadManifest("permissions", "permissions_http_scheme.json");
EXPECT_FALSE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest("permissions",
"permissions_http_scheme.json",
Extension::ALLOW_FILE_ACCESS);
EXPECT_FALSE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
// <all_urls> content script match
extension = LoadManifest("permissions", "content_script_all_urls.json");
EXPECT_TRUE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest("permissions", "content_script_all_urls.json",
Extension::ALLOW_FILE_ACCESS);
EXPECT_TRUE(extension->wants_file_access());
EXPECT_TRUE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
// file:///* content script match
extension = LoadManifest("permissions", "content_script_file_scheme.json");
EXPECT_TRUE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest("permissions", "content_script_file_scheme.json",
Extension::ALLOW_FILE_ACCESS);
EXPECT_TRUE(extension->wants_file_access());
EXPECT_TRUE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
// http://* content script match
extension = LoadManifest("permissions", "content_script_http_scheme.json");
EXPECT_FALSE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
extension = LoadManifest("permissions", "content_script_http_scheme.json",
Extension::ALLOW_FILE_ACCESS);
EXPECT_FALSE(extension->wants_file_access());
EXPECT_FALSE(extension->permissions_data()->CanRunContentScriptOnPage(
- extension, file_url, file_url, -1, -1, NULL));
+ extension.get(), file_url, file_url, -1, -1, NULL));
}
TEST(ExtensionTest, ExtraFlags) {
diff --git a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc
index c751157..907ab92 100644
--- a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc
@@ -73,11 +73,11 @@ TEST_F(ContentScriptsManifestTest, ContentScriptIds) {
scoped_refptr<Extension> extension2 =
LoadAndExpectSuccess("content_script_yahoo.json");
const UserScriptList& user_scripts1 =
- ContentScriptsInfo::GetContentScripts(extension1);
+ ContentScriptsInfo::GetContentScripts(extension1.get());
ASSERT_EQ(1u, user_scripts1.size());
int id = user_scripts1[0].id();
const UserScriptList& user_scripts2 =
- ContentScriptsInfo::GetContentScripts(extension2);
+ ContentScriptsInfo::GetContentScripts(extension2.get());
ASSERT_EQ(1u, user_scripts2.size());
// The id of the content script should be one higher than the previous.
EXPECT_EQ(id + 1, user_scripts2[0].id());
diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
index 1acf3f0..138e02d 100644
--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
@@ -85,7 +85,7 @@ TEST_F(OverrideSettingsTest, ParseManifest) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
#if defined(OS_WIN)
ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
@@ -128,7 +128,7 @@ TEST_F(OverrideSettingsTest, ParsePrepopulatedId) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
#if defined(OS_WIN)
ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
@@ -169,7 +169,7 @@ TEST_F(OverrideSettingsTest, ParseBrokenManifest) {
extensions::manifest_keys::kSettingsOverride),
error);
#else
- EXPECT_TRUE(extension);
+ EXPECT_TRUE(extension.get());
EXPECT_FALSE(
extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
#endif
diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
index da5ad3a..3228b44 100644
--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
@@ -62,7 +62,7 @@ TEST_F(UIOverrideTest, ParseManifest) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- ASSERT_TRUE(extension) << error;
+ ASSERT_TRUE(extension.get()) << error;
ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kUIOverride));
UIOverrides* ui_override = static_cast<UIOverrides*>(
@@ -91,7 +91,7 @@ TEST_F(UIOverrideTest, ParseBrokenManifest) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- EXPECT_FALSE(extension);
+ EXPECT_FALSE(extension.get());
EXPECT_EQ(
extensions::ErrorUtils::FormatErrorMessage(
extensions::manifest_errors::kInvalidEmptyDictionary,
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc
index 6608308..ad05250 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc
@@ -35,7 +35,7 @@ TEST_F(ExtensionManifestTest, ChromeURLPermissionAllowedWithFlag) {
EXPECT_EQ("", error);
const GURL newtab_url(chrome::kChromeUINewTabURL);
EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
- extension, newtab_url, newtab_url, 0, -1, &error))
+ extension.get(), newtab_url, newtab_url, 0, -1, &error))
<< error;
}
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index f72b3da..4cb09a1 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -797,7 +797,7 @@ TEST(PermissionsTest, FileSystemPermissionMessages) {
URLPatternSet(), URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_PLATFORM_APP);
+ permissions.get(), Manifest::TYPE_PLATFORM_APP);
ASSERT_EQ(1u, messages.size());
std::sort(messages.begin(), messages.end());
std::set<PermissionMessage::ID> ids;
@@ -818,7 +818,7 @@ TEST(PermissionsTest, HiddenFileSystemPermissionMessages) {
URLPatternSet(), URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_PLATFORM_APP);
+ permissions.get(), Manifest::TYPE_PLATFORM_APP);
ASSERT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kFileSystemWriteDirectory, messages[0].id());
}
@@ -835,7 +835,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
hosts, URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kTabs, messages[0].id());
}
@@ -850,7 +850,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
hosts, URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kBrowsingHistory, messages[0].id());
}
@@ -863,7 +863,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
api_permissions, ManifestPermissionSet(), hosts, URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kHostsAll, messages[0].id());
}
@@ -876,7 +876,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
api_permissions, ManifestPermissionSet(), hosts, URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kHostsAll, messages[0].id());
}
@@ -892,7 +892,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
URLPatternSet(), URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kBrowsingHistory, messages[0].id());
}
@@ -907,7 +907,7 @@ TEST(PermissionsTest, SuppressedPermissionMessages) {
URLPatternSet(), URLPatternSet()));
PermissionMessages messages =
PermissionMessageProvider::Get()->GetPermissionMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(PermissionMessage::kTabs, messages[0].id());
}
@@ -924,7 +924,7 @@ TEST(PermissionsTest, AccessToDevicesMessages) {
URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_USB),
messages[0]);
@@ -941,7 +941,7 @@ TEST(PermissionsTest, AccessToDevicesMessages) {
URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_USB),
messages[0]);
@@ -956,7 +956,7 @@ TEST(PermissionsTest, AccessToDevicesMessages) {
URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_SERIAL),
messages[0]);
@@ -972,7 +972,7 @@ TEST(PermissionsTest, AccessToDevicesMessages) {
URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_USB_SERIAL),
@@ -991,7 +991,7 @@ TEST(PermissionsTest, AccessToDevicesMessages) {
URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_USB_SERIAL),
@@ -1060,23 +1060,23 @@ TEST(PermissionsTest, MergedFileSystemPermissionComparison) {
URLPatternSet()));
const PermissionMessageProvider* provider = PermissionMessageProvider::Get();
- EXPECT_FALSE(provider->IsPrivilegeIncrease(write_directory_permissions,
- write_permissions,
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(write_directory_permissions.get(),
+ write_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(write_directory_permissions,
- directory_permissions,
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(write_directory_permissions.get(),
+ directory_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
- EXPECT_TRUE(provider->IsPrivilegeIncrease(write_permissions,
- directory_permissions,
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(write_permissions.get(),
+ directory_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
- EXPECT_TRUE(provider->IsPrivilegeIncrease(write_permissions,
- write_directory_permissions,
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(write_permissions.get(),
+ write_directory_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(directory_permissions,
- write_permissions,
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(directory_permissions.get(),
+ write_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
- EXPECT_TRUE(provider->IsPrivilegeIncrease(directory_permissions,
- write_directory_permissions,
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(directory_permissions.get(),
+ write_directory_permissions.get(),
Manifest::TYPE_PLATFORM_APP));
}
@@ -1159,7 +1159,7 @@ TEST(PermissionsTest, GetWarningMessages_CombinedSessions) {
URLPatternSet(), URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS),
@@ -1178,7 +1178,7 @@ TEST(PermissionsTest, GetWarningMessages_CombinedSessions) {
URLPatternSet(), URLPatternSet()));
std::vector<base::string16> messages =
PermissionMessageProvider::Get()->GetWarningMessages(
- permissions, Manifest::TYPE_EXTENSION);
+ permissions.get(), Manifest::TYPE_EXTENSION);
EXPECT_EQ(1u, messages.size());
EXPECT_EQ(l10n_util::GetStringUTF16(
IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS),
@@ -1631,8 +1631,8 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
// Test that paths are ignored.
elist2.ClearPatterns();
@@ -1640,8 +1640,8 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
URLPattern(URLPattern::SCHEME_HTTP, "http://www.google.com/*"));
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
// Test that RCDs are ignored.
elist2.ClearPatterns();
@@ -1649,8 +1649,8 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
URLPattern(URLPattern::SCHEME_HTTP, "http://www.google.com.hk/*"));
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
// Test that subdomain wildcards are handled properly.
elist2.ClearPatterns();
@@ -1658,7 +1658,7 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
URLPattern(URLPattern::SCHEME_HTTP, "http://*.google.com.hk/*"));
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_TRUE(provider->IsPrivilegeIncrease(set1, set2, type));
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
// TODO(jstritar): Does not match subdomains properly. http://crbug.com/65337
// EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
@@ -1670,8 +1670,8 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
URLPattern(URLPattern::SCHEME_HTTP, "http://www.example.org/path"));
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_TRUE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
// Test that different subdomains count as different hosts.
elist2.ClearPatterns();
@@ -1679,13 +1679,13 @@ TEST(PermissionsTest, IsHostPrivilegeIncrease) {
URLPattern(URLPattern::SCHEME_HTTP, "http://mail.google.com/*"));
set2 = new PermissionSet(empty_perms, empty_manifest_permissions,
elist2, slist2);
- EXPECT_TRUE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_TRUE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_TRUE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
// Test that platform apps do not have host permissions increases.
type = Manifest::TYPE_PLATFORM_APP;
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set1, set2, type));
- EXPECT_FALSE(provider->IsPrivilegeIncrease(set2, set1, type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set1.get(), set2.get(), type));
+ EXPECT_FALSE(provider->IsPrivilegeIncrease(set2.get(), set1.get(), type));
}
TEST(PermissionsTest, GetAPIsAsStrings) {
@@ -1780,8 +1780,8 @@ TEST(PermissionsTest, ChromeURLs) {
scoped_refptr<PermissionSet> permissions(
new PermissionSet(APIPermissionSet(), ManifestPermissionSet(),
allowed_hosts, URLPatternSet()));
- PermissionMessageProvider::Get()->
- GetPermissionMessages(permissions, Manifest::TYPE_EXTENSION);
+ PermissionMessageProvider::Get()->GetPermissionMessages(
+ permissions.get(), Manifest::TYPE_EXTENSION);
}
TEST(PermissionsTest, IsPrivilegeIncrease_DeclarativeWebRequest) {