summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorvollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-18 11:50:25 +0000
committervollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-18 11:50:25 +0000
commit4370fe281469ecd2bd2f5b4210fe2b910f2a3166 (patch)
tree4d396855a4d73afed524ff03d467f2b4944f7f49
parenta858fe98e22e2c0b2a57cdecc2d8568234af4a5f (diff)
downloadchromium_src-4370fe281469ecd2bd2f5b4210fe2b910f2a3166.zip
chromium_src-4370fe281469ecd2bd2f5b4210fe2b910f2a3166.tar.gz
chromium_src-4370fe281469ecd2bd2f5b4210fe2b910f2a3166.tar.bz2
Remove the "universal" accel. overflow scroll flags
They're not used anymore. R=abarth@chromium.org BUG=None Review URL: https://codereview.chromium.org/333293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278039 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--build/ios/grit_whitelist.txt2
-rw-r--r--chrome/app/generated_resources.grd6
-rw-r--r--chrome/browser/about_flags.cc9
-rw-r--r--chrome/browser/chromeos/login/chrome_restart_request.cc2
-rw-r--r--content/browser/renderer_host/render_process_host_impl.cc2
-rw-r--r--content/public/common/content_switches.cc9
-rw-r--r--content/public/common/content_switches.h2
-rw-r--r--content/renderer/render_view_impl.cc16
8 files changed, 0 insertions, 48 deletions
diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt
index 0915a9c..8c5252c 100644
--- a/build/ios/grit_whitelist.txt
+++ b/build/ios/grit_whitelist.txt
@@ -496,8 +496,6 @@ IDS_FLAGS_FORCE_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION
IDS_FLAGS_FORCE_ACCELERATED_OVERFLOW_SCROLL_MODE_NAME
IDS_FLAGS_FORCE_HIGH_DPI_DESCRIPTION
IDS_FLAGS_FORCE_HIGH_DPI_NAME
-IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION
-IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_NAME
IDS_FLAGS_IGNORE_GPU_BLACKLIST_DESCRIPTION
IDS_FLAGS_IGNORE_GPU_BLACKLIST_NAME
IDS_FLAGS_IMPL_SIDE_PAINTING_DESCRIPTION
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 4c7f027..3b90299 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -5633,12 +5633,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_FLAGS_FORCE_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION" desc="Description of the 'Accelerated overflow scroll mode' lab.">
When possible, puts the scrolling contents of an overflow scrolling element onto a composited layer for faster scrolling.
</message>
- <message name="IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_NAME" desc="Name of the 'Universal accelerated overflow scroll mode' lab.">
- Universal accelerated overflow scroll
- </message>
- <message name="IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION" desc="Description of the 'Universal accelerated overflow scroll mode' lab.">
- Puts scrolling content in composited layers, even in those cases where promoting the overflow scrolling element to a stacking context and a containing block would have broken stacking or clipping.
- </message>
<message name="IDS_FLAGS_DISABLE_LAYER_SQUASHING_NAME" desc="Name of the 'Disable layer squashing' lab.">
Disable layer squashing
</message>
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index b38fa9b..7577556 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -523,15 +523,6 @@ const Experiment kExperiments[] = {
switches::kDisableAcceleratedOverflowScroll)
},
{
- "force-universal-accelerated-composited-scrolling",
- IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_NAME,
- IDS_FLAGS_FORCE_UNIVERSAL_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION,
- kOsAll,
- ENABLE_DISABLE_VALUE_TYPE(
- switches::kEnableUniversalAcceleratedOverflowScroll,
- switches::kDisableUniversalAcceleratedOverflowScroll)
- },
- {
"disable_layer_squashing",
IDS_FLAGS_DISABLE_LAYER_SQUASHING_NAME,
IDS_FLAGS_DISABLE_LAYER_SQUASHING_DESCRIPTION,
diff --git a/chrome/browser/chromeos/login/chrome_restart_request.cc b/chrome/browser/chromeos/login/chrome_restart_request.cc
index eaefb6c..3693a5d 100644
--- a/chrome/browser/chromeos/login/chrome_restart_request.cc
+++ b/chrome/browser/chromeos/login/chrome_restart_request.cc
@@ -91,7 +91,6 @@ std::string DeriveCommandLine(const GURL& start_url,
::switches::kDisableThreadedCompositing,
::switches::kDisableTouchDragDrop,
::switches::kDisableTouchEditing,
- ::switches::kDisableUniversalAcceleratedOverflowScroll,
::switches::kDisableAcceleratedFixedRootBackground,
::switches::kDisableZeroCopy,
::switches::kEnableAcceleratedFixedRootBackground,
@@ -117,7 +116,6 @@ std::string DeriveCommandLine(const GURL& start_url,
::switches::kEnableThreadedCompositing,
::switches::kEnableTouchDragDrop,
::switches::kEnableTouchEditing,
- ::switches::kEnableUniversalAcceleratedOverflowScroll,
::switches::kEnableViewport,
::switches::kEnableViewportMeta,
::switches::kEnableZeroCopy,
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index de8f5b4..890c390 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1111,7 +1111,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kDisableTouchAdjustment,
switches::kDisableTouchDragDrop,
switches::kDisableTouchEditing,
- switches::kDisableUniversalAcceleratedOverflowScroll,
switches::kDisableZeroCopy,
switches::kDomAutomationController,
switches::kEnableAcceleratedFixedRootBackground,
@@ -1151,7 +1150,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kEnableStatsTable,
switches::kEnableStrictSiteIsolation,
switches::kEnableTargetedStyleRecalc,
- switches::kEnableUniversalAcceleratedOverflowScroll,
switches::kEnableTouchDragDrop,
switches::kEnableTouchEditing,
switches::kEnableViewport,
diff --git a/content/public/common/content_switches.cc b/content/public/common/content_switches.cc
index 247f10e..5973fc0 100644
--- a/content/public/common/content_switches.cc
+++ b/content/public/common/content_switches.cc
@@ -276,11 +276,6 @@ const char kDisableSSLFalseStart[] = "disable-ssl-false-start";
// Disable multithreaded GPU compositing of web content.
const char kDisableThreadedCompositing[] = "disable-threaded-compositing";
-// Disable accelerated overflow scrolling in corner cases (that would not be
-// handled by enable-accelerated-overflow-scroll).
-const char kDisableUniversalAcceleratedOverflowScroll[] =
- "disable-universal-accelerated-overflow-scroll";
-
// Don't enforce the same-origin policy. (Used by people testing their sites.)
const char kDisableWebSecurity[] = "disable-web-security";
@@ -506,10 +501,6 @@ const char kEnableTcpFastOpen[] = "enable-tcp-fastopen";
// Enable multithreaded GPU compositing of web content.
const char kEnableThreadedCompositing[] = "enable-threaded-compositing";
-// Enable accelerated overflow scrolling in all cases.
-const char kEnableUniversalAcceleratedOverflowScroll[] =
- "enable-universal-accelerated-overflow-scroll";
-
// Enable screen capturing support for MediaStream API.
const char kEnableUserMediaScreenCapturing[] =
"enable-usermedia-screen-capturing";
diff --git a/content/public/common/content_switches.h b/content/public/common/content_switches.h
index fabd6bf..f763e20 100644
--- a/content/public/common/content_switches.h
+++ b/content/public/common/content_switches.h
@@ -89,7 +89,6 @@ CONTENT_EXPORT extern const char kDisableSmoothScrolling[];
CONTENT_EXPORT extern const char kDisableSoftwareRasterizer[];
CONTENT_EXPORT extern const char kDisableSSLFalseStart[];
CONTENT_EXPORT extern const char kDisableThreadedCompositing[];
-CONTENT_EXPORT extern const char kDisableUniversalAcceleratedOverflowScroll[];
CONTENT_EXPORT extern const char kDisableWebSecurity[];
extern const char kDisableXSLT[];
extern const char kDisableXSSAuditor[];
@@ -145,7 +144,6 @@ CONTENT_EXPORT extern const char kEnableServiceWorkerSync[];
CONTENT_EXPORT extern const char kEnableTargetedStyleRecalc[];
CONTENT_EXPORT extern const char kEnableTcpFastOpen[];
CONTENT_EXPORT extern const char kEnableThreadedCompositing[];
-CONTENT_EXPORT extern const char kEnableUniversalAcceleratedOverflowScroll[];
CONTENT_EXPORT extern const char kEnableUserMediaScreenCapturing[];
CONTENT_EXPORT extern const char kEnableViewport[];
CONTENT_EXPORT extern const char kEnableViewportMeta[];
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 03e4795..0eed3aa 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -430,20 +430,6 @@ static bool ShouldUseCompositedScrollingForFrames(
return DeviceScaleEnsuresTextQuality(device_scale_factor);
}
-static bool ShouldUseUniversalAcceleratedCompositingForOverflowScroll() {
- const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-
- if (command_line.HasSwitch(
- switches::kDisableUniversalAcceleratedOverflowScroll))
- return false;
-
- if (command_line.HasSwitch(
- switches::kEnableUniversalAcceleratedOverflowScroll))
- return true;
-
- return false;
-}
-
static bool ShouldUseTransitionCompositing(float device_scale_factor) {
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
@@ -744,8 +730,6 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {
ShouldUseFixedPositionCompositing(device_scale_factor_));
webview()->settings()->setAcceleratedCompositingForOverflowScrollEnabled(
ShouldUseAcceleratedCompositingForOverflowScroll(device_scale_factor_));
- webview()->settings()->setCompositorDrivenAcceleratedScrollingEnabled(
- ShouldUseUniversalAcceleratedCompositingForOverflowScroll());
webview()->settings()->setAcceleratedCompositingForTransitionEnabled(
ShouldUseTransitionCompositing(device_scale_factor_));
webview()->settings()->setAcceleratedCompositingForFixedRootBackgroundEnabled(