summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-18 21:28:07 +0000
committermseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-18 21:28:07 +0000
commit4379c3d6557bfc50c86f4b84eb0fbf4618929397 (patch)
tree4c85a2a20839931af4c25fe050b9266d3cdd8e03
parente3179745cdc1a987b002452780c845df7002a2ff (diff)
downloadchromium_src-4379c3d6557bfc50c86f4b84eb0fbf4618929397.zip
chromium_src-4379c3d6557bfc50c86f4b84eb0fbf4618929397.tar.gz
chromium_src-4379c3d6557bfc50c86f4b84eb0fbf4618929397.tar.bz2
NaCl: Remove all Chromium-side use of the handle_pass library
The handle_pass library is no longer needed because it is replaced by Chromium's BrokerDuplicateHandle() function. Removing the Chromium-side uses will let me delete the library on the NaCl side. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719 TEST=nacl_integration etc. Review URL: https://chromiumcodereview.appspot.com/10083035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132868 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ppapi/native_client/src/trusted/plugin/module_ppapi.cc7
-rw-r--r--ppapi/native_client/src/trusted/plugin/plugin.cc10
-rw-r--r--ppapi/native_client/src/trusted/plugin/plugin.gyp7
-rw-r--r--ppapi/native_client/src/trusted/plugin/service_runtime.cc1
4 files changed, 0 insertions, 25 deletions
diff --git a/ppapi/native_client/src/trusted/plugin/module_ppapi.cc b/ppapi/native_client/src/trusted/plugin/module_ppapi.cc
index d292121..60c7625 100644
--- a/ppapi/native_client/src/trusted/plugin/module_ppapi.cc
+++ b/ppapi/native_client/src/trusted/plugin/module_ppapi.cc
@@ -7,7 +7,6 @@
#include "native_client/src/shared/imc/nacl_imc_c.h"
#include "native_client/src/shared/platform/nacl_time.h"
#include "native_client/src/trusted/desc/nrd_all_modules.h"
-#include "native_client/src/trusted/handle_pass/browser_handle.h"
#include "native_client/src/trusted/plugin/nacl_entry_points.h"
#include "native_client/src/trusted/plugin/plugin.h"
@@ -57,12 +56,6 @@ class ModulePpapi : public pp::Module {
NaClSrpcModuleInit();
#if NACL_WINDOWS && !defined(NACL_STANDALONE)
- // TODO(mseaborn): Remove this call because NaCl's handle_pass
- // module is replaced by Chrome's BrokerDuplicateHandle()
- // function. The call to NaClHandlePassBrowserRememberHandle() on
- // the NaCl side will have to be removed first.
- NaClHandlePassBrowserInit();
-
NaClSetBrokerDuplicateHandleFunc(private_interface_->BrokerDuplicateHandle);
#endif
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index ace9821..3a66e96 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -32,7 +32,6 @@
#include "native_client/src/shared/platform/nacl_check.h"
#include "native_client/src/shared/ppapi_proxy/browser_ppp.h"
#include "native_client/src/trusted/desc/nacl_desc_wrapper.h"
-#include "native_client/src/trusted/handle_pass/browser_handle.h"
#include "native_client/src/trusted/nonnacl_util/sel_ldr_launcher.h"
#include "native_client/src/trusted/plugin/json_manifest.h"
#include "native_client/src/trusted/plugin/nacl_subprocess.h"
@@ -757,11 +756,6 @@ bool Plugin::NexeIsContentHandler() const {
Plugin* Plugin::New(PP_Instance pp_instance) {
PLUGIN_PRINTF(("Plugin::New (pp_instance=%"NACL_PRId32")\n", pp_instance));
-#if NACL_WINDOWS && !defined(NACL_STANDALONE)
- if (!NaClHandlePassBrowserCtor()) {
- return NULL;
- }
-#endif
Plugin* plugin = new Plugin(pp_instance);
PLUGIN_PRINTF(("Plugin::New (plugin=%p)\n", static_cast<void*>(plugin)));
if (plugin == NULL) {
@@ -892,10 +886,6 @@ Plugin::~Plugin() {
(shutdown_start - ready_time_) / NACL_MICROS_PER_MILLI);
}
-#if NACL_WINDOWS && !defined(NACL_STANDALONE)
- NaClHandlePassBrowserDtor();
-#endif
-
url_downloaders_.erase(url_downloaders_.begin(), url_downloaders_.end());
ShutdownProxy();
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.gyp b/ppapi/native_client/src/trusted/plugin/plugin.gyp
index bfecdd7..b36b644 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.gyp
+++ b/ppapi/native_client/src/trusted/plugin/plugin.gyp
@@ -120,13 +120,6 @@
'mac_real_dsym': 1,
},
}],
- ['OS=="win"', {
- 'dependencies': [
- '<(DEPTH)/native_client/src/trusted/handle_pass/handle_pass.gyp:browserhandle',
- '<(DEPTH)/native_client/src/trusted/handle_pass/handle_pass.gyp:handle_lookup',
- '<(DEPTH)/native_client/src/trusted/handle_pass/handle_pass.gyp:ldrhandle',
- ],
- }],
],
},
],
diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
index dc0eee7..1b51bfe 100644
--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc
+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
@@ -33,7 +33,6 @@
#include "native_client/src/trusted/desc/nacl_desc_io.h"
#include "native_client/src/trusted/desc/nrd_xfer.h"
#include "native_client/src/trusted/desc/nrd_xfer_effector.h"
-#include "native_client/src/trusted/handle_pass/browser_handle.h"
#include "native_client/src/trusted/nonnacl_util/sel_ldr_launcher.h"
#include "native_client/src/trusted/plugin/manifest.h"