diff options
| author | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-02 04:55:20 +0000 |
|---|---|---|
| committer | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-02 04:55:20 +0000 |
| commit | 438e5b1c9d9c56804ae40746ac6d62f166533cba (patch) | |
| tree | f900a868f4d7d92ca87d04f312d5883b65e3bc7e | |
| parent | f056a5ffff9a96dbb23e53854645fe31c5605d59 (diff) | |
| download | chromium_src-438e5b1c9d9c56804ae40746ac6d62f166533cba.zip chromium_src-438e5b1c9d9c56804ae40746ac6d62f166533cba.tar.gz chromium_src-438e5b1c9d9c56804ae40746ac6d62f166533cba.tar.bz2 | |
Fix failure-to-update bug introduced with try job fetching rollback
BUG=178588
Review URL: https://chromiumcodereview.appspot.com/20974004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215221 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/common/extensions/docs/examples/extensions/buildbot/bg.js | 9 | ||||
| -rw-r--r-- | chrome/common/extensions/docs/examples/extensions/buildbot/manifest.json | 2 |
2 files changed, 8 insertions, 3 deletions
diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js b/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js index cff9f8e..a351678 100644 --- a/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js +++ b/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js @@ -176,7 +176,9 @@ function fetchPatches(issue, updatedCallback) { issue.full_patchsets[patch.patchset] = patch; - // TODO(wittman): Revise to reduce load on the try servers. + // TODO(wittman): Revise to reduce load on the try servers. Repeatedly + // loading old try results increases the size of the working set of try + // jobs on the try servers, causing them to become disk-bound. // patch.try_job_results.forEach(function(results) { // if (results.buildnumber) { // tryJobResultsOutstanding++; @@ -189,8 +191,11 @@ function fetchPatches(issue, updatedCallback) { // } // }); - if (++patchsetsRetrieved == issue.patchsets.length) + if (++patchsetsRetrieved == issue.patchsets.length) { updatedCallback(PATCHES_COMPLETE); + // TODO(wittman): Remove once we revise the try job fetching code. + updatedCallback(TRY_JOBS_COMPLETE); + } }); }); } diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/manifest.json b/chrome/common/extensions/docs/examples/extensions/buildbot/manifest.json index 3b0819a..1c1f5e0 100644 --- a/chrome/common/extensions/docs/examples/extensions/buildbot/manifest.json +++ b/chrome/common/extensions/docs/examples/extensions/buildbot/manifest.json @@ -1,6 +1,6 @@ { "name": "Chromium Buildbot Monitor", - "version": "0.8.3", + "version": "0.8.4", "description": "Displays the status of the Chromium buildbot in the toolbar. Click to see more detailed status in a popup.", "icons": { "128": "icon.png" }, "background": { |