diff options
author | groby <groby@chromium.org> | 2015-04-13 19:10:27 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-14 02:10:53 +0000 |
commit | 4403f23ba5eb4ff2b943b909a183965cc715ecbe (patch) | |
tree | 475f19a07fcda97208bbee2e5ab24ebacbada5be | |
parent | 44bacf3b85380d0466ea46ea5ab5fbb3d043e5b3 (diff) | |
download | chromium_src-4403f23ba5eb4ff2b943b909a183965cc715ecbe.zip chromium_src-4403f23ba5eb4ff2b943b909a183965cc715ecbe.tar.gz chromium_src-4403f23ba5eb4ff2b943b909a183965cc715ecbe.tar.bz2 |
Fix profiler.js to return valid source links
Profiler links used to rely on chromesrc.appspot.com - a custom server
to map file names/lines to a valid source link. That server seems dead
or non-working, so replacing this with a search on cs.chromium.org
In the vast majority of cases, that search has only one result and
directly shows the code. In ambiguous cases, it displays search
results.
BUG=257108
R=eroman@chromium.org
Review URL: https://codereview.chromium.org/1082963003
Cr-Commit-Position: refs/heads/master@{#324989}
-rw-r--r-- | chrome/browser/resources/profiler/profiler.js | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/chrome/browser/resources/profiler/profiler.js b/chrome/browser/resources/profiler/profiler.js index 9095872..fd7a65b 100644 --- a/chrome/browser/resources/profiler/profiler.js +++ b/chrome/browser/resources/profiler/profiler.js @@ -1070,12 +1070,10 @@ var MainView = (function() { var linenumber = m[2]; var link = addNode(td, 'a', filename + ' [' + linenumber + ']'); - // http://chromesrc.appspot.com is a server I wrote specifically for - // this task. It redirects to the appropriate source file; the file - // paths given by the compiler can be pretty crazy and different - // between platforms. - link.href = 'http://chromesrc.appspot.com/?path=' + - encodeURIComponent(filepath) + '&line=' + linenumber; + + link.href = 'https://code.google.com/p/chromium/codesearch#search/&q=' + + encodeURIComponent(filename) + ':' + linenumber + + '&sq=package:chromium&type=cs'; link.target = '_blank'; return; } |