summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormmenke <mmenke@chromium.org>2015-09-11 13:42:27 -0700
committerCommit bot <commit-bot@chromium.org>2015-09-11 20:43:11 +0000
commit468be2ff331c13b1a081d10a3c17e5366d26e577 (patch)
treecee2dbcb52ab7a5af00b531b8e614255a88c7ba6
parent7c54a1d92f5d20997f58cdc70bd5b51a4a77efee (diff)
downloadchromium_src-468be2ff331c13b1a081d10a3c17e5366d26e577.zip
chromium_src-468be2ff331c13b1a081d10a3c17e5366d26e577.tar.gz
chromium_src-468be2ff331c13b1a081d10a3c17e5366d26e577.tar.bz2
Remove reference counting from HttpNetworkSession.
This makes lifetime cleaner, and helps us avoid the case where an HttpNetworkSession outlives the components it points to. Also remove some weird uses a null NetLog in GCM. TBR=sgurun@chromium.org,davidben@chromium.org,droger@chromium.org BUG=515947 Review URL: https://codereview.chromium.org/1298253002 Cr-Commit-Position: refs/heads/master@{#348483}
-rw-r--r--android_webview/browser/net/aw_url_request_context_getter.cc19
-rw-r--r--android_webview/browser/net/aw_url_request_context_getter.h8
-rw-r--r--chrome/browser/io_thread.cc12
-rw-r--r--chrome/browser/io_thread.h4
-rw-r--r--chrome/browser/profiles/off_the_record_profile_io_data.cc8
-rw-r--r--chrome/browser/profiles/off_the_record_profile_io_data.h2
-rw-r--r--chrome/browser/profiles/profile_impl_io_data.cc21
-rw-r--r--chrome/browser/profiles/profile_impl_io_data.h2
-rw-r--r--chrome/browser/profiles/profile_io_data.cc23
-rw-r--r--chrome/browser/profiles/profile_io_data.h7
-rw-r--r--components/gcm_driver/gcm_client.h5
-rw-r--r--components/gcm_driver/gcm_client_impl.cc12
-rw-r--r--components/gcm_driver/gcm_client_impl.h10
-rw-r--r--components/gcm_driver/gcm_client_impl_unittest.cc10
-rw-r--r--content/shell/browser/shell_url_request_context_getter.cc5
-rw-r--r--google_apis/gcm/engine/connection_factory_impl.cc15
-rw-r--r--google_apis/gcm/engine/connection_factory_impl.h13
-rw-r--r--google_apis/gcm/tools/mcs_probe.cc6
-rw-r--r--ios/crnet/crnet_environment.mm7
-rw-r--r--ios/web/shell/shell_url_request_context_getter.cc5
-rw-r--r--jingle/glue/proxy_resolving_client_socket.cc2
-rw-r--r--jingle/glue/proxy_resolving_client_socket.h2
-rw-r--r--net/cert_net/cert_net_fetcher_impl_unittest.cc7
-rw-r--r--net/http/http_cache.cc38
-rw-r--r--net/http/http_cache.h17
-rw-r--r--net/http/http_network_layer.cc24
-rw-r--r--net/http/http_network_layer.h13
-rw-r--r--net/http/http_network_layer_unittest.cc4
-rw-r--r--net/http/http_network_session.h7
-rw-r--r--net/http/http_network_session_peer.cc3
-rw-r--r--net/http/http_network_session_peer.h6
-rw-r--r--net/http/http_network_transaction_ssl_unittest.cc2
-rw-r--r--net/http/http_network_transaction_unittest.cc392
-rw-r--r--net/http/http_proxy_client_socket_pool_unittest.cc4
-rw-r--r--net/http/http_response_body_drainer_unittest.cc2
-rw-r--r--net/http/http_stream_factory_impl_request_unittest.cc4
-rw-r--r--net/http/http_stream_factory_impl_unittest.cc58
-rw-r--r--net/http/mock_http_cache.cc7
-rw-r--r--net/proxy/proxy_script_fetcher_impl_unittest.cc9
-rw-r--r--net/quic/quic_end_to_end_unittest.cc4
-rw-r--r--net/quic/quic_network_transaction_unittest.cc4
-rw-r--r--net/socket/ssl_client_socket_pool_unittest.cc6
-rw-r--r--net/spdy/spdy_http_stream_unittest.cc5
-rw-r--r--net/spdy/spdy_network_transaction_unittest.cc91
-rw-r--r--net/spdy/spdy_proxy_client_socket_unittest.cc8
-rw-r--r--net/spdy/spdy_session_pool_unittest.cc28
-rw-r--r--net/spdy/spdy_session_unittest.cc16
-rw-r--r--net/spdy/spdy_stream_unittest.cc4
-rw-r--r--net/spdy/spdy_test_util_common.cc33
-rw-r--r--net/spdy/spdy_test_util_common.h10
-rw-r--r--net/url_request/url_request_context_builder.cc17
-rw-r--r--net/url_request/url_request_context_storage.cc5
-rw-r--r--net/url_request/url_request_context_storage.h13
-rw-r--r--net/url_request/url_request_test_util.cc8
-rw-r--r--net/url_request/url_request_unittest.cc11
-rw-r--r--net/url_request/view_cache_helper_unittest.cc6
56 files changed, 542 insertions, 522 deletions
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index def5f81..f54103c 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -182,11 +182,10 @@ AwURLRequestContextGetter::AwURLRequestContextGetter(
const base::FilePath& cache_path, net::CookieStore* cookie_store,
scoped_ptr<net::ProxyConfigService> config_service)
: cache_path_(cache_path),
+ net_log_(new net::NetLog()),
+ proxy_config_service_(config_service.Pass()),
cookie_store_(cookie_store),
- net_log_(new net::NetLog()) {
- proxy_config_service_ = config_service.Pass();
- http_user_agent_settings_.reset(
- new AwHttpUserAgentSettings());
+ http_user_agent_settings_(new AwHttpUserAgentSettings()) {
// CreateSystemProxyConfigService for Android must be called on main thread.
DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
@@ -231,17 +230,19 @@ void AwURLRequestContextGetter::InitializeURLRequestContext() {
PopulateNetworkSessionParams(url_request_context_.get(),
&network_session_params);
- net::HttpCache* main_cache = new net::HttpCache(
- network_session_params,
+ http_network_session_.reset(
+ new net::HttpNetworkSession(network_session_params));
+ main_http_factory_.reset(new net::HttpCache(
+ http_network_session_.get(),
new net::HttpCache::DefaultBackend(
net::DISK_CACHE,
net::CACHE_BACKEND_SIMPLE,
cache_path_,
20 * 1024 * 1024, // 20M
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)),
+ true /* set_up_quic_server_info */));
- main_http_factory_.reset(main_cache);
- url_request_context_->set_http_transaction_factory(main_cache);
+ url_request_context_->set_http_transaction_factory(main_http_factory_.get());
job_factory_ = CreateJobFactory(&protocol_handlers_,
request_interceptors_.Pass());
diff --git a/android_webview/browser/net/aw_url_request_context_getter.h b/android_webview/browser/net/aw_url_request_context_getter.h
index a7713fe..868a670 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.h
+++ b/android_webview/browser/net/aw_url_request_context_getter.h
@@ -65,13 +65,15 @@ class AwURLRequestContextGetter : public net::URLRequestContextGetter {
void InitializeURLRequestContext();
const base::FilePath cache_path_;
- scoped_refptr<net::CookieStore> cookie_store_;
+
scoped_ptr<net::NetLog> net_log_;
- scoped_ptr<net::URLRequestContext> url_request_context_;
scoped_ptr<net::ProxyConfigService> proxy_config_service_;
- scoped_ptr<net::URLRequestJobFactory> job_factory_;
+ scoped_ptr<net::HttpNetworkSession> http_network_session_;
scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
+ scoped_refptr<net::CookieStore> cookie_store_;
+ scoped_ptr<net::URLRequestJobFactory> job_factory_;
scoped_ptr<net::HttpUserAgentSettings> http_user_agent_settings_;
+ scoped_ptr<net::URLRequestContext> url_request_context_;
// ProtocolHandlers and interceptors are stored here between
// SetHandlersAndInterceptors() and the first GetURLRequestContext() call.
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 9ba5e1c..987a0c3 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -70,6 +70,7 @@
#include "net/http/http_auth_filter.h"
#include "net/http/http_auth_handler_factory.h"
#include "net/http/http_network_layer.h"
+#include "net/http/http_network_session.h"
#include "net/http/http_server_properties_impl.h"
#include "net/proxy/proxy_config_service.h"
#include "net/proxy/proxy_script_fetcher_impl.h"
@@ -1493,8 +1494,10 @@ net::URLRequestContext* IOThread::ConstructSystemRequestContext(
net::URLRequestContextBuilder::SetHttpNetworkSessionComponents(
context, &system_params);
+ globals->system_http_network_session.reset(
+ new net::HttpNetworkSession(system_params));
globals->system_http_transaction_factory.reset(
- new net::HttpNetworkLayer(new net::HttpNetworkSession(system_params)));
+ new net::HttpNetworkLayer(globals->system_http_network_session.get()));
context->set_http_transaction_factory(
globals->system_http_transaction_factory.get());
@@ -1544,15 +1547,16 @@ net::URLRequestContext* IOThread::ConstructProxyScriptFetcherContext(
tracked_objects::ScopedTracker tracking_profile2(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"466432 IOThread::ConstructProxyScriptFetcherContext2"));
- scoped_refptr<net::HttpNetworkSession> network_session(
+ globals->proxy_script_fetcher_http_network_session.reset(
new net::HttpNetworkSession(session_params));
// TODO(erikchen): Remove ScopedTracker below once http://crbug.com/466432
// is fixed.
tracked_objects::ScopedTracker tracking_profile3(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"466432 IOThread::ConstructProxyScriptFetcherContext3"));
- globals->proxy_script_fetcher_http_transaction_factory
- .reset(new net::HttpNetworkLayer(network_session.get()));
+ globals->proxy_script_fetcher_http_transaction_factory.reset(
+ new net::HttpNetworkLayer(
+ globals->proxy_script_fetcher_http_network_session.get()));
context->set_http_transaction_factory(
globals->proxy_script_fetcher_http_transaction_factory.get());
diff --git a/chrome/browser/io_thread.h b/chrome/browser/io_thread.h
index cc943df..21b57d3 100644
--- a/chrome/browser/io_thread.h
+++ b/chrome/browser/io_thread.h
@@ -54,6 +54,7 @@ class FtpTransactionFactory;
class HostMappingRules;
class HostResolver;
class HttpAuthHandlerFactory;
+class HttpNetworkSession;
class HttpServerProperties;
class HttpTransactionFactory;
class HttpUserAgentSettings;
@@ -135,6 +136,8 @@ class IOThread : public content::BrowserThreadDelegate {
scoped_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory;
scoped_ptr<net::HttpServerProperties> http_server_properties;
scoped_ptr<net::ProxyService> proxy_script_fetcher_proxy_service;
+ scoped_ptr<net::HttpNetworkSession>
+ proxy_script_fetcher_http_network_session;
scoped_ptr<net::HttpTransactionFactory>
proxy_script_fetcher_http_transaction_factory;
scoped_ptr<net::FtpTransactionFactory>
@@ -151,6 +154,7 @@ class IOThread : public content::BrowserThreadDelegate {
// ProxyService, since we always directly connect to fetch the PAC script.
scoped_ptr<net::URLRequestContext> proxy_script_fetcher_context;
scoped_ptr<net::ProxyService> system_proxy_service;
+ scoped_ptr<net::HttpNetworkSession> system_http_network_session;
scoped_ptr<net::HttpTransactionFactory> system_http_transaction_factory;
scoped_ptr<net::URLRequestJobFactory> system_url_request_job_factory;
scoped_ptr<net::URLRequestContext> system_request_context;
diff --git a/chrome/browser/profiles/off_the_record_profile_io_data.cc b/chrome/browser/profiles/off_the_record_profile_io_data.cc
index 85a30f5..015924d8 100644
--- a/chrome/browser/profiles/off_the_record_profile_io_data.cc
+++ b/chrome/browser/profiles/off_the_record_profile_io_data.cc
@@ -249,7 +249,9 @@ void OffTheRecordProfileIOData::InitializeInternal(
net::HttpCache::BackendFactory* main_backend =
net::HttpCache::DefaultBackend::InMemory(0);
- main_http_factory_ = CreateMainHttpFactory(profile_params, main_backend);
+ http_network_session_ = CreateHttpNetworkSession(*profile_params);
+ main_http_factory_ = CreateMainHttpFactory(http_network_session_.get(),
+ main_backend);
main_context->set_http_transaction_factory(main_http_factory_.get());
#if !defined(DISABLE_FTP_SUPPORT)
@@ -348,10 +350,8 @@ net::URLRequestContext* OffTheRecordProfileIOData::InitializeAppRequestContext(
// Use a separate in-memory cache for the app.
net::HttpCache::BackendFactory* app_backend =
net::HttpCache::DefaultBackend::InMemory(0);
- net::HttpNetworkSession* main_network_session =
- main_http_factory_->GetSession();
scoped_ptr<net::HttpCache> app_http_cache =
- CreateHttpFactory(main_network_session, app_backend);
+ CreateHttpFactory(http_network_session_.get(), app_backend);
context->SetHttpTransactionFactory(app_http_cache.Pass());
diff --git a/chrome/browser/profiles/off_the_record_profile_io_data.h b/chrome/browser/profiles/off_the_record_profile_io_data.h
index f1cd12e..ae229bd 100644
--- a/chrome/browser/profiles/off_the_record_profile_io_data.h
+++ b/chrome/browser/profiles/off_the_record_profile_io_data.h
@@ -20,6 +20,7 @@ class Profile;
namespace net {
class FtpTransactionFactory;
+class HttpNetworkSession;
class HttpTransactionFactory;
class SdchManager;
class SdchOwner;
@@ -144,6 +145,7 @@ class OffTheRecordProfileIOData : public ProfileIOData {
mutable scoped_ptr<ChromeNetworkDelegate> network_delegate_;
+ mutable scoped_ptr<net::HttpNetworkSession> http_network_session_;
mutable scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
mutable scoped_ptr<net::FtpTransactionFactory> ftp_factory_;
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index b45a287..b3c8748 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -57,6 +57,7 @@
#include "net/base/sdch_manager.h"
#include "net/ftp/ftp_network_layer.h"
#include "net/http/http_cache.h"
+#include "net/http/http_network_session.h"
#include "net/http/http_server_properties_manager.h"
#include "net/sdch/sdch_owner.h"
#include "net/ssl/channel_id_service.h"
@@ -537,22 +538,22 @@ void ProfileImplIOData::InitializeInternal(
set_channel_id_service(channel_id_service);
main_context->set_channel_id_service(channel_id_service);
- scoped_ptr<net::HttpCache> main_cache;
{
// TODO(ttuttle): Remove ScopedTracker below once crbug.com/436671 is fixed.
tracked_objects::ScopedTracker tracking_profile(
FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 HttpCache construction"));
- net::HttpCache::DefaultBackend* main_backend =
+ net::HttpCache::BackendFactory* main_backend(
new net::HttpCache::DefaultBackend(
net::DISK_CACHE,
ChooseCacheBackendType(),
lazy_params_->cache_path,
lazy_params_->cache_max_size,
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
- main_cache = CreateMainHttpFactory(profile_params, main_backend);
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
+ http_network_session_ = CreateHttpNetworkSession(*profile_params);
+ main_http_factory_ = CreateMainHttpFactory(http_network_session_.get(),
+ main_backend);
}
- main_http_factory_.reset(main_cache.release());
main_context->set_http_transaction_factory(main_http_factory_.get());
#if !defined(DISABLE_FTP_SUPPORT)
@@ -664,7 +665,7 @@ net::URLRequestContext* ProfileImplIOData::InitializeAppRequestContext(
partition_descriptor.path.Append(chrome::kCacheDirname);
// Use a separate HTTP disk cache for isolated apps.
- net::HttpCache::BackendFactory* app_backend = NULL;
+ net::HttpCache::BackendFactory* app_backend;
if (partition_descriptor.in_memory) {
app_backend = net::HttpCache::DefaultBackend::InMemory(0);
} else {
@@ -675,10 +676,8 @@ net::URLRequestContext* ProfileImplIOData::InitializeAppRequestContext(
app_cache_max_size_,
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
}
- net::HttpNetworkSession* main_network_session =
- main_http_factory_->GetSession();
scoped_ptr<net::HttpCache> app_http_cache =
- CreateHttpFactory(main_network_session, app_backend);
+ CreateHttpFactory(http_network_session_.get(), app_backend);
scoped_refptr<net::CookieStore> cookie_store = NULL;
if (partition_descriptor.in_memory) {
@@ -758,10 +757,8 @@ ProfileImplIOData::InitializeMediaRequestContext(
cache_path,
cache_max_size,
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
- net::HttpNetworkSession* main_network_session =
- main_http_factory_->GetSession();
scoped_ptr<net::HttpCache> media_http_cache =
- CreateHttpFactory(main_network_session, media_backend);
+ CreateHttpFactory(http_network_session_.get(), media_backend);
// Transfer ownership of the cache to MediaRequestContext.
context->SetHttpTransactionFactory(media_http_cache.Pass());
diff --git a/chrome/browser/profiles/profile_impl_io_data.h b/chrome/browser/profiles/profile_impl_io_data.h
index 214ec74..e8046fc 100644
--- a/chrome/browser/profiles/profile_impl_io_data.h
+++ b/chrome/browser/profiles/profile_impl_io_data.h
@@ -32,6 +32,7 @@ class DomainReliabilityMonitor;
namespace net {
class CookieCryptoDelegate;
class FtpTransactionFactory;
+class HttpNetworkSession;
class HttpServerProperties;
class HttpServerPropertiesManager;
class HttpTransactionFactory;
@@ -215,6 +216,7 @@ class ProfileImplIOData : public ProfileIOData {
mutable scoped_refptr<JsonPrefStore> network_json_store_;
+ mutable scoped_ptr<net::HttpNetworkSession> http_network_session_;
mutable scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
mutable scoped_ptr<net::FtpTransactionFactory> ftp_factory_;
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 6c78ef5..7eb4da2 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -66,6 +66,7 @@
#include "net/base/network_quality_estimator.h"
#include "net/cert/cert_verifier.h"
#include "net/cookies/canonical_cookie.h"
+#include "net/http/http_network_session.h"
#include "net/http/http_transaction_factory.h"
#include "net/http/http_util.h"
#include "net/http/transport_security_persister.h"
@@ -1301,13 +1302,12 @@ void ProfileIOData::DestroyResourceContext() {
resource_context_.reset();
}
-scoped_ptr<net::HttpCache> ProfileIOData::CreateMainHttpFactory(
- const ProfileParams* profile_params,
- net::HttpCache::BackendFactory* main_backend) const {
+scoped_ptr<net::HttpNetworkSession> ProfileIOData::CreateHttpNetworkSession(
+ const ProfileParams& profile_params) const {
net::HttpNetworkSession::Params params;
net::URLRequestContext* context = main_request_context();
- IOThread* const io_thread = profile_params->io_thread;
+ IOThread* const io_thread = profile_params.io_thread;
io_thread->InitializeNetworkSessionParams(&params);
net::URLRequestContextBuilder::SetHttpNetworkSessionComponents(context,
@@ -1321,11 +1321,19 @@ scoped_ptr<net::HttpCache> ProfileIOData::CreateMainHttpFactory(
if (data_reduction_proxy_io_data_.get())
params.proxy_delegate = data_reduction_proxy_io_data_->proxy_delegate();
- net::HttpNetworkSession* session = new net::HttpNetworkSession(params);
+ return scoped_ptr<net::HttpNetworkSession>(
+ new net::HttpNetworkSession(params));
+}
+
+scoped_ptr<net::HttpCache> ProfileIOData::CreateMainHttpFactory(
+ net::HttpNetworkSession* session,
+ net::HttpCache::BackendFactory* main_backend) const {
+ net::URLRequestContext* context = main_request_context();
return scoped_ptr<net::HttpCache>(new net::HttpCache(
new DevToolsNetworkTransactionFactory(
network_controller_handle_.GetController(), session),
- context->net_log(), main_backend));
+ context->net_log(), main_backend,
+ true /* set_up_quic_server_info */));
}
scoped_ptr<net::HttpCache> ProfileIOData::CreateHttpFactory(
@@ -1334,7 +1342,8 @@ scoped_ptr<net::HttpCache> ProfileIOData::CreateHttpFactory(
return scoped_ptr<net::HttpCache>(new net::HttpCache(
new DevToolsNetworkTransactionFactory(
network_controller_handle_.GetController(), shared_session),
- shared_session->net_log(), backend));
+ shared_session->net_log(), backend,
+ true /* set_up_quic_server_info */));
}
void ProfileIOData::SetCookieSettingsForTesting(
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index d90f71e..f395307 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -383,9 +383,12 @@ class ProfileIOData {
// URLRequests may be accessing.
void DestroyResourceContext();
- // Creates network session and main network transaction factory.
+ scoped_ptr<net::HttpNetworkSession> CreateHttpNetworkSession(
+ const ProfileParams& profile_params) const;
+
+ // Creates main network transaction factory.
scoped_ptr<net::HttpCache> CreateMainHttpFactory(
- const ProfileParams* profile_params,
+ net::HttpNetworkSession* session,
net::HttpCache::BackendFactory* main_backend) const;
// Creates network transaction factory.
diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h
index 0aa9a1a..5f7f293 100644
--- a/components/gcm_driver/gcm_client.h
+++ b/components/gcm_driver/gcm_client.h
@@ -217,9 +217,10 @@ class GCMClient {
// |chrome_build_info|: chrome info, i.e., version, channel and etc.
// |store_path|: path to the GCM store.
// |blocking_task_runner|: for running blocking file tasks.
- // |url_request_context_getter|: for url requests.
+ // |url_request_context_getter|: for url requests. The GCMClient must be
+ // deleted before the Getter's underlying URLRequestContext.
// |delegate|: the delegate whose methods will be called asynchronously in
- // response to events and messages.
+ // response to events and messages.
virtual void Initialize(
const ChromeBuildInfo& chrome_build_info,
const base::FilePath& store_path,
diff --git a/components/gcm_driver/gcm_client_impl.cc b/components/gcm_driver/gcm_client_impl.cc
index 1a95809..b0f298f 100644
--- a/components/gcm_driver/gcm_client_impl.cc
+++ b/components/gcm_driver/gcm_client_impl.cc
@@ -255,16 +255,15 @@ scoped_ptr<MCSClient> GCMInternalsBuilder::BuildMCSClient(
scoped_ptr<ConnectionFactory> GCMInternalsBuilder::BuildConnectionFactory(
const std::vector<GURL>& endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
- net::NetLog* net_log,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
GCMStatsRecorder* recorder) {
return make_scoped_ptr<ConnectionFactory>(
new ConnectionFactoryImpl(endpoints,
backoff_policy,
gcm_network_session,
http_network_session,
- net_log,
+ nullptr,
recorder));
}
@@ -326,7 +325,7 @@ void GCMClientImpl::Initialize(
url_request_context_getter_->GetURLRequestContext()->
GetNetworkSessionParams();
DCHECK(network_session_params);
- network_session_ = new net::HttpNetworkSession(*network_session_params);
+ network_session_.reset(new net::HttpNetworkSession(*network_session_params));
chrome_build_info_ = chrome_build_info;
@@ -483,11 +482,10 @@ void GCMClientImpl::InitializeMCSClient() {
connection_factory_ = internals_builder_->BuildConnectionFactory(
endpoints,
GetGCMBackoffPolicy(),
- network_session_,
+ network_session_.get(),
url_request_context_getter_->GetURLRequestContext()
->http_transaction_factory()
->GetSession(),
- net_log_.net_log(),
&recorder_);
connection_factory_->SetConnectionListener(this);
mcs_client_ = internals_builder_->BuildMCSClient(
diff --git a/components/gcm_driver/gcm_client_impl.h b/components/gcm_driver/gcm_client_impl.h
index 2542c68..176ee78 100644
--- a/components/gcm_driver/gcm_client_impl.h
+++ b/components/gcm_driver/gcm_client_impl.h
@@ -26,7 +26,6 @@
#include "google_apis/gcm/engine/unregistration_request.h"
#include "google_apis/gcm/protocol/android_checkin.pb.h"
#include "google_apis/gcm/protocol/checkin.pb.h"
-#include "net/log/net_log.h"
#include "net/url_request/url_request_context_getter.h"
class GURL;
@@ -67,9 +66,8 @@ class GCMInternalsBuilder {
virtual scoped_ptr<ConnectionFactory> BuildConnectionFactory(
const std::vector<GURL>& endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
- net::NetLog* net_log,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
GCMStatsRecorder* recorder);
};
@@ -336,12 +334,12 @@ class GCMClientImpl
// resetting and loading from the store again and again.
bool gcm_store_reset_;
- scoped_refptr<net::HttpNetworkSession> network_session_;
- net::BoundNetLog net_log_;
+ scoped_ptr<net::HttpNetworkSession> network_session_;
scoped_ptr<ConnectionFactory> connection_factory_;
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
// Controls receiving and sending of packets and reliable message queueing.
+ // Must be destroyed before |network_session_|.
scoped_ptr<MCSClient> mcs_client_;
scoped_ptr<CheckinRequest> checkin_request_;
diff --git a/components/gcm_driver/gcm_client_impl_unittest.cc b/components/gcm_driver/gcm_client_impl_unittest.cc
index 3fbb2e7..1befe0b 100644
--- a/components/gcm_driver/gcm_client_impl_unittest.cc
+++ b/components/gcm_driver/gcm_client_impl_unittest.cc
@@ -200,9 +200,8 @@ class FakeGCMInternalsBuilder : public GCMInternalsBuilder {
scoped_ptr<ConnectionFactory> BuildConnectionFactory(
const std::vector<GURL>& endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
- net::NetLog* net_log,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
GCMStatsRecorder* recorder) override;
private:
@@ -234,9 +233,8 @@ scoped_ptr<MCSClient> FakeGCMInternalsBuilder::BuildMCSClient(
scoped_ptr<ConnectionFactory> FakeGCMInternalsBuilder::BuildConnectionFactory(
const std::vector<GURL>& endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
- net::NetLog* net_log,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
GCMStatsRecorder* recorder) {
return make_scoped_ptr<ConnectionFactory>(new FakeConnectionFactory());
}
diff --git a/content/shell/browser/shell_url_request_context_getter.cc b/content/shell/browser/shell_url_request_context_getter.cc
index 6554e05..bbea904 100644
--- a/content/shell/browser/shell_url_request_context_getter.cc
+++ b/content/shell/browser/shell_url_request_context_getter.cc
@@ -199,8 +199,11 @@ net::URLRequestContext* ShellURLRequestContextGetter::GetURLRequestContext() {
network_session_params.host_resolver =
url_request_context_->host_resolver();
+ storage_->set_http_network_session(
+ make_scoped_ptr(new net::HttpNetworkSession(network_session_params)));
net::HttpCache* main_cache = new net::HttpCache(
- network_session_params, main_backend);
+ storage_->http_network_session(), main_backend,
+ true /* set_up_quic_server_info */);
storage_->set_http_transaction_factory(main_cache);
scoped_ptr<net::URLRequestJobFactoryImpl> job_factory(
diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc
index 4c4f279..19f456c 100644
--- a/google_apis/gcm/engine/connection_factory_impl.cc
+++ b/google_apis/gcm/engine/connection_factory_impl.cc
@@ -16,6 +16,7 @@
#include "net/base/net_errors.h"
#include "net/http/http_network_session.h"
#include "net/http/http_request_headers.h"
+#include "net/log/net_log.h"
#include "net/proxy/proxy_info.h"
#include "net/socket/client_socket_handle.h"
#include "net/socket/client_socket_pool_manager.h"
@@ -47,8 +48,8 @@ bool ShouldRestorePreviousBackoff(const base::TimeTicks& login_time,
ConnectionFactoryImpl::ConnectionFactoryImpl(
const std::vector<GURL>& mcs_endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
net::NetLog* net_log,
GCMStatsRecorder* recorder)
: mcs_endpoints_(mcs_endpoints),
@@ -68,8 +69,8 @@ ConnectionFactoryImpl::ConnectionFactoryImpl(
listener_(NULL),
weak_ptr_factory_(this) {
DCHECK_GE(mcs_endpoints_.size(), 1U);
- DCHECK(!http_network_session_.get() ||
- (gcm_network_session_.get() != http_network_session_.get()));
+ DCHECK(!http_network_session_ ||
+ (gcm_network_session_ != http_network_session_));
}
ConnectionFactoryImpl::~ConnectionFactoryImpl() {
@@ -457,7 +458,7 @@ void ConnectionFactoryImpl::OnProxyResolveDone(int status) {
gcm_network_session_->ssl_config_service()->GetSSLConfig(&ssl_config);
status = net::InitSocketHandleForTlsConnect(
net::HostPortPair::FromURL(GetCurrentEndpoint()),
- gcm_network_session_.get(),
+ gcm_network_session_,
proxy_info_,
ssl_config,
ssl_config,
@@ -558,7 +559,7 @@ int ConnectionFactoryImpl::ReconsiderProxyAfterError(int error) {
}
void ConnectionFactoryImpl::ReportSuccessfulProxyConnection() {
- if (gcm_network_session_.get() && gcm_network_session_->proxy_service())
+ if (gcm_network_session_ && gcm_network_session_->proxy_service())
gcm_network_session_->proxy_service()->ReportSuccess(proxy_info_, NULL);
}
@@ -574,7 +575,7 @@ void ConnectionFactoryImpl::CloseSocket() {
}
void ConnectionFactoryImpl::RebuildNetworkSessionAuthCache() {
- if (!http_network_session_.get() || !http_network_session_->http_auth_cache())
+ if (!http_network_session_ || !http_network_session_->http_auth_cache())
return;
gcm_network_session_->http_auth_cache()->UpdateAllFrom(
diff --git a/google_apis/gcm/engine/connection_factory_impl.h b/google_apis/gcm/engine/connection_factory_impl.h
index d979208..a07de12 100644
--- a/google_apis/gcm/engine/connection_factory_impl.h
+++ b/google_apis/gcm/engine/connection_factory_impl.h
@@ -36,11 +36,14 @@ class GCM_EXPORT ConnectionFactoryImpl :
// for proxy auth credentials (via its HttpAuthCache). |gcm_network_session|
// is the network session through which GCM connections should be made, and
// must not be the same as |http_network_session|.
+ //
+ // The caller is responsible for making sure the ConnectionFactoryImpl is
+ // destroyed before the |gcm_network_session| and |http_network_session|.
ConnectionFactoryImpl(
const std::vector<GURL>& mcs_endpoints,
const net::BackoffEntry::Policy& backoff_policy,
- const scoped_refptr<net::HttpNetworkSession>& gcm_network_session,
- const scoped_refptr<net::HttpNetworkSession>& http_network_session,
+ net::HttpNetworkSession* gcm_network_session,
+ net::HttpNetworkSession* http_network_session,
net::NetLog* net_log,
GCMStatsRecorder* recorder);
~ConnectionFactoryImpl() override;
@@ -135,10 +138,10 @@ class GCM_EXPORT ConnectionFactoryImpl :
// ---- net:: components for establishing connections. ----
// Network session for creating new GCM connections.
- const scoped_refptr<net::HttpNetworkSession> gcm_network_session_;
+ net::HttpNetworkSession* gcm_network_session_;
// HTTP Network session. If set, is used for extracting proxy auth
- // credentials. If not set, is ignored.
- const scoped_refptr<net::HttpNetworkSession> http_network_session_;
+ // credentials. If nullptr, is ignored.
+ net::HttpNetworkSession* http_network_session_;
// Net log to use in connection attempts.
net::BoundNetLog bound_net_log_;
// The current PAC request, if one exists. Owned by the proxy service.
diff --git a/google_apis/gcm/tools/mcs_probe.cc b/google_apis/gcm/tools/mcs_probe.cc
index 9d0881b..1ee66d9 100644
--- a/google_apis/gcm/tools/mcs_probe.cc
+++ b/google_apis/gcm/tools/mcs_probe.cc
@@ -229,7 +229,7 @@ class MCSProbe {
scoped_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory_;
scoped_ptr<net::HttpServerPropertiesImpl> http_server_properties_;
scoped_ptr<net::HostMappingRules> host_mapping_rules_;
- scoped_refptr<net::HttpNetworkSession> network_session_;
+ scoped_ptr<net::HttpNetworkSession> network_session_;
scoped_ptr<net::ProxyService> proxy_service_;
FakeGCMStatsRecorder recorder_;
@@ -293,7 +293,7 @@ void MCSProbe::Start() {
connection_factory_.reset(
new ConnectionFactoryImpl(endpoints,
kDefaultBackoffPolicy,
- network_session_,
+ network_session_.get(),
NULL,
&net_log_,
&recorder_));
@@ -403,7 +403,7 @@ void MCSProbe::BuildNetworkSession() {
session_params.net_log = &net_log_;
session_params.proxy_service = proxy_service_.get();
- network_session_ = new net::HttpNetworkSession(session_params);
+ network_session_.reset(new net::HttpNetworkSession(session_params));
}
void MCSProbe::ErrorCallback() {
diff --git a/ios/crnet/crnet_environment.mm b/ios/crnet/crnet_environment.mm
index 3eb873a..516d2e8 100644
--- a/ios/crnet/crnet_environment.mm
+++ b/ios/crnet/crnet_environment.mm
@@ -446,7 +446,12 @@ void CrNetEnvironment::InitializeOnNetworkThread() {
base::WorkerPool::GetTaskRunner(true));
}
- net::HttpCache* main_cache = new net::HttpCache(params, main_backend);
+ // TODO(mmenke): These really shouldn't be leaked.
+ // See https://crbug.com/523858.
+ net::HttpNetworkSession* http_network_session =
+ new net::HttpNetworkSession(params);
+ net::HttpCache* main_cache = new net::HttpCache(
+ http_network_session, main_backend, true /* set_up_quic_server_info */);
main_context_->set_http_transaction_factory(main_cache);
// Cookies
diff --git a/ios/web/shell/shell_url_request_context_getter.cc b/ios/web/shell/shell_url_request_context_getter.cc
index 5d8c660..9cd2d10 100644
--- a/ios/web/shell/shell_url_request_context_getter.cc
+++ b/ios/web/shell/shell_url_request_context_getter.cc
@@ -135,8 +135,11 @@ net::URLRequestContext* ShellURLRequestContextGetter::GetURLRequestContext() {
net::CACHE_BACKEND_DEFAULT,
cache_path, 0, cache_task_runner_);
+ storage_->set_http_network_session(
+ make_scoped_ptr(new net::HttpNetworkSession(network_session_params)));
net::HttpCache* main_cache =
- new net::HttpCache(network_session_params, main_backend);
+ new net::HttpCache(storage_->http_network_session(), main_backend,
+ true /* set_up_quic_server_info */);
storage_->set_http_transaction_factory(main_cache);
scoped_ptr<net::URLRequestJobFactoryImpl> job_factory(
diff --git a/jingle/glue/proxy_resolving_client_socket.cc b/jingle/glue/proxy_resolving_client_socket.cc
index 1fdb3ea..e71f362 100644
--- a/jingle/glue/proxy_resolving_client_socket.cc
+++ b/jingle/glue/proxy_resolving_client_socket.cc
@@ -90,7 +90,7 @@ ProxyResolvingClientSocket::ProxyResolvingClientSocket(
reference_params->use_alternative_services;
}
- network_session_ = new net::HttpNetworkSession(session_params);
+ network_session_.reset(new net::HttpNetworkSession(session_params));
}
ProxyResolvingClientSocket::~ProxyResolvingClientSocket() {
diff --git a/jingle/glue/proxy_resolving_client_socket.h b/jingle/glue/proxy_resolving_client_socket.h
index e8f22ce..14c8e24 100644
--- a/jingle/glue/proxy_resolving_client_socket.h
+++ b/jingle/glue/proxy_resolving_client_socket.h
@@ -89,7 +89,7 @@ class ProxyResolvingClientSocket : public net::StreamSocket {
net::CompletionCallback proxy_resolve_callback_;
net::CompletionCallback connect_callback_;
- scoped_refptr<net::HttpNetworkSession> network_session_;
+ scoped_ptr<net::HttpNetworkSession> network_session_;
// The transport socket.
scoped_ptr<net::ClientSocketHandle> transport_;
diff --git a/net/cert_net/cert_net_fetcher_impl_unittest.cc b/net/cert_net/cert_net_fetcher_impl_unittest.cc
index e602418..2cbc972 100644
--- a/net/cert_net/cert_net_fetcher_impl_unittest.cc
+++ b/net/cert_net/cert_net_fetcher_impl_unittest.cc
@@ -48,10 +48,11 @@ class RequestContext : public URLRequestContext {
params.proxy_service = proxy_service();
params.ssl_config_service = ssl_config_service();
params.http_server_properties = http_server_properties();
- scoped_refptr<HttpNetworkSession> network_session(
- new HttpNetworkSession(params));
+ storage_.set_http_network_session(
+ make_scoped_ptr(new HttpNetworkSession(params)));
storage_.set_http_transaction_factory(new HttpCache(
- network_session.get(), HttpCache::DefaultBackend::InMemory(0)));
+ storage_.http_network_session(), HttpCache::DefaultBackend::InMemory(0),
+ false /* set_up_quic_server_info */));
URLRequestJobFactoryImpl* job_factory = new URLRequestJobFactoryImpl();
storage_.set_job_factory(job_factory);
}
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index 796aeea..2306525 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -294,39 +294,20 @@ class HttpCache::QuicServerInfoFactoryAdaptor : public QuicServerInfoFactory {
};
//-----------------------------------------------------------------------------
-HttpCache::HttpCache(const HttpNetworkSession::Params& params,
- BackendFactory* backend_factory)
- : net_log_(params.net_log),
- backend_factory_(backend_factory),
- building_backend_(false),
- bypass_lock_for_test_(false),
- fail_conditionalization_for_test_(false),
- mode_(NORMAL),
- network_layer_(new HttpNetworkLayer(new HttpNetworkSession(params))),
- clock_(new base::DefaultClock()),
- weak_factory_(this) {
- SetupQuicServerInfoFactory(network_layer_->GetSession());
-}
-
-
// This call doesn't change the shared |session|'s QuicServerInfoFactory because
// |session| is shared.
HttpCache::HttpCache(HttpNetworkSession* session,
- BackendFactory* backend_factory)
- : net_log_(session->net_log()),
- backend_factory_(backend_factory),
- building_backend_(false),
- bypass_lock_for_test_(false),
- fail_conditionalization_for_test_(false),
- mode_(NORMAL),
- network_layer_(new HttpNetworkLayer(session)),
- clock_(new base::DefaultClock()),
- weak_factory_(this) {
-}
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info)
+ : HttpCache(new HttpNetworkLayer(session),
+ session->net_log(),
+ backend_factory,
+ set_up_quic_server_info) {}
HttpCache::HttpCache(HttpTransactionFactory* network_layer,
NetLog* net_log,
- BackendFactory* backend_factory)
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info)
: net_log_(net_log),
backend_factory_(backend_factory),
building_backend_(false),
@@ -336,7 +317,8 @@ HttpCache::HttpCache(HttpTransactionFactory* network_layer,
network_layer_(network_layer),
clock_(new base::DefaultClock()),
weak_factory_(this) {
- SetupQuicServerInfoFactory(network_layer_->GetSession());
+ if (set_up_quic_server_info)
+ SetupQuicServerInfoFactory(network_layer_->GetSession());
}
HttpCache::~HttpCache() {
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index 026d476..286c670 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -126,23 +126,26 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
static const int kPrefetchReuseMins = 5;
// The disk cache is initialized lazily (by CreateTransaction) in this case.
- // The HttpCache takes ownership of the |backend_factory|.
- HttpCache(const HttpNetworkSession::Params& params,
- BackendFactory* backend_factory);
-
- // The disk cache is initialized lazily (by CreateTransaction) in this case.
// Provide an existing HttpNetworkSession, the cache can construct a
// network layer with a shared HttpNetworkSession in order for multiple
// network layers to share information (e.g. authentication data). The
// HttpCache takes ownership of the |backend_factory|.
- HttpCache(HttpNetworkSession* session, BackendFactory* backend_factory);
+ //
+ // The HttpCache must be destroyed before the HttpNetworkSession.
+ //
+ // If |set_up_quic_server_info| is true, configures the cache to track
+ // information about servers supporting QUIC.
+ HttpCache(HttpNetworkSession* session,
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info);
// Initialize the cache from its component parts. The lifetime of the
// |network_layer| and |backend_factory| are managed by the HttpCache and
// will be destroyed using |delete| when the HttpCache is destroyed.
HttpCache(HttpTransactionFactory* network_layer,
NetLog* net_log,
- BackendFactory* backend_factory);
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info);
~HttpCache() override;
diff --git a/net/http/http_network_layer.cc b/net/http/http_network_layer.cc
index e0b3199..169a1cc 100644
--- a/net/http/http_network_layer.cc
+++ b/net/http/http_network_layer.cc
@@ -22,11 +22,11 @@ namespace net {
HttpNetworkLayer::HttpNetworkLayer(HttpNetworkSession* session)
: session_(session),
suspended_(false) {
- DCHECK(session_.get());
+ DCHECK(session_);
#if defined(OS_WIN)
- base::PowerMonitor* power_monitor = base::PowerMonitor::Get();
- if (power_monitor)
- power_monitor->AddObserver(this);
+ base::PowerMonitor* power_monitor = base::PowerMonitor::Get();
+ if (power_monitor)
+ power_monitor->AddObserver(this);
#endif
}
@@ -38,14 +38,6 @@ HttpNetworkLayer::~HttpNetworkLayer() {
#endif
}
-// static
-HttpTransactionFactory* HttpNetworkLayer::CreateFactory(
- HttpNetworkSession* session) {
- DCHECK(session);
-
- return new HttpNetworkLayer(session);
-}
-
int HttpNetworkLayer::CreateTransaction(RequestPriority priority,
scoped_ptr<HttpTransaction>* trans) {
if (suspended_)
@@ -59,13 +51,13 @@ HttpCache* HttpNetworkLayer::GetCache() {
return NULL;
}
-HttpNetworkSession* HttpNetworkLayer::GetSession() { return session_.get(); }
+HttpNetworkSession* HttpNetworkLayer::GetSession() {
+ return session_;
+}
void HttpNetworkLayer::OnSuspend() {
suspended_ = true;
-
- if (session_.get())
- session_->CloseIdleConnections();
+ session_->CloseIdleConnections();
}
void HttpNetworkLayer::OnResume() {
diff --git a/net/http/http_network_layer.h b/net/http/http_network_layer.h
index 23b4e1e..89ff8eb 100644
--- a/net/http/http_network_layer.h
+++ b/net/http/http_network_layer.h
@@ -26,18 +26,11 @@ class NET_EXPORT HttpNetworkLayer
NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
// Construct a HttpNetworkLayer with an existing HttpNetworkSession which
- // contains a valid ProxyService.
+ // contains a valid ProxyService. The HttpNetworkLayer must be destroyed
+ // before |session|.
explicit HttpNetworkLayer(HttpNetworkSession* session);
~HttpNetworkLayer() override;
- // Create a transaction factory that instantiate a network layer over an
- // existing network session. Network session contains some valuable
- // information (e.g. authentication data) that we want to share across
- // multiple network layers. This method exposes the implementation details
- // of a network layer, use this method with an existing network layer only
- // when network session is shared.
- static HttpTransactionFactory* CreateFactory(HttpNetworkSession* session);
-
// HttpTransactionFactory methods:
int CreateTransaction(RequestPriority priority,
scoped_ptr<HttpTransaction>* trans) override;
@@ -49,7 +42,7 @@ class NET_EXPORT HttpNetworkLayer
void OnResume() override;
private:
- const scoped_refptr<HttpNetworkSession> session_;
+ HttpNetworkSession* const session_;
bool suspended_;
DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer);
diff --git a/net/http/http_network_layer_unittest.cc b/net/http/http_network_layer_unittest.cc
index 9128cdd3..25c5ad7 100644
--- a/net/http/http_network_layer_unittest.cc
+++ b/net/http/http_network_layer_unittest.cc
@@ -45,7 +45,7 @@ class HttpNetworkLayerTest : public PlatformTest {
session_params.ssl_config_service = ssl_config_service_.get();
session_params.http_server_properties =
http_server_properties_.GetWeakPtr();
- network_session_ = new HttpNetworkSession(session_params);
+ network_session_.reset(new HttpNetworkSession(session_params));
factory_.reset(new HttpNetworkLayer(network_session_.get()));
}
@@ -259,7 +259,7 @@ class HttpNetworkLayerTest : public PlatformTest {
scoped_ptr<TransportSecurityState> transport_security_state_;
scoped_ptr<ProxyService> proxy_service_;
const scoped_refptr<SSLConfigService> ssl_config_service_;
- scoped_refptr<HttpNetworkSession> network_session_;
+ scoped_ptr<HttpNetworkSession> network_session_;
scoped_ptr<HttpNetworkLayer> factory_;
HttpServerPropertiesImpl http_server_properties_;
};
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index 7ccba86..7370933 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -57,8 +57,7 @@ class TransportSecurityState;
// This class holds session objects used by HttpNetworkTransaction objects.
class NET_EXPORT HttpNetworkSession
- : public base::RefCounted<HttpNetworkSession>,
- NON_EXPORTED_BASE(public base::NonThreadSafe) {
+ : NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
struct NET_EXPORT Params {
Params();
@@ -140,6 +139,7 @@ class NET_EXPORT HttpNetworkSession
};
explicit HttpNetworkSession(const Params& params);
+ ~HttpNetworkSession();
HttpAuthCache* http_auth_cache() { return &http_auth_cache_; }
SSLClientAuthCache* ssl_client_auth_cache() {
@@ -212,11 +212,8 @@ class NET_EXPORT HttpNetworkSession
bool HasSpdyExclusion(HostPortPair host_port_pair) const;
private:
- friend class base::RefCounted<HttpNetworkSession>;
friend class HttpNetworkSessionPeer;
- ~HttpNetworkSession();
-
ClientSocketPoolManager* GetSocketPoolManager(SocketPoolType pool_type);
NetLog* const net_log_;
diff --git a/net/http/http_network_session_peer.cc b/net/http/http_network_session_peer.cc
index a32e48b..a5fb8a5 100644
--- a/net/http/http_network_session_peer.cc
+++ b/net/http/http_network_session_peer.cc
@@ -14,8 +14,7 @@
namespace net {
-HttpNetworkSessionPeer::HttpNetworkSessionPeer(
- const scoped_refptr<HttpNetworkSession>& session)
+HttpNetworkSessionPeer::HttpNetworkSessionPeer(HttpNetworkSession* session)
: session_(session) {}
HttpNetworkSessionPeer::~HttpNetworkSessionPeer() {}
diff --git a/net/http/http_network_session_peer.h b/net/http/http_network_session_peer.h
index 755e539..ae57f39 100644
--- a/net/http/http_network_session_peer.h
+++ b/net/http/http_network_session_peer.h
@@ -18,8 +18,8 @@ class ProxyService;
class NET_EXPORT_PRIVATE HttpNetworkSessionPeer {
public:
- explicit HttpNetworkSessionPeer(
- const scoped_refptr<HttpNetworkSession>& session);
+ // |session| should outlive the HttpNetworkSessionPeer.
+ explicit HttpNetworkSessionPeer(HttpNetworkSession* session);
~HttpNetworkSessionPeer();
void SetClientSocketPoolManager(
@@ -32,7 +32,7 @@ class NET_EXPORT_PRIVATE HttpNetworkSessionPeer {
scoped_ptr<HttpStreamFactory> http_stream_factory_for_websocket);
private:
- const scoped_refptr<HttpNetworkSession> session_;
+ HttpNetworkSession* const session_;
DISALLOW_COPY_AND_ASSIGN(HttpNetworkSessionPeer);
};
diff --git a/net/http/http_network_transaction_ssl_unittest.cc b/net/http/http_network_transaction_ssl_unittest.cc
index 2db5a99..06fc21a 100644
--- a/net/http/http_network_transaction_ssl_unittest.cc
+++ b/net/http/http_network_transaction_ssl_unittest.cc
@@ -127,7 +127,7 @@ TEST_F(HttpNetworkTransactionSSLTest, SSLFallback) {
StaticSocketDataProvider data3(NULL, 0, NULL, 0);
mock_socket_factory_.AddSocketDataProvider(&data3);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
new HttpNetworkSession(session_params_));
scoped_ptr<HttpNetworkTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 25af22f..b895653 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -232,7 +232,8 @@ void AddWebSocketHeaders(HttpRequestHeaders* headers) {
headers->SetHeader("Sec-WebSocket-Key", "dGhlIHNhbXBsZSBub25jZQ==");
}
-HttpNetworkSession* CreateSession(SpdySessionDependencies* session_deps) {
+scoped_ptr<HttpNetworkSession> CreateSession(
+ SpdySessionDependencies* session_deps) {
return SpdySessionDependencies::SpdyCreateSession(session_deps);
}
@@ -327,7 +328,7 @@ class HttpNetworkTransactionTest
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -673,7 +674,7 @@ bool CheckNTLMServerAuth(const AuthChallengeInfo* auth_challenge) {
} // namespace
TEST_P(HttpNetworkTransactionTest, Basic) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
}
@@ -992,7 +993,7 @@ TEST_P(HttpNetworkTransactionTest, TwoIdenticalLocationHeaders) {
request.url = GURL("http://redirect.com/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1037,7 +1038,7 @@ TEST_P(HttpNetworkTransactionTest, Head) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
BeforeProxyHeadersSentHandler proxy_headers_handler;
@@ -1097,7 +1098,7 @@ TEST_P(HttpNetworkTransactionTest, Head) {
}
TEST_P(HttpNetworkTransactionTest, ReuseConnection) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockRead data_reads[] = {
MockRead("HTTP/1.1 200 OK\r\nContent-Length: 5\r\n\r\n"),
@@ -1155,7 +1156,7 @@ TEST_P(HttpNetworkTransactionTest, Ignores100) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1197,7 +1198,7 @@ TEST_P(HttpNetworkTransactionTest, Ignores1xx) {
request.url = GURL("http://www.foo.com/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1236,7 +1237,7 @@ TEST_P(HttpNetworkTransactionTest, Incomplete100ThenEOF) {
request.url = GURL("http://www.foo.com/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1267,7 +1268,7 @@ TEST_P(HttpNetworkTransactionTest, EmptyResponse) {
request.url = GURL("http://www.foo.com/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1296,7 +1297,7 @@ void HttpNetworkTransactionTest::KeepAliveConnectionResendRequestTest(
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Written data for successfully sending both requests.
MockWrite data1_writes[] = {
@@ -1386,7 +1387,7 @@ void HttpNetworkTransactionTest::PreconnectErrorResendRequestTest(
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
SSLSocketDataProvider ssl1(ASYNC, OK);
SSLSocketDataProvider ssl2(ASYNC, OK);
@@ -1582,7 +1583,7 @@ TEST_P(HttpNetworkTransactionTest, NonKeepAliveConnectionReset) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1632,7 +1633,7 @@ TEST_P(HttpNetworkTransactionTest, ThrottleBeforeNetworkStart) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1681,7 +1682,7 @@ TEST_P(HttpNetworkTransactionTest, ThrottleAndCancelBeforeNetworkStart) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1712,7 +1713,7 @@ TEST_P(HttpNetworkTransactionTest, KeepAliveEarlyClose) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1753,7 +1754,7 @@ TEST_P(HttpNetworkTransactionTest, KeepAliveEarlyClose2) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -1795,7 +1796,7 @@ TEST_P(HttpNetworkTransactionTest, KeepAliveAfterUnreadBody) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Note that because all these reads happen in the same
// StaticSocketDataProvider, it shows that the same socket is being reused for
@@ -1904,7 +1905,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuth) {
TestNetLog log;
session_deps_.net_log = &log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -2009,7 +2010,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotSendAuth) {
request.url = GURL("http://www.example.org/");
request.load_flags = LOAD_DO_NOT_SEND_AUTH_DATA;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -2060,7 +2061,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthKeepAlive) {
TestNetLog log;
session_deps_.net_log = &log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite(
@@ -2163,7 +2164,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthKeepAliveNoBody) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite(
@@ -2241,7 +2242,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthKeepAliveLargeBody) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite(
@@ -2327,7 +2328,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthKeepAliveImpatientServer) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite(
@@ -2422,7 +2423,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyNoKeepAliveHttp10) {
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes1[] = {
@@ -2546,7 +2547,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyNoKeepAliveHttp11) {
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes1[] = {
@@ -2670,7 +2671,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyKeepAliveHttp10) {
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -2777,7 +2778,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyKeepAliveHttp11) {
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -2881,7 +2882,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyKeepAliveHangupDuringBody) {
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session = CreateSession(&session_deps_);
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -2971,7 +2972,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyCancelTunnel) {
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3031,7 +3032,7 @@ TEST_P(HttpNetworkTransactionTest, SanitizeProxyAuthHeaders) {
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3092,7 +3093,7 @@ TEST_P(HttpNetworkTransactionTest, UnexpectedProxyAuth) {
request.load_flags = 0;
// We are using a DIRECT connection (i.e. no proxy) for this session.
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3140,7 +3141,7 @@ TEST_P(HttpNetworkTransactionTest,
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes1[] = {
@@ -3206,7 +3207,7 @@ TEST_P(HttpNetworkTransactionTest, HttpProxyLoadTimingNoPacTwoRequests) {
ProxyService::CreateFixed("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes1[] = {
@@ -3307,7 +3308,7 @@ TEST_P(HttpNetworkTransactionTest, HttpProxyLoadTimingWithPacTwoRequests) {
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes1[] = {
@@ -3405,7 +3406,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxyGet) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should use full url
MockWrite data_writes1[] = {
@@ -3468,7 +3469,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyGet) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// fetch http://www.example.org/ via SPDY
scoped_ptr<SpdyFrame> req(
@@ -3529,7 +3530,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyGetWithSessionRace) {
ProxyService::CreateFixed("https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Fetch http://www.example.org/ through the SPDY proxy.
scoped_ptr<SpdyFrame> req(
@@ -3567,7 +3568,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyGetWithSessionRace) {
SpdySessionKey key(
HostPortPair("proxy", 70), ProxyServer::Direct(), PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> spdy_session =
- CreateSecureSpdySession(session, key, log.bound());
+ CreateSecureSpdySession(session.get(), key, log.bound());
// Unstall the resolution begun by the transaction.
session_deps_.host_resolver->set_ondemand_mode(true);
@@ -3599,7 +3600,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyGetWithProxyAuth) {
ProxyService::CreateFixed("https://myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// The first request will be a bare GET, the second request will be a
// GET with a Proxy-Authorization header.
@@ -3700,7 +3701,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyConnectHttps) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3785,7 +3786,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyConnectSpdy) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3877,7 +3878,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyConnectFailure) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -3929,7 +3930,7 @@ TEST_P(HttpNetworkTransactionTest,
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps_));
HttpRequestInfo request1;
@@ -4072,7 +4073,7 @@ TEST_P(HttpNetworkTransactionTest,
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps_));
HttpRequestInfo request1;
@@ -4196,7 +4197,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyLoadTimingTwoHttpRequests) {
"https://proxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps_));
HttpRequestInfo request1;
@@ -4303,7 +4304,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxyAuthRetry) {
ProxyService::CreateFixed("https://myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should use full url
MockWrite data_writes1[] = {
@@ -4400,7 +4401,7 @@ void HttpNetworkTransactionTest::ConnectStatusHelperWithExpectedStatus(
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
MockWrite data_writes[] = {
@@ -4618,7 +4619,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthProxyThenServer) {
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -4754,7 +4755,7 @@ TEST_P(HttpNetworkTransactionTest, NTLMAuth1) {
HttpAuthHandlerNTLM::ScopedProcSetter proc_setter(MockGenerateRandom1,
MockGetHostName);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite("GET /kids/login.aspx HTTP/1.1\r\n"
@@ -4883,7 +4884,7 @@ TEST_P(HttpNetworkTransactionTest, NTLMAuth2) {
HttpAuthHandlerNTLM::ScopedProcSetter proc_setter(MockGenerateRandom2,
MockGetHostName);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes1[] = {
MockWrite("GET /kids/login.aspx HTTP/1.1\r\n"
@@ -5083,7 +5084,7 @@ TEST_P(HttpNetworkTransactionTest, LargeHeadersNoBody) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5122,7 +5123,7 @@ TEST_P(HttpNetworkTransactionTest,
// Configure against proxy server "myproxy:70".
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5176,7 +5177,7 @@ TEST_P(HttpNetworkTransactionTest, RecycleSocket) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5255,7 +5256,7 @@ TEST_P(HttpNetworkTransactionTest, RecycleSSLSocket) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5325,7 +5326,7 @@ TEST_P(HttpNetworkTransactionTest, RecycleDeadSSLSocket) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5393,7 +5394,7 @@ TEST_P(HttpNetworkTransactionTest, RecycleSocketAfterZeroContentLength) {
"rt=prt.2642,ol.2649,xjs.2951");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5459,7 +5460,7 @@ TEST_P(HttpNetworkTransactionTest, ResendRequestOnWriteBodyError) {
request[1].upload_data_stream = &upload_data_stream;
request[1].load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// The first socket is used for transaction 1 and the first attempt of
// transaction 2.
@@ -5537,7 +5538,7 @@ TEST_P(HttpNetworkTransactionTest, AuthIdentityInURL) {
request.url = GURL("http://foo:b@r@www.example.org/");
request.load_flags = LOAD_NORMAL;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5620,7 +5621,7 @@ TEST_P(HttpNetworkTransactionTest, WrongAuthIdentityInURL) {
request.load_flags = LOAD_NORMAL;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5731,7 +5732,7 @@ TEST_P(HttpNetworkTransactionTest, AuthIdentityInURLSuppressed) {
request.url = GURL("http://foo:bar@www.example.org/");
request.load_flags = LOAD_DO_NOT_USE_EMBEDDED_IDENTITY;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -5805,7 +5806,7 @@ TEST_P(HttpNetworkTransactionTest, AuthIdentityInURLSuppressed) {
// Test that previously tried username/passwords for a realm get re-used.
TEST_P(HttpNetworkTransactionTest, BasicAuthCacheAndPreauth) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Transaction 1: authenticate (foo, bar) on MyRealm1
{
@@ -6205,7 +6206,7 @@ TEST_P(HttpNetworkTransactionTest, DigestPreAuthNonceCount) {
new HttpAuthHandlerDigest::FixedNonceGenerator("0123456789abcdef");
digest_factory->set_nonce_generator(nonce_generator);
session_deps_.http_auth_handler_factory.reset(digest_factory);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Transaction 1: authenticate (foo, bar) on MyRealm1
{
@@ -6337,7 +6338,7 @@ TEST_P(HttpNetworkTransactionTest, DigestPreAuthNonceCount) {
// Test the ResetStateForRestart() private method.
TEST_P(HttpNetworkTransactionTest, ResetStateForRestart) {
// Create a transaction (the dependencies aren't important).
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpNetworkTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6384,7 +6385,7 @@ TEST_P(HttpNetworkTransactionTest, HTTPSBadCertificate) {
request.url = GURL("https://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6492,7 +6493,7 @@ TEST_P(HttpNetworkTransactionTest, HTTPSBadCertificateViaProxy) {
for (int i = 0; i < 2; i++) {
session_deps_.socket_factory->ResetNextMockIndexes();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6558,7 +6559,7 @@ TEST_P(HttpNetworkTransactionTest, HTTPSViaHttpsProxy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6617,7 +6618,7 @@ TEST_P(HttpNetworkTransactionTest, RedirectOfHttpsConnectViaHttpsProxy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6699,7 +6700,7 @@ TEST_P(HttpNetworkTransactionTest, RedirectOfHttpsConnectViaSpdyProxy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6752,7 +6753,7 @@ TEST_P(HttpNetworkTransactionTest,
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6810,7 +6811,7 @@ TEST_P(HttpNetworkTransactionTest,
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -6837,7 +6838,7 @@ TEST_P(HttpNetworkTransactionTest, BasicAuthSpdyProxy) {
ProxyService::CreateFixedFromPacResult("HTTPS myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since we have proxy, should try to establish tunnel.
scoped_ptr<SpdyFrame> req(spdy_util_.ConstructSpdyConnect(
@@ -6982,7 +6983,7 @@ TEST_P(HttpNetworkTransactionTest, CrossOriginProxyPush) {
// Enable cross-origin push.
session_deps_.trusted_spdy_proxy = "myproxy:70";
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<SpdyFrame> stream1_syn(
spdy_util_.ConstructSpdyGet(NULL, 0, false, 1, LOWEST, false));
@@ -7096,7 +7097,7 @@ TEST_P(HttpNetworkTransactionTest, CrossOriginProxyPushCorrectness) {
// Enable cross-origin push.
session_deps_.trusted_spdy_proxy = "myproxy:70";
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<SpdyFrame> stream1_syn(
spdy_util_.ConstructSpdyGet(NULL, 0, false, 1, LOWEST, false));
@@ -7225,7 +7226,7 @@ TEST_P(HttpNetworkTransactionTest, HTTPSBadCertificateViaHttpsProxy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7254,7 +7255,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_UserAgent) {
request.extra_headers.SetHeader(HttpRequestHeaders::kUserAgent,
"Chromium Ultra Awesome X Edition");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7295,7 +7296,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_UserAgentOverTunnel) {
"Chromium Ultra Awesome X Edition");
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7335,7 +7336,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_Referer) {
request.extra_headers.SetHeader(HttpRequestHeaders::kReferer,
"http://the.previous.site.com/");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7373,7 +7374,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_PostContentLengthZero) {
request.method = "POST";
request.url = GURL("http://www.example.org/");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7411,7 +7412,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_PutContentLengthZero) {
request.method = "PUT";
request.url = GURL("http://www.example.org/");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7449,7 +7450,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_HeadContentLengthZero) {
request.method = "HEAD";
request.url = GURL("http://www.example.org/");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7486,7 +7487,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_CacheControlNoCache) {
request.url = GURL("http://www.example.org/");
request.load_flags = LOAD_BYPASS_CACHE;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7527,7 +7528,7 @@ TEST_P(HttpNetworkTransactionTest,
request.url = GURL("http://www.example.org/");
request.load_flags = LOAD_VALIDATE_CACHE;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7566,7 +7567,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_ExtraHeaders) {
request.url = GURL("http://www.example.org/");
request.extra_headers.SetHeader("FooHeader", "Bar");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7607,7 +7608,7 @@ TEST_P(HttpNetworkTransactionTest, BuildRequest_ExtraHeadersStripped) {
request.extra_headers.SetHeader("hEllo", "Kitty");
request.extra_headers.SetHeader("FoO", "bar");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7653,7 +7654,7 @@ TEST_P(HttpNetworkTransactionTest, SOCKS4_HTTP_GET) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7712,7 +7713,7 @@ TEST_P(HttpNetworkTransactionTest, SOCKS4_SSL_GET) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7776,7 +7777,7 @@ TEST_P(HttpNetworkTransactionTest, SOCKS4_HTTP_GET_no_PAC) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7835,7 +7836,7 @@ TEST_P(HttpNetworkTransactionTest, SOCKS5_HTTP_GET) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7907,7 +7908,7 @@ TEST_P(HttpNetworkTransactionTest, SOCKS5_SSL_GET) {
TestNetLog net_log;
session_deps_.net_log = &net_log;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -7984,10 +7985,10 @@ struct GroupNameTest {
bool ssl;
};
-scoped_refptr<HttpNetworkSession> SetupSessionForGroupNameTests(
+scoped_ptr<HttpNetworkSession> SetupSessionForGroupNameTests(
NextProto next_proto,
SpdySessionDependencies* session_deps_) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -8001,16 +8002,15 @@ scoped_refptr<HttpNetworkSession> SetupSessionForGroupNameTests(
return session;
}
-int GroupNameTransactionHelper(
- const std::string& url,
- const scoped_refptr<HttpNetworkSession>& session) {
+int GroupNameTransactionHelper(const std::string& url,
+ HttpNetworkSession* session) {
HttpRequestInfo request;
request.method = "GET";
request.url = GURL(url);
request.load_flags = 0;
scoped_ptr<HttpTransaction> trans(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, session));
TestCompletionCallback callback;
@@ -8061,10 +8061,10 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForDirectConnections) {
for (size_t i = 0; i < arraysize(tests); ++i) {
session_deps_.proxy_service.reset(
ProxyService::CreateFixed(tests[i].proxy_server));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SetupSessionForGroupNameTests(GetParam(), &session_deps_));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
CaptureGroupNameTransportSocketPool* transport_conn_pool =
new CaptureGroupNameTransportSocketPool(NULL, NULL);
CaptureGroupNameSSLSocketPool* ssl_conn_pool =
@@ -8076,7 +8076,7 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForDirectConnections) {
peer.SetClientSocketPoolManager(mock_pool_manager.Pass());
EXPECT_EQ(ERR_IO_PENDING,
- GroupNameTransactionHelper(tests[i].url, session));
+ GroupNameTransactionHelper(tests[i].url, session.get()));
if (tests[i].ssl)
EXPECT_EQ(tests[i].expected_group_name,
ssl_conn_pool->last_group_name_received());
@@ -8123,10 +8123,10 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForHTTPProxyConnections) {
for (size_t i = 0; i < arraysize(tests); ++i) {
session_deps_.proxy_service.reset(
ProxyService::CreateFixed(tests[i].proxy_server));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SetupSessionForGroupNameTests(GetParam(), &session_deps_));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
HostPortPair proxy_host("http_proxy", 80);
CaptureGroupNameHttpProxySocketPool* http_proxy_pool =
@@ -8141,7 +8141,7 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForHTTPProxyConnections) {
peer.SetClientSocketPoolManager(mock_pool_manager.Pass());
EXPECT_EQ(ERR_IO_PENDING,
- GroupNameTransactionHelper(tests[i].url, session));
+ GroupNameTransactionHelper(tests[i].url, session.get()));
if (tests[i].ssl)
EXPECT_EQ(tests[i].expected_group_name,
ssl_conn_pool->last_group_name_received());
@@ -8193,10 +8193,10 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForSOCKSConnections) {
for (size_t i = 0; i < arraysize(tests); ++i) {
session_deps_.proxy_service.reset(
ProxyService::CreateFixed(tests[i].proxy_server));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SetupSessionForGroupNameTests(GetParam(), &session_deps_));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
HostPortPair proxy_host("socks_proxy", 1080);
CaptureGroupNameSOCKSSocketPool* socks_conn_pool =
@@ -8214,7 +8214,7 @@ TEST_P(HttpNetworkTransactionTest, GroupNameForSOCKSConnections) {
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
EXPECT_EQ(ERR_IO_PENDING,
- GroupNameTransactionHelper(tests[i].url, session));
+ GroupNameTransactionHelper(tests[i].url, session.get()));
if (tests[i].ssl)
EXPECT_EQ(tests[i].expected_group_name,
ssl_conn_pool->last_group_name_received());
@@ -8236,7 +8236,7 @@ TEST_P(HttpNetworkTransactionTest, ReconsiderProxyAfterFailedConnection) {
// connecting to both proxies (myproxy:70 and foobar:80).
session_deps_.host_resolver->rules()->AddSimulatedFailure("*");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8262,7 +8262,7 @@ void HttpNetworkTransactionTest::BypassHostCacheOnRefreshHelper(
// Select a host resolver that does caching.
session_deps_.host_resolver.reset(new MockCachingHostResolver);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8331,7 +8331,7 @@ TEST_P(HttpNetworkTransactionTest, RequestWriteError) {
StaticSocketDataProvider data(NULL, 0,
write_failure, arraysize(write_failure));
session_deps_.socket_factory->AddSocketDataProvider(&data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
TestCompletionCallback callback;
@@ -8359,7 +8359,7 @@ TEST_P(HttpNetworkTransactionTest, ConnectionClosedAfterStartOfHeaders) {
StaticSocketDataProvider data(data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
TestCompletionCallback callback;
@@ -8433,7 +8433,7 @@ TEST_P(HttpNetworkTransactionTest, DrainResetOK) {
StaticSocketDataProvider data2(data_reads2, arraysize(data_reads2),
data_writes2, arraysize(data_writes2));
session_deps_.socket_factory->AddSocketDataProvider(&data2);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
TestCompletionCallback callback1;
@@ -8489,7 +8489,7 @@ TEST_P(HttpNetworkTransactionTest, HTTPSViaProxyWithExtraData) {
session_deps_.socket_factory->ResetNextMockIndexes();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8506,7 +8506,7 @@ TEST_P(HttpNetworkTransactionTest, LargeContentLengthThenClose) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8555,7 +8555,7 @@ TEST_P(HttpNetworkTransactionTest, UploadFileSmallerThanLength) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8610,7 +8610,7 @@ TEST_P(HttpNetworkTransactionTest, UploadUnreadableFile) {
request.load_flags = 0;
// If we try to upload an unreadable file, the transaction should fail.
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8664,7 +8664,7 @@ TEST_P(HttpNetworkTransactionTest, CancelDuringInitRequestBody) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8771,7 +8771,7 @@ TEST_P(HttpNetworkTransactionTest, ChangeAuthRealms) {
TestCompletionCallback callback1;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8866,7 +8866,7 @@ TEST_P(HttpNetworkTransactionTest, HonorAlternativeServiceHeader) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8930,7 +8930,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotHonorAlternativeServiceHeader) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session = CreateSession(&session_deps_);
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -8987,7 +8987,7 @@ TEST_P(HttpNetworkTransactionTest, HonorMultipleAlternativeServiceHeader) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -9054,7 +9054,7 @@ TEST_P(HttpNetworkTransactionTest, HonorAlternateProtocolHeader) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -9111,7 +9111,7 @@ TEST_P(HttpNetworkTransactionTest, EmptyAlternateProtocolHeader) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HostPortPair http_host_port_pair("www.example.org", 80);
HttpServerProperties& http_server_properties =
@@ -9178,7 +9178,7 @@ TEST_P(HttpNetworkTransactionTest, AltSvcOverwritesAlternateProtocol) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -9237,7 +9237,7 @@ TEST_P(HttpNetworkTransactionTest, DisableAlternativeServiceToDifferentHost) {
nullptr, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session = CreateSession(&session_deps_);
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9281,7 +9281,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9347,7 +9347,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9399,7 +9399,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9450,7 +9450,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9502,7 +9502,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9553,7 +9553,7 @@ TEST_P(HttpNetworkTransactionTest,
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&second_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9599,7 +9599,7 @@ TEST_P(HttpNetworkTransactionTest, AlternateProtocolUnsafeBlocked) {
data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
@@ -9684,7 +9684,7 @@ TEST_P(HttpNetworkTransactionTest, UseAlternateProtocolForNpnSpdy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -9786,7 +9786,7 @@ TEST_P(HttpNetworkTransactionTest, AlternateProtocolWithSpdyLateBinding) {
// Socket 5 is the unsuccessful non-Alternate-Protocol for transaction 3.
session_deps_.socket_factory->AddSocketDataProvider(&hanging_socket);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
TestCompletionCallback callback1;
HttpNetworkTransaction trans1(DEFAULT_PRIORITY, session.get());
@@ -9877,7 +9877,7 @@ TEST_P(HttpNetworkTransactionTest, StallAlternateProtocolForNpnSpdy) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -10041,7 +10041,7 @@ TEST_P(HttpNetworkTransactionTest,
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -10134,7 +10134,7 @@ TEST_P(HttpNetworkTransactionTest,
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -10157,7 +10157,7 @@ TEST_P(HttpNetworkTransactionTest,
SpdySessionKey key(host_port_pair, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> spdy_session =
- CreateSecureSpdySession(session, key, BoundNetLog());
+ CreateSecureSpdySession(session.get(), key, BoundNetLog());
trans.reset(new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -10526,7 +10526,7 @@ TEST_P(HttpNetworkTransactionTest, GenerateAuthToken) {
request.url = GURL(test_config.server_url);
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpNetworkTransaction trans(DEFAULT_PRIORITY, session.get());
SSLSocketDataProvider ssl_socket_data_provider(SYNCHRONOUS, OK);
@@ -10625,12 +10625,12 @@ TEST_P(HttpNetworkTransactionTest, MultiRoundAuth) {
request.url = origin;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Use a TCP Socket Pool with only one connection per group. This is used
// to validate that the TCP socket is not released to the pool between
// each round of multi-round authentication.
- HttpNetworkSessionPeer session_peer(session);
+ HttpNetworkSessionPeer session_peer(session.get());
TransportClientSocketPool* transport_pool = new TransportClientSocketPool(
50, // Max sockets for pool
1, // Max sockets per group
@@ -10825,7 +10825,7 @@ TEST_P(HttpNetworkTransactionTest, NpnWithHttpOverSSL) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -10877,7 +10877,7 @@ TEST_P(HttpNetworkTransactionTest, SpdyPostNPNServerHangup) {
TestCompletionCallback callback;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11031,7 +11031,7 @@ TEST_P(HttpNetworkTransactionTest, SpdyAlternateProtocolThroughProxy) {
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl);
session_deps_.socket_factory->AddSocketDataProvider(
&hanging_non_alternate_protocol_socket);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// First round should work and provide the Alternate-Protocol state.
TestCompletionCallback callback_1;
@@ -11091,7 +11091,7 @@ TEST_P(HttpNetworkTransactionTest, SimpleCancel) {
request.load_flags = 0;
session_deps_.host_resolver->set_synchronous_mode(true);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11129,7 +11129,7 @@ TEST_P(HttpNetworkTransactionTest, CancelAfterHeaders) {
StaticSocketDataProvider data(data_reads, arraysize(data_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
{
HttpRequestInfo request;
@@ -11165,7 +11165,7 @@ TEST_P(HttpNetworkTransactionTest, ProxyGet) {
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpRequestInfo request;
request.method = "GET";
@@ -11229,7 +11229,7 @@ TEST_P(HttpNetworkTransactionTest, ProxyTunnelGet) {
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpRequestInfo request;
request.method = "GET";
@@ -11306,7 +11306,7 @@ TEST_P(HttpNetworkTransactionTest, ProxyTunnelGetHangup) {
session_deps_.proxy_service.reset(ProxyService::CreateFixed("myproxy:70"));
BoundTestNetLog log;
session_deps_.net_log = log.bound().net_log();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
HttpRequestInfo request;
request.method = "GET";
@@ -11378,14 +11378,14 @@ TEST_P(HttpNetworkTransactionTest, PreconnectWithExistingSpdySession) {
ssl.SetNextProto(GetParam());
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Set up an initial SpdySession in the pool to reuse.
HostPortPair host_port_pair("www.example.org", 443);
SpdySessionKey key(host_port_pair, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> spdy_session =
- CreateInsecureSpdySession(session, key, BoundNetLog());
+ CreateInsecureSpdySession(session.get(), key, BoundNetLog());
HttpRequestInfo request;
request.method = "GET";
@@ -11421,7 +11421,7 @@ void HttpNetworkTransactionTest::CheckErrorIsPassedBack(
session_deps_.socket_factory->AddSocketDataProvider(&data);
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11508,7 +11508,7 @@ TEST_P(HttpNetworkTransactionTest,
StaticSocketDataProvider data4(NULL, 0, NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data4);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11625,7 +11625,7 @@ TEST_P(HttpNetworkTransactionTest,
StaticSocketDataProvider data5(data2_reads, arraysize(data2_reads), NULL, 0);
session_deps_.socket_factory->AddSocketDataProvider(&data5);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11718,7 +11718,7 @@ TEST_P(HttpNetworkTransactionTest, ClientAuthCertCache_Proxy_Fail) {
for (size_t i = 0; i < arraysize(requests); ++i) {
session_deps_.socket_factory->ResetNextMockIndexes();
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpNetworkTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -11771,7 +11771,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPooling) {
// Set up a special HttpNetworkSession with a MockCachingHostResolver.
session_deps_.host_resolver.reset(new MockCachingHostResolver());
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
SpdySessionPoolPeer pool_peer(session->spdy_session_pool());
pool_peer.DisableDomainAuthenticationVerification();
@@ -11870,7 +11870,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPoolingAfterResolution) {
// Set up a special HttpNetworkSession with a MockCachingHostResolver.
session_deps_.host_resolver.reset(new MockCachingHostResolver());
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
SpdySessionPoolPeer pool_peer(session->spdy_session_pool());
pool_peer.DisableDomainAuthenticationVerification();
@@ -12000,7 +12000,7 @@ TEST_P(HttpNetworkTransactionTest,
HttpNetworkSession::Params params =
SpdySessionDependencies::CreateSessionParams(&session_deps_);
params.host_resolver = &host_resolver;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
SpdySessionPoolPeer pool_peer(session->spdy_session_pool());
pool_peer.DisableDomainAuthenticationVerification();
@@ -12140,7 +12140,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotUseSpdySessionForHttp) {
session_deps_.socket_factory->AddSocketDataProvider(&data1);
session_deps_.socket_factory->AddSocketDataProvider(&data2);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Start the first transaction to set up the SpdySession
HttpRequestInfo request1;
@@ -12252,7 +12252,7 @@ class AltSvcCertificateVerificationTest : public HttpNetworkTransactionTest {
session_deps_.socket_factory->AddSocketDataProvider(&data_refused);
session_deps_.use_alternative_services = true;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
AlternativeService alternative_service(
@@ -12356,7 +12356,7 @@ TEST_P(HttpNetworkTransactionTest, AlternativeServiceNotOnHttp11) {
// Set up alternative service for origin.
session_deps_.use_alternative_services = true;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
AlternativeService alternative_service(
@@ -12429,7 +12429,7 @@ TEST_P(HttpNetworkTransactionTest, FailedAlternativeServiceIsNotUserVisible) {
// Set up alternative service for origin.
session_deps_.use_alternative_services = true;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
AlternativeService alternative_service(
@@ -12538,7 +12538,7 @@ TEST_P(HttpNetworkTransactionTest, AlternativeServiceShouldNotPoolToHttp11) {
// Set up alternative service for origin.
session_deps_.use_alternative_services = true;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
AlternativeService alternative_service(
@@ -12672,7 +12672,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotUseSpdySessionForHttpOverTunnel) {
session_deps_.deterministic_socket_factory->AddSSLSocketDataProvider(&ssl2);
session_deps_.deterministic_socket_factory->AddSocketDataProvider(&data1);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSessionDeterministic(&session_deps_));
// Start the first transaction to set up the SpdySession
@@ -12806,7 +12806,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotUseSpdySessionIfCertDoesNotMatch) {
session_deps_.host_resolver->rules()->AddRule("news.example.org", ip_addr);
session_deps_.host_resolver->rules()->AddRule("proxy", ip_addr);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSessionDeterministic(&session_deps_));
// Start the first transaction to set up the SpdySession
@@ -12881,7 +12881,7 @@ TEST_P(HttpNetworkTransactionTest, ErrorSocketNotConnected) {
session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl2);
session_deps_.socket_factory->AddSocketDataProvider(&data2);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps_));
// Start the first transaction to set up the SpdySession and verify that
@@ -12920,7 +12920,7 @@ TEST_P(HttpNetworkTransactionTest, CloseIdleSpdySessionToOpenNewOne) {
// Use two different hosts with different IPs so they don't get pooled.
session_deps_.host_resolver->rules()->AddRule("www.a.com", "10.0.0.1");
session_deps_.host_resolver->rules()->AddRule("www.b.com", "10.0.0.2");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
SSLSocketDataProvider ssl1(ASYNC, OK);
ssl1.SetNextProto(GetParam());
@@ -13080,7 +13080,7 @@ TEST_P(HttpNetworkTransactionTest, HttpSyncConnectError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13113,7 +13113,7 @@ TEST_P(HttpNetworkTransactionTest, HttpAsyncConnectError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13146,7 +13146,7 @@ TEST_P(HttpNetworkTransactionTest, HttpSyncWriteError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13180,7 +13180,7 @@ TEST_P(HttpNetworkTransactionTest, HttpAsyncWriteError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13214,7 +13214,7 @@ TEST_P(HttpNetworkTransactionTest, HttpSyncReadError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13251,7 +13251,7 @@ TEST_P(HttpNetworkTransactionTest, HttpAsyncReadError) {
request.url = GURL("http://www.example.org/");
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13289,7 +13289,7 @@ TEST_P(HttpNetworkTransactionTest, GetFullRequestHeadersIncludesExtraHeader) {
request.load_flags = 0;
request.extra_headers.SetHeader("X-Foo", "bar");
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -13675,8 +13675,8 @@ class FakeWebSocketStreamCreateHelper :
// Make sure that HttpNetworkTransaction passes on its priority to its
// stream request on start.
TEST_P(HttpNetworkTransactionTest, SetStreamRequestPriorityOnStart) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
- HttpNetworkSessionPeer peer(session);
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ HttpNetworkSessionPeer peer(session.get());
FakeStreamFactory* fake_factory = new FakeStreamFactory();
peer.SetHttpStreamFactory(scoped_ptr<HttpStreamFactory>(fake_factory));
@@ -13698,8 +13698,8 @@ TEST_P(HttpNetworkTransactionTest, SetStreamRequestPriorityOnStart) {
// Make sure that HttpNetworkTransaction passes on its priority
// updates to its stream request.
TEST_P(HttpNetworkTransactionTest, SetStreamRequestPriority) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
- HttpNetworkSessionPeer peer(session);
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ HttpNetworkSessionPeer peer(session.get());
FakeStreamFactory* fake_factory = new FakeStreamFactory();
peer.SetHttpStreamFactory(scoped_ptr<HttpStreamFactory>(fake_factory));
@@ -13723,8 +13723,8 @@ TEST_P(HttpNetworkTransactionTest, SetStreamRequestPriority) {
// Make sure that HttpNetworkTransaction passes on its priority
// updates to its stream.
TEST_P(HttpNetworkTransactionTest, SetStreamPriority) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
- HttpNetworkSessionPeer peer(session);
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ HttpNetworkSessionPeer peer(session.get());
FakeStreamFactory* fake_factory = new FakeStreamFactory();
peer.SetHttpStreamFactory(scoped_ptr<HttpStreamFactory>(fake_factory));
@@ -13753,8 +13753,8 @@ TEST_P(HttpNetworkTransactionTest, CreateWebSocketHandshakeStream) {
std::string test_cases[] = {"ws://www.example.org/",
"wss://www.example.org/"};
for (size_t i = 0; i < arraysize(test_cases); ++i) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
- HttpNetworkSessionPeer peer(session);
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ HttpNetworkSessionPeer peer(session.get());
FakeStreamFactory* fake_factory = new FakeStreamFactory();
FakeWebSocketStreamCreateHelper websocket_stream_create_helper;
peer.SetHttpStreamFactoryForWebSocket(
@@ -13835,7 +13835,7 @@ TEST_P(HttpNetworkTransactionTest, CloseSSLSocketOnIdleForHttpRequest) {
http_writes, arraysize(http_writes));
session_deps_.socket_factory->AddSocketDataProvider(&http_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Start the SSL request.
TestCompletionCallback ssl_callback;
@@ -13917,7 +13917,7 @@ TEST_P(HttpNetworkTransactionTest, CloseSSLSocketOnIdleForHttpRequest2) {
http_writes, arraysize(http_writes));
session_deps_.socket_factory->AddSocketDataProvider(&http_data);
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Preconnect an SSL socket. A preconnect is needed because connect jobs are
// cancelled when a normal transaction is cancelled.
@@ -13958,7 +13958,7 @@ TEST_P(HttpNetworkTransactionTest, PostReadsErrorResponseAfterReset) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14003,7 +14003,7 @@ TEST_P(HttpNetworkTransactionTest, PostReadsErrorResponseAfterReset) {
// response from a server that rejected a POST with a CONNECTION_RESET.
TEST_P(HttpNetworkTransactionTest,
PostReadsErrorResponseAfterResetOnReusedSocket) {
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes[] = {
MockWrite("GET / HTTP/1.1\r\n"
"Host: www.foo.com\r\n"
@@ -14097,7 +14097,7 @@ TEST_P(HttpNetworkTransactionTest,
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14152,7 +14152,7 @@ TEST_P(HttpNetworkTransactionTest, ChunkedPostReadsErrorResponseAfterReset) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14211,7 +14211,7 @@ TEST_P(HttpNetworkTransactionTest, PostReadsErrorResponseAfterResetAnd100) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -14264,7 +14264,7 @@ TEST_P(HttpNetworkTransactionTest, PostIgnoresNonErrorResponseAfterReset) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14306,7 +14306,7 @@ TEST_P(HttpNetworkTransactionTest,
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14349,7 +14349,7 @@ TEST_P(HttpNetworkTransactionTest, PostIgnoresHttp09ResponseAfterReset) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14389,7 +14389,7 @@ TEST_P(HttpNetworkTransactionTest, PostIgnoresPartial400HeadersAfterReset) {
request.upload_data_stream = &upload_data_stream;
request.load_flags = 0;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
@@ -14430,7 +14430,7 @@ TEST_P(HttpNetworkTransactionTest, ProxyHeadersNotSentOverWssTunnel) {
session_deps_.proxy_service.reset(
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
// Since a proxy is configured, try to establish a tunnel.
MockWrite data_writes[] = {
@@ -14537,7 +14537,7 @@ TEST_P(HttpNetworkTransactionTest, ProxyHeadersNotSentOverWsTunnel) {
session_deps_.proxy_service.reset(
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
MockWrite data_writes[] = {
// Try to establish a tunnel for the WebSocket connection, with
@@ -14613,7 +14613,7 @@ TEST_P(HttpNetworkTransactionTest, TotalNetworkBytesPost) {
request.url = GURL("http://www.foo.com/");
request.upload_data_stream = &upload_data_stream;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
MockWrite data_writes[] = {
@@ -14657,7 +14657,7 @@ TEST_P(HttpNetworkTransactionTest, TotalNetworkBytesPost100Continue) {
request.url = GURL("http://www.foo.com/");
request.upload_data_stream = &upload_data_stream;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
MockWrite data_writes[] = {
@@ -14702,7 +14702,7 @@ TEST_P(HttpNetworkTransactionTest, TotalNetworkBytesChunkedPost) {
request.url = GURL("http://www.foo.com/");
request.upload_data_stream = &upload_data_stream;
- scoped_refptr<HttpNetworkSession> session(CreateSession(&session_deps_));
+ scoped_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
// Send headers successfully, but get an error while sending the body.
diff --git a/net/http/http_proxy_client_socket_pool_unittest.cc b/net/http/http_proxy_client_socket_pool_unittest.cc
index 6b44dbb..bbd7e31 100644
--- a/net/http/http_proxy_client_socket_pool_unittest.cc
+++ b/net/http/http_proxy_client_socket_pool_unittest.cc
@@ -287,7 +287,7 @@ class HttpProxyClientSocketPoolTest
ssl_data_->SetNextProto(GetParam().protocol);
}
- HttpNetworkSession* CreateNetworkSession() {
+ scoped_ptr<HttpNetworkSession> CreateNetworkSession() {
return SpdySessionDependencies::SpdyCreateSession(&session_deps_);
}
@@ -303,7 +303,7 @@ class HttpProxyClientSocketPoolTest
scoped_ptr<CertVerifier> cert_verifier_;
SSLClientSocketPool ssl_socket_pool_;
- const scoped_refptr<HttpNetworkSession> session_;
+ const scoped_ptr<HttpNetworkSession> session_;
protected:
SpdyTestUtil spdy_util_;
diff --git a/net/http/http_response_body_drainer_unittest.cc b/net/http/http_response_body_drainer_unittest.cc
index b2defb0a..4a9deda 100644
--- a/net/http/http_response_body_drainer_unittest.cc
+++ b/net/http/http_response_body_drainer_unittest.cc
@@ -231,7 +231,7 @@ class HttpResponseBodyDrainerTest : public testing::Test {
scoped_refptr<SSLConfigService> ssl_config_service_;
scoped_ptr<HttpServerPropertiesImpl> http_server_properties_;
scoped_ptr<TransportSecurityState> transport_security_state_;
- const scoped_refptr<HttpNetworkSession> session_;
+ const scoped_ptr<HttpNetworkSession> session_;
CloseResultWaiter result_waiter_;
MockHttpStream* const mock_stream_; // Owned by |drainer_|.
HttpResponseBodyDrainer* const drainer_; // Deletes itself.
diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc
index c4173ea..6a4fffa 100644
--- a/net/http/http_stream_factory_impl_request_unittest.cc
+++ b/net/http/http_stream_factory_impl_request_unittest.cc
@@ -63,8 +63,8 @@ TEST_P(HttpStreamFactoryImplRequestTest, SetPriority) {
SpdySessionDependencies session_deps(GetParam(),
ProxyService::CreateDirect());
- scoped_refptr<HttpNetworkSession>
- session(SpdySessionDependencies::SpdyCreateSession(&session_deps));
+ scoped_ptr<HttpNetworkSession> session =
+ SpdySessionDependencies::SpdyCreateSession(&session_deps);
HttpStreamFactoryImpl* factory =
static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory());
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 9bf70e0..f4954bd 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -430,9 +430,9 @@ TEST_P(HttpStreamFactoryTest, PreconnectDirect) {
for (size_t i = 0; i < arraysize(kTests); ++i) {
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateDirect());
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
CapturePreconnectsTransportSocketPool* transport_conn_pool =
new CapturePreconnectsTransportSocketPool(
session_deps.host_resolver.get(),
@@ -458,9 +458,9 @@ TEST_P(HttpStreamFactoryTest, PreconnectHttpProxy) {
for (size_t i = 0; i < arraysize(kTests); ++i) {
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateFixed("http_proxy"));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
HostPortPair proxy_host("http_proxy", 80);
CapturePreconnectsHttpProxySocketPool* http_proxy_pool =
new CapturePreconnectsHttpProxySocketPool(
@@ -487,9 +487,9 @@ TEST_P(HttpStreamFactoryTest, PreconnectSocksProxy) {
for (size_t i = 0; i < arraysize(kTests); ++i) {
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateFixed("socks4://socks_proxy:1080"));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
HostPortPair proxy_host("socks_proxy", 1080);
CapturePreconnectsSOCKSSocketPool* socks_proxy_pool =
new CapturePreconnectsSOCKSSocketPool(
@@ -516,9 +516,9 @@ TEST_P(HttpStreamFactoryTest, PreconnectDirectWithExistingSpdySession) {
for (size_t i = 0; i < arraysize(kTests); ++i) {
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateDirect());
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
// Put a SpdySession in the pool.
HostPortPair host_port_pair("www.google.com", 443);
@@ -557,9 +557,9 @@ TEST_P(HttpStreamFactoryTest, PreconnectUnsafePort) {
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateDirect());
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
- HttpNetworkSessionPeer peer(session);
+ HttpNetworkSessionPeer peer(session.get());
CapturePreconnectsTransportSocketPool* transport_conn_pool =
new CapturePreconnectsTransportSocketPool(
session_deps.host_resolver.get(),
@@ -588,7 +588,7 @@ TEST_P(HttpStreamFactoryTest, JobNotifiesProxy) {
socket_data2.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data2);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream. It should succeed using the second proxy in the
@@ -637,8 +637,7 @@ TEST_P(HttpStreamFactoryTest, UnreachableQuicProxyMarkedAsBad) {
params.ssl_config_service = ssl_config_service.get();
params.http_server_properties = http_server_properties.GetWeakPtr();
- scoped_refptr<HttpNetworkSession> session;
- session = new HttpNetworkSession(params);
+ scoped_ptr<HttpNetworkSession> session(new HttpNetworkSession(params));
session->quic_stream_factory()->set_require_confirmation(false);
StaticSocketDataProvider socket_data1;
@@ -700,8 +699,7 @@ TEST_P(HttpStreamFactoryTest, QuicLossyProxyMarkedAsBad) {
params.http_server_properties = http_server_properties.GetWeakPtr();
params.quic_max_number_of_lossy_connections = 2;
- scoped_refptr<HttpNetworkSession> session;
- session = new HttpNetworkSession(params);
+ scoped_ptr<HttpNetworkSession> session(new HttpNetworkSession(params));
session->quic_stream_factory()->set_require_confirmation(false);
session->quic_stream_factory()->number_of_lossy_connections_[99] =
@@ -748,7 +746,7 @@ TEST_P(HttpStreamFactoryTest, PrivacyModeDisablesChannelId) {
SSLSocketDataProvider ssl(ASYNC, OK);
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Set an existing SpdySession in the pool.
@@ -814,7 +812,7 @@ TEST_P(HttpStreamFactoryTest, PrivacyModeUsesDifferentSocketPoolGroup) {
SSLSocketDataProvider ssl(ASYNC, OK);
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
SSLClientSocketPool* ssl_pool = session->GetSSLSocketPool(
HttpNetworkSession::NORMAL_SOCKET_POOL);
@@ -864,7 +862,7 @@ TEST_P(HttpStreamFactoryTest, GetLoadState) {
socket_data.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
HttpRequestInfo request_info;
@@ -891,7 +889,7 @@ TEST_P(HttpStreamFactoryTest, RequestHttpStream) {
socket_data.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream. It should succeed using the second proxy in the
@@ -941,7 +939,7 @@ TEST_P(HttpStreamFactoryTest, RequestHttpStreamOverSSL) {
SSLSocketDataProvider ssl_socket_data(ASYNC, OK);
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
@@ -986,7 +984,7 @@ TEST_P(HttpStreamFactoryTest, RequestHttpStreamOverProxy) {
socket_data.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream. It should succeed using the second proxy in the
@@ -1039,7 +1037,7 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketBasicHandshakeStream) {
socket_data.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
@@ -1087,7 +1085,7 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketBasicHandshakeStreamOverSSL) {
SSLSocketDataProvider ssl_socket_data(ASYNC, OK);
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
@@ -1132,7 +1130,7 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketBasicHandshakeStreamOverProxy) {
socket_data.set_connect_data(MockConnect(ASYNC, OK));
session_deps.socket_factory->AddSocketDataProvider(&socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
@@ -1193,7 +1191,7 @@ TEST_P(HttpStreamFactoryTest, RequestSpdyHttpStream) {
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
HostPortPair host_port_pair("www.google.com", 443);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
@@ -1246,8 +1244,8 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketSpdyHandshakeStreamButGetSSL) {
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
HostPortPair host_port_pair("www.google.com", 80);
- scoped_refptr<HttpNetworkSession>
- session(SpdySessionDependencies::SpdyCreateSession(&session_deps));
+ scoped_ptr<HttpNetworkSession> session(
+ SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
HttpRequestInfo request_info;
@@ -1298,8 +1296,8 @@ TEST_P(HttpStreamFactoryTest, DISABLED_RequestWebSocketSpdyHandshakeStream) {
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
HostPortPair host_port_pair("www.google.com", 80);
- scoped_refptr<HttpNetworkSession>
- session(SpdySessionDependencies::SpdyCreateSession(&session_deps));
+ scoped_ptr<HttpNetworkSession> session(
+ SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
HttpRequestInfo request_info;
@@ -1380,7 +1378,7 @@ TEST_P(HttpStreamFactoryTest, DISABLED_OrphanedWebSocketStream) {
ssl_socket_data.SetNextProto(GetParam());
session_deps.socket_factory->AddSSLSocketDataProvider(&ssl_socket_data);
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(&session_deps));
// Now request a stream.
diff --git a/net/http/mock_http_cache.cc b/net/http/mock_http_cache.cc
index d939a3d..10f4c09 100644
--- a/net/http/mock_http_cache.cc
+++ b/net/http/mock_http_cache.cc
@@ -519,13 +519,10 @@ int MockBackendFactory::CreateBackend(NetLog* net_log,
//-----------------------------------------------------------------------------
-MockHttpCache::MockHttpCache()
- : http_cache_(new MockNetworkLayer(), NULL, new MockBackendFactory()) {
-}
+MockHttpCache::MockHttpCache() : MockHttpCache(new MockBackendFactory()) {}
MockHttpCache::MockHttpCache(HttpCache::BackendFactory* disk_cache_factory)
- : http_cache_(new MockNetworkLayer(), NULL, disk_cache_factory) {
-}
+ : http_cache_(new MockNetworkLayer(), nullptr, disk_cache_factory, true) {}
disk_cache::Backend* MockHttpCache::backend() {
TestCompletionCallback cb;
diff --git a/net/proxy/proxy_script_fetcher_impl_unittest.cc b/net/proxy/proxy_script_fetcher_impl_unittest.cc
index 0ffe0c0..f27ccfd 100644
--- a/net/proxy/proxy_script_fetcher_impl_unittest.cc
+++ b/net/proxy/proxy_script_fetcher_impl_unittest.cc
@@ -75,10 +75,11 @@ class RequestContext : public URLRequestContext {
params.proxy_service = proxy_service();
params.ssl_config_service = ssl_config_service();
params.http_server_properties = http_server_properties();
- scoped_refptr<HttpNetworkSession> network_session(
- new HttpNetworkSession(params));
- storage_.set_http_transaction_factory(new HttpCache(
- network_session.get(), HttpCache::DefaultBackend::InMemory(0)));
+ storage_.set_http_network_session(
+ make_scoped_ptr(new HttpNetworkSession(params)));
+ storage_.set_http_transaction_factory(
+ new HttpCache(storage_.http_network_session(),
+ HttpCache::DefaultBackend::InMemory(0), false));
URLRequestJobFactoryImpl* job_factory = new URLRequestJobFactoryImpl();
#if !defined(DISABLE_FILE_SUPPORT)
job_factory->SetProtocolHandler("file",
diff --git a/net/quic/quic_end_to_end_unittest.cc b/net/quic/quic_end_to_end_unittest.cc
index 0229034..fdcaec9 100644
--- a/net/quic/quic_end_to_end_unittest.cc
+++ b/net/quic/quic_end_to_end_unittest.cc
@@ -48,7 +48,7 @@ const char kResponseBody[] = "some arbitrary response body";
// Factory for creating HttpTransactions, used by TestTransactionConsumer.
class TestTransactionFactory : public HttpTransactionFactory {
public:
- TestTransactionFactory(const HttpNetworkSession::Params& params)
+ explicit TestTransactionFactory(const HttpNetworkSession::Params& params)
: session_(new HttpNetworkSession(params)) {}
~TestTransactionFactory() override {}
@@ -65,7 +65,7 @@ class TestTransactionFactory : public HttpTransactionFactory {
HttpNetworkSession* GetSession() override { return session_.get(); };
private:
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
};
} // namespace
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index ffd1918..acc6429 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -259,7 +259,7 @@ class QuicNetworkTransactionTest
params_.next_protos = NextProtosWithSpdyAndQuic(true, true);
}
- session_ = new HttpNetworkSession(params_);
+ session_.reset(new HttpNetworkSession(params_));
session_->quic_stream_factory()->set_require_confirmation(false);
ASSERT_EQ(params_.quic_socket_receive_buffer_size,
session_->quic_stream_factory()->socket_receive_buffer_size());
@@ -366,7 +366,7 @@ class QuicNetworkTransactionTest
MockClock* clock_; // Owned by QuicStreamFactory after CreateSession.
QuicTestPacketMaker maker_;
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
MockClientSocketFactory socket_factory_;
MockCryptoClientStreamFactory crypto_client_stream_factory_;
MockHostResolver host_resolver_;
diff --git a/net/socket/ssl_client_socket_pool_unittest.cc b/net/socket/ssl_client_socket_pool_unittest.cc
index 48d6670..9bbe659 100644
--- a/net/socket/ssl_client_socket_pool_unittest.cc
+++ b/net/socket/ssl_client_socket_pool_unittest.cc
@@ -185,7 +185,7 @@ class SSLClientSocketPoolTest
const scoped_refptr<SSLConfigService> ssl_config_service_;
const scoped_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_;
HttpServerPropertiesImpl http_server_properties_;
- const scoped_refptr<HttpNetworkSession> session_;
+ const scoped_ptr<HttpNetworkSession> session_;
scoped_refptr<TransportSocketParams> direct_transport_socket_params_;
MockTransportClientSocketPool transport_socket_pool_;
@@ -828,7 +828,7 @@ TEST_P(SSLClientSocketPoolTest, IPPooling) {
CreatePool(true /* tcp pool */, false, false);
base::WeakPtr<SpdySession> spdy_session =
- CreateSecureSpdySession(session_, test_hosts[0].key, BoundNetLog());
+ CreateSecureSpdySession(session_.get(), test_hosts[0].key, BoundNetLog());
EXPECT_TRUE(
HasSpdySession(session_->spdy_session_pool(), test_hosts[0].key));
@@ -885,7 +885,7 @@ void SSLClientSocketPoolTest::TestIPPoolingDisabled(
CreatePool(true /* tcp pool */, false, false);
base::WeakPtr<SpdySession> spdy_session =
- CreateSecureSpdySession(session_, test_hosts[0].key, BoundNetLog());
+ CreateSecureSpdySession(session_.get(), test_hosts[0].key, BoundNetLog());
EXPECT_TRUE(
HasSpdySession(session_->spdy_session_pool(), test_hosts[0].key));
diff --git a/net/spdy/spdy_http_stream_unittest.cc b/net/spdy/spdy_http_stream_unittest.cc
index 69ad12c..fc2989a 100644
--- a/net/spdy/spdy_http_stream_unittest.cc
+++ b/net/spdy/spdy_http_stream_unittest.cc
@@ -90,7 +90,8 @@ class SpdyHttpStreamTest : public testing::Test,
new SequencedSocketData(reads, reads_count, writes, writes_count));
session_deps_.socket_factory->AddSocketDataProvider(sequenced_data_.get());
http_session_ = SpdySessionDependencies::SpdyCreateSession(&session_deps_);
- session_ = CreateInsecureSpdySession(http_session_, key, BoundNetLog());
+ session_ =
+ CreateInsecureSpdySession(http_session_.get(), key, BoundNetLog());
}
void TestSendCredentials(
@@ -102,7 +103,7 @@ class SpdyHttpStreamTest : public testing::Test,
TestNetLog net_log_;
SpdySessionDependencies session_deps_;
scoped_ptr<SequencedSocketData> sequenced_data_;
- scoped_refptr<HttpNetworkSession> http_session_;
+ scoped_ptr<HttpNetworkSession> http_session_;
base::WeakPtr<SpdySession> session_;
private:
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index cc7ba20..5a0228d 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -370,16 +370,14 @@ class SpdyNetworkTransactionTest
}
}
- void SetSession(const scoped_refptr<HttpNetworkSession>& session) {
- session_ = session;
+ void SetSession(scoped_ptr<HttpNetworkSession> session) {
+ session_ = session.Pass();
}
HttpNetworkTransaction* trans() { return trans_.get(); }
void ResetTrans() { trans_.reset(); }
TransactionHelperResult& output() { return output_; }
const HttpRequestInfo& request() const { return request_; }
- const scoped_refptr<HttpNetworkSession>& session() const {
- return session_;
- }
+ HttpNetworkSession* session() const { return session_.get(); }
scoped_ptr<SpdySessionDependencies>& session_deps() {
return session_deps_;
}
@@ -397,7 +395,7 @@ class SpdyNetworkTransactionTest
HttpRequestInfo request_;
RequestPriority priority_;
scoped_ptr<SpdySessionDependencies> session_deps_;
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
TransactionHelperResult output_;
scoped_ptr<SocketDataProvider> first_transaction_;
SSLVector ssl_vector_;
@@ -586,7 +584,7 @@ class SpdyNetworkTransactionTest
SpdySessionKey key(host_port_pair, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
BoundNetLog log;
- const scoped_refptr<HttpNetworkSession>& session = helper.session();
+ HttpNetworkSession* session = helper.session();
base::WeakPtr<SpdySession> spdy_session =
session->spdy_session_pool()->FindAvailableSession(key, log);
ASSERT_TRUE(spdy_session != NULL);
@@ -614,7 +612,7 @@ class SpdyNetworkTransactionTest
// Request the pushed path.
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
rv = trans2->Start(
&CreateGetPushRequest(), callback.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
@@ -653,12 +651,11 @@ class SpdyNetworkTransactionTest
helper->ResetTrans();
}
- static void StartTransactionCallback(
- const scoped_refptr<HttpNetworkSession>& session,
- GURL url,
- int result) {
+ static void StartTransactionCallback(HttpNetworkSession* session,
+ GURL url,
+ int result) {
scoped_ptr<HttpNetworkTransaction> trans(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, session));
TestCompletionCallback callback;
HttpRequestInfo request;
request.method = "GET";
@@ -723,7 +720,7 @@ INSTANTIATE_TEST_CASE_P(
TEST_P(SpdyNetworkTransactionTest, Constructor) {
scoped_ptr<SpdySessionDependencies> session_deps(
CreateSpdySessionDependencies(GetParam()));
- scoped_refptr<HttpNetworkSession> session(
+ scoped_ptr<HttpNetworkSession> session(
SpdySessionDependencies::SpdyCreateSession(session_deps.get()));
scoped_ptr<HttpTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
@@ -891,11 +888,11 @@ TEST_P(SpdyNetworkTransactionTest, ThreeGets) {
helper.AddData(&data_placeholder);
helper.AddData(&data_placeholder);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans3(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -976,9 +973,9 @@ TEST_P(SpdyNetworkTransactionTest, TwoGetsLateBinding) {
// on will negotiate SPDY and will be used for all requests.
helper.AddData(&data_placeholder);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -1064,9 +1061,9 @@ TEST_P(SpdyNetworkTransactionTest, TwoGetsLateBindingFromPreconnect) {
helper.AddData(&data_placeholder);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -1181,11 +1178,11 @@ TEST_P(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrent) {
helper.RunPreTestSetup();
helper.AddData(&data);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans3(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -1316,13 +1313,13 @@ TEST_P(SpdyNetworkTransactionTest, FourGetsWithMaxConcurrentPriority) {
helper.AddData(&data);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans3(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans4(
- new HttpNetworkTransaction(HIGHEST, helper.session().get()));
+ new HttpNetworkTransaction(HIGHEST, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -1445,11 +1442,11 @@ TEST_P(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentDelete) {
helper.RunPreTestSetup();
helper.AddData(&data);
scoped_ptr<HttpNetworkTransaction> trans1(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
scoped_ptr<HttpNetworkTransaction> trans3(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -1576,10 +1573,10 @@ TEST_P(SpdyNetworkTransactionTest, ThreeGetsWithMaxConcurrentSocketClose) {
// there needs to be three sets of SSL connection data.
helper.AddData(&data_placeholder);
helper.AddData(&data_placeholder);
- HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session().get());
- HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session().get());
+ HttpNetworkTransaction trans1(DEFAULT_PRIORITY, helper.session());
+ HttpNetworkTransaction trans2(DEFAULT_PRIORITY, helper.session());
HttpNetworkTransaction* trans3(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback1;
TestCompletionCallback callback2;
@@ -4583,8 +4580,8 @@ TEST_P(SpdyNetworkTransactionTest, ProxyConnect) {
helper.session_deps().reset(CreateSpdySessionDependencies(
GetParam(),
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70")));
- helper.SetSession(make_scoped_refptr(
- SpdySessionDependencies::SpdyCreateSession(helper.session_deps().get())));
+ helper.SetSession(
+ SpdySessionDependencies::SpdyCreateSession(helper.session_deps().get()));
helper.RunPreTestSetup();
HttpNetworkTransaction* trans = helper.trans();
@@ -4648,8 +4645,8 @@ TEST_P(SpdyNetworkTransactionTest, DirectConnectProxyReconnect) {
helper.session_deps().reset(CreateSpdySessionDependencies(
GetParam(),
ProxyService::CreateFixedFromPacResult("DIRECT; PROXY myproxy:70")));
- helper.SetSession(make_scoped_refptr(
- SpdySessionDependencies::SpdyCreateSession(helper.session_deps().get())));
+ helper.SetSession(
+ SpdySessionDependencies::SpdyCreateSession(helper.session_deps().get()));
SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool();
helper.RunPreTestSetup();
@@ -4734,16 +4731,16 @@ TEST_P(SpdyNetworkTransactionTest, DirectConnectProxyReconnect) {
scoped_ptr<SpdySessionDependencies> ssd_proxy(
CreateSpdySessionDependencies(GetParam()));
// Ensure that this transaction uses the same SpdySessionPool.
- scoped_refptr<HttpNetworkSession> session_proxy(
+ scoped_ptr<HttpNetworkSession> session_proxy(
SpdySessionDependencies::SpdyCreateSession(ssd_proxy.get()));
NormalSpdyTransactionHelper helper_proxy(request_proxy, DEFAULT_PRIORITY,
BoundNetLog(), GetParam(), NULL);
- HttpNetworkSessionPeer session_peer(session_proxy);
+ HttpNetworkSessionPeer session_peer(session_proxy.get());
scoped_ptr<ProxyService> proxy_service(
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
session_peer.SetProxyService(proxy_service.get());
helper_proxy.session_deps().swap(ssd_proxy);
- helper_proxy.SetSession(session_proxy);
+ helper_proxy.SetSession(session_proxy.Pass());
helper_proxy.RunPreTestSetup();
helper_proxy.AddData(data_proxy.get());
@@ -4818,7 +4815,7 @@ TEST_P(SpdyNetworkTransactionTest, VerifyRetryOnConnectionReset) {
for (int i = 0; i < 2; ++i) {
scoped_ptr<HttpNetworkTransaction> trans(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
TestCompletionCallback callback;
int rv = trans->Start(
@@ -5134,7 +5131,7 @@ TEST_P(SpdyNetworkTransactionTest, ServerPushClaimBeforeHeaders) {
// Request the pushed path. At this point, we've received the push, but the
// headers are not yet complete.
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
rv = trans2->Start(
&CreateGetPushRequest(), callback.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
@@ -5272,7 +5269,7 @@ TEST_P(SpdyNetworkTransactionTest, ServerPushWithTwoHeaderFrames) {
// Request the pushed path. At this point, we've received the push, but the
// headers are not yet complete.
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
rv = trans2->Start(
&CreateGetPushRequest(), callback.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
@@ -5388,7 +5385,7 @@ TEST_P(SpdyNetworkTransactionTest, ServerPushWithNoStatusHeaderFrames) {
// Request the pushed path. At this point, we've received the push, but the
// headers are not yet complete.
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session().get()));
+ new HttpNetworkTransaction(DEFAULT_PRIORITY, helper.session()));
rv = trans2->Start(
&CreateGetPushRequest(), callback.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
@@ -5727,7 +5724,7 @@ TEST_P(SpdyNetworkTransactionTest, OutOfOrderSynStream) {
HttpRequestInfo info2 = CreateGetRequest();
TestCompletionCallback callback2;
scoped_ptr<HttpNetworkTransaction> trans2(
- new HttpNetworkTransaction(MEDIUM, helper.session().get()));
+ new HttpNetworkTransaction(MEDIUM, helper.session()));
rv = trans2->Start(&info2, callback2.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
base::RunLoop().RunUntilIdle();
@@ -5735,7 +5732,7 @@ TEST_P(SpdyNetworkTransactionTest, OutOfOrderSynStream) {
HttpRequestInfo info3 = CreateGetRequest();
TestCompletionCallback callback3;
scoped_ptr<HttpNetworkTransaction> trans3(
- new HttpNetworkTransaction(HIGHEST, helper.session().get()));
+ new HttpNetworkTransaction(HIGHEST, helper.session()));
rv = trans3->Start(&info3, callback3.callback(), BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
base::RunLoop().RunUntilIdle();
diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc
index 9d3e03e..a8362e3 100644
--- a/net/spdy/spdy_proxy_client_socket_unittest.cc
+++ b/net/spdy/spdy_proxy_client_socket_unittest.cc
@@ -123,7 +123,7 @@ class SpdyProxyClientSocketTest
BoundTestNetLog net_log_;
private:
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
scoped_refptr<IOBuffer> read_buf_;
SpdySessionDependencies session_deps_;
MockConnect connect_data_;
@@ -147,7 +147,6 @@ INSTANTIATE_TEST_CASE_P(NextProto,
SpdyProxyClientSocketTest::SpdyProxyClientSocketTest()
: spdy_util_(GetParam()),
- session_(NULL),
read_buf_(NULL),
session_deps_(GetParam()),
connect_data_(SYNCHRONOUS, OK),
@@ -189,9 +188,8 @@ void SpdyProxyClientSocketTest::Initialize(MockRead* reads,
&session_deps_);
// Creates the SPDY session and stream.
- spdy_session_ =
- CreateInsecureSpdySession(
- session_, endpoint_spdy_session_key_, BoundNetLog());
+ spdy_session_ = CreateInsecureSpdySession(
+ session_.get(), endpoint_spdy_session_key_, BoundNetLog());
base::WeakPtr<SpdyStream> spdy_stream(
CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, spdy_session_, url_, LOWEST,
diff --git a/net/spdy/spdy_session_pool_unittest.cc b/net/spdy/spdy_session_pool_unittest.cc
index fccfadd..86b3b4a 100644
--- a/net/spdy/spdy_session_pool_unittest.cc
+++ b/net/spdy/spdy_session_pool_unittest.cc
@@ -44,7 +44,7 @@ class SpdySessionPoolTest : public ::testing::Test,
void RunIPPoolingTest(SpdyPoolCloseSessionsType close_sessions_type);
SpdySessionDependencies session_deps_;
- scoped_refptr<HttpNetworkSession> http_session_;
+ scoped_ptr<HttpNetworkSession> http_session_;
SpdySessionPool* spdy_session_pool_;
};
@@ -115,7 +115,7 @@ TEST_P(SpdySessionPoolTest, CloseCurrentSessions) {
// Setup the first session to the first host.
base::WeakPtr<SpdySession> session =
- CreateInsecureSpdySession(http_session_, test_key, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), test_key, BoundNetLog());
// Flush the SpdySession::OnReadComplete() task.
base::MessageLoop::current()->RunUntilIdle();
@@ -160,7 +160,7 @@ TEST_P(SpdySessionPoolTest, CloseCurrentIdleSessions) {
SpdySessionKey key1(test_host_port_pair1, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> session1 =
- CreateInsecureSpdySession(http_session_, key1, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), key1, BoundNetLog());
GURL url1(kTestHost1);
base::WeakPtr<SpdyStream> spdy_stream1 =
CreateStreamSynchronously(SPDY_BIDIRECTIONAL_STREAM,
@@ -174,7 +174,7 @@ TEST_P(SpdySessionPoolTest, CloseCurrentIdleSessions) {
SpdySessionKey key2(test_host_port_pair2, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> session2 =
- CreateInsecureSpdySession(http_session_, key2, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), key2, BoundNetLog());
GURL url2(kTestHost2);
base::WeakPtr<SpdyStream> spdy_stream2 =
CreateStreamSynchronously(SPDY_BIDIRECTIONAL_STREAM,
@@ -188,7 +188,7 @@ TEST_P(SpdySessionPoolTest, CloseCurrentIdleSessions) {
SpdySessionKey key3(test_host_port_pair3, ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> session3 =
- CreateInsecureSpdySession(http_session_, key3, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), key3, BoundNetLog());
GURL url3(kTestHost3);
base::WeakPtr<SpdyStream> spdy_stream3 =
CreateStreamSynchronously(SPDY_BIDIRECTIONAL_STREAM,
@@ -286,7 +286,7 @@ TEST_P(SpdySessionPoolTest, CloseAllSessions) {
// Setup the first session to the first host.
base::WeakPtr<SpdySession> session =
- CreateInsecureSpdySession(http_session_, test_key, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), test_key, BoundNetLog());
// Flush the SpdySession::OnReadComplete() task.
base::MessageLoop::current()->RunUntilIdle();
@@ -375,9 +375,8 @@ void SpdySessionPoolTest::RunIPPoolingTest(
CreateNetworkSession();
// Setup the first session to the first host.
- base::WeakPtr<SpdySession> session =
- CreateInsecureSpdySession(
- http_session_, test_hosts[0].key, BoundNetLog());
+ base::WeakPtr<SpdySession> session = CreateInsecureSpdySession(
+ http_session_.get(), test_hosts[0].key, BoundNetLog());
// Flush the SpdySession::OnReadComplete() task.
base::MessageLoop::current()->RunUntilIdle();
@@ -399,9 +398,8 @@ void SpdySessionPoolTest::RunIPPoolingTest(
// Create a new session to host 2.
session_deps_.socket_factory->AddSocketDataProvider(&data);
- base::WeakPtr<SpdySession> session2 =
- CreateInsecureSpdySession(
- http_session_, test_hosts[2].key, BoundNetLog());
+ base::WeakPtr<SpdySession> session2 = CreateInsecureSpdySession(
+ http_session_.get(), test_hosts[2].key, BoundNetLog());
// Verify that we have sessions for everything.
EXPECT_TRUE(HasSpdySession(spdy_session_pool_, test_hosts[0].key));
@@ -538,7 +536,7 @@ TEST_P(SpdySessionPoolTest, IPAddressChanged) {
SpdySessionKey keyA(
test_host_port_pairA, ProxyServer::Direct(), PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> sessionA =
- CreateInsecureSpdySession(http_session_, keyA, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), keyA, BoundNetLog());
GURL urlA(kTestHostA);
base::WeakPtr<SpdyStream> spdy_streamA = CreateStreamSynchronously(
@@ -564,7 +562,7 @@ TEST_P(SpdySessionPoolTest, IPAddressChanged) {
SpdySessionKey keyB(
test_host_port_pairB, ProxyServer::Direct(), PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> sessionB =
- CreateInsecureSpdySession(http_session_, keyB, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), keyB, BoundNetLog());
EXPECT_TRUE(sessionB->IsAvailable());
GURL urlB(kTestHostB);
@@ -580,7 +578,7 @@ TEST_P(SpdySessionPoolTest, IPAddressChanged) {
SpdySessionKey keyC(
test_host_port_pairC, ProxyServer::Direct(), PRIVACY_MODE_DISABLED);
base::WeakPtr<SpdySession> sessionC =
- CreateInsecureSpdySession(http_session_, keyC, BoundNetLog());
+ CreateInsecureSpdySession(http_session_.get(), keyC, BoundNetLog());
sessionC->CloseSessionOnError(ERR_SPDY_PROTOCOL_ERROR, "Error!");
EXPECT_TRUE(sessionC->IsDraining());
diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc
index c077195..ced9f81 100644
--- a/net/spdy/spdy_session_unittest.cc
+++ b/net/spdy/spdy_session_unittest.cc
@@ -135,8 +135,8 @@ class SpdySessionTest : public PlatformTest,
void CreateInsecureSpdySession() {
DCHECK(!session_);
- session_ =
- ::net::CreateInsecureSpdySession(http_session_, key_, log_.bound());
+ session_ = ::net::CreateInsecureSpdySession(http_session_.get(), key_,
+ log_.bound());
}
void StallSessionSend() {
@@ -174,7 +174,7 @@ class SpdySessionTest : public PlatformTest,
SpdyTestUtil spdy_util_;
SpdySessionDependencies session_deps_;
- scoped_refptr<HttpNetworkSession> http_session_;
+ scoped_ptr<HttpNetworkSession> http_session_;
base::WeakPtr<SpdySession> session_;
SpdySessionPool* spdy_session_pool_;
GURL test_url_;
@@ -314,7 +314,7 @@ TEST_P(SpdySessionTest, GoAwayImmediatelyWithNoActiveStreams) {
CreateNetworkSession();
session_ = TryCreateInsecureSpdySessionExpectingFailure(
- http_session_, key_, ERR_CONNECTION_CLOSED, BoundNetLog());
+ http_session_.get(), key_, ERR_CONNECTION_CLOSED, BoundNetLog());
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(session_);
@@ -2192,7 +2192,7 @@ TEST_P(SpdySessionTest, VerifyDomainAuthentication) {
CreateNetworkSession();
- session_ = CreateSecureSpdySession(http_session_, key_, BoundNetLog());
+ session_ = CreateSecureSpdySession(http_session_.get(), key_, BoundNetLog());
EXPECT_TRUE(session_->VerifyDomainAuthentication("www.example.org"));
EXPECT_TRUE(session_->VerifyDomainAuthentication("mail.example.org"));
@@ -2222,7 +2222,7 @@ TEST_P(SpdySessionTest, ConnectionPooledWithTlsChannelId) {
CreateNetworkSession();
- session_ = CreateSecureSpdySession(http_session_, key_, BoundNetLog());
+ session_ = CreateSecureSpdySession(http_session_.get(), key_, BoundNetLog());
EXPECT_TRUE(session_->VerifyDomainAuthentication("www.example.org"));
EXPECT_TRUE(session_->VerifyDomainAuthentication("mail.example.org"));
@@ -2967,8 +2967,8 @@ TEST_P(SpdySessionTest, CloseOneIdleConnectionWithAlias) {
// Create an idle SPDY session.
SpdySessionKey key1(HostPortPair("1.com", 80), ProxyServer::Direct(),
PRIVACY_MODE_DISABLED);
- base::WeakPtr<SpdySession> session1 =
- ::net::CreateInsecureSpdySession(http_session_, key1, BoundNetLog());
+ base::WeakPtr<SpdySession> session1 = ::net::CreateInsecureSpdySession(
+ http_session_.get(), key1, BoundNetLog());
EXPECT_FALSE(pool->IsStalled());
// Set up an alias for the idle SPDY session, increasing its ref count to 2.
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index 044be4b..e4fd077 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -55,7 +55,7 @@ class SpdyStreamTest : public ::testing::Test,
base::WeakPtr<SpdySession> CreateDefaultSpdySession() {
SpdySessionKey key(HostPortPair("www.example.org", 80),
ProxyServer::Direct(), PRIVACY_MODE_DISABLED);
- return CreateInsecureSpdySession(session_, key, BoundNetLog());
+ return CreateInsecureSpdySession(session_.get(), key, BoundNetLog());
}
void TearDown() override { base::MessageLoop::current()->RunUntilIdle(); }
@@ -99,7 +99,7 @@ class SpdyStreamTest : public ::testing::Test,
SpdyTestUtil spdy_util_;
SpdySessionDependencies session_deps_;
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
private:
// Used by Add{Read,Write}() above.
diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc
index 7fe1896..a7b5db0 100644
--- a/net/spdy/spdy_test_util_common.cc
+++ b/net/spdy/spdy_test_util_common.cc
@@ -415,26 +415,27 @@ SpdySessionDependencies::SpdySessionDependencies(NextProto protocol,
SpdySessionDependencies::~SpdySessionDependencies() {}
// static
-HttpNetworkSession* SpdySessionDependencies::SpdyCreateSession(
+scoped_ptr<HttpNetworkSession> SpdySessionDependencies::SpdyCreateSession(
SpdySessionDependencies* session_deps) {
HttpNetworkSession::Params params = CreateSessionParams(session_deps);
params.client_socket_factory = session_deps->socket_factory.get();
- HttpNetworkSession* http_session = new HttpNetworkSession(params);
+ scoped_ptr<HttpNetworkSession> http_session(new HttpNetworkSession(params));
SpdySessionPoolPeer pool_peer(http_session->spdy_session_pool());
pool_peer.SetEnableSendingInitialData(false);
- return http_session;
+ return http_session.Pass();
}
// static
-HttpNetworkSession* SpdySessionDependencies::SpdyCreateSessionDeterministic(
+scoped_ptr<HttpNetworkSession>
+SpdySessionDependencies::SpdyCreateSessionDeterministic(
SpdySessionDependencies* session_deps) {
HttpNetworkSession::Params params = CreateSessionParams(session_deps);
params.client_socket_factory =
session_deps->deterministic_socket_factory.get();
- HttpNetworkSession* http_session = new HttpNetworkSession(params);
+ scoped_ptr<HttpNetworkSession> http_session(new HttpNetworkSession(params));
SpdySessionPoolPeer pool_peer(http_session->spdy_session_pool());
pool_peer.SetEnableSendingInitialData(false);
- return http_session;
+ return http_session.Pass();
}
// static
@@ -498,12 +499,14 @@ SpdyURLRequestContext::SpdyURLRequestContext(NextProto protocol)
params.enable_spdy_ping_based_connection_checking = false;
params.spdy_default_protocol = protocol;
params.http_server_properties = http_server_properties();
- scoped_refptr<HttpNetworkSession> network_session(
- new HttpNetworkSession(params));
- SpdySessionPoolPeer pool_peer(network_session->spdy_session_pool());
+ storage_.set_http_network_session(
+ make_scoped_ptr(new HttpNetworkSession(params)));
+ SpdySessionPoolPeer pool_peer(
+ storage_.http_network_session()->spdy_session_pool());
pool_peer.SetEnableSendingInitialData(false);
- storage_.set_http_transaction_factory(new HttpCache(
- network_session.get(), HttpCache::DefaultBackend::InMemory(0)));
+ storage_.set_http_transaction_factory(
+ new HttpCache(storage_.http_network_session(),
+ HttpCache::DefaultBackend::InMemory(0), false));
}
SpdyURLRequestContext::~SpdyURLRequestContext() {
@@ -517,7 +520,7 @@ bool HasSpdySession(SpdySessionPool* pool, const SpdySessionKey& key) {
namespace {
base::WeakPtr<SpdySession> CreateSpdySessionHelper(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log,
Error expected_status,
@@ -578,7 +581,7 @@ base::WeakPtr<SpdySession> CreateSpdySessionHelper(
} // namespace
base::WeakPtr<SpdySession> CreateInsecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log) {
return CreateSpdySessionHelper(http_session, key, net_log,
@@ -586,7 +589,7 @@ base::WeakPtr<SpdySession> CreateInsecureSpdySession(
}
base::WeakPtr<SpdySession> TryCreateInsecureSpdySessionExpectingFailure(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
Error expected_error,
const BoundNetLog& net_log) {
@@ -596,7 +599,7 @@ base::WeakPtr<SpdySession> TryCreateInsecureSpdySessionExpectingFailure(
}
base::WeakPtr<SpdySession> CreateSecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log) {
return CreateSpdySessionHelper(http_session, key, net_log,
diff --git a/net/spdy/spdy_test_util_common.h b/net/spdy/spdy_test_util_common.h
index 5364fe3..8cb2dd0 100644
--- a/net/spdy/spdy_test_util_common.h
+++ b/net/spdy/spdy_test_util_common.h
@@ -193,9 +193,9 @@ struct SpdySessionDependencies {
~SpdySessionDependencies();
- static HttpNetworkSession* SpdyCreateSession(
+ static scoped_ptr<HttpNetworkSession> SpdyCreateSession(
SpdySessionDependencies* session_deps);
- static HttpNetworkSession* SpdyCreateSessionDeterministic(
+ static scoped_ptr<HttpNetworkSession> SpdyCreateSessionDeterministic(
SpdySessionDependencies* session_deps);
static HttpNetworkSession::Params CreateSessionParams(
SpdySessionDependencies* session_deps);
@@ -243,7 +243,7 @@ bool HasSpdySession(SpdySessionPool* pool, const SpdySessionKey& key);
// session pool in |http_session|. A SPDY session for |key| must not
// already exist.
base::WeakPtr<SpdySession> CreateInsecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log);
@@ -252,14 +252,14 @@ base::WeakPtr<SpdySession> CreateInsecureSpdySession(
// not already exist. The session will be created but close in the
// next event loop iteration.
base::WeakPtr<SpdySession> TryCreateInsecureSpdySessionExpectingFailure(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
Error expected_error,
const BoundNetLog& net_log);
// Like CreateInsecureSpdySession(), but uses TLS.
base::WeakPtr<SpdySession> CreateSecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log);
diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc
index 508b182..6782083 100644
--- a/net/url_request/url_request_context_builder.cc
+++ b/net/url_request/url_request_context_builder.cc
@@ -387,9 +387,12 @@ scoped_ptr<URLRequestContext> URLRequestContextBuilder::Build() {
network_session_params.quic_connection_options =
http_network_session_params_.quic_connection_options;
- HttpTransactionFactory* http_transaction_factory = NULL;
+ storage->set_http_network_session(
+ make_scoped_ptr(new HttpNetworkSession(network_session_params)));
+
+ HttpTransactionFactory* http_transaction_factory;
if (http_cache_enabled_) {
- HttpCache::BackendFactory* http_cache_backend = NULL;
+ HttpCache::BackendFactory* http_cache_backend;
if (http_cache_params_.type == HttpCacheParams::DISK) {
http_cache_backend = new HttpCache::DefaultBackend(
DISK_CACHE, CACHE_BACKEND_DEFAULT, http_cache_params_.path,
@@ -399,13 +402,11 @@ scoped_ptr<URLRequestContext> URLRequestContextBuilder::Build() {
HttpCache::DefaultBackend::InMemory(http_cache_params_.max_size);
}
- http_transaction_factory = new HttpCache(
- network_session_params, http_cache_backend);
+ http_transaction_factory = new HttpCache(storage->http_network_session(),
+ http_cache_backend, true);
} else {
- scoped_refptr<HttpNetworkSession> network_session(
- new HttpNetworkSession(network_session_params));
-
- http_transaction_factory = new HttpNetworkLayer(network_session.get());
+ http_transaction_factory =
+ new HttpNetworkLayer(storage->http_network_session());
}
storage->set_http_transaction_factory(http_transaction_factory);
diff --git a/net/url_request/url_request_context_storage.cc b/net/url_request/url_request_context_storage.cc
index b334632..1fb1b07 100644
--- a/net/url_request/url_request_context_storage.cc
+++ b/net/url_request/url_request_context_storage.cc
@@ -94,6 +94,11 @@ void URLRequestContextStorage::set_transport_security_state(
transport_security_state_.reset(transport_security_state);
}
+void URLRequestContextStorage::set_http_network_session(
+ scoped_ptr<HttpNetworkSession> http_network_session) {
+ http_network_session_ = http_network_session.Pass();
+}
+
void URLRequestContextStorage::set_http_transaction_factory(
HttpTransactionFactory* http_transaction_factory) {
context_->set_http_transaction_factory(http_transaction_factory);
diff --git a/net/url_request/url_request_context_storage.h b/net/url_request/url_request_context_storage.h
index fd3c4a2..f3b60f7 100644
--- a/net/url_request/url_request_context_storage.h
+++ b/net/url_request/url_request_context_storage.h
@@ -18,6 +18,7 @@ class CookieStore;
class FtpTransactionFactory;
class HostResolver;
class HttpAuthHandlerFactory;
+class HttpNetworkSession;
class HttpServerProperties;
class HttpTransactionFactory;
class HttpUserAgentSettings;
@@ -59,6 +60,8 @@ class NET_EXPORT URLRequestContextStorage {
void set_cookie_store(CookieStore* cookie_store);
void set_transport_security_state(
TransportSecurityState* transport_security_state);
+ void set_http_network_session(
+ scoped_ptr<HttpNetworkSession> http_network_session);
void set_http_transaction_factory(
HttpTransactionFactory* http_transaction_factory);
void set_job_factory(URLRequestJobFactory* job_factory);
@@ -68,6 +71,12 @@ class NET_EXPORT URLRequestContextStorage {
HttpUserAgentSettings* http_user_agent_settings);
void set_sdch_manager(scoped_ptr<SdchManager> sdch_manager);
+ // Everything else can be access through the URLRequestContext, but this
+ // cannot. Having an accessor for it makes usage a little cleaner.
+ HttpNetworkSession* http_network_session() const {
+ return http_network_session_.get();
+ }
+
private:
// We use a raw pointer to prevent reference cycles, since
// URLRequestContextStorage can often be contained within a URLRequestContext
@@ -90,6 +99,10 @@ class NET_EXPORT URLRequestContextStorage {
scoped_refptr<CookieStore> cookie_store_;
scoped_ptr<TransportSecurityState> transport_security_state_;
+ // Not actually pointed at by the URLRequestContext, but may be used (but not
+ // owned) by the HttpTransactionFactory.
+ scoped_ptr<HttpNetworkSession> http_network_session_;
+
scoped_ptr<HttpTransactionFactory> http_transaction_factory_;
scoped_ptr<URLRequestJobFactory> job_factory_;
scoped_ptr<URLRequestThrottlerManager> throttler_manager_;
diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc
index 2692034..e692c8f 100644
--- a/net/url_request/url_request_test_util.cc
+++ b/net/url_request/url_request_test_util.cc
@@ -111,9 +111,11 @@ void TestURLRequestContext::Init() {
params.network_delegate = network_delegate();
params.http_server_properties = http_server_properties();
params.net_log = net_log();
- context_storage_.set_http_transaction_factory(new HttpCache(
- new HttpNetworkSession(params),
- HttpCache::DefaultBackend::InMemory(0)));
+ context_storage_.set_http_network_session(
+ make_scoped_ptr(new HttpNetworkSession(params)));
+ context_storage_.set_http_transaction_factory(
+ new HttpCache(context_storage_.http_network_session(),
+ HttpCache::DefaultBackend::InMemory(0), false));
}
// In-memory cookie store.
if (!cookie_store())
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index da340ea..346f0e52 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -7031,12 +7031,14 @@ TEST_F(URLRequestTestHTTP, NetworkSuspendTest) {
default_context_.http_auth_handler_factory();
params.network_delegate = &default_network_delegate_;
params.http_server_properties = default_context_.http_server_properties();
+ scoped_ptr<HttpNetworkSession> network_session(
+ new HttpNetworkSession(params));
scoped_ptr<HttpNetworkLayer> network_layer(
- new HttpNetworkLayer(new HttpNetworkSession(params)));
+ new HttpNetworkLayer(network_session.get()));
network_layer->OnSuspend();
HttpCache http_cache(network_layer.release(), default_context_.net_log(),
- HttpCache::DefaultBackend::InMemory(0));
+ HttpCache::DefaultBackend::InMemory(0), true);
TestURLRequestContext context(true);
context.set_http_transaction_factory(&http_cache);
@@ -8080,9 +8082,10 @@ TEST_F(HTTPSRequestTest, SSLSessionCacheShardTest) {
params.http_server_properties = default_context_.http_server_properties();
params.ssl_session_cache_shard = "alternate";
+ scoped_ptr<HttpNetworkSession> network_session(
+ new HttpNetworkSession(params));
scoped_ptr<HttpCache> cache(new HttpCache(
- new HttpNetworkSession(params),
- HttpCache::DefaultBackend::InMemory(0)));
+ network_session.get(), HttpCache::DefaultBackend::InMemory(0), false));
default_context_.set_http_transaction_factory(cache.get());
diff --git a/net/url_request/view_cache_helper_unittest.cc b/net/url_request/view_cache_helper_unittest.cc
index 284482a..e10b203 100644
--- a/net/url_request/view_cache_helper_unittest.cc
+++ b/net/url_request/view_cache_helper_unittest.cc
@@ -31,8 +31,10 @@ class TestURLRequestContext : public URLRequestContext {
};
TestURLRequestContext::TestURLRequestContext()
- : cache_(new MockNetworkLayer(), NULL,
- HttpCache::DefaultBackend::InMemory(0)) {
+ : cache_(new MockNetworkLayer(),
+ nullptr,
+ HttpCache::DefaultBackend::InMemory(0),
+ true) {
set_http_transaction_factory(&cache_);
}